Re: RFR: JDK-8310550: Adjust references to rt.jar [v2]

2023-06-30 Thread Matthias Baesken 
> There are a few references to rt.jar in comments and in the codebase itself. 
> Some of them might be removed or adjusted.

Matthias Baesken has updated the pull request incrementally with one additional 
commit since the last revision:

  Adjust comment in src/java.sql/share/classes/java/sql/DriverManager.java

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/14593/files
  - new: https://git.openjdk.org/jdk/pull/14593/files/5d52b4cb..6665f60b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14593&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14593&range=00-01

  Stats: 6 lines in 1 file changed: 1 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/14593.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14593/head:pull/14593

PR: https://git.openjdk.org/jdk/pull/14593

Re: RFR: JDK-8310550: Adjust references to rt.jar [v2]

2023-06-30 Thread Matthias Baesken 
On Wed, 28 Jun 2023 13:22:20 GMT, Matthias Baesken  wrote:

>>> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is 
>>> declared in module java.base, which does not export it to module java.sql' 
>>> Is there any concern to export it as well to module java.sql ? And btw did 
>>> you mean to use it like this, in the if ?
>>> 
>>> `if (callerCL == null || VM.isSystemDomainLoader(callerCL)) { callerCL = 
>>> Thread.currentThread().getContextClassLoader(); }`
>> 
>> It was just a passing comment, I didn't meant to suggest changing it as part 
>> of this PR. We have always think twice before adding qualified exports from 
>> java.base and this is case where java.sql is very "non-core", we don't want 
>> to give it any access to java.base internals.
>
> Hi Alan, thanks for clarifying.  So I should only adjust the comment, correct 
> ?

Hi Alan, I adjusted the comment in DriverManager.java  .

-

PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1247686721