Re: RFR: JDK-8317636: Improve heap walking API tests to verify correctness of field indexes [v3]

2024-02-02 Thread Alex Menkov 
On Sat, 3 Feb 2024 00:44:42 GMT, Serguei Spitsyn  wrote:

>> Alex Menkov has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   indent
>
> test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp
>  line 64:
> 
>> 62: static bool is_static_field(JNIEnv* env, jclass klass, jfieldID fid) {
>> 63:   enum {
>> 64:ACC_STATIC= 0x0008,
> 
> Nit: Indent is 1 instead of 2.

fixed.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/17580#discussion_r1476916568

Re: RFR: JDK-8317636: Improve heap walking API tests to verify correctness of field indexes [v3]

2024-02-02 Thread Serguei Spitsyn 
On Fri, 2 Feb 2024 23:10:32 GMT, Alex Menkov  wrote:

>> The fix adds new test for FollowReferences JVMTI function to verify 
>> correctness of reported field indexes.
>
> Alex Menkov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   indent

Marked as reviewed by sspitsyn (Reviewer).

test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp
 line 64:

> 62: static bool is_static_field(JNIEnv* env, jclass klass, jfieldID fid) {
> 63:   enum {
> 64:ACC_STATIC= 0x0008,

Nit: Indent is 1 instead of 2.

-

PR Review: https://git.openjdk.org/jdk/pull/17580#pullrequestreview-1860688173
PR Review Comment: https://git.openjdk.org/jdk/pull/17580#discussion_r1476897942

Re: RFR: JDK-8317636: Improve heap walking API tests to verify correctness of field indexes [v3]

2024-02-02 Thread Alex Menkov 
> The fix adds new test for FollowReferences JVMTI function to verify 
> correctness of reported field indexes.

Alex Menkov has updated the pull request incrementally with one additional 
commit since the last revision:

  indent

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17580/files
  - new: https://git.openjdk.org/jdk/pull/17580/files/c5e7b787..a0fffef3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17580&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17580&range=01-02

  Stats: 391 lines in 1 file changed: 56 ins; 56 del; 279 mod
  Patch: https://git.openjdk.org/jdk/pull/17580.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17580/head:pull/17580

PR: https://git.openjdk.org/jdk/pull/17580