Re: RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v11]
On Wed, 31 Jan 2024 11:22:27 GMT, Joachim Kern wrote: >> The load library gets the entire library name, after construction from >> dll_build_name. This is always a .so file name. When .so file name fails to >> load, we fallback to .a filename. >> Do i need to mention the filename as libfilename.so then ? > > Yes, I think this would make it clear. Please use space after comma. - PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1477871269
Re: RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v11]
On Wed, 31 Jan 2024 07:42:49 GMT, Suchismith Roy wrote: >> src/hotspot/os/aix/os_aix.cpp line 1166: >> >>> 1164: Search order: >>> 1165: libfilename-> load "libfilename.so" first,then load libfilename.a,on >>> failure. >>> 1166: In,OpenJ9,the libary with .so extension is loaded first and then .a >>> extension,on failure. >> >> Hi Suchi, I'm puzzled. Your comment implies for me, that load library gets a >> 'base' filename without 'lib' prefix and without extension (e.g. 'name'). >> Then the j9 code creates the filename 'libname.so' first and on failure >> 'libname.a' second. What about given libname.so explicitly (e.g. >> libname.so)? Does j9 really use 'libname.a' as a failure fallback in this >> case? > > The load library gets the entire library name, after construction from > dll_build_name. This is always a .so file name. When .so file name fails to > load, we fallback to .a filename. > Do i need to mention the filename as libfilename.so then ? Yes, I think this would make it clear. - PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1472683336
Re: RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v11]
On Mon, 29 Jan 2024 09:48:40 GMT, Joachim Kern wrote: >> Suchismith Roy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update comment > > src/hotspot/os/aix/os_aix.cpp line 1166: > >> 1164: Search order: >> 1165: libfilename-> load "libfilename.so" first,then load libfilename.a,on >> failure. >> 1166: In,OpenJ9,the libary with .so extension is loaded first and then .a >> extension,on failure. > > Hi Suchi, I'm puzzled. Your comment implies for me, that load library gets a > 'base' filename without 'lib' prefix and without extension (e.g. 'name'). > Then the j9 code creates the filename 'libname.so' first and on failure > 'libname.a' second. What about given libname.so explicitly (e.g. libname.so)? > Does j9 really use 'libname.a' as a failure fallback in this case? The load library gets the entire library name, after construction from dll_build_name. This is always a .so file name. When .so file name fails to load, we fallback to .a filename. Do i need to mention the filename as libfilename.so then ? - PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1472417159
Re: RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v11]
On Sat, 27 Jan 2024 17:38:59 GMT, Suchismith Roy wrote: >> J2SE agent does not start and throws error when it tries to find the shared >> library ibm_16_am. >> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load >> fails.It fails to identify the shared library ibm_16_am.a shared archive >> file on AIX. >> Hence we are providing a function which will additionally search for .a file >> on AIX ,when the search for .so file fails. > > Suchismith Roy has updated the pull request incrementally with one additional > commit since the last revision: > > update comment src/hotspot/os/aix/os_aix.cpp line 1166: > 1164: Search order: > 1165: libfilename-> load "libfilename.so" first,then load libfilename.a,on > failure. > 1166: In,OpenJ9,the libary with .so extension is loaded first and then .a > extension,on failure. Hi Suchi, I'm puzzled. Your comment implies for me, that load library gets a 'base' filename without 'lib' prefix and without extension (e.g. 'name'). Then the j9 code creates the filename 'libname.so' first and on failure 'libname.a' second. What about given libname.so explicitly (e.g. libname.so)? Does j9 really use 'libname.a' as a failure fallback in this case? - PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1469331769
Re: RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v11]
> J2SE agent does not start and throws error when it tries to find the shared > library ibm_16_am. > After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load > fails.It fails to identify the shared library ibm_16_am.a shared archive file > on AIX. > Hence we are providing a function which will additionally search for .a file > on AIX ,when the search for .so file fails. Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: update comment - Changes: - all: https://git.openjdk.org/jdk/pull/16604/files - new: https://git.openjdk.org/jdk/pull/16604/files/cbad4f9a..257f5def Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16604=10 - incr: https://webrevs.openjdk.org/?repo=jdk=16604=09-10 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16604.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16604/head:pull/16604 PR: https://git.openjdk.org/jdk/pull/16604
