Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Matthias Baesken
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken  wrote:

>> We still have quite a lot of OS400 / pase related coding in the hotspot AIX 
>> codebase. But this does not work and was never supported in OpenJDK. So we 
>> can remove this.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   adjust/remove some comments

Hi Lutz and Christoph, thanks for the reviews !

-

PR Comment: https://git.openjdk.org/jdk/pull/18471#issuecomment-2020898141


Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Lutz Schmidt
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken  wrote:

>> We still have quite a lot of OS400 / pase related coding in the hotspot AIX 
>> codebase. But this does not work and was never supported in OpenJDK. So we 
>> can remove this.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   adjust/remove some comments

Looks good.

-

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18471#pullrequestreview-1960988506


Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Christoph Langer
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken  wrote:

>> We still have quite a lot of OS400 / pase related coding in the hotspot AIX 
>> codebase. But this does not work and was never supported in OpenJDK. So we 
>> can remove this.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   adjust/remove some comments

Marked as reviewed by clanger (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18471#pullrequestreview-1960822263


Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Matthias Baesken
> We still have quite a lot of OS400 / pase related coding in the hotspot AIX 
> codebase. But this does not work and was never supported in OpenJDK. So we 
> can remove this.

Matthias Baesken has updated the pull request incrementally with one additional 
commit since the last revision:

  adjust/remove some comments

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18471/files
  - new: https://git.openjdk.org/jdk/pull/18471/files/d1c4c7de..ba02f086

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18471&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18471&range=00-01

  Stats: 10 lines in 1 file changed: 0 ins; 9 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18471.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18471/head:pull/18471

PR: https://git.openjdk.org/jdk/pull/18471