Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 18 commits: > > - Merge branch 'openjdk:master' into patch-6 > - Whitespace > - Revert > - _MSC_VER > - Restore visCPP > - Restore gcc attribute > - Revert gcc > - Revert > - Semicolon > - gcc offset_of > - ... and 8 more: https://git.openjdk.org/jdk/compare/5a82fa3b...6c289fb3 Filed: [JDK-8310863](https://bugs.openjdk.org/browse/JDK-8310863) - PR Comment: https://git.openjdk.org/jdk/pull/13258#issuecomment-1606362416
Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]
On Sun, 25 Jun 2023 15:58:06 GMT, Julian Waters wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 18 commits: >> >> - Merge branch 'openjdk:master' into patch-6 >> - Whitespace >> - Revert >> - _MSC_VER >> - Restore visCPP >> - Restore gcc attribute >> - Revert gcc >> - Revert >> - Semicolon >> - gcc offset_of >> - ... and 8 more: https://git.openjdk.org/jdk/compare/5a82fa3b...6c289fb3 > > Bumping @TheShermanTanker this is causing build failures in our CI in tier1: c:\sb\prod\1687737602\workspace\open\src\jdk.jdwp.agent\share\native\libjdwp\ArrayReferenceImpl.c(26): fatal error C1083: Cannot open include file: 'stdalign.h': No such file or directory - PR Comment: https://git.openjdk.org/jdk/pull/13258#issuecomment-1606360752
Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 18 commits: > > - Merge branch 'openjdk:master' into patch-6 > - Whitespace > - Revert > - _MSC_VER > - Restore visCPP > - Restore gcc attribute > - Revert gcc > - Revert > - Semicolon > - gcc offset_of > - ... and 8 more: https://git.openjdk.org/jdk/compare/5a82fa3b...6c289fb3 Marked as reviewed by mdoerr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13258#pullrequestreview-1497130480
Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 18 commits: > > - Merge branch 'openjdk:master' into patch-6 > - Whitespace > - Revert > - _MSC_VER > - Restore visCPP > - Restore gcc attribute > - Revert gcc > - Revert > - Semicolon > - gcc offset_of > - ... and 8 more: https://git.openjdk.org/jdk/compare/5a82fa3b...6c289fb3 Bumping - PR Comment: https://git.openjdk.org/jdk/pull/13258#issuecomment-1606141758
Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]
> C11 has been stable for a long time on all platforms, so native code can use > the standard alignas operator for alignment requirements Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge branch 'openjdk:master' into patch-6 - Whitespace - Revert - _MSC_VER - Restore visCPP - Restore gcc attribute - Revert gcc - Revert - Semicolon - gcc offset_of - ... and 8 more: https://git.openjdk.org/jdk/compare/5a82fa3b...6c289fb3 - Changes: https://git.openjdk.org/jdk/pull/13258/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13258&range=05 Stats: 11 lines in 3 files changed: 5 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/13258.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13258/head:pull/13258 PR: https://git.openjdk.org/jdk/pull/13258
