Re: RFR: 8324512: Serial: Remove Generation::Name [v2]

2024-01-24 Thread Albert Mingkun Yang
On Tue, 23 Jan 2024 18:37:45 GMT, Albert Mingkun Yang  wrote:

>> Trivial removing redundant code.
>
> Albert Mingkun Yang has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   year

Thanks for review.

-

PR Comment: https://git.openjdk.org/jdk/pull/17530#issuecomment-1907796915


Re: RFR: 8324512: Serial: Remove Generation::Name [v2]

2024-01-23 Thread Albert Mingkun Yang
> Trivial removing redundant code.

Albert Mingkun Yang has updated the pull request incrementally with one 
additional commit since the last revision:

  year

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17530/files
  - new: https://git.openjdk.org/jdk/pull/17530/files/fd278ec6..6fc1a6c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=17530=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=17530=00-01

  Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/17530.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17530/head:pull/17530

PR: https://git.openjdk.org/jdk/pull/17530


Re: RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Chris Plummer
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang  wrote:

> Trivial removing redundant code.

SA changes look good to me.

Copyrights still need updating in a few files.

-

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17530#pullrequestreview-1839481177


Re: RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Ivan Walulya
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang  wrote:

> Trivial removing redundant code.

Marked as reviewed by iwalulya (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/17530#pullrequestreview-1839014944


Re: RFR: 8324512: Serial: Remove Generation::Name

2024-01-23 Thread Stefan Karlsson
On Tue, 23 Jan 2024 10:20:46 GMT, Albert Mingkun Yang  wrote:

> Trivial removing redundant code.

Marked as reviewed by stefank (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/17530#pullrequestreview-1838769192