Re: RFR: 8324845: management.properties text "interface name" is misleading [v2]
On Wed, 31 Jan 2024 21:29:14 GMT, Kevin Walls wrote: >> We have the text "host-or-interface-name" describing the >> com.sun.management.jmxremote.host property in management.properties, but >> interface names (like "eth0" or "lo", or "ens3"...) are not what it accepts. >> It should just say it needs to be a host name or address. >> >> This change only affects comment text in a properties file. >> >> (We don't currently mention this property in other docs, e.g. in the M&M >> guide.) > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > text update Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/17615#issuecomment-1920859573
Re: RFR: 8324845: management.properties text "interface name" is misleading [v2]
On Wed, 31 Jan 2024 21:29:14 GMT, Kevin Walls wrote: >> We have the text "host-or-interface-name" describing the >> com.sun.management.jmxremote.host property in management.properties, but >> interface names (like "eth0" or "lo", or "ens3"...) are not what it accepts. >> It should just say it needs to be a host name or address. >> >> This change only affects comment text in a properties file. >> >> (We don't currently mention this property in other docs, e.g. in the M&M >> guide.) > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > text update Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17615#pullrequestreview-1855667712
Re: RFR: 8324845: management.properties text "interface name" is misleading [v2]
On Wed, 31 Jan 2024 21:29:14 GMT, Kevin Walls wrote: >> We have the text "host-or-interface-name" describing the >> com.sun.management.jmxremote.host property in management.properties, but >> interface names (like "eth0" or "lo", or "ens3"...) are not what it accepts. >> It should just say it needs to be a host name or address. >> >> This change only affects comment text in a properties file. >> >> (We don't currently mention this property in other docs, e.g. in the M&M >> guide.) > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > text update Marked as reviewed by mchung (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17615#pullrequestreview-1855055246
Re: RFR: 8324845: management.properties text "interface name" is misleading [v2]
On Mon, 29 Jan 2024 15:24:45 GMT, Alan Bateman wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> text update > > src/jdk.management.agent/share/conf/management.properties line 258: > >> 256: # >> 257: # com.sun.management.jmxremote.host= >> 258: # Specifies the address on which the JMX RMI agent will bind. > > The placeholder is "host-name-or-address" so it might be clearer to say the > local host name or IP address in the description. ok! - PR Review Comment: https://git.openjdk.org/jdk/pull/17615#discussion_r1473484519
Re: RFR: 8324845: management.properties text "interface name" is misleading [v2]
> We have the text "host-or-interface-name" describing the > com.sun.management.jmxremote.host property in management.properties, but > interface names (like "eth0" or "lo", or "ens3"...) are not what it accepts. > It should just say it needs to be a host name or address. > > This change only affects comment text in a properties file. > > (We don't currently mention this property in other docs, e.g. in the M&M > guide.) Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: text update - Changes: - all: https://git.openjdk.org/jdk/pull/17615/files - new: https://git.openjdk.org/jdk/pull/17615/files/d1eaf87b..58cdf0cf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17615&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17615&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17615.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17615/head:pull/17615 PR: https://git.openjdk.org/jdk/pull/17615
