Re: [sfc-dev] [netvirt-dev] Disable BFD monitoring for tunnels by default

2019-01-27 Thread Sam Hague
On Wed, Jan 23, 2019, 5:58 AM Dimple Jain  Hi Sam,
>
> I have raised a patch to disable BFD by default and Karthika has modified
> genius csit accordingly.
>
> Here are the patches for the same. Both the patches should be merged
> together.
>
> Can you please review and merge.
>
The genius patch is merged. Does it matter if the CSIT patch is not?

And do we need anything for netvirt? There is a direct tunnel suite there
also.

And what about the plain netvirt CSIT, is that just going to have bfd
disabled?

>
>
> https://git.opendaylight.org/gerrit/#/c/79629/
>
> https://git.opendaylight.org/gerrit/#/c/79836/
>
>
>
>
>
> Thanks & Regards,
>
> Dimple.
>
>
>
>
>
> *From:* netvirt-dev-boun...@lists.opendaylight.org [mailto:
> netvirt-dev-boun...@lists.opendaylight.org] *On Behalf Of *Brady Johnson
> *Sent:* Thursday, December 20, 2018 2:34 PM
> *To:* Faseela K 
> *Cc:* odl netvirt dev ;
> genius-...@lists.opendaylight.org; sfc-dev@lists.opendaylight.org
> *Subject:* Re: [netvirt-dev] [sfc-dev] Disable BFD monitoring for tunnels
> by default
>
>
>
> No objections from me, thanks.
>
>
> Regards,
>
>
>
> *Brady Johnson*
>
> bjohn...@inocybe.ca
>
>
>
> [image: Image removed by sender.]
>
>
>
>
>
>
>
>
>
> On Thu, Dec 20, 2018 at 6:31 AM Faseela K  wrote:
>
> Brady/David,
>
>Any objections from sfc side?
>
> Thanks,
>
> Faseela
>
>
>
> *From:* Sam Hague [mailto:sha...@redhat.com]
> *Sent:* Wednesday, December 19, 2018 10:30 PM
> *To:* Faseela K 
> *Cc:* genius-...@lists.opendaylight.org; sfc-dev@lists.opendaylight.org;
> odl netvirt dev ; Brady Allen Johnson
> 
> *Subject:* Re: [sfc-dev] Disable BFD monitoring for tunnels by default
>
>
>
>
>
>
>
> On Sat, Dec 15, 2018 at 9:42 AM Faseela K  wrote:
>
> Hi,
>
>
>
>There was a discussion in last genius weekly call, whether we can
> disable tunnel monitoring by default.
>
> Vishal indicated that netvirt would prefer disabling monitoring by
> default.
>
>And can be enabled explicitly if required.
>
>Any concerns if we do that?
>
> This is a good idea. We talked about this a while back also and thought we
> decided to do the same. The upstream netvirt csit does not use bfd.
>
>
>
> Does disabling the bfd have any impact on the tunnel issues that are being
> debugged or is this a benign change?
>
>
>
> This would clean up the logs also as the bfd stuff is noisy in the
> ovsdb/vswitchd logs that the upstream csit collects.
>
>
>
> Thanks,
>
> Faseela
>
> ___
> sfc-dev mailing list
> sfc-dev@lists.opendaylight.org
> https://lists.opendaylight.org/mailman/listinfo/sfc-dev
>
>
___
sfc-dev mailing list
sfc-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/sfc-dev


Re: [sfc-dev] [netvirt-dev] Disable BFD monitoring for tunnels by default

2019-01-23 Thread Dimple Jain
Hi Sam,
I have raised a patch to disable BFD by default and Karthika has modified 
genius csit accordingly.
Here are the patches for the same. Both the patches should be merged together.
Can you please review and merge.

https://git.opendaylight.org/gerrit/#/c/79629/
https://git.opendaylight.org/gerrit/#/c/79836/


Thanks & Regards,
Dimple.


From: netvirt-dev-boun...@lists.opendaylight.org 
[mailto:netvirt-dev-boun...@lists.opendaylight.org] On Behalf Of Brady Johnson
Sent: Thursday, December 20, 2018 2:34 PM
To: Faseela K 
Cc: odl netvirt dev ; 
genius-...@lists.opendaylight.org; sfc-dev@lists.opendaylight.org
Subject: Re: [netvirt-dev] [sfc-dev] Disable BFD monitoring for tunnels by 
default

No objections from me, thanks.

Regards,

Brady Johnson
bjohn...@inocybe.ca<mailto:bjohn...@inocybe.ca>


[Image removed by sender.]






On Thu, Dec 20, 2018 at 6:31 AM Faseela K 
mailto:faseel...@ericsson.com>> wrote:
Brady/David,
   Any objections from sfc side?
Thanks,
Faseela

From: Sam Hague [mailto:sha...@redhat.com<mailto:sha...@redhat.com>]
Sent: Wednesday, December 19, 2018 10:30 PM
To: Faseela K mailto:faseel...@ericsson.com>>
Cc: 
genius-...@lists.opendaylight.org<mailto:genius-...@lists.opendaylight.org>; 
sfc-dev@lists.opendaylight.org<mailto:sfc-dev@lists.opendaylight.org>; odl 
netvirt dev 
mailto:netvirt-...@lists.opendaylight.org>>;
 Brady Allen Johnson mailto:bjohn...@inocybe.ca>>
Subject: Re: [sfc-dev] Disable BFD monitoring for tunnels by default



On Sat, Dec 15, 2018 at 9:42 AM Faseela K 
mailto:faseel...@ericsson.com>> wrote:
Hi,

   There was a discussion in last genius weekly call, whether we can disable 
tunnel monitoring by default.
Vishal indicated that netvirt would prefer disabling monitoring by default.
   And can be enabled explicitly if required.
   Any concerns if we do that?
This is a good idea. We talked about this a while back also and thought we 
decided to do the same. The upstream netvirt csit does not use bfd.

Does disabling the bfd have any impact on the tunnel issues that are being 
debugged or is this a benign change?

This would clean up the logs also as the bfd stuff is noisy in the 
ovsdb/vswitchd logs that the upstream csit collects.

Thanks,
Faseela
___
sfc-dev mailing list
sfc-dev@lists.opendaylight.org<mailto:sfc-dev@lists.opendaylight.org>
https://lists.opendaylight.org/mailman/listinfo/sfc-dev
___
sfc-dev mailing list
sfc-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/sfc-dev