[jira] Commented: (SLING-292) µjax Post Ser vlet does not use correct HTTP status codes

2008-02-29 Thread Lars Trieloff (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573648#action_12573648
 ] 

Lars Trieloff commented on SLING-292:
-

Felix, I think this should be fixed as well. Displaying the status code is 
nice, but sending the correct HTTP response is even more important.

Tobias, I do not understand your comment, normal form posts will get a styled 
error message for 500 and AJAX posts can evaluate the status code easily 
without parsing the response (http://www.w3schools.com/xml/xml_http.asp)

> µjax Post Servlet does not use correct HTTP status codes
> 
>
> Key: SLING-292
> URL: https://issues.apache.org/jira/browse/SLING-292
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Lars Trieloff
>
> The µjax Post Servlet does not use correct HTTP status codes when trying to 
> write nodes without permissions. Expected status code is 403 (forbidden), if 
> no user is logged in (no credentials in the request), status code 401 might 
> be more appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SLING-294) Nodetypes not registered if repository becomes available after bundle is loaded

2008-02-29 Thread Bertrand Delacretaz (JIRA)
Nodetypes not registered if repository becomes available after bundle is loaded
---

 Key: SLING-294
 URL: https://issues.apache.org/jira/browse/SLING-294
 Project: Sling
  Issue Type: Bug
  Components: Repository, Resource
Reporter: Bertrand Delacretaz


Related to SLING-132: if the repository service becomes available after a 
bundle that contains nodetype definitions was loaded, it seems like the 
nodetypes are never registered.

The initial content loading seems to work in such a case.

I haven't done extensive tests yet, creating the issue so that we don't forget 
to look at it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-295:
---

Attachment: patch.txt

Hacked patch to demonstrate the wanted behaviour.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>  Components: ujax
>Reporter: Carsten Ziegeler
> Attachments: patch.txt
>
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-295:
---

   Component/s: (was: ujax)
  Assignee: Carsten Ziegeler
Remaining Estimate: 0h
 Original Estimate: 0h

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573809#action_12573809
 ] 

Carsten Ziegeler commented on SLING-295:


Rethinking and locking at the code, I guess it's easier to use the special 
prefix "ujax:" as some other code already handels all parameters starting with 
this prefix as special parameters. if we introduce "jcr:" prefix, we have to 
update all these locations as well.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>  Components: ujax
>Reporter: Carsten Ziegeler
> Attachments: patch.txt
>
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573791#action_12573791
 ] 

Felix Meschberger commented on SLING-295:
-

How about jcr:primaryType ? Btw. the same holds for mixin node types .. which 
should be manageable through ujax, IMHO (At least I had a use case for an 
integration test ;-) )

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>  Components: ujax
>Reporter: Carsten Ziegeler
> Attachments: patch.txt
>
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)
Specify nodetype for node creation
--

 Key: SLING-295
 URL: https://issues.apache.org/jira/browse/SLING-295
 Project: Sling
  Issue Type: Improvement
  Components: ujax
Reporter: Carsten Ziegeler


It would be nice to specify the node type for new nodes when they are created 
through the post servlet.

Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573804#action_12573804
 ] 

Carsten Ziegeler commented on SLING-295:


jcr:primaryType sounds good
and then either
jcr:mixinTypes : comma separeted list
or
jcr:mixinType which can occur more than once?

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>  Components: ujax
>Reporter: Carsten Ziegeler
> Attachments: patch.txt
>
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SLING-296) Relative paths for the sling:target property of a sling:redirect resource should be supported

2008-02-29 Thread Felix Meschberger (JIRA)
Relative paths for the sling:target property of a sling:redirect resource 
should be supported
-

 Key: SLING-296
 URL: https://issues.apache.org/jira/browse/SLING-296
 Project: Sling
  Issue Type: Improvement
  Components: ServletResolver
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: 2.0.0


Currently the sling:target property of a sling:redirect resource must be an 
absolute path or a node reference. It would be usefull, if this target path 
could also be set to a relative path.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-292) µjax Post Ser vlet does not use correct HTTP status codes

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573821#action_12573821
 ] 

Tobias Bocanegra commented on SLING-292:


the problem is if the user selects 'display user friendly errors' as available 
in many browsers.

> µjax Post Servlet does not use correct HTTP status codes
> 
>
> Key: SLING-292
> URL: https://issues.apache.org/jira/browse/SLING-292
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Lars Trieloff
>
> The µjax Post Servlet does not use correct HTTP status codes when trying to 
> write nodes without permissions. Expected status code is 403 (forbidden), if 
> no user is logged in (no credentials in the request), status code 401 might 
> be more appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (SLING-262) ResourceProvider can not provide children list

2008-02-29 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger resolved SLING-262.
-

   Resolution: Fixed
Fix Version/s: 2.0.0

Also implemented the ResourceProvider.listChildren method correctly in the 
sling/servlet-resolver module in Rev. 632383.

Please close this issue, if your problem is fixed. Thanks.

BTW: By these implementations it is now finally possible to traverse the 
resource tree.

> ResourceProvider can not provide children list
> --
>
> Key: SLING-262
> URL: https://issues.apache.org/jira/browse/SLING-262
> Project: Sling
>  Issue Type: Bug
>  Components: Resource
>Reporter: christian
>Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> But the JcrResourceResolver's listChildren(Resource) relies on the Resource 
> beeing descendable in order to list its children.
> See Ln 191 resp. 197 of JcrResourceProvider.
> Resources provided by a ResourceProvider can not implement Descendabel 
> interface.
> This interface is not exported from the jcr/resource -bundle.
> As a Resoult its children never can be listed via the Resolver

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573827#action_12573827
 ] 

Felix Meschberger commented on SLING-295:
-

> locking at the code, I guess it's easier to use the special prefix "ujax:"

Ah, you are right. ok. Then ujax: is probably better.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-262) ResourceProvider can not provide children list

2008-02-29 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573822#action_12573822
 ] 

Felix Meschberger commented on SLING-262:
-

Implemented support for ResourceProvider.listChildren in the jcr/resource 
bundle in Rev. 632379.

> ResourceProvider can not provide children list
> --
>
> Key: SLING-262
> URL: https://issues.apache.org/jira/browse/SLING-262
> Project: Sling
>  Issue Type: Bug
>  Components: Resource
>Reporter: christian
>Assignee: Felix Meschberger
>
> But the JcrResourceResolver's listChildren(Resource) relies on the Resource 
> beeing descendable in order to list its children.
> See Ln 191 resp. 197 of JcrResourceProvider.
> Resources provided by a ResourceProvider can not implement Descendabel 
> interface.
> This interface is not exported from the jcr/resource -bundle.
> As a Resoult its children never can be listed via the Resolver

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-262) ResourceProvider can not provide children list

2008-02-29 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573814#action_12573814
 ] 

Felix Meschberger commented on SLING-262:
-

Extend the ResourceProvider API in Rev. 632373 to state the handling of deeply 
nested resources for which no actual parent hierarchy exists.

Consider for example a provided resource at /sample/path where the /sample 
resource does not actually exist. To be able to traverse the resource tree to 
the /sample/path resource, the resource provider's listChildren method is also 
called for the "/" resource. In this case the method must return an iterator 
providing a "/sample" resource. This resource should be a SyntheticResource 
whose resource type MUST be set to ResourceProvider.RESOURCE_TYPE_SYNTHETIC 
("sling:syntheticResourceProviderResource").

> ResourceProvider can not provide children list
> --
>
> Key: SLING-262
> URL: https://issues.apache.org/jira/browse/SLING-262
> Project: Sling
>  Issue Type: Bug
>  Components: Resource
>Reporter: christian
>Assignee: Felix Meschberger
>
> But the JcrResourceResolver's listChildren(Resource) relies on the Resource 
> beeing descendable in order to list its children.
> See Ln 191 resp. 197 of JcrResourceProvider.
> Resources provided by a ResourceProvider can not implement Descendabel 
> interface.
> This interface is not exported from the jcr/resource -bundle.
> As a Resoult its children never can be listed via the Resolver

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-292) µjax Post Ser vlet does not use correct HTTP status codes

2008-02-29 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573843#action_12573843
 ] 

Felix Meschberger commented on SLING-292:
-

This is really a problem, but I consider it worth to send "ok" where in 
reality, the job has not been done. And in fact, the user is probably happier 
to see the "user-friendly" message telling something was wrong than being 
tricked into believing everything was fine and not reading the fine print.

> µjax Post Servlet does not use correct HTTP status codes
> 
>
> Key: SLING-292
> URL: https://issues.apache.org/jira/browse/SLING-292
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Lars Trieloff
>
> The µjax Post Servlet does not use correct HTTP status codes when trying to 
> write nodes without permissions. Expected status code is 403 (forbidden), if 
> no user is logged in (no credentials in the request), status code 401 might 
> be more appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (SLING-296) Relative paths for the sling:target property of a sling:redirect resource should be supported

2008-02-29 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger closed SLING-296.
---

Resolution: Fixed

Fixed in Rev. 632389.

> Relative paths for the sling:target property of a sling:redirect resource 
> should be supported
> -
>
> Key: SLING-296
> URL: https://issues.apache.org/jira/browse/SLING-296
> Project: Sling
>  Issue Type: Improvement
>  Components: ServletResolver
>Reporter: Felix Meschberger
>Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently the sling:target property of a sling:redirect resource must be an 
> absolute path or a node reference. It would be usefull, if this target path 
> could also be set to a relative path.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573869#action_12573869
 ] 

Tobias Bocanegra commented on SLING-295:


i can provide a fix, if you wish.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573868#action_12573868
 ] 

Tobias Bocanegra commented on SLING-295:


> > locking at the code, I guess it's easier to use the special prefix "ujax:"
> Ah, you are right. ok. Then ujax: is probably better.
i don't think so.

the jcr:primaryType should be used, since it's already defined by JCR. i don't 
think that introducing a new mechanism is intuitive. 

example:

POST /foo/bar/*
jcr:primaryType="my:nodetype"


> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573870#action_12573870
 ] 

Tobias Bocanegra commented on SLING-295:


btw: the creation of the 'intermediate' nodes should only rely on 'default node 
creation'. as defined by the repository.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-292) µjax Post Ser vlet does not use correct HTTP status codes

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573873#action_12573873
 ] 

Tobias Bocanegra commented on SLING-292:


this is not a problem when a human user sends the post, but rather in some UIs 
where the form is posted in a hidden frame and the script takes care of 
reloading the respective elements of the page.
in this case, the UI scripts need to be able to parse the errors no matter how 
the user has configured the browser.

> µjax Post Servlet does not use correct HTTP status codes
> 
>
> Key: SLING-292
> URL: https://issues.apache.org/jira/browse/SLING-292
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Lars Trieloff
>
> The µjax Post Servlet does not use correct HTTP status codes when trying to 
> write nodes without permissions. Expected status code is 403 (forbidden), if 
> no user is logged in (no credentials in the request), status code 401 might 
> be more appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SLING-298) FormEncoding parameter should be ignored during POST processing

2008-02-29 Thread Carsten Ziegeler (JIRA)
FormEncoding parameter should be ignored during POST processing
---

 Key: SLING-298
 URL: https://issues.apache.org/jira/browse/SLING-298
 Project: Sling
  Issue Type: Bug
  Components: ujax
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler


The FormEncoding parameter should be ignored during post processing and not be 
set as a property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573874#action_12573874
 ] 

Carsten Ziegeler commented on SLING-295:


I have a solution running and am currently testing.
The intermediate nodes rely on default node creation.
The code of the post servlet is already very complex. While testing I stumbed 
across some problems with
all the different parameters used for different things, so atm i think we 
should not introduce a new prefix
to be handled by the servlet.
So I'll go with "ujax:" for now, but we can change it to "jcr:" prefix then 
easily.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SLING-299) Node creation without properties doesn't work

2008-02-29 Thread Carsten Ziegeler (JIRA)
Node creation without properties doesn't work
-

 Key: SLING-299
 URL: https://issues.apache.org/jira/browse/SLING-299
 Project: Sling
  Issue Type: Bug
  Components: ujax
Reporter: Carsten Ziegeler


If a new node should be created without setting a property, the node is never 
created as the processContent() method in the ujax post processor only acts 
when a property is available.
Now, this use case might be questionable, however it seems strange to not 
create the node.
I've added and disabled a test case in the CreateNodeTest test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread David Nuescheler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573880#action_12573880
 ] 

David Nuescheler commented on SLING-295:


I would go with the jcr:primaryType aswell instead of a magic ujax:primaryType.
 
So far we used ujax: for things that don't have representation in content. I 
think everything that has trivial representation in content should map the name 
of the property directly to the form input name just make it simple to 
understand.
I think it is intuitive for the user to use jcr:primaryType and other jcr: 
properties.
In my mind jcr:mixinTypes for example should be treated like a normal 
multivalue property, please don't introduce a special comma separated case for 
that.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SLING-297) Exceptions during processing of POST are never logged

2008-02-29 Thread Carsten Ziegeler (JIRA)
Exceptions during processing of POST are never logged
-

 Key: SLING-297
 URL: https://issues.apache.org/jira/browse/SLING-297
 Project: Sling
  Issue Type: Bug
  Components: ujax
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler


If an exception occurs during POST processing, it is never logged.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (SLING-297) Exceptions during processing of POST are never logged

2008-02-29 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-297.
--

   Resolution: Fixed
Fix Version/s: 2.0.0

> Exceptions during processing of POST are never logged
> -
>
> Key: SLING-297
> URL: https://issues.apache.org/jira/browse/SLING-297
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> If an exception occurs during POST processing, it is never logged.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-298) FormEncoding parameter should be ignored during POST processing

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573893#action_12573893
 ] 

Tobias Bocanegra commented on SLING-298:


imo this should be treated specially. just prefix all other props with "./" and 
you're set.

eg:

POST /foo/bar
FormEncoding = "utf-8"
./jcr:title = "hello"

> FormEncoding parameter should be ignored during POST processing
> ---
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not 
> be set as a property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (SLING-298) FormEncoding parameter should be ignored during POST processing

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573893#action_12573893
 ] 

tripod edited comment on SLING-298 at 2/29/08 10:49 AM:
--

imo this should not be treated specially. just prefix all other props with "./" 
and you're set.

eg:

POST /foo/bar
FormEncoding = "utf-8"
./jcr:title = "hello"

  was (Author: tripod):
imo this should be treated specially. just prefix all other props with "./" 
and you're set.

eg:

POST /foo/bar
FormEncoding = "utf-8"
./jcr:title = "hello"
  
> FormEncoding parameter should be ignored during POST processing
> ---
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not 
> be set as a property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-298) FormEncoding parameter should be ignored during POST processing

2008-02-29 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573895#action_12573895
 ] 

Carsten Ziegeler commented on SLING-298:


Then perhaps the processing of properties in the ujax post processor is wrong. 
Without my latest fix, the FormEncoding property was set on newly created nodes.


> FormEncoding parameter should be ignored during POST processing
> ---
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not 
> be set as a property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-299) Node creation without properties doesn't work

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573910#action_12573910
 ] 

Tobias Bocanegra commented on SLING-299:


the createNode() handles "/*" nodes but not "/new_node" 

> Node creation without properties doesn't work
> -
>
> Key: SLING-299
> URL: https://issues.apache.org/jira/browse/SLING-299
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>
> If a new node should be created without setting a property, the node is never 
> created as the processContent() method in the ujax post processor only acts 
> when a property is available.
> Now, this use case might be questionable, however it seems strange to not 
> create the node.
> I've added and disabled a test case in the CreateNodeTest test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573898#action_12573898
 ] 

Carsten Ziegeler commented on SLING-295:


As I said, I'm not against using "jcr:primaryType" - but for now, I don't have 
the overview where we have to check for "jcr:*" throughout the ujax code base
Same applies to jcr:mixinTypes  - i'm using ujax:mixinTypes for now.

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-298) FormEncoding parameter should be ignored during POST processing

2008-02-29 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573902#action_12573902
 ] 

Carsten Ziegeler commented on SLING-298:


I guess this has to do with SLING-299, if no parameter starting with "./" is 
set, FormEncoding is assumed to specify a property.

> FormEncoding parameter should be ignored during POST processing
> ---
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not 
> be set as a property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-299) Node creation without properties doesn't work

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573897#action_12573897
 ] 

Tobias Bocanegra commented on SLING-299:


shouldn't be the case anymore since SLING-285 introduced a new handling for 
node creation.


> Node creation without properties doesn't work
> -
>
> Key: SLING-299
> URL: https://issues.apache.org/jira/browse/SLING-299
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>
> If a new node should be created without setting a property, the node is never 
> created as the processContent() method in the ujax post processor only acts 
> when a property is available.
> Now, this use case might be questionable, however it seems strange to not 
> create the node.
> I've added and disabled a test case in the CreateNodeTest test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-297) Exceptions during processing of POST are never logged

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573900#action_12573900
 ] 

Tobias Bocanegra commented on SLING-297:


i strongly disagree with this patch!
you just fixed 3 bugs at once in the same checkin although the other were not 
agreed.

please revert

> Exceptions during processing of POST are never logged
> -
>
> Key: SLING-297
> URL: https://issues.apache.org/jira/browse/SLING-297
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: 2.0.0
>
>
> If an exception occurs during POST processing, it is never logged.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SLING-298) FormEncoding parameter should be ignored during POST processing

2008-02-29 Thread Tobias Bocanegra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573909#action_12573909
 ] 

Tobias Bocanegra commented on SLING-298:


since the FormEncoding is used internally in sling as hint for a missing POST 
content type,
we might rename it to something more specific, like:

X-HTTP-ContentType

> FormEncoding parameter should be ignored during POST processing
> ---
>
> Key: SLING-298
> URL: https://issues.apache.org/jira/browse/SLING-298
> Project: Sling
>  Issue Type: Bug
>  Components: ujax
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>
> The FormEncoding parameter should be ignored during post processing and not 
> be set as a property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SLING-295) Specify nodetype for node creation

2008-02-29 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra updated SLING-295:
---

Attachment: ujax_create_fix.r632454.patch

includes fix for this issue and SLING-299.

changes:
- divided content processing in 2 steps:
  1) collect all properties
  2) write back content
- altered deepGetOrCreateNode() to use jcr:primaryType and jcr:mixinType props
- simplified RequestProperty to be less intelligent. always has an 'abs path'
- targeted node is always created
- added test cases for (deep) node creation with node types
- (re)enabled move test cases

> Specify nodetype for node creation
> --
>
> Key: SLING-295
> URL: https://issues.apache.org/jira/browse/SLING-295
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Attachments: patch.txt, ujax_create_fix.r632454.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> It would be nice to specify the node type for new nodes when they are created 
> through the post servlet.
> Perhaps by specifying a node type parameter (like ujax:nodetype)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SLING-280) ujax post serlvet should be able to insert new nodes at specified location

2008-02-29 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra updated SLING-280:
---

Attachment: ujax_order_fix.r632454.patch

implements node ordering as described by bertrand.
note that this patch also includes the changes of my patch of SLING-295.


> ujax post serlvet should be able to insert new nodes at specified location
> --
>
> Key: SLING-280
> URL: https://issues.apache.org/jira/browse/SLING-280
> Project: Sling
>  Issue Type: Improvement
>Reporter: Tobias Bocanegra
> Attachments: ujax_order_fix.r632454.patch
>
>
> the current version only supports: ujax:order = 0, which orders a newly 
> created node above it's siblings.
> suggest to implement the following variants:
> ujax:order= ("below" | "above" ) [name]
> example: 
> /a
> /b
> /c
> ujax:order="above b"  -> /a, /newnode, /b, /c
> ujax:order="above a"  -> /newnode, /a, /b, /c
> ujax:order="above"  -> /newnode, /a, /b, /c
> ujax:order="below b" -> /a,/b,/newnode,/c
> ujax:order="below c" -> /a,/b,/c,/newnode
> ujax:order="below" -> /a,/b,/c,/newnode
> Please note that JCR does not support the 'below' ordering and it's 'above' 
> handling is different. but i think in  scripting environment, where you loop 
> over a list. the "below" makes sense, since you don't need to know the next 
> list item when drawing the 'insert' form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (SLING-293) bundle resource content loader should use default nodetype if non specified in the serialization

2008-02-29 Thread Tobias Bocanegra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra closed SLING-293.
--


thanks.

> bundle resource content loader should use default nodetype if non specified 
> in the serialization
> 
>
> Key: SLING-293
> URL: https://issues.apache.org/jira/browse/SLING-293
> Project: Sling
>  Issue Type: Bug
>  Components: Resource
>Reporter: Tobias Bocanegra
>Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> the primary node type of the 'nodes' that the content loader used to install 
> bundled content is initialized with 'nt:unstructured'.
> this causes new nodes always to be created with 'nt:unstructured' even if no 
> primary type is specified in the serialization.
> the correct way would be to use: Node.addNode(String name); and let the 
> repository choose the correct nodetype.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.