Re: [jira] Commented: (SLING-249) Allow mapping nodes to internet domains
On Nov 27, 2008, at 4:25 AM, Felix Meschberger wrote: Roy T. Fielding schrieb: But that is backwards, in my opinion. We should have a node called /content/beispiel that says it is a hard link (alias) for /content/sample because sample may be a fixed node type that is either non-modifiable or limited in its allowed properties. Does JCR support hard links natively in JSR 283? If not, we can use sling:alias. I defined a mixin node type sling:ResourceAlias, which provides the sling:alias property and which may be assigned to the resoure which would take the property. There are catches with each solution: My solution, which you call "backwards" is harder to implement in the resolver since we have to scan the children for any property set as expected. On the other hand it is easier to manage as a property of the resource to which it applies and it moves together with the resource. Your solution (lets call it "forward") is simpler to implement in the resolver, but we would have to check on each access whether there is a property set on the resovled resource. But managing the value is more complicated because when moving the target (move, delete, copy) the alias still "points" to the old location thus resolution will be failing. I tend to prefer the "backwards" way. I should have mentioned that the reason it is backwards is because resources are expected to have hierarchical names that may be governed by access control. Names under a given level (collection) are expected to be allocated through permissions on that level, just as you need write permission on a filesystem directory in order to change the filenames within it. That access control may be delegated down to individual nodes. In other words, the ownership of a child node does not imply permission to create sibling nodes/aliases, which makes the "backwards" way a minor security hole. For example, say I have a hierarchy like path owner === === /students/(admin) |mike(mike) |kim (kim) `roy (roy) and then kim graduates. The admin owner of /students/ decides to delete /students/kim because the association is gone, and has implemented some default code somewhere that says a "not found" under students will result in a 410 (Gone) message. The backwards scheme will allow any student to recreate /students/kim as an alias to their own (authorized) page. Likewise, students can create their own fun aliases, like "bestinclass" "sir_farts_a_lot", etc. And, while that's just a silly example, the same would be true of multiple merchants sharing a single host, or rival dealerships within the same manufacturer's information space. Roy
Reference Properties
Is there a way to post an html form in sling and have it automatically create a REFERENCE property or do I have to handle to post in code and create the REFERENCE property manually. Darrell Pittman Developer zedIT Solutions Incorporated Creating IT Solutions that produce business results. 210 Water Street | Suite 400 St. John's, Newfoundland A1C 1A9 Direct: 709.722.7213 ext.222 | Toll Free: 877.722.1177 Fax: 709.722.7214 | Web: www.zeditsolutions.com http://www.zeditsolutions.com/> The information contained in this email is strictly confidential and may be legally privileged and protected from disclosure by law. This email is intended for use by the addressee only. Notice is hereby given that any disclosure, use or copying of the information by anyone other than the intended recipient is strictly prohibited and may be illegal. If you have received this email in error, please destroy all electronic and other copies of this message and contact the sender or zed at [EMAIL PROTECTED] mailto:[EMAIL PROTECTED]>
[jira] Commented: (SLING-755) Move /system/sling/jcrinstall servlet to its own bundle
[ https://issues.apache.org/jira/browse/SLING-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652876#action_12652876 ] Felix Meschberger commented on SLING-755: - Hmm, looking at the JcrInstallServlet code, this looks like it would best be a web console plugin ;-) I think the JcrInstallServlet could in fact report more on its working like: what locations are being considered, what has been found there, whether that has been applied or not and why not ... This all would make a perfect addition to the console. It looks just kind of strange having a buindle with a single class in it > Move /system/sling/jcrinstall servlet to its own bundle > --- > > Key: SLING-755 > URL: https://issues.apache.org/jira/browse/SLING-755 > Project: Sling > Issue Type: Improvement > Components: JCR Install >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: JCR Install 2.0.4 > > > Making a servlet out of the jcrinstall RepositoryObserver class introduces > dependencies on the sling api and servlet bundles, which are not desired for > jcrinstall - its dependencies should be kept to a minimum. > I'll move the servlet to its own bundle - it is currently only needed for > integration testing, but might be useful for other monitoring purposes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-755) Move /system/sling/jcrinstall servlet to its own bundle
[ https://issues.apache.org/jira/browse/SLING-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-755. --- Resolution: Fixed Fix Version/s: JCR Install 2.0.4 extensions/jcrinstall/servlet module added in revision 722981 - sorry, didn't take time to look at the optional dependencies options, that's one more bundle that does not much I think it's cleaner in this way. > Move /system/sling/jcrinstall servlet to its own bundle > --- > > Key: SLING-755 > URL: https://issues.apache.org/jira/browse/SLING-755 > Project: Sling > Issue Type: Improvement > Components: JCR Install >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: JCR Install 2.0.4 > > > Making a servlet out of the jcrinstall RepositoryObserver class introduces > dependencies on the sling api and servlet bundles, which are not desired for > jcrinstall - its dependencies should be kept to a minimum. > I'll move the servlet to its own bundle - it is currently only needed for > integration testing, but might be useful for other monitoring purposes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-755) Move /system/sling/jcrinstall servlet to its own bundle
[ https://issues.apache.org/jira/browse/SLING-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652859#action_12652859 ] Bertrand Delacretaz commented on SLING-755: --- > Can you come around by making the import dependency optional and only > register the > servlet should the dependency be resovled ? (Similar to what we do with the > web console plugins) We could probably do that, but as the jcrinstall servlet is currently only used in integration tests, I think it's better to separate it and keep the jcrinstall dependencies to the bare minimum. > Move /system/sling/jcrinstall servlet to its own bundle > --- > > Key: SLING-755 > URL: https://issues.apache.org/jira/browse/SLING-755 > Project: Sling > Issue Type: Improvement > Components: JCR Install >Reporter: Bertrand Delacretaz >Priority: Minor > > Making a servlet out of the jcrinstall RepositoryObserver class introduces > dependencies on the sling api and servlet bundles, which are not desired for > jcrinstall - its dependencies should be kept to a minimum. > I'll move the servlet to its own bundle - it is currently only needed for > integration testing, but might be useful for other monitoring purposes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-755) Move /system/sling/jcrinstall servlet to its own bundle
[ https://issues.apache.org/jira/browse/SLING-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652855#action_12652855 ] Felix Meschberger commented on SLING-755: - What is the kind of undesired dependencies ? Can you come around by making the import dependency optional and only register the servlet should the dependency be resovled ? (Similar to what we do with the web console plugins) > Move /system/sling/jcrinstall servlet to its own bundle > --- > > Key: SLING-755 > URL: https://issues.apache.org/jira/browse/SLING-755 > Project: Sling > Issue Type: Improvement > Components: JCR Install >Reporter: Bertrand Delacretaz >Priority: Minor > > Making a servlet out of the jcrinstall RepositoryObserver class introduces > dependencies on the sling api and servlet bundles, which are not desired for > jcrinstall - its dependencies should be kept to a minimum. > I'll move the servlet to its own bundle - it is currently only needed for > integration testing, but might be useful for other monitoring purposes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-755) Move /system/sling/jcrinstall servlet to its own bundle
Move /system/sling/jcrinstall servlet to its own bundle --- Key: SLING-755 URL: https://issues.apache.org/jira/browse/SLING-755 Project: Sling Issue Type: Improvement Components: JCR Install Reporter: Bertrand Delacretaz Priority: Minor Making a servlet out of the jcrinstall RepositoryObserver class introduces dependencies on the sling api and servlet bundles, which are not desired for jcrinstall - its dependencies should be kept to a minimum. I'll move the servlet to its own bundle - it is currently only needed for integration testing, but might be useful for other monitoring purposes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-734) jcrinstall integration tests
[ https://issues.apache.org/jira/browse/SLING-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-734. - Resolution: Fixed Fix Version/s: JCR Install 2.0.4 Added two more stress tests in revision 722928. Closing this issue, please open more specific issues for missing tests if needed. > jcrinstall integration tests > > > Key: SLING-734 > URL: https://issues.apache.org/jira/browse/SLING-734 > Project: Sling > Issue Type: Test > Components: JCR Install >Reporter: Bertrand Delacretaz > Fix For: JCR Install 2.0.4 > > > Create integration tests for jcrinstall, to test startup and bundles > installs/updates/deletes on a real repository, as opposed to the current > mock-based tests. > Those tests should be in a separate module so as not to slow down the Sling > build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-734) jcrinstall integration tests
[ https://issues.apache.org/jira/browse/SLING-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652819#action_12652819 ] Bertrand Delacretaz commented on SLING-734: --- I also added a jcrinstall info servlet at system/sling/jcrinstall, outputs info in Properties format, example: #jcrinstall status #Wed Dec 03 15:56:26 CET 2008 bundles.in.state.32=33 jcrinstall.enabled=false bundles.in.state.4=140 osgi.start.level=20 > jcrinstall integration tests > > > Key: SLING-734 > URL: https://issues.apache.org/jira/browse/SLING-734 > Project: Sling > Issue Type: Test > Components: JCR Install >Reporter: Bertrand Delacretaz > > Create integration tests for jcrinstall, to test startup and bundles > installs/updates/deletes on a real repository, as opposed to the current > mock-based tests. > Those tests should be in a separate module so as not to slow down the Sling > build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-752) JcrResourceResolver2 resolve(String) method not API conform
[ https://issues.apache.org/jira/browse/SLING-752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned SLING-752: --- Assignee: Felix Meschberger > JcrResourceResolver2 resolve(String) method not API conform > --- > > Key: SLING-752 > URL: https://issues.apache.org/jira/browse/SLING-752 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.4 >Reporter: christian >Assignee: Felix Meschberger >Priority: Minor > Attachments: SLING-752-2.patch, SLING-752.patch > > > Affected is the JcrResourceResolver2#resolve(abspath) method. > If abspath argument doesn't point to an Item, the resolver returns a > Resource of type non-existing. > The API according its JAVA-Doc requires to return in this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-752) JcrResourceResolver2 resolve(String) method not API conform
[ https://issues.apache.org/jira/browse/SLING-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652793#action_12652793 ] Felix Meschberger commented on SLING-752: - Applied the JavaDoc clarification of the second patch in Rev. 722892 Adapted the old JcrResourceResolver in Rev. 722886 > JcrResourceResolver2 resolve(String) method not API conform > --- > > Key: SLING-752 > URL: https://issues.apache.org/jira/browse/SLING-752 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.4 >Reporter: christian >Priority: Minor > Attachments: SLING-752-2.patch, SLING-752.patch > > > Affected is the JcrResourceResolver2#resolve(abspath) method. > If abspath argument doesn't point to an Item, the resolver returns a > Resource of type non-existing. > The API according its JAVA-Doc requires to return in this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-734) jcrinstall integration tests
[ https://issues.apache.org/jira/browse/SLING-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652787#action_12652787 ] Bertrand Delacretaz commented on SLING-734: --- Test infrastructure created in revision 722885, first simple test works (InstallClonedBundlesTest). The tests can easily create large number of bundles, by creating and installing clones of the test "observer" bundle, each with its own unique symbolic name. See http://svn.apache.org/repos/asf/incubator/sling/trunk/extensions/jcrinstall/testing/README.txt for more info. > jcrinstall integration tests > > > Key: SLING-734 > URL: https://issues.apache.org/jira/browse/SLING-734 > Project: Sling > Issue Type: Test > Components: JCR Install >Reporter: Bertrand Delacretaz > > Create integration tests for jcrinstall, to test startup and bundles > installs/updates/deletes on a real repository, as opposed to the current > mock-based tests. > Those tests should be in a separate module so as not to slow down the Sling > build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-752) JcrResourceResolver2 resolve(String) method not API conform
[ https://issues.apache.org/jira/browse/SLING-752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated SLING-752: Attachment: SLING-752-2.patch Modified API doc patch: * Allows resolve(String) to return null for compatibility * Documents optional SlingException may be thrown * Requires parameters to resolve(String) and resolve(HttpServletRequest) > JcrResourceResolver2 resolve(String) method not API conform > --- > > Key: SLING-752 > URL: https://issues.apache.org/jira/browse/SLING-752 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.4 >Reporter: christian >Priority: Minor > Attachments: SLING-752-2.patch, SLING-752.patch > > > Affected is the JcrResourceResolver2#resolve(abspath) method. > If abspath argument doesn't point to an Item, the resolver returns a > Resource of type non-existing. > The API according its JAVA-Doc requires to return in this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-752) JcrResourceResolver2 resolve(String) method not API conform
[ https://issues.apache.org/jira/browse/SLING-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652785#action_12652785 ] Felix Meschberger commented on SLING-752: - As pointed out by Carsten in the thread at [1], it is more important to be backwards compatible in this case. So I will modify the JavaDoc as follows: * resolve(HttpServletRequest) never returns null (has always been like that) * resolve(HttpServletRequest, String) never returns null (is a new method anyway) * resolve(String) will return null if no resource can be resolved [1] http://markmail.org/message/ulqwzjilp6prq75m > JcrResourceResolver2 resolve(String) method not API conform > --- > > Key: SLING-752 > URL: https://issues.apache.org/jira/browse/SLING-752 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.4 >Reporter: christian >Priority: Minor > Attachments: SLING-752.patch > > > Affected is the JcrResourceResolver2#resolve(abspath) method. > If abspath argument doesn't point to an Item, the resolver returns a > Resource of type non-existing. > The API according its JAVA-Doc requires to return in this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-754) Servlets registered with selectors and methods are not found
[ https://issues.apache.org/jira/browse/SLING-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652773#action_12652773 ] Felix Meschberger commented on SLING-754: - Applied fix in Rev. 722872 which should now consider this registration pattern. > Servlets registered with selectors and methods are not found > > > Key: SLING-754 > URL: https://issues.apache.org/jira/browse/SLING-754 > Project: Sling > Issue Type: Bug > Components: Servlets Resolver >Affects Versions: Servlets Resolver 2.0.6 >Reporter: Felix Meschberger >Assignee: Felix Meschberger > Fix For: Servlets Resolver 2.0.6 > > > After the implementation of SLING-748, servlets registered with selectors and > with method names are not resolved any more. > A Servlet is registered as a resource at a path derieved from the selectors > with the method name appended. For example a servlet registered with > selectors "sample.selector" and method "POST" is registered as > "/sample/selector.POST.servlet" > The new servlet resolver does not check for the "selector.POST" pattern of > script names and hence misses servlets thus registered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-754) Servlets registered with selectors and methods are not found
Servlets registered with selectors and methods are not found Key: SLING-754 URL: https://issues.apache.org/jira/browse/SLING-754 Project: Sling Issue Type: Bug Components: Servlets Resolver Affects Versions: Servlets Resolver 2.0.6 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Servlets Resolver 2.0.6 After the implementation of SLING-748, servlets registered with selectors and with method names are not resolved any more. A Servlet is registered as a resource at a path derieved from the selectors with the method name appended. For example a servlet registered with selectors "sample.selector" and method "POST" is registered as "/sample/selector.POST.servlet" The new servlet resolver does not check for the "selector.POST" pattern of script names and hence misses servlets thus registered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (SLING-752) JcrResourceResolver2 resolve(String) method not API conform
Hi Carsten Ziegeler schrieb: > Felix Meschberger wrote: >> Thanks for pointing this out. >> >> According to the current (and previous) implementation and expectations, >> this JavaDoc is wrong and the JavaDoc of the other resolve methods is >> incomplete and does not reflect intentions. >> >> The intentions are, that the resolve methods never return null but >> instead return a NonExistingResource if the path cannot resolve to a >> resource. >> >> This contrasts with the getResource methods, which in fact will return >> null if a resource cannot be found (and hence never return a >> NonExistingResource). >> >> So the solution to this problem would be update the JavaDoc to something >> like: "@return The resource addressed by the path or NonExistingResource >> if no resource can be resolved". >> > Hmm, so far the resolve(String) method returned null if the resource > could not be found. So I fear we can't change this behaviour as this > would introduce incompatibilities :( Yikes ! I did not read the code thoroughly enough ! It is the resolve(HttpServletRequest) method which never returns null. > > I'm all for a consistent behaviour so your suggestions make sense. > > People are always confused what the difference between resolve(String) > and getResource(String) is - if the only difference is that the latter > returns null in the case of a non existing resource we might also forget > about this method completly :) One difference is (the intended) return of null or not. Another difference is the resolution approach: resolve() tries hard finding a resource applying a lot of mapping logic. getResource() just simply tries to get the resource with the exact path and goes with the result. But I agree, that for the sake of backwards compatibility, the resolve(String) method should probably really return null. My Bad. Regards Felix > > Carsten
[jira] Commented: (SLING-753) Create new launchpad package project
[ https://issues.apache.org/jira/browse/SLING-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652722#action_12652722 ] Carsten Ziegeler commented on SLING-753: What about using deployment packages? > Create new launchpad package project > > > Key: SLING-753 > URL: https://issues.apache.org/jira/browse/SLING-753 > Project: Sling > Issue Type: Improvement > Components: Launchpad Launcher >Reporter: Felix Meschberger > > Currently the launchpad/app project prepares a runnable jar package from the > launchpad/base project (providing the launcher) and all the bundles required > for inclusion. The launchpad/webapp project takes the launchpad/app package > and modifies it by adding servlet container integration and removing the > embedded servlet container. > This construct creates a complicated dependency in the webapp project on app > internals. > It would probably be better to have a launchpad/package project, which just > packages everything which web app and app have in common and have the app and > webapp projects extend the package by adding additional stuff required for > the specific environment (standalone vs. servlet container). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-753) Create new launchpad package project
[ https://issues.apache.org/jira/browse/SLING-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652715#action_12652715 ] Bertrand Delacretaz commented on SLING-753: --- Sounds good, the current way of building the webapps (launchpad/webapp, launchpad/testing and the recently added extensions/jcrinstall/testing) is complicated and causes duplication between modules. Anything that allows these projects to inherit from a common base is welcome. > Create new launchpad package project > > > Key: SLING-753 > URL: https://issues.apache.org/jira/browse/SLING-753 > Project: Sling > Issue Type: Improvement > Components: Launchpad Launcher >Reporter: Felix Meschberger > > Currently the launchpad/app project prepares a runnable jar package from the > launchpad/base project (providing the launcher) and all the bundles required > for inclusion. The launchpad/webapp project takes the launchpad/app package > and modifies it by adding servlet container integration and removing the > embedded servlet container. > This construct creates a complicated dependency in the webapp project on app > internals. > It would probably be better to have a launchpad/package project, which just > packages everything which web app and app have in common and have the app and > webapp projects extend the package by adding additional stuff required for > the specific environment (standalone vs. servlet container). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
