Re: felix.service.urlhandlers disabled?
Felix Meschberger said the following on 03/04/2009 07:39 AM: > Hi Reto, > > Reto Bachmann-Gmür schrieb: > >> Is a version including this change available from a maven repository? >> > > Unfortunately not yet. Because of synchronization issues (there are > reproducible deadlocks) in the current Felix framework releases, we are > waiting for the next release of the Felix framework before we release > our launchpad. > > But if you can live with a SNAPSHOT, I can deploy one. > Than would be great (we're already using the snapshot version). Cheers, reto > Regards > Felix > > >> Cheers, >> reto >> >> Felix Meschberger said the following on 02/18/2009 03:22 PM: >> >>> As of Rev. 745521 I have enabled the URLHandlers by default again. See >>> also SLING-862 [1] >>> >>> Regards >>> Felix >>> >>> [1] https://issues.apache.org/jira/browse/SLING-862 >>> >>> Vidar Ramdal schrieb: >>> >>> Is there a reason for felix.service.urlhandlers=false in sling.properties? I had another case with this earlier, and I was under the impression that urlhandlers were to be enabled by default in the next release [1]. [1] http://markmail.org/message/qwfetelev7qjrzge >> > >
[jira] Commented: (SLING-877) Avoid calling Locale.getAvailableLocales() because it is very slow
[
https://issues.apache.org/jira/browse/SLING-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678689#action_12678689
]
Alexander Klimetschek commented on SLING-877:
-
toLocale() is only called during the component activation to set the default
locale based on the component configuration. I can imagine two optimizations:
a) make this lazy-loading (not sure when this might be called):
private Locale internalGetDefaultLocale() {
if (this.defaultLocale == null) {
this.defaultLocale = toLocale(localeString);
}
}
b) since in most cases the default locale will be english anyway, a simple
check could skip toLocale() and the performance intensive
Locale.getAvailableLocales() completely:
if ("en".equals(localeString)) {
this.defaultLocale = Locale.ENGLISH;
} else {
this.defaultLocale = internalGetDefaultLocale();
}
> Avoid calling Locale.getAvailableLocales() because it is very slow
> --
>
> Key: SLING-877
> URL: https://issues.apache.org/jira/browse/SLING-877
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Thomas Mueller
>
> Currently, JcrResourceBundleProvider.toLocale calls
> Locale.getAvailableLocales().
> The first call to this method is very slow (3.4 seconds on my machine) because
> it scans many jar files.
> http://svn.apache.org/viewvc/incubator/sling/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java?view=markup
> It looks like calling this method is not required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-877) Avoid calling Locale.getAvailableLocales() because it is very slow
[ https://issues.apache.org/jira/browse/SLING-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-877: - Attachment: JcrResourceBundleProvider.patch This patch reduces the startup time for my application from 12 seconds to 9 seconds. It does not seem to have any side-effect. > Avoid calling Locale.getAvailableLocales() because it is very slow > -- > > Key: SLING-877 > URL: https://issues.apache.org/jira/browse/SLING-877 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Thomas Mueller > Attachments: JcrResourceBundleProvider.patch > > > Currently, JcrResourceBundleProvider.toLocale calls > Locale.getAvailableLocales(). > The first call to this method is very slow (3.4 seconds on my machine) because > it scans many jar files. > http://svn.apache.org/viewvc/incubator/sling/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java?view=markup > It looks like calling this method is not required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-877) Avoid calling Locale.getAvailableLocales() because it is very slow
[
https://issues.apache.org/jira/browse/SLING-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678709#action_12678709
]
Jukka Zitting commented on SLING-877:
-
I would even question the need for the Locale.getISOLanguages() and
Locale.getISOCountries() calls in the method. A Locale instance is just an
identifier of the desired locale, so I'd argue that we should use the
user-specified value as-is without trying to filter or map it according to what
values the system may know about.
The method could well be something as simple as this:
String[] parts = localeString.split("_");
switch (parts.length) {
case 0: // empty locale string, use the default
return Locale.getDefault();
case 1: // only language
return new Locale(parts[0]);
case 2: // country is also available
return new Locale(parts[0], parts[1]);
case 3: // language, country and variant
default: // ... and skip everything after that
return new Locale(parts[0], parts[1], parts[2]);
}
> Avoid calling Locale.getAvailableLocales() because it is very slow
> --
>
> Key: SLING-877
> URL: https://issues.apache.org/jira/browse/SLING-877
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Thomas Mueller
> Attachments: JcrResourceBundleProvider.patch
>
>
> Currently, JcrResourceBundleProvider.toLocale calls
> Locale.getAvailableLocales().
> The first call to this method is very slow (3.4 seconds on my machine) because
> it scans many jar files.
> http://svn.apache.org/viewvc/incubator/sling/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java?view=markup
> It looks like calling this method is not required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-877) Avoid calling Locale.getAvailableLocales() because it is very slow
[
https://issues.apache.org/jira/browse/SLING-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678718#action_12678718
]
Bertrand Delacretaz commented on SLING-877:
---
Agree with Jukka that not doing any checks seems reasonable.
Do you know what's specified to happen if calling new Locale("foo", "bar") and
there's no foo_bar locale available?
In a quick test I seem to get the VM's default locale in that case, but the
Locale javadocs don't specify this case.
> Avoid calling Locale.getAvailableLocales() because it is very slow
> --
>
> Key: SLING-877
> URL: https://issues.apache.org/jira/browse/SLING-877
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Thomas Mueller
> Attachments: JcrResourceBundleProvider.patch
>
>
> Currently, JcrResourceBundleProvider.toLocale calls
> Locale.getAvailableLocales().
> The first call to this method is very slow (3.4 seconds on my machine) because
> it scans many jar files.
> http://svn.apache.org/viewvc/incubator/sling/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java?view=markup
> It looks like calling this method is not required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Jackrabbit User Admininstration
On Fri, Feb 27, 2009 at 10:53 AM, Felix Meschberger wrote:
> Eric Norman contributed Jackrabbit User Administration as part of
> SLING-875 [1]. Thanks alot for this, this fills an important gap IMHO.
I have started to look at Eric's UserManager stuff, and it looks
really useful. However, I'm unable to get it to work ("Invalid
operation specified for POST request") when running the samples
attached to SLING-875.
Are we still waiting for SLING-651, or is there some other problem I'm
running into?
> [1] https://issues.apache.org/jira/browse/SLING-875
--
Vidar S. Ramdal - http://www.idium.no
Akersgata 16, N-0158 Oslo, Norway
