Re: [Vote] Release Apache Sling 5
On Wed, May 6, 2009 at 5:33 PM, Carsten Ziegeler cziege...@apache.org wrote: ...I redid the release, which is not version 5 and we can vote again :)... I guess you mean *now* version 5 ;-) +1 on the release, details below. Signatures and digests verified. Tests with Maven version: 2.0.9, Java version: 1.5.0_16 on macosx 10.5.6. sling-5-incubator-source-release.tar.gz 2d3f26b986b12e4c3863c8352508cc6c sling-5-incubator-source-release.zip e60241ee568f76872684348690b069d5 Checked that those contain the exact same files. That source builds with mvn clean install after deleting the org/apache/sling in my local maven repository, but on my first build two tests failed in JspForwardTest (test result attached). Tried two more builds with no errors, didn't investigate more. The launchpad app: org.apache.sling.launchpad.app-5-incubator-bin.tar.gz bce9be4df9de0bb8e3f856dc83034fdb org.apache.sling.launchpad.app-5-incubator-bin.zip c96face22c569d5795ea549f729e2294 Checked that both contain the exact same files, which includes a useless nearly empty org.apache.sling.launchpad.app-5-incubator-sources.jar, no big deal. The runnable jar found in those passes all launchpad/testing integration tests, except those that use the launchpad/test-services bundle which is not present, that's correct. The launchpad webapp: org.apache.sling.launchpad.webapp-5-incubator.war e5e7acb1d7140f10e8247a4076ca094c Same test results as with the runnable jar, tested with tomcat 6.0.16. ...In addition I've built the corresponding maven artifacts of all modules... Didn't check those. Thanks for your work! -Bertrand --- Test set: org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest --- Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.07 sec FAILURE! testWithForward(org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest) Time elapsed: 0.342 sec FAILURE! junit.framework.AssertionFailedError: Text of node A is not included (html body h1JSP template/h1 p class=mainText B 1241774350710/p h2Test 1/h2 ppathToInclude = /JspForwardTest/1241774350700/text_a_1241774350700/p pIncluding /JspForwardTest/1241774350700/text_a_1241774350700/p html body h1JSP template/h1 p class=mainText A 1241774350700/p h2Test 1/h2 h2Test 2/h2 h2Test 3/h2 h2Test 4/h2 /body /html h2Test 2/h2 h2Test 3/h2 h2Test 4/h2 /body /html ) at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest.testWithForward(JspForwardTest.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at junit.framework.TestCase.runTest(TestCase.java:168) at junit.framework.TestCase.runBare(TestCase.java:134) at junit.framework.TestResult$1.protect(TestResult.java:110) at junit.framework.TestResult.runProtected(TestResult.java:128) at junit.framework.TestResult.run(TestResult.java:113) at junit.framework.TestCase.run(TestCase.java:124) at junit.framework.TestSuite.runTest(TestSuite.java:232) at junit.framework.TestSuite.run(TestSuite.java:227) at org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at
Re: [Vote] Release Apache Sling 5
We (other people in the Sakai community) have seen the same failures locally on one or two machines. It was thought to be down to other sling servers sitting on either port 8080, or but after stopping those instances and re-running the tests the passed and we didn't investigate further. BTW, this was a checkout of the tag and not a download of the release. Ian On 8 May 2009, at 11:24, Bertrand Delacretaz wrote: That source builds with mvn clean install after deleting the org/apache/sling in my local maven repository, but on my first build two tests failed in JspForwardTest (test result attached). Tried two more builds with no errors, didn't investigate more.
Re: [Vote] Release Apache Sling 5
Hi, Ian Boston schrieb: We (other people in the Sakai community) have seen the same failures locally on one or two machines. It was thought to be down to other sling servers sitting on either port 8080, or but after stopping those instances and re-running the tests the passed and we didn't investigate further. BTW, this was a checkout of the tag and not a download of the release. Ian On 8 May 2009, at 11:24, Bertrand Delacretaz wrote: That source builds with mvn clean install after deleting the org/apache/sling in my local maven repository, but on my first build two tests failed in JspForwardTest (test result attached). Tried two more builds with no errors, didn't investigate more. This test is about whether forwarding in jsp works at all (this generally has no issue) and checking for the forward loop limit (this may occasionally fail, though I do not understand right now, why) Regards Felix
Re: file upload question
Hi Juerg, Sling also reads the input for multipart/form-data encoded POSTs and provides them as RequestParamater objects [1] See [2] for full details. HTH Regards Felix [1] http://people.apache.org/~fmeschbe/slingdocs.762729/org/apache/sling/api/request/RequestParameter.html [2] http://incubator.apache.org/sling/site/request-parameters.html Juerg Meier schrieb: hi all, Re the file upload example at http://dev.day.com/microsling/content/blogs/main/fileuploadsinsling.html, code snippet # 3: how would you extract the original filename there? I tried it to parse it with commons fileupload, but this throws an IllegalStateException Request Data has already been read . Thanks, Juerg
Re: [Vote] Release Apache Sling 5
On Fri, May 8, 2009 at 1:49 PM, Felix Meschberger fmesc...@gmail.com wrote: Hi, Ian Boston schrieb: We (other people in the Sakai community) have seen the same failures locally on one or two machines. It was thought to be down to other sling servers sitting on either port 8080, or but after stopping those instances and re-running the tests the passed and we didn't investigate further. BTW, this was a checkout of the tag and not a download of the release. Ian On 8 May 2009, at 11:24, Bertrand Delacretaz wrote: That source builds with mvn clean install after deleting the org/apache/sling in my local maven repository, but on my first build two tests failed in JspForwardTest (test result attached). Tried two more builds with no errors, didn't investigate more. This test is about whether forwarding in jsp works at all (this generally has no issue) and checking for the forward loop limit (this may occasionally fail, though I do not understand right now, why) In my tests it's not the loop test that failed, it's Text of node A is not included in testWithForward(), so include was not working. Wondering if this might have to do with some service not being completely started when the tests run. -Bertrand
JspForwardTest Failure (was: [Vote] Release Apache Sling 5)
Hi, Bertrand Delacretaz schrieb: On Fri, May 8, 2009 at 1:49 PM, Felix Meschberger fmesc...@gmail.com wrote: Hi, Ian Boston schrieb: We (other people in the Sakai community) have seen the same failures locally on one or two machines. It was thought to be down to other sling servers sitting on either port 8080, or but after stopping those instances and re-running the tests the passed and we didn't investigate further. BTW, this was a checkout of the tag and not a download of the release. Ian On 8 May 2009, at 11:24, Bertrand Delacretaz wrote: That source builds with mvn clean install after deleting the org/apache/sling in my local maven repository, but on my first build two tests failed in JspForwardTest (test result attached). Tried two more builds with no errors, didn't investigate more. This test is about whether forwarding in jsp works at all (this generally has no issue) and checking for the forward loop limit (this may occasionally fail, though I do not understand right now, why) In my tests it's not the loop test that failed, it's Text of node A is not included in testWithForward(), so include was not working. Wondering if this might have to do with some service not being completely started when the tests run. Strange, usually this test runs late IIRC and does not use much services except the JSP script handler. Regards Felix -Bertrand
Re: [Vote] Release Apache Sling 5
I am seeing the following running the standalone launchpad with a clean build of the sling-5-incubator-source-release tag, (and a clear local repo for both o.a.sling and o.a.felix) should it be happening ? HTTP ERROR 500 Problem accessing /system/console/configMgr. Reason: Filter cannot be null Caused by: java.lang.NullPointerException: Filter cannot be null at org.apache.felix.framework.FilterImpl.(FilterImpl.java:59) at org .apache .felix.framework.BundleContextImpl.createFilter(BundleContextImpl.java: 102) at org .apache .felix .webconsole .internal.compendium.ConfigManager.renderContent(ConfigManager.java:228) at org .apache .felix .webconsole .AbstractWebConsolePlugin.doGet(AbstractWebConsolePlugin.java:113) at org .apache .felix .webconsole.internal.compendium.ConfigManager.doGet(ConfigManager.java: 201) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org .apache .felix .webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:311) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java: 502) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:389) at org .ops4j .pax .web .service .internal .HttpServiceServletHandler.handle(HttpServiceServletHandler.java:64) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765) at org .ops4j .pax .web .service.internal.HttpServiceContext.handle(HttpServiceContext.java:111) at org.ops4j.pax.web.service.internal.JettyServerHandlerCollection.handle (JettyServerHandlerCollection.java:64) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:324) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java: 535) at org.mortbay.jetty.HttpConnection $RequestHandler.headerComplete(HttpConnection.java:865) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:539) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org .mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java: 409) at org.mortbay.thread.QueuedThreadPool $PoolThread.run(QueuedThreadPool.java:520) On 8 May 2009, at 13:41, Bertrand Delacretaz wrote: On Fri, May 8, 2009 at 1:49 PM, Felix Meschberger fmesc...@gmail.com wrote: Hi, Ian Boston schrieb: We (other people in the Sakai community) have seen the same failures locally on one or two machines. It was thought to be down to other sling servers sitting on either port 8080, or but after stopping those instances and re-running the tests the passed and we didn't investigate further. BTW, this was a checkout of the tag and not a download of the release. Ian On 8 May 2009, at 11:24, Bertrand Delacretaz wrote: That source builds with mvn clean install after deleting the org/apache/sling in my local maven repository, but on my first build two tests failed in JspForwardTest (test result attached). Tried two more builds with no errors, didn't investigate more. This test is about whether forwarding in jsp works at all (this generally has no issue) and checking for the forward loop limit (this may occasionally fail, though I do not understand right now, why) In my tests it's not the loop test that failed, it's Text of node A is not included in testWithForward(), so include was not working. Wondering if this might have to do with some service not being completely started when the tests run. -Bertrand
