[jira] Commented: (SLING-549) Scala script engine
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700220#action_12700220 ] Michael Dürig commented on SLING-549: - I created SLING-928 for the missing integration test and added a patch there. So I think this issue can be closed. > Scala script engine > --- > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Felix Meschberger >Priority: Minor > Attachments: SLING-549-2.patch, SLING-549-3.patch, > SLING-549-integration-test.patch, SLING-549-integration-test.patch, > SLING-549.patch > > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-549) Scala script engine
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675944#action_12675944 ] Bertrand Delacretaz commented on SLING-549: --- SLING-865 means integration tests will need to be moved to contrib/launchpad/testing. I'm fine with doing that, just making a note here to remember it. > Scala script engine > --- > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Felix Meschberger >Priority: Minor > Attachments: SLING-549-2.patch, SLING-549-3.patch, > SLING-549-integration-test.patch, SLING-549-integration-test.patch, > SLING-549.patch > > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-549) Scala script engine
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669894#action_12669894 ] Felix Meschberger commented on SLING-549: - Oops, the reactor used the same artifactId as the ScriptEngine project. I fixed this to be ...reactor now in Rev. 740242. Also in this revision I modified the root reactor POM to refer to the scala reactor instead of the projects directly. > Scala script engine > --- > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Felix Meschberger >Priority: Minor > Attachments: SLING-549-2.patch, SLING-549-3.patch, SLING-549.patch > > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-549) Scala script engine
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669723#action_12669723 ] Michael Dürig commented on SLING-549: - ok everything seems to work fine. The only thing I noticed is that the Scala scripting engine is not buildable from sling\scripting\scala. If I try to do so Maven fails with [INFO] Project 'org.apache.sling:org.apache.sling.scripting.scala' is duplicated in the reactor If this is not easy to fix, I suggest to remove the reactor pom from that location. I'll follow up on the integration test later this week. > Scala script engine > --- > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Felix Meschberger >Priority: Minor > Attachments: SLING-549-2.patch, SLING-549-3.patch, SLING-549.patch > > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-549) Scala script engine
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669581#action_12669581 ] Bertrand Delacretaz commented on SLING-549: --- Thanks Felix for taking care of this. > Could you please verify that everything works alright and then close this > issue ? Michael, while you're at it, could you add an integration test for this module in the launchpad/testing module? A smoke test similar to [1] would be good already, just something that proves that the Scala engine is basically working. This would also require adding the required sling/scala modules to launchpad/testing/pom.xml [1] launchpad/testing/src/test/resources/integration-test/rendering-test.jsp and launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/JspScriptingTest.java > Scala script engine > --- > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Felix Meschberger >Priority: Minor > Attachments: SLING-549-2.patch, SLING-549-3.patch, SLING-549.patch > > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
