Re: Adding non-integration tests for the launchpad code
On Fri, Apr 24, 2009 at 9:18 PM, Aaron Zeckoski wrote: > ...I am pretty sure the code is being exercised by the > integration tests since they are all working but I would be more > comfortable if there were unit tests in place as well. Agree 100%, go for it! > ... It would make > the patch much bigger though so it might be something that the > community would prefer not happen. What are the options/policies here?... Somewhat larger patches are not a problem as long as they are "atomic", i.e. each patch should fix/implement one thing only, or a closely related and consistent set of things. This allows us to accept/improve/reject each patch individually. Automated tests clearly belong to the patch that they test. -Bertrand
Re: Adding non-integration tests for the launchpad code
> Are you referring to SLING-922 ? In this case, I would assume, the unit > tests go into the launchpad/base module ? Yeah, this is what I was thinking. I don't want to mix them with the integration tests. :-) -AZ On Fri, Apr 24, 2009 at 8:28 PM, Felix Meschberger wrote: > Hi Aaron, > > Are you referring to SLING-922 ? In this case, I would assume, the unit > tests go into the launchpad/base module ? > > So putting them into src/test/java would be just fine. > > Im am not sure, whether we should include unit tests for the > launchpad/base module in the launchpad/testing module. This would then > smell more like "integration" tests to me. > > Regards > Felix > > Aaron Zeckoski schrieb: >> I would like to add a few unit tests to the launchpad code which I am >> updating with a patch. It seems like I would need to create a new test >> folder and package structure so before I do it I wanted to see if this >> was ok. I am pretty sure the code is being exercised by the >> integration tests since they are all working but I would be more >> comfortable if there were unit tests in place as well. It would make >> the patch much bigger though so it might be something that the >> community would prefer not happen. What are the options/policies here? >> >> -AZ >> > -- Aaron Zeckoski (aar...@vt.edu) Senior Research Engineer - CARET - Cambridge University [http://bugs.sakaiproject.org/confluence/display/~aaronz/] Sakai Fellow - [http://aaronz-sakai.blogspot.com/]
Re: Adding non-integration tests for the launchpad code
Hi Aaron, Are you referring to SLING-922 ? In this case, I would assume, the unit tests go into the launchpad/base module ? So putting them into src/test/java would be just fine. Im am not sure, whether we should include unit tests for the launchpad/base module in the launchpad/testing module. This would then smell more like "integration" tests to me. Regards Felix Aaron Zeckoski schrieb: > I would like to add a few unit tests to the launchpad code which I am > updating with a patch. It seems like I would need to create a new test > folder and package structure so before I do it I wanted to see if this > was ok. I am pretty sure the code is being exercised by the > integration tests since they are all working but I would be more > comfortable if there were unit tests in place as well. It would make > the patch much bigger though so it might be something that the > community would prefer not happen. What are the options/policies here? > > -AZ >
Adding non-integration tests for the launchpad code
I would like to add a few unit tests to the launchpad code which I am updating with a patch. It seems like I would need to create a new test folder and package structure so before I do it I wanted to see if this was ok. I am pretty sure the code is being exercised by the integration tests since they are all working but I would be more comfortable if there were unit tests in place as well. It would make the patch much bigger though so it might be something that the community would prefer not happen. What are the options/policies here? -AZ -- Aaron Zeckoski (aar...@vt.edu) Senior Research Engineer - CARET - Cambridge University [http://bugs.sakaiproject.org/confluence/display/~aaronz/] Sakai Fellow - [http://aaronz-sakai.blogspot.com/]
