[jira] Commented: (SOLR-85) [PATCH] Add update form to the admin screen
[
http://issues.apache.org/jira/browse/SOLR-85?page=comments#action_12459240 ]
Thorsten Scherler commented on SOLR-85:
---
Well this issue can be seen as enabler for SOLR-66.
Especially the upload part.
@Yonik, yes the commons-fileupload.jar handles the multi-part posts:
ServletFileUpload upload = new ServletFileUpload(factory);
// Parse the request
List iter;
try {
iter = upload.parseRequest(request);
} catch (FileUploadException e) {
throw new IOException(
"FileUploadException\nStack: "
+ e);
}
We then wrap the file and open an input stream, which we pass to the core.
InputStream stream = item.getInputStream();
commandReader = new BufferedReader(new InputStreamReader(stream));
core.update(commandReader, responseWriter);
I reckon we could test the mime-type of the file before posting it to the
core.update.
This way we can generate xml out of csv like in SOLR-66.
So instead making SOLR-66 a servlet on its on it should become something like a
solr.input.plugin. A input plugin is code that is transforming incoming input
to solr internal xml markup used fo updates.
Now lets assume the csv has a register input plugin then we need to change
core.update(commandReader, responseWriter);
to something like
InputPlugin plugin = core.lookupPlugin(stream);
core.update(plugin.getReader(), responseWriter);
The lookup would be done done via a register that contains all input plugins
and their mime-type pairs. This way one can imagine not only cvs or xml as
input data. Imagine one want to use a SQL backend to update solr, with a sql
input plugin that would become an easy task.
the only hard thing is how to auto determine (configure) the plugins used for
certain streams. As a workaround one could add the plugin as input parameter.
WDYT?
> [PATCH] Add update form to the admin screen
> ---
>
> Key: SOLR-85
> URL: http://issues.apache.org/jira/browse/SOLR-85
> Project: Solr
> Issue Type: New Feature
> Components: update
>Reporter: Thorsten Scherler
> Attachments: solar-85.png, solar-85.png,
> solar-85.with.file.upload.diff, solr-85.diff, solr-85.diff, solr-85.FINAL.diff
>
>
> It would be nice to have a webform to update solr via a http interface
> instead of using the post.sh.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-85) [PATCH] Add update form to the admin screen
[ http://issues.apache.org/jira/browse/SOLR-85?page=all ] Thorsten Scherler updated SOLR-85: -- Attachment: solar-85.with.file.upload.diff On Fri, 2006-12-15 at 09:08 -0800, Yonik Seeley (JIRA) wrote: Yonik Seeley commented on SOLR-85: > -- > > Cool stuff Thorsten! Cheers. :) > Things like this can increase the user-friendliness of Solr and make it > easier to learn. Yeah, and play around platform independent. > To be safe though, perhaps there should be an "update" page so someone > doesn't change an index with a single errant click? Done this, updated patch attached. > And make it easy to disable the update page from solrconfig.xml, Done this: ... ... true > and put a comment telling people how it can be disabled. I added further comments on the pages (index + update) how to change the behavior. > "commit" and "optimize" buttons would be nice! There is a commit checkbox, if you check it, after your update statements it will do as well a commit. Not sure about the optimize button, what will it do? > > Some ideas for a "future" update page (doesn't need to be in this patch) > - something that helps you build the XML... select a field, input value(s), > and have a "generate request" button so you can see what is about to be sent. yeah that would be nice > - show some update statistics... number of pending documents, etc yeah > - support for future update syntaxes (CSV?) see my comment before, I reckon the best way would be that the cvs becomes an input plugin and returns xml instead actually handle the request. Then the default input plugin (if no other input plugin is selected) would be a xml plugin, treating the Stream as is. > - ability to select files to upload you mean, more then one file? Yeah, should not be too hard. Anyway like you stated "future update page", maybe best to apply this patch and we open a new one for the mentioned enhancements. WDYT? > [PATCH] Add update form to the admin screen > --- > > Key: SOLR-85 > URL: http://issues.apache.org/jira/browse/SOLR-85 > Project: Solr > Issue Type: New Feature > Components: update >Reporter: Thorsten Scherler > Attachments: solar-85.png, solar-85.png, > solar-85.with.file.upload.diff, solar-85.with.file.upload.diff, solr-85.diff, > solr-85.diff, solr-85.FINAL.diff > > > It would be nice to have a webform to update solr via a http interface > instead of using the post.sh. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-85) [PATCH] Add update form to the admin screen
[ http://issues.apache.org/jira/browse/SOLR-85?page=all ] Thorsten Scherler updated SOLR-85: -- Attachment: solar-85.with.file.upload.diff Changing sysout to log. Removing obsolete variables. > [PATCH] Add update form to the admin screen > --- > > Key: SOLR-85 > URL: http://issues.apache.org/jira/browse/SOLR-85 > Project: Solr > Issue Type: New Feature > Components: update >Reporter: Thorsten Scherler > Attachments: solar-85.png, solar-85.png, > solar-85.with.file.upload.diff, solar-85.with.file.upload.diff, > solar-85.with.file.upload.diff, solr-85.diff, solr-85.diff, solr-85.FINAL.diff > > > It would be nice to have a webform to update solr via a http interface > instead of using the post.sh. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SOLR-86) [PATCH] standalone updater cli based on httpClient
[PATCH] standalone updater cli based on httpClient --- Key: SOLR-86 URL: http://issues.apache.org/jira/browse/SOLR-86 Project: Solr Issue Type: New Feature Components: update Reporter: Thorsten Scherler We need a cross platform replacement for the post.sh. The attached code is a direct replacement of the post.sh since it is actually doing the same exact thing. In the future one can extend the CLI with other feature like auto commit, etc.. Right now the code assumes that SOLR-85 is applied since we using the servlet of this issue to actually do the update. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-86) [PATCH] standalone updater cli based on httpClient
[ http://issues.apache.org/jira/browse/SOLR-86?page=all ] Attachment: solr-86.diff > [PATCH] standalone updater cli based on httpClient > --- > > Key: SOLR-86 > URL: http://issues.apache.org/jira/browse/SOLR-86 > Project: Solr > Issue Type: New Feature > Components: update >Reporter: Thorsten Scherler > Attachments: solr-86.diff > > > We need a cross platform replacement for the post.sh. > The attached code is a direct replacement of the post.sh since it is actually > doing the same exact thing. > In the future one can extend the CLI with other feature like auto commit, > etc.. > Right now the code assumes that SOLR-85 is applied since we using the servlet > of this issue to actually do the update. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SOLR-86) [PATCH] standalone updater cli based on httpClient
[ http://issues.apache.org/jira/browse/SOLR-86?page=comments#action_12459385 ] Thorsten Scherler commented on SOLR-86: --- Index: src/tools/updater/lib/commons-httpclient-3.0.1.jar Index: src/tools/updater/lib/commons-codec-1.3.jar Index: src/tools/updater/lib/commons-logging-1.1.jar see http://jakarta.apache.org/commons/httpclient/dependencies.html for the download pages. After applying the patch and adding above libs to src/tools/updater/lib you can install the updater with: ant updater.jar and follow the instructions given in this target. > [PATCH] standalone updater cli based on httpClient > --- > > Key: SOLR-86 > URL: http://issues.apache.org/jira/browse/SOLR-86 > Project: Solr > Issue Type: New Feature > Components: update >Reporter: Thorsten Scherler > Attachments: solr-86.diff > > > We need a cross platform replacement for the post.sh. > The attached code is a direct replacement of the post.sh since it is actually > doing the same exact thing. > In the future one can extend the CLI with other feature like auto commit, > etc.. > Right now the code assumes that SOLR-85 is applied since we using the servlet > of this issue to actually do the update. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (SOLR-85) [PATCH] Add update form to the admin screen
On Fri, 2006-12-15 at 11:16 -0800, Chris Hostetter wrote: > : The next thing on my list is to write a small cli based on httpclient to > : send the update docs as alternative of the post.sh. > > You may want to take a look at SOLR-20 and SOLR-30 ... those issues are > first stabs at Java Client APIs for query/update which if cleaned up a bit > could become the basis for your CLI. Hmm, I had a look at them but actually what I came up with is way smaller and more focused on the update part. https://issues.apache.org/jira/browse/SOLR-86 It is a replacement of the post.sh not much more (yet). salu2 -- thorsten "Together we stand, divided we fall!" Hey you (Pink Floyd)
[jira] Updated: (SOLR-85) [PATCH] Add update form to the admin screen
[ http://issues.apache.org/jira/browse/SOLR-85?page=all ] Thorsten Scherler updated SOLR-85: -- Attachment: solar-85.with.file.upload.diff Always using as surrounding tag. When in multiPart mode the commit field needs to be read within the multiPart processing. > [PATCH] Add update form to the admin screen > --- > > Key: SOLR-85 > URL: http://issues.apache.org/jira/browse/SOLR-85 > Project: Solr > Issue Type: New Feature > Components: update >Reporter: Thorsten Scherler > Attachments: solar-85.png, solar-85.png, > solar-85.with.file.upload.diff, solar-85.with.file.upload.diff, > solar-85.with.file.upload.diff, solar-85.with.file.upload.diff, solr-85.diff, > solr-85.diff, solr-85.FINAL.diff > > > It would be nice to have a webform to update solr via a http interface > instead of using the post.sh. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (SOLR-85) [PATCH] Add update form to the admin screen
On 12/18/06 7:52 AM, "Thorsten Scherler" <[EMAIL PROTECTED]> wrote: > On Fri, 2006-12-15 at 11:16 -0800, Chris Hostetter wrote: >> : The next thing on my list is to write a small cli based on httpclient to >> : send the update docs as alternative of the post.sh. >> >> You may want to take a look at SOLR-20 and SOLR-30 ... those issues are >> first stabs at Java Client APIs for query/update which if cleaned up a bit >> could become the basis for your CLI. > > Hmm, I had a look at them but actually what I came up with is way > smaller and more focused on the update part. > > https://issues.apache.org/jira/browse/SOLR-86 > > It is a replacement of the post.sh not much more (yet). I'll take a look at this. I also wrote my own, because I had no idea that the Java client code existed. wunder -- Walter Underwood Search Guru, Netflix
[jira] Updated: (SOLR-86) [PATCH] standalone updater cli based on httpClient
[ http://issues.apache.org/jira/browse/SOLR-86?page=all ] Thorsten Scherler updated SOLR-86: -- Attachment: solr-86.diff Adding auto commit to the updater. > [PATCH] standalone updater cli based on httpClient > --- > > Key: SOLR-86 > URL: http://issues.apache.org/jira/browse/SOLR-86 > Project: Solr > Issue Type: New Feature > Components: update >Reporter: Thorsten Scherler > Attachments: solr-86.diff, solr-86.diff > > > We need a cross platform replacement for the post.sh. > The attached code is a direct replacement of the post.sh since it is actually > doing the same exact thing. > In the future one can extend the CLI with other feature like auto commit, > etc.. > Right now the code assumes that SOLR-85 is applied since we using the servlet > of this issue to actually do the update. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Bertrand's Jira perms
I've added "bdelacretaz" to the solr-developers group in JIRA. (sorry for the delay) Erik On Dec 16, 2006, at 2:57 AM, Chris Hostetter wrote: Hmmm... acctually, i just found the mail from when Bertrand became a committer: Yonik sid he didn't have the Jira permissions. It looks like Doug did it for Mike. Doug: can you add Bertrand to solr-developers in Jira and/or give one of the rest of use the neccessary permissions to modify the group membership? : Date: Thu, 14 Dec 2006 19:41:43 -0800 (PST) : From: Chris Hostetter <[EMAIL PROTECTED]> : Reply-To: solr-dev@lucene.apache.org : To: solr-dev@lucene.apache.org : Subject: Bertrand's Jira perms : : : Yonik: : : It looks like Bertrand never got added to the solr-developers list. : : (that's what controls the list of asignee's as well right?) : : : : : : Date: Thu, 14 Dec 2006 05:06:22 -0800 (PST) : : From: "Bertrand Delacretaz (JIRA)" <[EMAIL PROTECTED]> : : Reply-To: solr-dev@lucene.apache.org : : To: solr-dev@lucene.apache.org : : Subject: [jira] Commented: (SOLR-59) Copy request parameters to Solr's : : response : : : : [ http://issues.apache.org/jira/browse/SOLR-59? page=comments#action_12458466 ] : : : : Bertrand Delacretaz commented on SOLR-59: : : - : : : : Thanks Yonik, I have commited your patch. : : : : I have renamed the OutputWriterTest.testOriginalSolrWriter test to testSOLR59responseHeaderVersions, and added a test where the "version"parameter is not used. : : : : I think you can close this issue (apparently I don't have sufficient permissions to do that). : : : : > Copy request parameters to Solr's response : : > -- : : > : : > Key: SOLR-59 : : > URL: http://issues.apache.org/jira/browse/ SOLR-59 : : > Project: Solr : : > Issue Type: Improvement : : >Reporter: Bertrand Delacretaz : : > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, SOLR-59-20061103.patch, SOLR-59-20061106- newfiles.tar.gz, SOLR-59-20061106.patch, SOLR-59-20061213.patch, SOLR-59-new-files-20061102.tar.gz : : > : : > : : > This patch copies the request parameters (explicit ones only, not the defaults) to Solr's XML output. : : > It is not configurable yet, it is enabled by default and adds a "queryParameters" list to the responseHeader: : : > : : > 0 : : > 1 : : > : : > : : > red : : > blue : : > : : > 10 : : > 0 : : > on : : > solr : : > : : > 2.1 : : > : : > : : > The above example includes a multi-valued parameter, "multi". : : > This might still change a bit, but if someone wants to play with it or improve it, here you go. : : : : -- : : This message is automatically generated by JIRA. : : - : : If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/ Administrators.jspa : : - : : For more information on JIRA, see: http://www.atlassian.com/ software/jira : : : : : : : : : : -Hoss : -Hoss
[jira] Updated: (SOLR-84) New Solr logo?
[ http://issues.apache.org/jira/browse/SOLR-84?page=all ] Linda Tan updated SOLR-84: -- Attachment: solr-logo-20061218.JPG Here's the logo without the crescent. IMO it looks better... less cluttered. -linda > New Solr logo? > -- > > Key: SOLR-84 > URL: http://issues.apache.org/jira/browse/SOLR-84 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: solr-84-source-files.zip, solr-logo-20061214.jpg, > solr-logo-20061218.JPG > > > Following up on SOLR-76, our trainee Nicolas Barbay (nicolas (put at here) > sarraux-dessous.ch) has reworked his logo proposal to be more "solar". > This can either be the start of a logo contest, or if people like it we could > adopt it. The gradients can make it a bit hard to integrate, not sure if this > is really a problem. > WDYT? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz resolved SOLR-59. - Resolution: Fixed Let's try my brand new Jira karma by resolving this... > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-20061103.patch, SOLR-59-20061106-newfiles.tar.gz, > SOLR-59-20061106.patch, SOLR-59-20061213.patch, > SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Bertrand's Jira perms
On 12/18/06, Erik Hatcher <[EMAIL PROTECTED]> wrote: I've added "bdelacretaz" to the solr-developers group in JIRA... Thanks, Ithe additional Jira functions work for me now. -Bertrand
