[jira] Commented: (SOLR-81) Add Query Spellchecker functionality
[ https://issues.apache.org/jira/browse/SOLR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483805 ] Otis Gospodnetic commented on SOLR-81: -- Hoss, another poossibly interesting and useful addition: Make use of public RAMDirectory(Directory dir) and allow one to specify that even though the spellchecker index exists in FS, use it only to pull it into a RAMDir-based index. Might not be a huge win because most spellchecker indices are probably pretty small and easily fit in RAM already, even when they are FSDir-based, but I thought I'd mention it anyway. > Add Query Spellchecker functionality > > > Key: SOLR-81 > URL: https://issues.apache.org/jira/browse/SOLR-81 > Project: Solr > Issue Type: New Feature > Components: search >Reporter: Otis Gospodnetic >Priority: Minor > Attachments: hoss.spell.patch, SOLR-81-edgengram-ngram.patch, > SOLR-81-ngram-schema.patch, SOLR-81-ngram.patch, SOLR-81-ngram.patch, > SOLR-81-ngram.patch, SOLR-81-ngram.patch, SOLR-81-spellchecker.patch, > SOLR-81-spellchecker.patch, SOLR-81-spellchecker.patch > > > Use the simple approach of n-gramming outside of Solr and indexing n-gram > documents. For example: > > lettuce > let > let ett ttu tuc uce > uce > lett > lett ettu ttuc tuce > tuce > > See: > http://www.mail-archive.com/solr-user@lucene.apache.org/msg01254.html > Java clients: SOLR-20 (add delete commit optimize), SOLR-30 (search) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-81) Add Query Spellchecker functionality
[ https://issues.apache.org/jira/browse/SOLR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483804 ] Otis Gospodnetic commented on SOLR-81: -- I haven't applied this and tried it, but I looked at the patch, and like the changes. The only issues I could stop are 3 typos that we can clean up later. > Add Query Spellchecker functionality > > > Key: SOLR-81 > URL: https://issues.apache.org/jira/browse/SOLR-81 > Project: Solr > Issue Type: New Feature > Components: search >Reporter: Otis Gospodnetic >Priority: Minor > Attachments: hoss.spell.patch, SOLR-81-edgengram-ngram.patch, > SOLR-81-ngram-schema.patch, SOLR-81-ngram.patch, SOLR-81-ngram.patch, > SOLR-81-ngram.patch, SOLR-81-ngram.patch, SOLR-81-spellchecker.patch, > SOLR-81-spellchecker.patch, SOLR-81-spellchecker.patch > > > Use the simple approach of n-gramming outside of Solr and indexing n-gram > documents. For example: > > lettuce > let > let ett ttu tuc uce > uce > lett > lett ettu ttuc tuce > tuce > > See: > http://www.mail-archive.com/solr-user@lucene.apache.org/msg01254.html > Java clients: SOLR-20 (add delete commit optimize), SOLR-30 (search) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-195) Wildcard/prefix queries not highlighted
[ https://issues.apache.org/jira/browse/SOLR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483799 ] Hoss Man commented on SOLR-195: --- i bet this could be fixed by adding an extractTerms method to ConstantScorePrefixQuery > Wildcard/prefix queries not highlighted > --- > > Key: SOLR-195 > URL: https://issues.apache.org/jira/browse/SOLR-195 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.1.0, 1.2 >Reporter: Mike Klaas >Priority: Minor > Fix For: 1.2 > > > Possible bug in query rewrite()ing: > http://www.nabble.com/return-matched-terms---fuzzy-or-wildcard-searches-tf3452757.html#a9640214 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-182) register SolrRequestHandlers at runtime / lazy loading
[ https://issues.apache.org/jira/browse/SOLR-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483796 ] Ryan McKinley commented on SOLR-182: yes, that situation is handled by this patch. This was one of my primary reasons for writing it! This patch lets you do call SolrCore.getCore() and inspect the schema/index/whatever. Without it, you need to do some sort of lazy loading after the first request. > register SolrRequestHandlers at runtime / lazy loading > -- > > Key: SOLR-182 > URL: https://issues.apache.org/jira/browse/SOLR-182 > Project: Solr > Issue Type: Improvement >Reporter: Ryan McKinley > Fix For: 1.2 > > Attachments: SOLR-182-RuntimeRequestHandlers.patch, > SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch, > SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch > > > It would be useful to be able to register handlers after SolrCore has been > initialized initialized. It is also useful to be able to ask what handlers > are registered and to where. This patch adds the following functions to > SolrCore: > SolrRequestHandler registerRequestHandler(String handlerName, > SolrRequestHandler handler); > Collection getRequestHandlers(Class SolrRequestHandler> clazz); > It also guarantees that request handlers will be initialized with an argument > saying what path it is registered to. RequestHandlerBase gets a bean for the > registered path. > While discussing this, Yonik suggested making it possible to defer > initialization of some handlers that will be infrequently used. I added the > 'LazyRequestHandlerWrapper' (if taking this out makes the patch any easier > to commit - it can get its own issue) > check: > http://www.nabble.com/Dynamic-RequestHandler-loading-tf3351707.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-81) Add Query Spellchecker functionality
[ https://issues.apache.org/jira/browse/SOLR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483795 ] Ryan McKinley commented on SOLR-81: --- > * can't do relative path to dataDir, because we can't getdataDir, >because SolrCore isn't done initializing yet. with SOLR-182, SolrCore gets initialized first - so we could use relative paths during handler initialization. > Add Query Spellchecker functionality > > > Key: SOLR-81 > URL: https://issues.apache.org/jira/browse/SOLR-81 > Project: Solr > Issue Type: New Feature > Components: search >Reporter: Otis Gospodnetic >Priority: Minor > Attachments: hoss.spell.patch, SOLR-81-edgengram-ngram.patch, > SOLR-81-ngram-schema.patch, SOLR-81-ngram.patch, SOLR-81-ngram.patch, > SOLR-81-ngram.patch, SOLR-81-ngram.patch, SOLR-81-spellchecker.patch, > SOLR-81-spellchecker.patch, SOLR-81-spellchecker.patch > > > Use the simple approach of n-gramming outside of Solr and indexing n-gram > documents. For example: > > lettuce > let > let ett ttu tuc uce > uce > lett > lett ettu ttuc tuce > tuce > > See: > http://www.mail-archive.com/solr-user@lucene.apache.org/msg01254.html > Java clients: SOLR-20 (add delete commit optimize), SOLR-30 (search) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-182) register SolrRequestHandlers at runtime / lazy loading
[ https://issues.apache.org/jira/browse/SOLR-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483794 ] Hoss Man commented on SOLR-182: --- related note i'm typing before i forget... in SOLR-81 i tried to call SolrCore.getSolrCore.getDataDir() in the init method of a requestHandler and got an infinite loop. I can't remember if this type of situation would be prevented by this patch or not ... if it isn't that doesn't mean this patch shouldn't be committed, it just means we should probably open a separate bug to try and detect/prevent/error in that situation. > register SolrRequestHandlers at runtime / lazy loading > -- > > Key: SOLR-182 > URL: https://issues.apache.org/jira/browse/SOLR-182 > Project: Solr > Issue Type: Improvement >Reporter: Ryan McKinley > Fix For: 1.2 > > Attachments: SOLR-182-RuntimeRequestHandlers.patch, > SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch, > SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch > > > It would be useful to be able to register handlers after SolrCore has been > initialized initialized. It is also useful to be able to ask what handlers > are registered and to where. This patch adds the following functions to > SolrCore: > SolrRequestHandler registerRequestHandler(String handlerName, > SolrRequestHandler handler); > Collection getRequestHandlers(Class SolrRequestHandler> clazz); > It also guarantees that request handlers will be initialized with an argument > saying what path it is registered to. RequestHandlerBase gets a bean for the > registered path. > While discussing this, Yonik suggested making it possible to defer > initialization of some handlers that will be infrequently used. I added the > 'LazyRequestHandlerWrapper' (if taking this out makes the patch any easier > to commit - it can get its own issue) > check: > http://www.nabble.com/Dynamic-RequestHandler-loading-tf3351707.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-81) Add Query Spellchecker functionality
[ https://issues.apache.org/jira/browse/SOLR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-81: - Attachment: hoss.spell.patch patch makes a few changes, if there are no objections i'll try to commit this on monday * fixed NPE if no q param (when using cmd) * fixed schema.xml to know about "words" field in spellchecker.xml * cmd=rebuild needs to be disabled if termSourceField is null * added "cmd=reopen" for people maintaining the spell index externally. * added support for ramDir based spell index. * can't do relative path to dataDir, because we can't getdataDir, because SolrCore isn't done initializing yet. * added more explanation to solrconfig.xml about meaning of params, and changed the default values to work for anyone (using ramdir) * I punted on the issue of field type encoding by making it clear in the solrconfig.xml comments that termSourceField needs to use a simple field type Remaining issues... * should we add a firstSearcher or newSearcher hook to rebuild in the example solrconfig.xml ? * i don't have an optinion about passing an IndexReader to suggestSimilar, if we want to do that it shouldn't be a static reader, it should come from the current request ... in the meantime i changed the name of the current one to "nullReader" so it's clear what it is. * the indenting is currently a hodgepodge of 2spaces vs 4 spaces ... i'll fix after commiting (trying to keep the patch easy to read for now) > Add Query Spellchecker functionality > > > Key: SOLR-81 > URL: https://issues.apache.org/jira/browse/SOLR-81 > Project: Solr > Issue Type: New Feature > Components: search >Reporter: Otis Gospodnetic >Priority: Minor > Attachments: hoss.spell.patch, SOLR-81-edgengram-ngram.patch, > SOLR-81-ngram-schema.patch, SOLR-81-ngram.patch, SOLR-81-ngram.patch, > SOLR-81-ngram.patch, SOLR-81-ngram.patch, SOLR-81-spellchecker.patch, > SOLR-81-spellchecker.patch, SOLR-81-spellchecker.patch > > > Use the simple approach of n-gramming outside of Solr and indexing n-gram > documents. For example: > > lettuce > let > let ett ttu tuc uce > uce > lett > lett ettu ttuc tuce > tuce > > See: > http://www.mail-archive.com/solr-user@lucene.apache.org/msg01254.html > Java clients: SOLR-20 (add delete commit optimize), SOLR-30 (search) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-195) Wildcard/prefix queries not highlighted
Wildcard/prefix queries not highlighted --- Key: SOLR-195 URL: https://issues.apache.org/jira/browse/SOLR-195 Project: Solr Issue Type: Bug Components: search Affects Versions: 1.1.0, 1.2 Reporter: Mike Klaas Priority: Minor Fix For: 1.2 Possible bug in query rewrite()ing: http://www.nabble.com/return-matched-terms---fuzzy-or-wildcard-searches-tf3452757.html#a9640214 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.