Re: svn commit: r734860 - /lucene/solr/trunk/src/java/org/apache/solr/handler/XMLLoader.java

2009-01-15 Thread Ryan McKinley

thanks hoss!


On Jan 15, 2009, at 6:51 PM, hoss...@apache.org wrote:


Author: hossman
Date: Thu Jan 15 15:51:20 2009
New Revision: 734860

URL: http://svn.apache.org/viewvc?rev=734860&view=rev
Log:
revert Koji's revert of ryan's exception chaining -- but this time  
using java 1.5


Modified:
   lucene/solr/trunk/src/java/org/apache/solr/handler/XMLLoader.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/handler/ 
XMLLoader.java

URL: 
http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/XMLLoader.java?rev=734860&r1=734859&r2=734860&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- lucene/solr/trunk/src/java/org/apache/solr/handler/ 
XMLLoader.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/handler/ 
XMLLoader.java Thu Jan 15 15:51:20 2009

@@ -70,7 +70,7 @@
}
catch (XMLStreamException e) {
  //Hmmm, not quite right
-  throw new IOException(e.getMessage());
+  throw (IOException) new  
IOException(e.getMessage()).initCause(e);

} finally {
  IOUtils.closeQuietly(reader);
}






[jira] Closed: (SOLR-955) JdbcDataSource : getARow() : Do not hardcode default type ..

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay closed SOLR-955.



Thanks Shalin . 

> JdbcDataSource : getARow() : Do not hardcode default type ..
> 
>
> Key: SOLR-955
> URL: https://issues.apache.org/jira/browse/SOLR-955
> Project: Solr
>  Issue Type: Improvement
>  Components: contrib - DataImportHandler
>Affects Versions: 1.3
> Environment: Java 6 , Tomcat 6
>Reporter: Kay Kay
>Assignee: Shalin Shekhar Mangar
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-955.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Patch to replace the hard-coded default type in getARow() method (instead of 
> 12, it should have been Types.VARCHAR ) - without affecting the semantics. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-935:
-

Priority: Major  (was: Minor)

Increasing priority since in a workflow scenario with more than 2 delta-import 
requests received at the server - we need some way to track in the debug log 
that one of them actually failed and need to be tried again. 

> DataImportHandler: Add logging to record failure to acquire lock by 
> DataImporter for a given request 
> -
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
>  Issue Type: Improvement
>  Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
>Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until 
> before  importLock.tryLock() method and then depending on the scheduling - 
> one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the 
> failure to acquire the mutex, to distinguish between successful start of 
> import and failure to do so. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-963) SolrQuery#addFacetField - Optimize addition of fields

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-963:
-

Attachment: SOLR-963.patch

add FacetFields en masse . 

> SolrQuery#addFacetField -  Optimize addition of fields 
> ---
>
> Key: SOLR-963
> URL: https://issues.apache.org/jira/browse/SOLR-963
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-963.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> Instead of adding one facet field each -  use the overloaded function in 
> ModifiableSolrParams (that takes all the elements) that adds facet fields en 
> masse .. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-963) SolrQuery#addFacetField - Optimize addition of fields

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-963:
-

  Component/s: clients - java
Fix Version/s: 1.4
 Priority: Minor  (was: Major)
  Description: Instead of adding one facet field each -  use the 
overloaded function in ModifiableSolrParams (that takes all the elements) that 
adds facet fields en masse ..   (was: Instead of adding one facet field each - 
optimize the function in ModifiableSolrParams that adds facet fields en masse 
.. )
Affects Version/s: 1.3

> SolrQuery#addFacetField -  Optimize addition of fields 
> ---
>
> Key: SOLR-963
> URL: https://issues.apache.org/jira/browse/SOLR-963
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> Instead of adding one facet field each -  use the overloaded function in 
> ModifiableSolrParams (that takes all the elements) that adds facet fields en 
> masse .. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-963) SolrQuery#addFacetField - Optimize addition of fields

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-963:
-

Attachment: (was: SOLR-963.patch)

> SolrQuery#addFacetField -  Optimize addition of fields 
> ---
>
> Key: SOLR-963
> URL: https://issues.apache.org/jira/browse/SOLR-963
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> Instead of adding one facet field each -  use the overloaded function in 
> ModifiableSolrParams (that takes all the elements) that adds facet fields en 
> masse .. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-963) SolrQuery#addFacetField - Optimize addition of fields

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-963:
-

Attachment: SOLR-963.patch

SolrQuery#addFacetField - add all of the fields en masse .. 

> SolrQuery#addFacetField -  Optimize addition of fields 
> ---
>
> Key: SOLR-963
> URL: https://issues.apache.org/jira/browse/SOLR-963
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> Instead of adding one facet field each -  use the overloaded function in 
> ModifiableSolrParams (that takes all the elements) that adds facet fields en 
> masse .. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SOLR-963) SolrQuery#addFacetField - Optimize addition of fields

2009-01-15 Thread Kay Kay (JIRA)
SolrQuery#addFacetField -  Optimize addition of fields 
---

 Key: SOLR-963
 URL: https://issues.apache.org/jira/browse/SOLR-963
 Project: Solr
  Issue Type: Improvement
 Environment: Java 6, Tomcat 6
Reporter: Kay Kay


Instead of adding one facet field each - optimize the function in 
ModifiableSolrParams that adds facet fields en masse .. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-962) ModifiableSolrParams#add javadoc

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-962:
-

Attachment: SOLR-962.patch

ModifiableSolrParams#add(String, String ...) 

> ModifiableSolrParams#add javadoc 
> -
>
> Key: SOLR-962
> URL: https://issues.apache.org/jira/browse/SOLR-962
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-962.patch
>
>
> Javadoc 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-962) ModifiableSolrParams#add javadoc

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-962:
-

  Component/s: clients - java
Fix Version/s: 1.4
 Priority: Minor  (was: Major)
  Description: Javadoc 
  Environment: Java 6, Tomcat 6
Affects Version/s: 1.3

> ModifiableSolrParams#add javadoc 
> -
>
> Key: SOLR-962
> URL: https://issues.apache.org/jira/browse/SOLR-962
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-962.patch
>
>
> Javadoc 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-820) replicate After startup for new replication

2009-01-15 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664246#action_12664246
 ] 

Shalin Shekhar Mangar commented on SOLR-820:


Thanks for reporting this Michael. I'll try to reproduce the issue.

> replicate After startup for new replication
> ---
>
> Key: SOLR-820
> URL: https://issues.apache.org/jira/browse/SOLR-820
> Project: Solr
>  Issue Type: Improvement
>  Components: replication (scripts)
>Reporter: Noble Paul
>Assignee: Shalin Shekhar Mangar
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-820.patch
>
>
> add another option of 
> {code}
>  startup
> {code}
> so that replication can be triggered w/o a commit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SOLR-962) ModifiableSolrParams#add javadoc

2009-01-15 Thread Kay Kay (JIRA)
ModifiableSolrParams#add javadoc 
-

 Key: SOLR-962
 URL: https://issues.apache.org/jira/browse/SOLR-962
 Project: Solr
  Issue Type: Improvement
Reporter: Kay Kay




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (SOLR-883) Cores created through Admin do not have the implicit properties set

2009-01-15 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar reassigned SOLR-883:
--

Assignee: Shalin Shekhar Mangar

> Cores created through Admin do not have the implicit properties set
> ---
>
> Key: SOLR-883
> URL: https://issues.apache.org/jira/browse/SOLR-883
> Project: Solr
>  Issue Type: Bug
>Reporter: Noble Paul
>Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
>
> When a core is present in the solr.xml , the core has all the implicit 
> properties set. But when it is created through the REST API. It is not set

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (SOLR-955) JdbcDataSource : getARow() : Do not hardcode default type ..

2009-01-15 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar resolved SOLR-955.


Resolution: Fixed
  Assignee: Shalin Shekhar Mangar

Committed revision 734801.

Thanks Kay!

> JdbcDataSource : getARow() : Do not hardcode default type ..
> 
>
> Key: SOLR-955
> URL: https://issues.apache.org/jira/browse/SOLR-955
> Project: Solr
>  Issue Type: Improvement
>  Components: contrib - DataImportHandler
>Affects Versions: 1.3
> Environment: Java 6 , Tomcat 6
>Reporter: Kay Kay
>Assignee: Shalin Shekhar Mangar
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-955.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Patch to replace the hard-coded default type in getARow() method (instead of 
> 12, it should have been Types.VARCHAR ) - without affecting the semantics. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (SOLR-865) Support document updates in binary format

2009-01-15 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar resolved SOLR-865.


Resolution: Fixed

Committed revision 734796.

Thanks Noble!

> Support document updates in binary format
> -
>
> Key: SOLR-865
> URL: https://issues.apache.org/jira/browse/SOLR-865
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java, update
>Affects Versions: 1.4
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-865.patch, SOLR-865.patch, SOLR-865.patch, 
> SOLR-865.patch, SOLR-865.patch, SOLR-865.patch, SOLR-865.patch
>
>
> SolrJ uses the fast and compact 'javabin' format for querying Solr which is a 
> huge performance improvement over the xml format. We should make it possible 
> to use the 'javabin' format for document updates as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-865) Support document updates in binary format

2009-01-15 Thread Shalin Shekhar Mangar (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-865:
---

Attachment: SOLR-865.patch

Syncing with trunk and adding javadocs in a few places.

I'll commit this shortly. We can open separate issues to migrate other 
SolrServer implementations to the RequestWriter API.

> Support document updates in binary format
> -
>
> Key: SOLR-865
> URL: https://issues.apache.org/jira/browse/SOLR-865
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java, update
>Affects Versions: 1.4
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-865.patch, SOLR-865.patch, SOLR-865.patch, 
> SOLR-865.patch, SOLR-865.patch, SOLR-865.patch, SOLR-865.patch
>
>
> SolrJ uses the fast and compact 'javabin' format for querying Solr which is a 
> huge performance improvement over the xml format. We should make it possible 
> to use the 'javabin' format for document updates as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay closed SOLR-961.



Thanks Ryan . 

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> 
>
> Key: SOLR-961
> URL: https://issues.apache.org/jira/browse/SOLR-961
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6 
>Reporter: Kay Kay
>Assignee: Ryan McKinley
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

2009-01-15 Thread Ryan McKinley (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan McKinley resolved SOLR-961.


Resolution: Fixed

Committed revision 734790.

thanks Kay

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> 
>
> Key: SOLR-961
> URL: https://issues.apache.org/jira/browse/SOLR-961
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6 
>Reporter: Kay Kay
>Assignee: Ryan McKinley
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

2009-01-15 Thread Ryan McKinley (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan McKinley reassigned SOLR-961:
--

Assignee: Ryan McKinley

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> 
>
> Key: SOLR-961
> URL: https://issues.apache.org/jira/browse/SOLR-961
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6 
>Reporter: Kay Kay
>Assignee: Ryan McKinley
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-961:
-

Fix Version/s: 1.4
Affects Version/s: 1.3

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> 
>
> Key: SOLR-961
> URL: https://issues.apache.org/jira/browse/SOLR-961
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Affects Versions: 1.3
> Environment: Java 6, Tomcat 6 
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay updated SOLR-961:
-

Attachment: SOLR-961.patch

1. New Test case added for ModifiableSolrParamsTest 

2. Change ModifiableSolrParams.add() implementation. 

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> 
>
> Key: SOLR-961
> URL: https://issues.apache.org/jira/browse/SOLR-961
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
> Environment: Java 6, Tomcat 6 
>Reporter: Kay Kay
>Priority: Minor
> Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

2009-01-15 Thread Kay Kay (JIRA)
Efficient array copy in ModifiableSolrParams#add(String, String...) 


 Key: SOLR-961
 URL: https://issues.apache.org/jira/browse/SOLR-961
 Project: Solr
  Issue Type: Improvement
  Components: clients - java
 Environment: Java 6, Tomcat 6 
Reporter: Kay Kay
Priority: Minor
 Attachments: SOLR-961.patch

Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay closed SOLR-912.



> org.apache.solr.common.util.NamedList - Typesafe efficient variant - 
> ModernNamedList introduced - implementing the same API as NamedList
> 
>
> Key: SOLR-912
> URL: https://issues.apache.org/jira/browse/SOLR-912
> Project: Solr
>  Issue Type: Improvement
>  Components: search
>Affects Versions: 1.4
> Environment: Tomcat 6, JRE 6, Solr 1.3+ nightlies 
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: NLProfile.java, SOLR-912.patch, SOLR-912.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> The implementation of NamedList - while being fast - is not necessarily 
> type-safe. I have implemented an additional implementation of the same - 
> ModernNamedList (a type-safe variation providing the same interface as 
> NamedList) - while preserving the semantics in terms of ordering of elements 
> and allowing null elements for key and values (keys are always Strings , 
> while values correspond to generics ). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (SOLR-912) org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay resolved SOLR-912.
--

Resolution: Won't Fix

Agreed.  This patch is too late in the game w.r.t type safety to change the 
underlying behavior at this point. 

> org.apache.solr.common.util.NamedList - Typesafe efficient variant - 
> ModernNamedList introduced - implementing the same API as NamedList
> 
>
> Key: SOLR-912
> URL: https://issues.apache.org/jira/browse/SOLR-912
> Project: Solr
>  Issue Type: Improvement
>  Components: search
>Affects Versions: 1.4
> Environment: Tomcat 6, JRE 6, Solr 1.3+ nightlies 
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: NLProfile.java, SOLR-912.patch, SOLR-912.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> The implementation of NamedList - while being fast - is not necessarily 
> type-safe. I have implemented an additional implementation of the same - 
> ModernNamedList (a type-safe variation providing the same interface as 
> NamedList) - while preserving the semantics in terms of ordering of elements 
> and allowing null elements for key and values (keys are always Strings , 
> while values correspond to generics ). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (SOLR-960) CommonsHttpSolrServer - documentation - phase II (Addition of log in setMaxRetries as a warning for out of range input)

2009-01-15 Thread Kay Kay (JIRA)

 [ 
https://issues.apache.org/jira/browse/SOLR-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kay Kay closed SOLR-960.



> CommonsHttpSolrServer - documentation - phase II  (Addition of log in 
> setMaxRetries as a warning for out of range input) 
> -
>
> Key: SOLR-960
> URL: https://issues.apache.org/jira/browse/SOLR-960
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-960.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add javadoc for : 
> CommonsHttpSolrServer#AGENT
> CommonsHttpSolrServer#_invariantParams
> CommonsHttpSolrServer#_followRedirects
> CommonsHttpSolrServer#_allowCompression , _maxRetries 
> #setConnectionTimeout, #setSoTimeout
> #setConnectionManagerTimeout(int) deprecated in favor of 
> #setConnectionManagerTimeout(long) with the same API as in HttpClient 3.1 . 
> #setMaxRetries -  there would be a warning in the log message if the maximum 
> retries were > 1 to keep the programmer explicitly aware of the same. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-960) CommonsHttpSolrServer - documentation - phase II (Addition of log in setMaxRetries as a warning for out of range input)

2009-01-15 Thread Kay Kay (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664136#action_12664136
 ] 

Kay Kay commented on SOLR-960:
--

Thanks Otis. 

> CommonsHttpSolrServer - documentation - phase II  (Addition of log in 
> setMaxRetries as a warning for out of range input) 
> -
>
> Key: SOLR-960
> URL: https://issues.apache.org/jira/browse/SOLR-960
> Project: Solr
>  Issue Type: Improvement
>  Components: clients - java
>Reporter: Kay Kay
>Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-960.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add javadoc for : 
> CommonsHttpSolrServer#AGENT
> CommonsHttpSolrServer#_invariantParams
> CommonsHttpSolrServer#_followRedirects
> CommonsHttpSolrServer#_allowCompression , _maxRetries 
> #setConnectionTimeout, #setSoTimeout
> #setConnectionManagerTimeout(int) deprecated in favor of 
> #setConnectionManagerTimeout(long) with the same API as in HttpClient 3.1 . 
> #setMaxRetries -  there would be a warning in the log message if the maximum 
> retries were > 1 to keep the programmer explicitly aware of the same. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.