[jira] Commented: (SOLR-1688) Inner class FieldCacheSources should be refactored into their own classes
[
https://issues.apache.org/jira/browse/SOLR-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794664#action_12794664
]
Shalin Shekhar Mangar commented on SOLR-1688:
-
Chris, isn't referring to it as a ValueSource instance enough for SOLR-1586?
{quote}
What's more troubling is that the FieldType/FieldCacheSources are defined in an
inconsistent fashion: some are done as inner classes, e.g., StrFieldSource and
SortableFloatFieldSource, while others are defined as individual classes (e.g.,
FloatFIeldSource).
{quote}
That is not really a problem. The field types are always loaded by Solr so
whether they are an inner class or independent does not matter too much.
> Inner class FieldCacheSources should be refactored into their own classes
> -
>
> Key: SOLR-1688
> URL: https://issues.apache.org/jira/browse/SOLR-1688
> Project: Solr
> Issue Type: Improvement
> Components: search
>Affects Versions: 1.4
> Environment: indep. of env.
>Reporter: Chris A. Mattmann
> Fix For: 1.5
>
> Attachments: SOLR-1688.Mattmann.122609.patch.txt
>
>
> While working on SOLR-1586 I noticed that outside of class level access (or
> package level), you can't really reference FieldCacheSources that are defined
> inside of their FieldType constituents (e.g., in the case of StrFieldSource
> as defined in StrField). What's more troubling is that the
> FieldType/FieldCacheSources are defined in an inconsistent fashion: some are
> done as inner classes, e.g., StrFieldSource and SortableFloatFieldSource,
> while others are defined as individual classes (e.g., FloatFIeldSource). This
> patch will make them all consistent and define each FieldCacheSource as an
> outside class, present in o.a.solr.search.function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1586) Create Spatial Point FieldTypes
[ https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris A. Mattmann updated SOLR-1586: Attachment: SOLR-1586.Mattmann.122609.patch.txt - updated Grant's patch with more javadocs - formatting updates - fixed bug about referencing StrFieldSource via SOLR-1688 I get errors on the following tests: [junit] Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 2.473 sec [junit] Test org.apache.solr.search.function.distance.DistanceFunctionTest FAILED [junit] Tests run: 5, Failures: 1, Errors: 0, Time elapsed: 6.32 sec [junit] Test org.apache.solr.schema.PolyFieldTest FAILED Which I think Grant noted in his prior comment. > Create Spatial Point FieldTypes > --- > > Key: SOLR-1586 > URL: https://issues.apache.org/jira/browse/SOLR-1586 > Project: Solr > Issue Type: Improvement >Reporter: Grant Ingersoll >Assignee: Grant Ingersoll >Priority: Minor > Fix For: 1.5 > > Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.120709.geohashonly.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt, > SOLR-1586.Mattmann.122609.patch.txt, SOLR-1586.patch > > > Per SOLR-773, create field types that hid the details of creating tiers, > geohash and lat/lon fields. > Fields should take in lat/lon points in a single form, as in: > lat lon -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1688) Inner class FieldCacheSources should be refactored into their own classes
[ https://issues.apache.org/jira/browse/SOLR-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris A. Mattmann updated SOLR-1688: Attachment: SOLR-1688.Mattmann.122609.patch.txt > Inner class FieldCacheSources should be refactored into their own classes > - > > Key: SOLR-1688 > URL: https://issues.apache.org/jira/browse/SOLR-1688 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 1.4 > Environment: indep. of env. >Reporter: Chris A. Mattmann > Fix For: 1.5 > > Attachments: SOLR-1688.Mattmann.122609.patch.txt > > > While working on SOLR-1586 I noticed that outside of class level access (or > package level), you can't really reference FieldCacheSources that are defined > inside of their FieldType constituents (e.g., in the case of StrFieldSource > as defined in StrField). What's more troubling is that the > FieldType/FieldCacheSources are defined in an inconsistent fashion: some are > done as inner classes, e.g., StrFieldSource and SortableFloatFieldSource, > while others are defined as individual classes (e.g., FloatFIeldSource). This > patch will make them all consistent and define each FieldCacheSource as an > outside class, present in o.a.solr.search.function. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-1688) Inner class FieldCacheSources should be refactored into their own classes
Inner class FieldCacheSources should be refactored into their own classes - Key: SOLR-1688 URL: https://issues.apache.org/jira/browse/SOLR-1688 Project: Solr Issue Type: Improvement Components: search Affects Versions: 1.4 Environment: indep. of env. Reporter: Chris A. Mattmann Fix For: 1.5 While working on SOLR-1586 I noticed that outside of class level access (or package level), you can't really reference FieldCacheSources that are defined inside of their FieldType constituents (e.g., in the case of StrFieldSource as defined in StrField). What's more troubling is that the FieldType/FieldCacheSources are defined in an inconsistent fashion: some are done as inner classes, e.g., StrFieldSource and SortableFloatFieldSource, while others are defined as individual classes (e.g., FloatFIeldSource). This patch will make them all consistent and define each FieldCacheSource as an outside class, present in o.a.solr.search.function. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1586) Create Spatial Point FieldTypes
[ https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll updated SOLR-1586: -- Attachment: SOLR-1586.patch Here's a patch with both geohash and Cartesian Tier. Note, the test for Cartesian Tier (in PolyFieldTest) is not yet correct even though I think the underlying functionality is. (In other words, the test itself is not right). Comments/improvements welcome. Still needs javadocs (and wiki docs on http://wiki.apache.org/solr/SpatialSearch). One of the interesting things for Cart Tier is what the notion of a field query and range query are. See my thoughts in the comments. Also, I currently am throwing an UnsupportedOpException in getValueSource in Cart Tier stuff. Not sure if it is meaningful or not to allow functions to operate on the whole tier. > Create Spatial Point FieldTypes > --- > > Key: SOLR-1586 > URL: https://issues.apache.org/jira/browse/SOLR-1586 > Project: Solr > Issue Type: Improvement >Reporter: Grant Ingersoll >Assignee: Grant Ingersoll >Priority: Minor > Fix For: 1.5 > > Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.120709.geohashonly.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt, SOLR-1586.patch > > > Per SOLR-773, create field types that hid the details of creating tiers, > geohash and lat/lon fields. > Fields should take in lat/lon points in a single form, as in: > lat lon -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1586) Create Spatial Point FieldTypes
[ https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794628#action_12794628 ] Grant Ingersoll commented on SOLR-1586: --- For better or worse, yes. It's either that, or it needs to be duplicated here until Solr is on 3.x of Lucene and can incorporate your changes there. > Create Spatial Point FieldTypes > --- > > Key: SOLR-1586 > URL: https://issues.apache.org/jira/browse/SOLR-1586 > Project: Solr > Issue Type: Improvement >Reporter: Grant Ingersoll >Assignee: Grant Ingersoll >Priority: Minor > Fix For: 1.5 > > Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.120709.geohashonly.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt > > > Per SOLR-773, create field types that hid the details of creating tiers, > geohash and lat/lon fields. > Fields should take in lat/lon points in a single form, as in: > lat lon -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1586) Create Spatial Point FieldTypes
[ https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794627#action_12794627 ] Chris Male commented on SOLR-1586: -- Hi Grant, Are you building the CartesianTier field type against the existing CartesianTier API? > Create Spatial Point FieldTypes > --- > > Key: SOLR-1586 > URL: https://issues.apache.org/jira/browse/SOLR-1586 > Project: Solr > Issue Type: Improvement >Reporter: Grant Ingersoll >Assignee: Grant Ingersoll >Priority: Minor > Fix For: 1.5 > > Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.120709.geohashonly.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt > > > Per SOLR-773, create field types that hid the details of creating tiers, > geohash and lat/lon fields. > Fields should take in lat/lon points in a single form, as in: > lat lon -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1586) Create Spatial Point FieldTypes
[ https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794620#action_12794620 ] Grant Ingersoll commented on SOLR-1586: --- Should have a CartesianTier field type patch today. > Create Spatial Point FieldTypes > --- > > Key: SOLR-1586 > URL: https://issues.apache.org/jira/browse/SOLR-1586 > Project: Solr > Issue Type: Improvement >Reporter: Grant Ingersoll >Assignee: Grant Ingersoll >Priority: Minor > Fix For: 1.5 > > Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.120709.geohashonly.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt > > > Per SOLR-773, create field types that hid the details of creating tiers, > geohash and lat/lon fields. > Fields should take in lat/lon points in a single form, as in: > lat lon -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1583) Create DataSources that return InputStream
[ https://issues.apache.org/jira/browse/SOLR-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794599#action_12794599 ] Noble Paul commented on SOLR-1583: -- hiding which problem? why is there a problem? > Create DataSources that return InputStream > -- > > Key: SOLR-1583 > URL: https://issues.apache.org/jira/browse/SOLR-1583 > Project: Solr > Issue Type: New Feature > Components: contrib - DataImportHandler >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Minor > Fix For: 1.5 > > Attachments: SOLR-1583.patch > > > Tika integration means the source has to be binary that is the DataSource > must be of type DataSource . All the DataSource should > have a binary counterpart. > * BinURLDataSource > * BinContentStreamDataSource > * BinFileDataOurce -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Solr nightly build failure
init-forrest-entities: [mkdir] Created dir: /tmp/apache-solr-nightly/build [mkdir] Created dir: /tmp/apache-solr-nightly/build/web compile-solrj: [mkdir] Created dir: /tmp/apache-solr-nightly/build/solrj [javac] Compiling 88 source files to /tmp/apache-solr-nightly/build/solrj [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. compile: [mkdir] Created dir: /tmp/apache-solr-nightly/build/solr [javac] Compiling 410 source files to /tmp/apache-solr-nightly/build/solr [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. compileTests: [mkdir] Created dir: /tmp/apache-solr-nightly/build/tests [javac] Compiling 208 source files to /tmp/apache-solr-nightly/build/tests [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. dist-contrib: init: [mkdir] Created dir: /tmp/apache-solr-nightly/contrib/clustering/build/classes [mkdir] Created dir: /tmp/apache-solr-nightly/contrib/clustering/lib/downloads [mkdir] Created dir: /tmp/apache-solr-nightly/build/docs/api init-forrest-entities: compile-solrj: compile: [javac] Compiling 1 source file to /tmp/apache-solr-nightly/build/solr [javac] Note: /tmp/apache-solr-nightly/src/java/org/apache/solr/search/DocSetHitCollector.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. make-manifest: [mkdir] Created dir: /tmp/apache-solr-nightly/build/META-INF proxy.setup: check-files: get-colt: [get] Getting: http://repo1.maven.org/maven2/colt/colt/1.2.0/colt-1.2.0.jar [get] To: /tmp/apache-solr-nightly/contrib/clustering/lib/downloads/colt-1.2.0.jar get-pcj: [get] Getting: http://repo1.maven.org/maven2/pcj/pcj/1.2/pcj-1.2.jar [get] To: /tmp/apache-solr-nightly/contrib/clustering/lib/downloads/pcj-1.2.jar get-nni: [get] Getting: http://download.carrot2.org/maven2/org/carrot2/nni/1.0.0/nni-1.0.0.jar [get] To: /tmp/apache-solr-nightly/contrib/clustering/lib/downloads/nni-1.0.0.jar get-simple-xml: [get] Getting: http://mirrors.ibiblio.org/pub/mirrors/maven2/org/simpleframework/simple-xml/1.7.3/simple-xml-1.7.3.jar [get] To: /tmp/apache-solr-nightly/contrib/clustering/lib/downloads/simple-xml-1.7.3.jar get-libraries: compile: [javac] Compiling 7 source files to /tmp/apache-solr-nightly/contrib/clustering/build/classes [javac] Note: /tmp/apache-solr-nightly/contrib/clustering/src/main/java/org/apache/solr/handler/clustering/carrot2/CarrotClusteringEngine.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. build: [jar] Building jar: /tmp/apache-solr-nightly/contrib/clustering/build/apache-solr-clustering-1.5-dev.jar dist: [copy] Copying 1 file to /tmp/apache-solr-nightly/dist init: [mkdir] Created dir: /tmp/apache-solr-nightly/contrib/dataimporthandler/target/classes init-forrest-entities: compile-solrj: compile: [javac] Compiling 1 source file to /tmp/apache-solr-nightly/build/solr [javac] Note: /tmp/apache-solr-nightly/src/java/org/apache/solr/search/DocSetHitCollector.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. make-manifest: compile: [javac] Compiling 46 source files to /tmp/apache-solr-nightly/contrib/dataimporthandler/target/classes [javac] Note: /tmp/apache-solr-nightly/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. compileExtras: [mkdir] Created dir: /tmp/apache-solr-nightly/contrib/dataimporthandler/target/extras/classes [javac] Compiling 2 source files to /tmp/apache-solr-nightly/contrib/dataimporthandler/target/extras/classes [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. build: [jar] Building jar: /tmp/apache-solr-nightly/contrib/dataimporthandler/target/apache-solr-dataimporthandler-1.5-dev.jar [jar] Building jar: /tmp/apache-solr-nightly/contrib/dataimporthandler/target/apache-solr-dataimporthandler-extras-1.5
