[jira] Commented: (SOLR-216) Improvements to solr.py
[ https://issues.apache.org/jira/browse/SOLR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629976#action_12629976 ] Dariusz Suchojad commented on SOLR-216: --- Hi Mike, I've joined the solrpy (http://code.google.com/p/solrpy/) project where I'd like to incorporate the changes I had made and to work on adding more features to the Python client. I hope to get back to the discussion when, like you said, it becomes more stable and popular. Improvements to solr.py --- Key: SOLR-216 URL: https://issues.apache.org/jira/browse/SOLR-216 Project: Solr Issue Type: Improvement Components: clients - python Affects Versions: 1.2 Reporter: Jason Cater Assignee: Mike Klaas Priority: Trivial Attachments: solr-solrpy-r5.patch, solr.py, solr.py, solr.py, solr.py, test_all.py I've taken the original solr.py code and extended it to include higher-level functions. * Requires python 2.3+ * Supports SSL (https://) schema * Conforms (mostly) to PEP 8 -- the Python Style Guide * Provides a high-level results object with implicit data type conversion * Supports batching of update commands -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-216) Improvements to solr.py
[ https://issues.apache.org/jira/browse/SOLR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622470#action_12622470 ] Dariusz Suchojad commented on SOLR-216: --- I just checked solr.py with 1.3 (r685786) and, except for the one mentioned above, all tests pass correctly. However, I would like to add some more tests before merging features from other places, replacing xml.sax with etree/lxml or use some other Python 2.5 niceties. One thing I still don't know what to do about though is batch updating, I can't get it working right now, and I'm still not sure what it is good for, hence it's hard for me to come up with some good test cases here before trying to fix it :-) Improvements to solr.py --- Key: SOLR-216 URL: https://issues.apache.org/jira/browse/SOLR-216 Project: Solr Issue Type: Improvement Components: clients - python Affects Versions: 1.2 Reporter: Jason Cater Assignee: Mike Klaas Priority: Trivial Attachments: solr-solrpy-r5.patch, solr.py, solr.py, solr.py, solr.py, test_all.py I've taken the original solr.py code and extended it to include higher-level functions. * Requires python 2.3+ * Supports SSL (https://) schema * Conforms (mostly) to PEP 8 -- the Python Style Guide * Provides a high-level results object with implicit data type conversion * Supports batching of update commands -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-703) Make UUIDField.toInternal use UUID.fromString
[ https://issues.apache.org/jira/browse/SOLR-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dariusz Suchojad updated SOLR-703: -- Attachment: SOLR-703-code.patch Code. Make UUIDField.toInternal use UUID.fromString - Key: SOLR-703 URL: https://issues.apache.org/jira/browse/SOLR-703 Project: Solr Issue Type: Improvement Affects Versions: 1.3 Reporter: Dariusz Suchojad Priority: Minor Attachments: SOLR-703-code.patch I thought I'd just mention that java.util.UUID supports parsing of strings containing UUIDs while still choking on anything UUID-like or simply plain wrong, as seen in attached patch and unittests. It won't accept Windows GUIDs with curly brackets {12345678-1234-5678-1234-567812345678}, but then again, neither did the previous code. Perhaps it should though? Considering that it will fail when someone starts pulling data directly from MSSQL (http://wiki.apache.org/solr/DataImportHandler)? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-703) Make UUIDField.toInternal use UUID.fromString
Make UUIDField.toInternal use UUID.fromString - Key: SOLR-703 URL: https://issues.apache.org/jira/browse/SOLR-703 Project: Solr Issue Type: Improvement Affects Versions: 1.3 Reporter: Dariusz Suchojad Priority: Minor Attachments: SOLR-703-code.patch I thought I'd just mention that java.util.UUID supports parsing of strings containing UUIDs while still choking on anything UUID-like or simply plain wrong, as seen in attached patch and unittests. It won't accept Windows GUIDs with curly brackets {12345678-1234-5678-1234-567812345678}, but then again, neither did the previous code. Perhaps it should though? Considering that it will fail when someone starts pulling data directly from MSSQL (http://wiki.apache.org/solr/DataImportHandler)? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-703) Make UUIDField.toInternal use UUID.fromString
[ https://issues.apache.org/jira/browse/SOLR-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dariusz Suchojad updated SOLR-703: -- Attachment: SOLR-703-unittests.patch Unittests. Make UUIDField.toInternal use UUID.fromString - Key: SOLR-703 URL: https://issues.apache.org/jira/browse/SOLR-703 Project: Solr Issue Type: Improvement Affects Versions: 1.3 Reporter: Dariusz Suchojad Priority: Minor Attachments: SOLR-703-code.patch, SOLR-703-unittests.patch I thought I'd just mention that java.util.UUID supports parsing of strings containing UUIDs while still choking on anything UUID-like or simply plain wrong, as seen in attached patch and unittests. It won't accept Windows GUIDs with curly brackets {12345678-1234-5678-1234-567812345678}, but then again, neither did the previous code. Perhaps it should though? Considering that it will fail when someone starts pulling data directly from MSSQL (http://wiki.apache.org/solr/DataImportHandler)? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-216) Improvements to solr.py
[ https://issues.apache.org/jira/browse/SOLR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dariusz Suchojad updated SOLR-216: -- Attachment: solr.py solr.py intended to work with Solr 1.2 Improvements to solr.py --- Key: SOLR-216 URL: https://issues.apache.org/jira/browse/SOLR-216 Project: Solr Issue Type: Improvement Components: clients - python Affects Versions: 1.2 Reporter: Jason Cater Assignee: Mike Klaas Priority: Trivial Attachments: solr.py, solr.py, solr.py, solr.py I've taken the original solr.py code and extended it to include higher-level functions. * Requires python 2.3+ * Supports SSL (https://) schema * Conforms (mostly) to PEP 8 -- the Python Style Guide * Provides a high-level results object with implicit data type conversion * Supports batching of update commands -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-216) Improvements to solr.py
[ https://issues.apache.org/jira/browse/SOLR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dariusz Suchojad updated SOLR-216: -- Attachment: solr-solrpy-r5.patch Patch against r5 of http://code.google.com/p/solrpy/ to make it work with Solr 1.2 Improvements to solr.py --- Key: SOLR-216 URL: https://issues.apache.org/jira/browse/SOLR-216 Project: Solr Issue Type: Improvement Components: clients - python Affects Versions: 1.2 Reporter: Jason Cater Assignee: Mike Klaas Priority: Trivial Attachments: solr-solrpy-r5.patch, solr.py, solr.py, solr.py, solr.py, test_all.py I've taken the original solr.py code and extended it to include higher-level functions. * Requires python 2.3+ * Supports SSL (https://) schema * Conforms (mostly) to PEP 8 -- the Python Style Guide * Provides a high-level results object with implicit data type conversion * Supports batching of update commands -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-216) Improvements to solr.py
[ https://issues.apache.org/jira/browse/SOLR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622390#action_12622390 ] Dariusz Suchojad commented on SOLR-216: --- Hello, there are a few Python clients available, which is quite confusing, so I took the one with the richest API available (http://code.google.com/p/solrpy/, rev5) and created a set of test cases which you may found in attached file test_all.py. The tests are meant to be run with Solr 1.2 and only after applying attached solr-solrpy-r5.patch, which fixes a couple of issues while still trying not to break the already exposed API. Attached is also a solr.py module with the patch applied. One of the tests is failing deliberately, I'm simply not sure whether doing batch updates is still feasible with Solr 1.2. What I'd like to propose now is to integrate all the code available - solrpy and pysolr from code.google.com, the crude tiny one from Solr SVN (http://svn.apache.org/viewvc/lucene/solr/trunk/client/python/), various patches from JIRA - replace the XML parser used currently with elementtree or, optionally, lxml (which is *the* toolkit for any high-performance XML processing with Python), add more tests and have one officially blessed rich client for Python. I'm willing to do all the dirty work if there's a consensus among people using Solr with Python that doing so is a good idea. What do you think? Improvements to solr.py --- Key: SOLR-216 URL: https://issues.apache.org/jira/browse/SOLR-216 Project: Solr Issue Type: Improvement Components: clients - python Affects Versions: 1.2 Reporter: Jason Cater Assignee: Mike Klaas Priority: Trivial Attachments: solr-solrpy-r5.patch, solr.py, solr.py, solr.py, solr.py, test_all.py I've taken the original solr.py code and extended it to include higher-level functions. * Requires python 2.3+ * Supports SSL (https://) schema * Conforms (mostly) to PEP 8 -- the Python Style Guide * Provides a high-level results object with implicit data type conversion * Supports batching of update commands -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.