[jira] Issue Comment Edited: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704748#action_12704748 ] Wojtek Piaseczny edited comment on SOLR-748 at 4/30/09 12:03 PM: - Patch implements Shalin's suggested changes. was (Author: wojtekpia): Path implements Shalin's suggested changes. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Shalin Shekhar Mangar > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, > SOLR-748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: SOLR-748.patch Path implements Shalin's suggested changes. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Shalin Shekhar Mangar > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, > SOLR-748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704695#action_12704695 ] Wojtek Piaseczny commented on SOLR-748: --- Shalin, 1. Makes sense. 2. Using public access seems dangerous, but is consistent with a lot of the code in this project, so it's probably the right solution. 3. Makes sense. I'll post a patch shortly. (Also, thanks for taking this issue!) > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Shalin Shekhar Mangar > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: SOLR-748.patch Updated patch for April 24th trunk code. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Erik Hatcher > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) Support facet.sort=false (index order) with distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671496#action_12671496 ] Wojtek Piaseczny commented on SOLR-764: --- In the new implementation, sort=false and sort=lex are the same. In the previous implementation, specifying sort=false would sort sortable-numbers (like sint) numerically, rather lexicographically. So there's a slight inconsistency between the new and old implementation. I like the idea of adding a numeric sort order. > Support facet.sort=false (index order) with distributed search > -- > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-764.patch, SOLR-764.patch > > > Distributed search does not currently support sorting facets by index order > (facet.sort=false). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) Support facet.sort=false (index order) with distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670949#action_12670949 ] Wojtek Piaseczny commented on SOLR-764: --- I found one small issue: sorting lexicographically gives the wrong order when the field type is a sortable number (e.g. sint). I think the fix is to change DistribFieldFacet.getLexSorted() to compare on term number instead of name. (maybe this should be a comment on SOLR 781 instead). > Support facet.sort=false (index order) with distributed search > -- > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-764.patch, SOLR-764.patch > > > Distributed search does not currently support sorting facets by index order > (facet.sort=false). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: SOLR-748.patch Previous patch didn't apply cleanly. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Erik Hatcher > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: (was: SOLR-748.patch) > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Erik Hatcher > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: SOLR-748.patch Updated patch for Jan 26th trunk. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Erik Hatcher > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-974) DataImportHandler should not commit if no data has been updated
[ https://issues.apache.org/jira/browse/SOLR-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667306#action_12667306 ] Wojtek Piaseczny commented on SOLR-974: --- Why only if the command is delta-import? I'm managing my updates within my DB, so I'm always using the full-import command. > DataImportHandler should not commit if no data has been updated > --- > > Key: SOLR-974 > URL: https://issues.apache.org/jira/browse/SOLR-974 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-974.patch > > > The DataImportHandler always finishes an import with a commit, even if it > retrieved no data from its data source. Add a short circuit to not commit if > no data was imported. > Related discussion: > http://www.nabble.com/Performance-Hit-for-Zero-Record-Dataimport-td21572935.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-974) DataImportHandler should not commit if no data has been updated
DataImportHandler should not commit if no data has been updated --- Key: SOLR-974 URL: https://issues.apache.org/jira/browse/SOLR-974 Project: Solr Issue Type: Improvement Components: contrib - DataImportHandler Affects Versions: 1.3 Reporter: Wojtek Piaseczny Priority: Minor Fix For: 1.4 The DataImportHandler always finishes an import with a commit, even if it retrieved no data from its data source. Add a short circuit to not commit if no data was imported. Related discussion: http://www.nabble.com/Performance-Hit-for-Zero-Record-Dataimport-td21572935.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632986#action_12632986 ] Wojtek Piaseczny commented on SOLR-748: --- Are there any objections to committing this patch? I realize I didn't mention exactly what I'm using this for. I want to override the finishStage method of the FacetComponent class in my own facet component. To use values calculated by the default behavior of the FacetComponent class, I need several classes to be public (the ones listed above). > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) Support facet.sort=false (index order) with distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630397#action_12630397 ] Wojtek Piaseczny commented on SOLR-764: --- I measured how long the sort takes in my case: for collections of up to about 1100 items it took less than 1 ms. Compared with my average response times (~1000 ms), it truly is insignificant. > Support facet.sort=false (index order) with distributed search > -- > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-764.patch > > > Distributed search does not currently support sorting facets by index order > (facet.sort=false). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) Support facet.sort=false (index order) with distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630285#action_12630285 ] Wojtek Piaseczny commented on SOLR-764: --- Do you think it's worth keeping lexicographically sorted facets separate (i.e. in listFacets) and optimizing the combining code specifically for that case? I misunderstood what term number meant, thanks for clarifying. > Support facet.sort=false (index order) with distributed search > -- > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-764.patch > > > Distributed search does not currently support sorting facets by index order > (facet.sort=false). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-768) Set last_index_time in full-import command
[ https://issues.apache.org/jira/browse/SOLR-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630252#action_12630252 ] Wojtek Piaseczny commented on SOLR-768: --- Thanks Noble. How do we get this committed? > Set last_index_time in full-import command > -- > > Key: SOLR-768 > URL: https://issues.apache.org/jira/browse/SOLR-768 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-768.patch, SOLR-768.patch > > > Variables are being resolved before executing the full-import command, but > the last_index_time is not set (not read from file). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-768) Set last_index_time in full-import command
Set last_index_time in full-import command -- Key: SOLR-768 URL: https://issues.apache.org/jira/browse/SOLR-768 Project: Solr Issue Type: Improvement Components: contrib - DataImportHandler Affects Versions: 1.3 Reporter: Wojtek Piaseczny Fix For: 1.4 Attachments: SOLR-768.patch Variables are being resolved before executing the full-import command, but the last_index_time is not set (not read from file). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-768) Set last_index_time in full-import command
[ https://issues.apache.org/jira/browse/SOLR-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-768: -- Attachment: SOLR-768.patch Patch sets last index time before doing a full-import > Set last_index_time in full-import command > -- > > Key: SOLR-768 > URL: https://issues.apache.org/jira/browse/SOLR-768 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-768.patch > > > Variables are being resolved before executing the full-import command, but > the last_index_time is not set (not read from file). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) Support facet.sort=false (index order) with distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629949#action_12629949 ] Wojtek Piaseczny commented on SOLR-764: --- I notice this patch consolidates the FacetInfo class' 'topFacets' & 'listFacets' into a single collection. Do you know why these were ever separate? I had guessed it was because when 'listFacets' was being populated (only when facet.sort=false), it was being populated with data that was already ordered correctly per shard, and that combining the data (while maintaining sort order) from each shard could be optimized beyond calling Arrays.sort(). Shouldn't the getTermSorted method always use name instead of term number? > Support facet.sort=false (index order) with distributed search > -- > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-764.patch > > > Distributed search does not currently support sorting facets by index order > (facet.sort=false). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) facet.limit=-1 with facet.sort=false does not work in distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629892#action_12629892 ] Wojtek Piaseczny commented on SOLR-764: --- I want to show dynamic ranges for numeric facets. My (and probably most??) implementation for building dynamic ranges requires the numbers to be sorted by facet name rather than by occurrences. > facet.limit=-1 with facet.sort=false does not work in distributed search > > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > > If you specify facet.limit=-1 and facet.sort=false, no facet results are > returned. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-764) facet.limit=-1 with facet.sort=false does not work in distributed search
[ https://issues.apache.org/jira/browse/SOLR-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629887#action_12629887 ] Wojtek Piaseczny commented on SOLR-764: --- I'm trying to get all facets from all shards, ordered alphabetically. I'm not trying to disable facets. SOLR-755 solves the case where facet.limit=-1 and facet.sort=true, but not where facet.sort=false. A comment in SOLR-755 states: "Note that one must add facet.sorted=true in conjunction with facet.limit=-1 since it defaults to unsorted (or sorted-by-term), and this is currently unsupported by distributed search." > facet.limit=-1 with facet.sort=false does not work in distributed search > > > Key: SOLR-764 > URL: https://issues.apache.org/jira/browse/SOLR-764 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > > If you specify facet.limit=-1 and facet.sort=false, no facet results are > returned. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-764) facet.limit=-1 with facet.sort=false does not work in distributed search
facet.limit=-1 with facet.sort=false does not work in distributed search Key: SOLR-764 URL: https://issues.apache.org/jira/browse/SOLR-764 Project: Solr Issue Type: New Feature Affects Versions: 1.3 Reporter: Wojtek Piaseczny Fix For: 1.4 If you specify facet.limit=-1 and facet.sort=false, no facet results are returned. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: SOLR-748.patch SOLR-755 broke the previous patch. This patch contains no new functionality. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: 748.patch, SOLR-748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-760) Add behavior options to SearchComponents
Add behavior options to SearchComponents Key: SOLR-760 URL: https://issues.apache.org/jira/browse/SOLR-760 Project: Solr Issue Type: New Feature Affects Versions: 1.3 Reporter: Wojtek Piaseczny Fix For: 1.4 SearchComponents that use a previously computed document set should have an option to specify which document set to use. SearchComponents that output a document set should have the option to overwrite the default document set. For example, when using a FacetComponent after a MoreLikeThisComponent, you should be able to tell the FacetComponent to use either the document set created by the QueryComponent or by the MoreLikeThisComponent. You should also be able to tell the MoreLikeThisComponent to overwrite the QueryComponent's document set. Related discussion: http://www.nabble.com/Faceting-MoreLikeThisComponent-results-to19206833.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-755) facet.limit=-1 does not work in distributed search
[ https://issues.apache.org/jira/browse/SOLR-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628670#action_12628670 ] Wojtek Piaseczny commented on SOLR-755: --- Hi Yonik, I submitted a patch for SOLR 748 (https://issues.apache.org/jira/browse/SOLR-748) a few days ago. I'm guessing that whatever changes you make for this bug will break my patch. Could you review my patch while you're making these changes? Thanks, Wojtek Quoted from: http://www.nabble.com/-jira--Created%3A-%28SOLR-755%29-facet.limit%3D-1-does-not-work-in-distributed-search-tp19334831p19334879.html > facet.limit=-1 does not work in distributed search > -- > > Key: SOLR-755 > URL: https://issues.apache.org/jira/browse/SOLR-755 > Project: Solr > Issue Type: Bug >Reporter: Yonik Seeley >Assignee: Yonik Seeley >Priority: Minor > > If you specify facet.limit=-1 in distributed mode, no facet results are > returned. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-742) Unable to create dynamic fields with custom DataImportHandler transformer
[ https://issues.apache.org/jira/browse/SOLR-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628138#action_12628138 ] Wojtek Piaseczny commented on SOLR-742: --- That fixed my issue, thank you! > Unable to create dynamic fields with custom DataImportHandler transformer > - > > Key: SOLR-742 > URL: https://issues.apache.org/jira/browse/SOLR-742 > Project: Solr > Issue Type: Bug > Components: contrib - DataImportHandler >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: SOLR-742.patch, SOLR-742.patch > > > Discussion at: > http://www.nabble.com/Creating-dynamic-fields-with-DataImportHandler-to19226532.html > Dynamic fields aren't created when specified in a DataImportHandler's > transformer. > Reproducing the issue: > I have defined a dynamic field (of type sdouble) in my schema called > "_dynamic*". Inside the transformer's transformRow method, I am adding the > name-value pair "_dynamicTest" and '1.0'. No errors are observed, but the > data does not appear in the index after importing is complete. > Interestingly, I can specify that same name-value pair combination in the > DataImportHandler's config file, and it does appear in the index. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628036#action_12628036 ] Wojtek Piaseczny commented on SOLR-748: --- A more detailed list of changes: ShardFacetCount, DistribFieldFacet, and FacetInfo classes become final public. Their member variables become private, and are accessible (get & set) through public accessors. FieldFacet becomes a public class. Its member variables become protected, and are accessible (get & set) through public accessors. ResponseBuilder's private member variable _facetInfo renamed to facetInfo and made public. FacetComponent uses public accessors to access class members. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: 748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-748) FacetComponent helper classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-748: -- Attachment: 748.patch Implements the proposed solution. > FacetComponent helper classes are package restricted > > > Key: SOLR-748 > URL: https://issues.apache.org/jira/browse/SOLR-748 > Project: Solr > Issue Type: Bug > Components: search >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > Attachments: 748.patch > > > Original discussion: > http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html > The FacetComponent class uses several helper classes that currently have > package-restricted access. This makes it impossible to extend the > FacetComponent without rewriting most of its functionality. > A proposed solution is to make those classes public and make their public > member variables accessibly only through get and set functions (i.e. make > them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-748) FacetComponent helper classes are package restricted
FacetComponent helper classes are package restricted Key: SOLR-748 URL: https://issues.apache.org/jira/browse/SOLR-748 Project: Solr Issue Type: Bug Components: search Affects Versions: 1.3 Reporter: Wojtek Piaseczny Fix For: 1.4 Attachments: 748.patch Original discussion: http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html The FacetComponent class uses several helper classes that currently have package-restricted access. This makes it impossible to extend the FacetComponent without rewriting most of its functionality. A proposed solution is to make those classes public and make their public member variables accessibly only through get and set functions (i.e. make them private). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-742) Unable to create dynamic fields with custom DataImportHandler transformer
[ https://issues.apache.org/jira/browse/SOLR-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wojtek Piaseczny updated SOLR-742: -- Fix Version/s: (was: 1.3) 1.4 > Unable to create dynamic fields with custom DataImportHandler transformer > - > > Key: SOLR-742 > URL: https://issues.apache.org/jira/browse/SOLR-742 > Project: Solr > Issue Type: Bug > Components: contrib - DataImportHandler >Affects Versions: 1.3 >Reporter: Wojtek Piaseczny > Fix For: 1.4 > > > Discussion at: > http://www.nabble.com/Creating-dynamic-fields-with-DataImportHandler-to19226532.html > Dynamic fields aren't created when specified in a DataImportHandler's > transformer. > Reproducing the issue: > I have defined a dynamic field (of type sdouble) in my schema called > "_dynamic*". Inside the transformer's transformRow method, I am adding the > name-value pair "_dynamicTest" and '1.0'. No errors are observed, but the > data does not appear in the index after importing is complete. > Interestingly, I can specify that same name-value pair combination in the > DataImportHandler's config file, and it does appear in the index. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-742) Unable to create dynamic fields with custom DataImportHandler transformer
Unable to create dynamic fields with custom DataImportHandler transformer - Key: SOLR-742 URL: https://issues.apache.org/jira/browse/SOLR-742 Project: Solr Issue Type: Bug Components: contrib - DataImportHandler Affects Versions: 1.3 Reporter: Wojtek Piaseczny Fix For: 1.3 Discussion at: http://www.nabble.com/Creating-dynamic-fields-with-DataImportHandler-to19226532.html Dynamic fields aren't created when specified in a DataImportHandler's transformer. Reproducing the issue: I have defined a dynamic field (of type sdouble) in my schema called "_dynamic*". Inside the transformer's transformRow method, I am adding the name-value pair "_dynamicTest" and '1.0'. No errors are observed, but the data does not appear in the index after importing is complete. Interestingly, I can specify that same name-value pair combination in the DataImportHandler's config file, and it does appear in the index. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
