[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697599#action_12697599 ] Yonik Seeley commented on SOLR-1079: Just got back from vacation... bq. Do we all agree that we should go with whatever name Lucene selects? +1 > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-1079-fixcompilation.patch, SOLR-1079.patch, > SOLR-1079.patch > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695934#action_12695934 ] Shalin Shekhar Mangar commented on SOLR-1079: - Please ignore the last patch. Some more changes are required. I'll post a new one soon. > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-1079.patch > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688781#action_12688781 ] Hoss Man commented on SOLR-1079: bq. we should just rename to whatever it is in Lucene since the flag will pretty much never appear in Solr schemas anyway. reading the msgs in order, you convinced me, and then you un-convinced me, and then you re-un-convinced me. as long as it's going to be an option 99% of the world doesn't need to know about, and will need lots of documentation to explain anyway, it might as well be a long name that's consistent with the underlying java code. > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688386#action_12688386 ] Yonik Seeley commented on SOLR-1079: I disagree that "omitTf" is misleading... one would already have to be an expert to assume that it meant anything. But while I started arguing one way in my previous message, I convinced myself of the opposite by the end - we should just rename to whatever it is in Lucene since the flag will pretty much never appear in Solr schemas anyway. > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688382#action_12688382 ] Otis Gospodnetic commented on SOLR-1079: I agree with shorter is better... though we should avoid cryptic or misleading. I think omitTf is misleading. I'd rather we think of something that's maybe less descriptive (since one will need to look at the docs anyway), but not misleading (making the person think looking at the docs is not necessary) maybe omitTerm? "Info"? That would sort of match Lucene's TermInfo object (which doesn't encompass Payloads, though). > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688104#action_12688104 ] Noble Paul commented on SOLR-1079: -- keeping it short is better . The documentation can have details . > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688102#action_12688102 ] Shalin Shekhar Mangar commented on SOLR-1079: - bq. almost no one will have pre-conceived notions about what "omitTf" will do anyway... they will need to look at the description. Hence this is really only a documentation problem, not a naming problem. Good point! It if confuses me, I'm sure to check the documentation before changing it. I'm open to keeping it as is or changing it to conform to Lucene. I don't think it matters too much. My main goal is to make everybody aware of Lucene's changes and to have more documentation on this. Neither the example schema nor the SchemaXml wiki page have any details about omitTf. The only place it is mentioned is the change log. > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1079) Rename omitTf to omitTermFreqAndPositions
[ https://issues.apache.org/jira/browse/SOLR-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688078#action_12688078 ] Yonik Seeley commented on SOLR-1079: We need to get the latest lucene libs and adjust our code, but I'd vote for keeping our schema flag as "omitTf" for the following reasons: - omitTermFreqAndPositions is looong - it's not comprehensive anyway - omitTermFreqAndPositionsAndPayloads? ;-P - and still... some people may not realize that phrase queries need positions, or that things that don't look like phrase queries may get turned into phrase queries (foo-bar and WDF for example). - most Solr users don't *need* to know what it does... we default non-text fields to use omitTf... text fields should always default to that. - almost no one will have pre-conceived notions about what "omitTf" will do anyway... they will need to look at the description. Hence this is really only a documentation problem, not a naming problem. On the other side of the coin if we do the correct defaults (which I believe we do) then omitTermFreqAndPositions would rarely appear in anyone's schema anyway. Only the most advanced user would choose to change the defaults and for them a consistency with lucene naming may be desired? After all that, I guess I should have argued against Lucene renaming omitTf... and at this point Solr should probably just follow suit? > Rename omitTf to omitTermFreqAndPositions > - > > Key: SOLR-1079 > URL: https://issues.apache.org/jira/browse/SOLR-1079 > Project: Solr > Issue Type: Improvement > Components: documentation, update >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: 1.4 > > > LUCENE-1561 has renamed omitTf. > See > http://www.lucidimagination.com/search/document/376c1c12dd464164/lucene_1561_and_omittf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
