[jira] Commented: (SOLR-1718) Carriage return should submit query admin form
[ https://issues.apache.org/jira/browse/SOLR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829082#action_12829082 ] David Smiley commented on SOLR-1718: bq. It sounds like what you are really suggesting is that we change the /admin/index.jsp form to use a input type=text / instead of a textarea / for the q param, and not that we add special (javascript) logic to the form to submit if someone presses Enter inside the existing textarea / ... which i have a lot less objection to then going out of our way to violate standard form convention. Yes. Carriage return should submit query admin form -- Key: SOLR-1718 URL: https://issues.apache.org/jira/browse/SOLR-1718 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: 1.4 Reporter: David Smiley Priority: Minor Hitting the carriage return on the keyboard should submit the search query on the admin front screen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1718) Carriage return should submit query admin form
[
https://issues.apache.org/jira/browse/SOLR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828842#action_12828842
]
Hoss Man commented on SOLR-1718:
bq. Consider the JIRA interface we are using to comment on this issue.
Sure, but that's an {{input type=text /}}, not a {{textarea /}} ... the
expected semantics are completely different. With a {{input type=text /}}
box the browser already takes care of submitting the form if you hit Enter (and
FWIW: most browsers i know of also submit forms if you use Shift-Enter in a
{{textarea /}})
It sounds like what you are really suggesting is that we change the
/admin/index.jsp form to use a {{input type=text /}} instead of a
{{textarea /}} for the q param, and not that we add special (javascript)
logic to the form to submit if someone presses Enter inside the existing
{{textarea /}} ... which i have a lot less objection to then going out of
our way to violate standard form convention.
Carriage return should submit query admin form
--
Key: SOLR-1718
URL: https://issues.apache.org/jira/browse/SOLR-1718
Project: Solr
Issue Type: Improvement
Components: web gui
Affects Versions: 1.4
Reporter: David Smiley
Priority: Minor
Hitting the carriage return on the keyboard should submit the search query on
the admin front screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1718) Carriage return should submit query admin form
[
https://issues.apache.org/jira/browse/SOLR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805190#action_12805190
]
Hoss Man commented on SOLR-1718:
I don't understand what you mean. both forms use a {{textarea}}, why should
the behavior of one textarea be different from the behavior of the other (and
every other html textarea on the web) ?
Carriage return should submit query admin form
--
Key: SOLR-1718
URL: https://issues.apache.org/jira/browse/SOLR-1718
Project: Solr
Issue Type: Improvement
Components: web gui
Affects Versions: 1.4
Reporter: David Smiley
Priority: Minor
Hitting the carriage return on the keyboard should submit the search query on
the admin front screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1718) Carriage return should submit query admin form
[ https://issues.apache.org/jira/browse/SOLR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805219#action_12805219 ] David Smiley commented on SOLR-1718: Consider the JIRA interface we are using to comment on this issue. At the top-right of the screen is a QUICK SEARCH: box. It doesn't even have a submit button, it just works with hitting the return key. Carriage return should submit query admin form -- Key: SOLR-1718 URL: https://issues.apache.org/jira/browse/SOLR-1718 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: 1.4 Reporter: David Smiley Priority: Minor Hitting the carriage return on the keyboard should submit the search query on the admin front screen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1718) Carriage return should submit query admin form
[ https://issues.apache.org/jira/browse/SOLR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12800040#action_12800040 ] Hoss Man commented on SOLR-1718: presumably you mean when the search text area is in focus (if someone isn't using a mouse and selects a link as the currently active screen element, then hitting return should open that link per the conventions of the browser) Adding something to make the form work like this seems unnecessary ... particularly since it prevents people from including newlines in their input ... which can actually matter depending on the query parser/analyzer you are using -- not to mention i like using newlines when submitting complex queries just to improve readability. Carriage return should submit query admin form -- Key: SOLR-1718 URL: https://issues.apache.org/jira/browse/SOLR-1718 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: 1.4 Reporter: David Smiley Priority: Minor Hitting the carriage return on the keyboard should submit the search query on the admin front screen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1718) Carriage return should submit query admin form
[ https://issues.apache.org/jira/browse/SOLR-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12800090#action_12800090 ] David Smiley commented on SOLR-1718: I think you're point about longer queries makes sense... but then perhaps make the full interface form work in that way, (given a larger text box), and leave the front admin page for quick queries. Carriage return should submit query admin form -- Key: SOLR-1718 URL: https://issues.apache.org/jira/browse/SOLR-1718 Project: Solr Issue Type: Improvement Components: web gui Affects Versions: 1.4 Reporter: David Smiley Priority: Minor Hitting the carriage return on the keyboard should submit the search query on the admin front screen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
