[jira] Commented: (SOLR-1830) tests should be able to use RAMDirectory
[
https://issues.apache.org/jira/browse/SOLR-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12847557#action_12847557
]
Yonik Seeley commented on SOLR-1830:
So... I went and coded up a quick class to switch factories based on a system
property... and then realized that it was silly since we can just do this:
{code}
!-- solr.StandardDirectoryFactory is filesystem based, the default.
solr.RAMDirectoryFactory is memory based and not persistent. --
directoryFactory name=DirectoryFactory
class=${solr.directoryFactory:solr.StandardDirectoryFactory}/
{code}
tests should be able to use RAMDirectory
Key: SOLR-1830
URL: https://issues.apache.org/jira/browse/SOLR-1830
Project: Solr
Issue Type: Improvement
Reporter: Yonik Seeley
Priority: Minor
Tests should be able to use RAMDirectoryFactory.
We probably want the ability to have ant switch between FS and RAM so both
can be tested (RAM normally, FS for nightly?)
Some tests will need FS regardless, and those could use the same control
mechanism as ant, presumably a system property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1830) tests should be able to use RAMDirectory
[ https://issues.apache.org/jira/browse/SOLR-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846891#action_12846891 ] Yonik Seeley commented on SOLR-1830: The issue was that the writer being opened in the test was not closed. This didn't bother FSDirectory for some reason - but I haven't looked into it. tests should be able to use RAMDirectory Key: SOLR-1830 URL: https://issues.apache.org/jira/browse/SOLR-1830 Project: Solr Issue Type: Improvement Reporter: Yonik Seeley Priority: Minor Tests should be able to use RAMDirectoryFactory. We probably want the ability to have ant switch between FS and RAM so both can be tested (RAM normally, FS for nightly?) Some tests will need FS regardless, and those could use the same control mechanism as ant, presumably a system property. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1830) tests should be able to use RAMDirectory
[ https://issues.apache.org/jira/browse/SOLR-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846896#action_12846896 ] Yonik Seeley commented on SOLR-1830: A quick datapoint - BasicFunctionalityTest dropped from 18.2s to 12.2s (50% improvement) for me on ubuntu ext4. People on other platforms would probably see much less of an improvement. tests should be able to use RAMDirectory Key: SOLR-1830 URL: https://issues.apache.org/jira/browse/SOLR-1830 Project: Solr Issue Type: Improvement Reporter: Yonik Seeley Priority: Minor Tests should be able to use RAMDirectoryFactory. We probably want the ability to have ant switch between FS and RAM so both can be tested (RAM normally, FS for nightly?) Some tests will need FS regardless, and those could use the same control mechanism as ant, presumably a system property. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1830) tests should be able to use RAMDirectory
[
https://issues.apache.org/jira/browse/SOLR-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846747#action_12846747
]
Yonik Seeley commented on SOLR-1830:
Adding directoryFactory name=DirectoryFactory
class=solr.RAMDirectoryFactory/
to the example solrconfig.xml seems to work fine. However adding it to the
config file for BasicFunctionalityTest causes it to fail.
This happens in the second test method of the class, so it's likely something
isn't being cleaned up.
{code}
[junit] Testsuite: org.apache.solr.BasicFunctionalityTest
[junit] at org.apache.lucene.store.Lock.obtain(Lock.java:84)
[junit] at
org.apache.lucene.index.IndexWriter.lt;initgt;(IndexWriter.java:1100)
[junit] at
org.apache.lucene.index.IndexWriter.lt;initgt;(IndexWriter.java:997)
[junit] at
org.apache.solr.update.SolrIndexWriter.lt;initgt;(SolrIndexWriter.java:191)
[junit] at
org.apache.solr.update.UpdateHandler.createMainIndexWriter(UpdateHandler.java:99)
[junit] at
org.apache.solr.update.DirectUpdateHandler2.openWriter(DirectUpdateHandler2.java:173)
[junit] at
org.apache.solr.update.DirectUpdateHandler2.delete(DirectUpdateHandler2.java:286)
[junit] at
org.apache.solr.update.processor.RunUpdateProcessor.processDelete(RunUpdateProcessorFactory.java:68)
[junit] at
org.apache.solr.handler.XMLLoader.processDelete(XMLLoader.java:234)
[junit] at
org.apache.solr.handler.XMLLoader.processUpdate(XMLLoader.java:180)
[junit] at
org.apache.solr.handler.XmlUpdateRequestHandler.doLegacyUpdate(XmlUpdateRequestHandler.java:130)
[junit] at org.apache.solr.util.TestHarness.update(TestHarness.java:211)
[junit] at
org.apache.solr.util.TestHarness.checkUpdateStatus(TestHarness.java:250)
[junit] at
org.apache.solr.util.TestHarness.validateUpdate(TestHarness.java:225)
[junit] at
org.apache.solr.util.AbstractSolrTestCase.checkUpdateU(AbstractSolrTestCase.java:188)
[junit] at
org.apache.solr.util.AbstractSolrTestCase.assertU(AbstractSolrTestCase.java:167)
[junit] at
org.apache.solr.BasicFunctionalityTest.testSomeStuff(BasicFunctionalityTest.java:130)
{code}
tests should be able to use RAMDirectory
Key: SOLR-1830
URL: https://issues.apache.org/jira/browse/SOLR-1830
Project: Solr
Issue Type: Improvement
Reporter: Yonik Seeley
Priority: Minor
Tests should be able to use RAMDirectoryFactory.
We probably want the ability to have ant switch between FS and RAM so both
can be tested (RAM normally, FS for nightly?)
Some tests will need FS regardless, and those could use the same control
mechanism as ant, presumably a system property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
