[jira] Commented: (SOLR-281) Search Components (plugins)
[
https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12564739#action_12564739
]
Michael Dodsworth commented on SOLR-281:
{quote}
That would require instantiation with reflection I think.
{quote}
Reflection is already being used to create the QParserPlugins (SolrCore:1027
and AbstractPluginLoader:83) - I'm guessing the reason for the plugin is just
to avoid creating instances through reflection on every parse (as you could
keep hold of the QParser class and call newInstance). The second point is moot,
once you take away the need for createParser(...).
It's really not that big-a-deal, in the scheme of things.
{quote}
QParserPlugin is that interface essentially (except that its an class instead
of an interface). For library maintainers an abstract class is preferred over
an interface for things that a user will extend... that way signature changes
can be made in a backward compatible manner.
{quote}
As an aside, method signature changes are usually trivial to fix; personally,
the pain of those fixes is favourable to extending an abstract class
unnecessarily.
Are there any architectural reworking projects on the roadmap? I'm sure
backward compatibility is a massive concern; perhaps with the more modular
plugin design route Solr is going down, those concerns can be addressed. If
there's a chance of being accepted, I would love to contribute a move towards
using Spring.
Search Components (plugins)
---
Key: SOLR-281
URL: https://issues.apache.org/jira/browse/SOLR-281
Project: Solr
Issue Type: New Feature
Components: search
Affects Versions: 1.3
Reporter: Ryan McKinley
Assignee: Ryan McKinley
Fix For: 1.3
Attachments: SOLR-281-ComponentInit.patch,
SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
solr-281.patch, solr-281.patch, solr-281.patch
A request handler with pluggable search components for things like:
- standard
- dismax
- more-like-this
- highlighting
- field collapsing
For more discussion, see:
http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12564853#action_12564853 ] Yonik Seeley commented on SOLR-281: --- Followed up on solr-dev to avoid stealing more of this JIRA isse: http://www.nabble.com/Re%3A--jira--Commented%3A-Search-Components-%28plugins%29-to15227648.html#a15227648 Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Components: search Affects Versions: 1.3 Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.3 Attachments: SOLR-281-ComponentInit.patch, SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[
https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12564453#action_12564453
]
Yonik Seeley commented on SOLR-281:
---
{quote}The QParserPlugin class seems unnecessary: all it does is implement
init() and add a createParser method. Why not just have the parser constructor
take those arguments...{quote}
That would require instantiation with reflection I think.
{quote}or, if that can't be done, create an interface to allow the parser
itself implement both init() and createParser() (or create()). It then avoids
having to create 2 classes (in the case of DisMax, in the same file...which is
not pretty).{quote}
QParserPlugin *is* that interface essentially (except that its an class instead
of an interface). For library maintainers an abstract class is preferred over
an interface for things that a user will extend... that way signature changes
can be made in a backward compatible manner.
Search Components (plugins)
---
Key: SOLR-281
URL: https://issues.apache.org/jira/browse/SOLR-281
Project: Solr
Issue Type: New Feature
Components: search
Affects Versions: 1.3
Reporter: Ryan McKinley
Assignee: Ryan McKinley
Fix For: 1.3
Attachments: SOLR-281-ComponentInit.patch,
SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
solr-281.patch, solr-281.patch, solr-281.patch
A request handler with pluggable search components for things like:
- standard
- dismax
- more-like-this
- highlighting
- field collapsing
For more discussion, see:
http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12564449#action_12564449 ] Michael Dodsworth commented on SOLR-281: This is great; decomposing the handler and allowing the components to be wired up in the config really helps development (and maintenance of those changes). For my purposes, I needed to make a change to the way the dismax query was being generated. Using the DisMaxQParserPlugin as a template, I created my own QParser and associated QParserPlugin; changed the relevant bits; added a queryParser... entry in solrconfig.xml; added the 'defType' parameter to the wanted SearchHandler configuration...and...all works well. Just a few comments: * I had to make the QParser parse() method public (as the new query parser may still need to use the existing query parsers (backup lucene parser, boost parser, function parser, etc). * The QParserPlugin class seems unnecessary: all it does is implement init() and add a createParser method. Why not just have the parser constructor take those arguments...or, if that can't be done, create an interface to allow the parser itself implement both init() and createParser() (or create()). It then avoids having to create 2 classes (in the case of DisMax, in the same file...which is not pretty). Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Components: search Affects Versions: 1.3 Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.3 Attachments: SOLR-281-ComponentInit.patch, SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551058 ] Ryan McKinley commented on SOLR-281: Sabyasachi - check that your patch does not comment out the loading line... the committed version of this patch is not commented out: http://svn.apache.org/repos/asf/lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Components: search Affects Versions: 1.3 Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.3 Attachments: SOLR-281-ComponentInit.patch, SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550031 ] Sabyasachi Dalal commented on SOLR-281: --- I am updating the distributed search patch (SOLR-303) with this patch. I added the dist search components as, searchComponent name=gstat class=org.apache.solr.handler.federated.component.GlobalCollectionStatComponent / searchComponent name=mqp class=org.apache.solr.handler.federated.component.MainQPhaseComponent / searchComponent name=aqp class=org.apache.solr.handler.federated.component.AuxiliaryQPhaseComponent / requestHandler name=/search class=solr.SearchHandler lst name=defaults str name=echoParamsexplicit/str /lst arr name=last-components strgstat/str strmqp/str straqp/str /arr /requestHandler But it was not working. On debugging i found that these added components were not getting registered. I made the following change in SolrCore.loadSearchComponents, // NamedListPluginLoaderSearchComponent loader = new NamedListPluginLoaderSearchComponent( xpath, searchComponents ); NamedListPluginLoaderSearchComponent loader = new NamedListPluginLoaderSearchComponent( xpath, components ); Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Components: search Affects Versions: 1.3 Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.3 Attachments: SOLR-281-ComponentInit.patch, SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545911 ] Yonik Seeley commented on SOLR-281: --- The other idea I had was numeric positioning... query=1000, facet=2000, etc, and so a user could add their component at any point. Perhaps your first/last is sufficient though. Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Components: search Affects Versions: 1.3 Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.3 Attachments: SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545938 ] Ryan McKinley commented on SOLR-281: The problem first/last is trying to solve is to let a custom handler automatically incorporate default changes to the standard components without editing solrconfig.xml. Numeric positioning seems a bit brittle unless the 'standard' components have a locked position. Without opening the door to legacy problems, I don't see any good way to insert a component between facet and mlt without specifying the whole chain. Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Components: search Affects Versions: 1.3 Reporter: Ryan McKinley Assignee: Ryan McKinley Fix For: 1.3 Attachments: SOLR-281-ComponentInit.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541785 ] Henri Biestro commented on SOLR-281: Not sure process-wise whether votes/watchers got a say, my apologies if not; +1 otherwise. Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541786 ] Yonik Seeley commented on SOLR-281: --- I'm checking out the latest version now... Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[
https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537645
]
Yonik Seeley commented on SOLR-281:
---
{quote}Yonik, i could not get your last patch to apply cleanly to trunk. {quote}
That's OK, the one you produced fails for me on a clean checkout too looks
like maybe we hit a little corner case with patch/diff.
Should we perhaps commit this working version, marking ResponseBuilder as
in-flux, and then continue generating patches from that???
Search Components (plugins)
---
Key: SOLR-281
URL: https://issues.apache.org/jira/browse/SOLR-281
Project: Solr
Issue Type: New Feature
Reporter: Ryan McKinley
Attachments: SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch,
solr-281.patch, solr-281.patch, solr-281.patch
A request handler with pluggable search components for things like:
- standard
- dismax
- more-like-this
- highlighting
- field collapsing
For more discussion, see:
http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537648 ] Yonik Seeley commented on SOLR-281: --- I'll see if I can jiggle things a bit to get better patch behavior first... Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537652 ] Yonik Seeley commented on SOLR-281: --- Hold on... this patch is double in size from the last for some reason deleting. Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537740 ] Ryan McKinley commented on SOLR-281: ok, that one works (or close enough) Should we perhaps commit this working version, marking ResponseBuilder as in-flux, and then continue generating patches from that??? If you feel comfortable with the big picture, yes, I think we should commit this and refine the ResponseBuilder and perhaps the configuration options in smaller patches. Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch, solr-281.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536667 ] Henri Biestro commented on SOLR-281: updated to work with trunk (587079); updated HighlightComponent to use SolrHighlighter. junit 0 failures/0 errors on Solaris 10 WinXP. I've tried and failed to overcome the diff/patch rejects that Pieter experienced. I generated the patch from a Solaris 10 using GNU patch with: svn diff --diff-cmd /usr/bin/diff -x -w -B -b -E -d -N -u ~/solr-281.patch I applied it to a clean trunk on Solaris 10 WinXP (using cygwin) with: patch -u -p 0 ~/solr-281.patch StandardRequestHandler.java generates rejects; replace the whole class definition with the '-' prefixed lines of the reject. *WARNING* since this is a 'unified' patch and not wanting to mess with Sharad Ryan's patch versions, I attached the patch as solr-281.patch (*not* as SOLR-281-SearchComponents.patch) Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536878 ] Yonik Seeley commented on SOLR-281: --- FYI, I'm in the process of updating this patch to work with trunk again (pluggable query parser stuff... SOLR-334) Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, solr-281.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527931 ] Pieter Berkel commented on SOLR-281: I'm having trouble applying the latest patch to trunk (r575809) again: $ patch -p0 ../SOLR-281-SearchComponents.patch ... patching file src/java/org/apache/solr/handler/StandardRequestHandler.java Hunk #1 FAILED at 17. Hunk #2 FAILED at 45. 2 out of 2 hunks FAILED -- saving rejects to file src/java/org/apache/solr/handler/StandardRequestHandler.java.rej patching file src/java/org/apache/solr/handler/DisMaxRequestHandler.java Hunk #2 FAILED at 118. 1 out of 2 hunks FAILED -- saving rejects to file src/java/org/apache/solr/handler/DisMaxRequestHandler.java.rej It also looks like the additions to solrconfig.xml have not been included in the latest patch either. I was also going to suggest that it might be a good idea to support class shorthand notation, so org.apache.solr.handler.component.* can be written solr.component.* in solrconfig.xml. Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520434 ] Pieter Berkel commented on SOLR-281: I just tried this patch on svn trunk (r566899) and got the following failures: $ patch -p0 ../SOLR-281-SearchComponents.patch ... patching file src/java/org/apache/solr/handler/StandardRequestHandler.java Hunk #1 succeeded at 17 with fuzz 1. Hunk #2 FAILED at 45. 1 out of 2 hunks FAILED -- saving rejects to file src/java/org/apache/solr/handler/StandardRequestHandler.java.rej ... patching file src/java/org/apache/solr/handler/DisMaxRequestHandler.java Hunk #1 FAILED at 17. 1 out of 1 hunk FAILED -- saving rejects to file src/java/org/apache/solr/handler/DisMaxRequestHandler.java.rej I suspect it is the changes made by SOLR-326 that is causing the these problems, would it be possible for you to create a new patch? thanks, Piete Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516732 ] Ryan McKinley commented on SOLR-281: Is anybody working on this issue? not actively. if not, I can start looking at it. Of course! Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SOLR-281) Search Components (plugins)
Sharad, I'm interested in implementing MoreLikeThis support in the Dismax request handler (see SOLR-295) and it seems the best way forward is through the search components idea suggested in SOLR-281. I'm not actively working on it at the moment either but I think it's an important development and it would be great if you can make some progress. Once the interface is standardized I'll have a crack at expanding the MoreLikeThis suppport. cheers, Piete
[jira] Commented: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511678 ] Pieter Berkel commented on SOLR-281: I really like this modular approach to handling search requests, it will greatly simplify the process of adding new functionality (e.g. collapsing, faceting, more-like-this) to existing handlers without the need for unnecessary code replication. My primary goal is to extend the more-like-this handler capabilities and make them available to other handlers (such as dismax), and I think the proposed solution is a good approach. Some issues that I can forsee though are: 1) Ordering: its fairly obvious that certain handlers need to be called before others (e.g. standard / dismax query parsing before faceting / highlighting) however there may be cases where the required sequence of events may be more subtle (e.g. faceting the results of a more-like-this query). There probably needs to be some mechanism to determine the order in which the components are prepared / processed. 2) Dependancy: a situation may arise where a component depends on operations performed by another component (e.g. more-like-this may take advantage of the dismax 'bq' parameter), perhaps there needs to be some method of specifying component dependency so that the SearchHandler can load and process required components automatically? I hope this make sense, I'm fairly new to Solr development so I'm afraid my contributions to this issue would be mostly limited to (hopefully helpful) ideas and suggestions however I'm happy to tinker with the patched code from above and help test this new component framework as it is developed. cheers, Pieter Search Components (plugins) --- Key: SOLR-281 URL: https://issues.apache.org/jira/browse/SOLR-281 Project: Solr Issue Type: New Feature Reporter: Ryan McKinley Attachments: SOLR-281-SearchComponents.patch A request handler with pluggable search components for things like: - standard - dismax - more-like-this - highlighting - field collapsing For more discussion, see: http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
