[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624446#action_12624446 ] Koji Sekiguchi commented on SOLR-517: - Committed revision 687825. highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Assignee: Koji Sekiguchi Priority: Minor Fix For: 1.3 Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch, SOLR-517.patch, TestNegativeIdf.java On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[
https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623976#action_12623976
]
Koji Sekiguchi commented on SOLR-517:
-
Hmmm. New lucene-highlighter-2.4-dev.jar solves this issue but causes
testPhraseHighlighter junit error:
{noformat}
$ ant clean test
:
[junit] Running org.apache.solr.highlight.HighlighterTest
[junit] Tests run: 17, Failures: 0, Errors: 1, Time elapsed: 21.313 sec
[junit] Test org.apache.solr.highlight.HighlighterTest FAILED
{noformat}
I'll look into this on tomorrow.
highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
-
Key: SOLR-517
URL: https://issues.apache.org/jira/browse/SOLR-517
Project: Solr
Issue Type: Bug
Components: highlighter
Affects Versions: 1.2, 1.3
Reporter: Koji Sekiguchi
Assignee: Koji Sekiguchi
Priority: Minor
Fix For: 1.3
Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch,
SOLR-517.patch, TestNegativeIdf.java
On un-optimized index, highlighter doesn't work with
hl.requireFieldMatch=true.
see:
http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[
https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624134#action_12624134
]
Koji Sekiguchi commented on SOLR-517:
-
The cause of the junit error is lack of lucene-memory-2.4-dev.jar. The latest
lucene-memory-2.4-dev.jar needs LUCENE-1334.
So we need these changes to be committed (r687014):
{noformat}
$ svn status
M lib\lucene-snowball-2.4-dev.jar
M lib\lucene-core-2.4-dev.jar
M lib\lucene-highlighter-2.4-dev.jar
M lib\lucene-spellchecker-2.4-dev.jar
M lib\lucene-analyzers-2.4-dev.jar
A lib\lucene-memory-2.4-dev.jar
M lib\lucene-queries-2.4-dev.jar
M src\test\org\apache\solr\highlight\HighlighterTest.java
{noformat}
All test pass.
I'll commit them tomorrow if there is no objections.
highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
-
Key: SOLR-517
URL: https://issues.apache.org/jira/browse/SOLR-517
Project: Solr
Issue Type: Bug
Components: highlighter
Affects Versions: 1.2, 1.3
Reporter: Koji Sekiguchi
Assignee: Koji Sekiguchi
Priority: Minor
Fix For: 1.3
Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch,
SOLR-517.patch, TestNegativeIdf.java
On un-optimized index, highlighter doesn't work with
hl.requireFieldMatch=true.
see:
http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621769#action_12621769 ] Mark Miller commented on SOLR-517: -- Thanks much Koji - appreciate it and if it is indeed something I can handle at the Lucene highlighter I'll add an issue soon. You'll get a null fragment due to negative idf. Easiest way to avoid negative idf, switch the scorer: Thanks! Thats probably the issue...I was looking for an exception - didn't realize it emitted a null fragment instead. I'll dig into things sometime today. highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Priority: Minor Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch, SOLR-517.patch, TestNegativeIdf.java On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621778#action_12621778 ] Mark Miller commented on SOLR-517: -- I'll take care of it at the Lucene Highlighter level: https://issues.apache.org/jira/browse/LUCENE-1355 Thanks again Koji. highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Priority: Minor Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch, SOLR-517.patch, TestNegativeIdf.java On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621665#action_12621665 ] Mark Miller commented on SOLR-517: -- I'd be happy to fix this in the Lucene Highlighter, but what is actually going on to get a negative? By the look of it, I don't see possible values that could create a negative result - even if you allowed for negative inputs, you could still only get positives, NAN, or Infinity. Can you elaborate or make a test case? Also, it doesn't appear helpful to use the IndexReader method unless you want to use those scores for other things (gradient highlighting etc). If you count on that, it can't be changed, if you don't it should be changed. highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Priority: Minor Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621667#action_12621667 ] Koji Sekiguchi commented on SOLR-517: - bq. Can you elaborate or make a test case? The patch includes a test case that indicates negative idf. If it doesn't please let me know so that I do double check. bq. Also, it doesn't appear helpful to use the IndexReader method unless you want to use those scores for other things (gradient highlighting etc). If you count on that, it can't be changed, if you don't it should be changed. I'm afraid but I don't understand what you are saying (current trunk is using IndexReader method). highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Priority: Minor Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621671#action_12621671 ] Mark Miller commented on SOLR-517: -- Yeah, I had tried to turn that test into duplicate Lucene actions, and I couldn't replicate the problem. I will give it a whirl with solr when I get a chance. What values for totalNumDocs and docFreq are being used when you get the exception? I still don't see how your seeing a negative there... I'm afraid but I don't understand what you are saying (current trunk is using IndexReader method). If you use the IndexReader method token scoring is done using the idf formula - so you could do highlighting to varying degrees based on the score. There is a cost to this to get the info for the idf calculation and then also the calculation. If you don't use the IndexReader method, hits are just scored 1 or 0 pretty much. Thats all thats need for basic highlighting. But if no one is using the richer highlighting scores, you pay for nothing. highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Priority: Minor Attachments: SOLR-517.patch, SOLR-517.patch, SOLR-517.patch On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-517) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index
[ https://issues.apache.org/jira/browse/SOLR-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12602857#action_12602857 ] Mike Klaas commented on SOLR-517: - Koji: Is this resolved? I seemed to recall that we brought this up on java-dev, but I can't find the thread at the moment. (I don't think that the right thing to do is remove idf fetching of the terms as your patch proposes) highlighter doesn't work with hl.requireFieldMatch=true on un-optimized index - Key: SOLR-517 URL: https://issues.apache.org/jira/browse/SOLR-517 Project: Solr Issue Type: Bug Components: highlighter Affects Versions: 1.2, 1.3 Reporter: Koji Sekiguchi Priority: Minor Attachments: SOLR-517.patch, SOLR-517.patch On un-optimized index, highlighter doesn't work with hl.requireFieldMatch=true. see: http://www.nabble.com/hl.requireFieldMatch-and-idf-td16324482.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
