[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-07-04 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610638#action_12610638
 ] 

Shalin Shekhar Mangar commented on SOLR-609:


The accuracy request parameter is not supported by this component. The request 
handler accepts the accuracy as a request parameter and calls Lucene 
SpellChecker.setAccuracy before getting the suggestion. However, this is 
neither thread-safe nor can we guarantee that the accuracy is actually enforced 
for the suggestion.

However, you can set the accuracy as a configuration parameter just like you 
set the spellCheckIndexDir. I shall update the wiki documentation with this bit.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-07-04 Thread Ronald Braun (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610634#action_12610634
 ] 

Ronald Braun commented on SOLR-609:
---

Is the accuracy (or sp.query.accuracy) parameter from 
SpellCheckerRequestHandler also supported by SpellCheckComponent (there is no 
documentation about it on the wiki)?  If so, presumably it is handled by this 
same mechanism, but thought I'd throw it out there.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-06-30 Thread Grant Ingersoll (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609314#action_12609314
 ] 

Grant Ingersoll commented on SOLR-609:
--

OK, I committed this, give it a try.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-06-30 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609312#action_12609312
 ] 

Shalin Shekhar Mangar commented on SOLR-609:


bq. Yeah, this probably makes sense. We could roll this one back. I haven't 
tested it, but I'm thinking it is just a documentation issue, then, right? As 
the ReqHandler will take care of the default handling stuff.

Yes, I think we should do that. No need to rewrite the 
defaults/appends/invariants parameter handling in this component which is taken 
care of by request handlers.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-06-30 Thread Grant Ingersoll (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609300#action_12609300
 ] 

Grant Ingersoll commented on SOLR-609:
--

{quote}
Actually, now that I think about it, another way would have been to add these 
default params to the request handler which is using SpellCheckComponent.
{quote}

Yeah, this probably makes sense.  We could roll this one back.  I haven't 
tested it, but I'm thinking it is just a documentation issue, then, right?  As 
the ReqHandler will take care of the default handling stuff.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-06-29 Thread Norberto Meijome (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609148#action_12609148
 ] 

Norberto Meijome commented on SOLR-609:
---

Confirmed working ok.

To make it clear, the 'spellcheck=true' param to enable the spellchecker by 
default has to be added, in solrconfig.xml , to the query handler section, not 
the spell checker itself - i may update the wiki to reflect this.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-06-29 Thread Norberto Meijome (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609143#action_12609143
 ] 

Norberto Meijome commented on SOLR-609:
---

??Actually, now that I think about it, another way would have been to add these 
default params to the request handler which is using SpellCheckComponent.??

True - it would help if one wanted to run the same spellchecker with different 
defaults and different query handlers , ie, different defaults for spellchecker 
if using qt=standard vs qt=dismax. 

In your implementation, we'd have to have a different spellchecker component 
handler defined, which is fine in most cases, at least for me... Would it be a 
problem having different spellchecker handlers pointing to the same data 
directory  ? 

thanks!
B

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (SOLR-609) SpellCheckComponent doesn't read default options from solrconfig.xml

2008-06-27 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608760#action_12608760
 ] 

Shalin Shekhar Mangar commented on SOLR-609:


Actually, now that I think about it, another way would have been to add these 
default params to the request handler which is using SpellCheckComponent.

> SpellCheckComponent doesn't read default options from solrconfig.xml
> 
>
> Key: SOLR-609
> URL: https://issues.apache.org/jira/browse/SOLR-609
> Project: Solr
>  Issue Type: Bug
>  Components: spellchecker
>Affects Versions: 1.3
> Environment: confirmed on FreeBSD7-stable , nightly 1.3 build 
> (2008-06-25) , jdk1.6.
> I am using the spellchecker called as last-components from my dismax handler.
>Reporter: Norberto Meijome
>Assignee: Grant Ingersoll
>Priority: Minor
> Attachments: SOLR-609.patch
>
>
> solrconfig.xml contains :
> [...]
>class="org.apache.solr.handler.component.SpellCheckComponent">
>   
>   
>   false
>   
>   true
>   
>   1
>   
>   true
>   
> [... all default options after this]
> confirmed options .count , collate , extendedResults set in solrconfig.xml 
> take no effect on the query . They work as intended if added to the URL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.