[jira] Commented: (SOLR-698) SpellCheckComponent should use the queryString set in the ResponseBuilder
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622480#action_12622480 ] Shalin Shekhar Mangar commented on SOLR-698: ResponseBuilder#setQueryString can be used by other components to change the query itself before it is passed down to SpellCheckComponent. Moreover all other components such as FacetComponent, QueryComponent and DebugComponent use the ResponseBuilder#getQueryString. I guess SpellCheckComponent should also do the same. SpellCheckComponent should use the queryString set in the ResponseBuilder - Key: SOLR-698 URL: https://issues.apache.org/jira/browse/SOLR-698 Project: Solr Issue Type: Improvement Components: spellchecker Reporter: Steven Broadbridge Attachments: SOLR-698.patch SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the q parameter. This will allow it to be used with query components besides QueryComponent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-698) SpellCheckComponent should use the queryString set in the ResponseBuilder
[ https://issues.apache.org/jira/browse/SOLR-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622413#action_12622413 ] Lars Kotthoff commented on SOLR-698: Isn't the queryString attribute of ResponseBuilder the same as CommonParams.Q? At least a quick review of the code suggests that it's only ever set to CommonParams.Q. Could you elaborate on how this allows SpellCheckComponent to be used with more components? If you need a special spellcheck query you can specify spellcheck.q in the request. SpellCheckComponent should use the queryString set in the ResponseBuilder - Key: SOLR-698 URL: https://issues.apache.org/jira/browse/SOLR-698 Project: Solr Issue Type: Improvement Components: spellchecker Reporter: Steven Broadbridge Attachments: SOLR-698.patch SpellCheckComponent should check if a previous component has set the queryString property on ResponseBuilder before using the q parameter. This will allow it to be used with query components besides QueryComponent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
