[jira] Commented: (SOLR-952) duplicated code in (Default)SolrHighlighter and HighlightingUtils
[ https://issues.apache.org/jira/browse/SOLR-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674830#action_12674830 ] Mike Klaas commented on SOLR-952: - HighlightingUtils has been deprecated for at least one release; can't we just rip it out? > duplicated code in (Default)SolrHighlighter and HighlightingUtils > - > > Key: SOLR-952 > URL: https://issues.apache.org/jira/browse/SOLR-952 > Project: Solr > Issue Type: Bug > Components: highlighter >Affects Versions: 1.4 >Reporter: Chris Harris >Priority: Minor > Attachments: SOLR-952.patch > > > A large quantity of code is duplicated between the deprecated > HighlightingUtils class and the newer SolrHighlighter and > DefaultSolrHighlighter (which have been getting bug fixes and enhancements). > The Utils class is no longer used anywhere in Solr, but people writing > plugins may be taking advantage of it, so it should be cleaned up. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-952) duplicated code in (Default)SolrHighlighter and HighlightingUtils
[ https://issues.apache.org/jira/browse/SOLR-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677555#action_12677555 ] Hoss Man commented on SOLR-952: --- bq. HighlightingUtils has been deprecated for at least one release; can't we just rip it out? it depends on how strict we want to be about backwards compatibility -- which has never been extremely well defined for Solr. following hte Lucene-Java model, we should be back compatible with java class compatibility until 2.0 ... but since Solr tends to focus more on the HTTP API, i'm certainly fine with saying we aim for HTTP/REST back-compat between major versions, and have a more relaxed view on the class compatibility for plugin developers ... but if we really want to get into this is a much broader discussion. for the purposes of this issue does anyone see any reason *not* to commit the patch? > duplicated code in (Default)SolrHighlighter and HighlightingUtils > - > > Key: SOLR-952 > URL: https://issues.apache.org/jira/browse/SOLR-952 > Project: Solr > Issue Type: Bug > Components: highlighter >Affects Versions: 1.4 >Reporter: Chris Harris >Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-952.patch > > > A large quantity of code is duplicated between the deprecated > HighlightingUtils class and the newer SolrHighlighter and > DefaultSolrHighlighter (which have been getting bug fixes and enhancements). > The Utils class is no longer used anywhere in Solr, but people writing > plugins may be taking advantage of it, so it should be cleaned up. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-952) duplicated code in (Default)SolrHighlighter and HighlightingUtils
[ https://issues.apache.org/jira/browse/SOLR-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683801#action_12683801 ] Shalin Shekhar Mangar commented on SOLR-952: bq. for the purposes of this issue does anyone see any reason not to commit the patch? +1 for commit. I'm fine with removing the class too. > duplicated code in (Default)SolrHighlighter and HighlightingUtils > - > > Key: SOLR-952 > URL: https://issues.apache.org/jira/browse/SOLR-952 > Project: Solr > Issue Type: Bug > Components: highlighter >Affects Versions: 1.4 >Reporter: Chris Harris >Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-952.patch > > > A large quantity of code is duplicated between the deprecated > HighlightingUtils class and the newer SolrHighlighter and > DefaultSolrHighlighter (which have been getting bug fixes and enhancements). > The Utils class is no longer used anywhere in Solr, but people writing > plugins may be taking advantage of it, so it should be cleaned up. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
