[jira] Issue Comment Edited: (SOLR-617) Allow configurable deletion policy

2008-09-23 Thread Akshay K. Ukey (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633649#action_12633649
 ] 

akshay edited comment on SOLR-617 at 9/23/08 1:13 AM:
--

This patch has:
1. maxCommitAge configuration support
2. Reservation mechanism is added in the ReplicationHandler configuration. Code 
for the same is in the latest patch of 
https://issues.apache.org/jira/browse/SOLR-561
3. Test cases.

  was (Author: akshay):
Patch with test cases and in sync with trunk.
  
> Allow configurable deletion policy
> --
>
> Key: SOLR-617
> URL: https://issues.apache.org/jira/browse/SOLR-617
> Project: Solr
>  Issue Type: New Feature
>  Components: search, update
>Affects Versions: 1.4
>Reporter: Noble Paul
>Assignee: Shalin Shekhar Mangar
>Priority: Minor
> Fix For: 1.4
>
> Attachments: 617.patch, solr-617.patch, solr-617.patch, solr-617.patch
>
>
> Lucene API provides means to configure deletion policy. Solr should be able 
> to expose it through configuration in solrconfig.xml. Moreover the new 
> replication (SOLR-561) strategy is going to rely on this .
> I propose the configuration go into the   section
> sample configuration
> {code:xml|title=solrconfig.xml}
> 
> 
> 
>
> true
>  
> 
>  
> 
> 
> 
>   
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (SOLR-617) Allow configurable deletion policy

2008-09-02 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626572#action_12626572
 ] 

shalinmangar edited comment on SOLR-617 at 9/2/08 4:59 AM:


Thanks for the patch Akshay!

I think we should allow a user to specify his custom IndexDeletionPolicy too. 
We can provide a default implementation with all the options specified in the 
issue description. So I propose that we have the following syntax:

{code:xml}

{code}

The default implementation will be SolrIndexDeletionPolicy which can be 
configured through a NamedList. Any custom deletion policy will be initialized 
with a NamedList if it implements NamedListInitializedPlugin.
{code:xml}


  
  true
  
  
  
  

{code}

To facilitate replication, we can have a wrapper over the IndexDeletionPolicy 
which can provide us the features needed for replication (SOLR-561). We need 
access to a list of non-deleted IndexCommit instances, a way to lookup 
IndexCommit given a version as well as the latest commit point. 

  was (Author: shalinmangar):
Thanks for the patch Akshay!

I think we should allow a user to specify his custom IndexDeletionPolicy too. 
We can provide a default implementation with all the options specified in the 
issue description. So I propose that we have the following syntax:

{code:xml}

{code}

The default implementation will be SolrIndexDeletionPolicy which can be 
configured through a NamedList. Any custom deletion policy will be initialized 
with a NamedList if it implements NamedListInitializedPlugin.
{code:xml}


  
  true
  
  
  
  

{code}

To facilitate replication, we can have a wrapper over the IndexDeletionPolicy 
which can provide us the features needed for replication (SOLR-561). We need 
access to a list of non-deleted IndexCommit instances, a way to lookup 
IndexCommit given a version as well as the latest commit point. 
  
> Allow configurable deletion policy
> --
>
> Key: SOLR-617
> URL: https://issues.apache.org/jira/browse/SOLR-617
> Project: Solr
>  Issue Type: New Feature
>  Components: search, update
>Affects Versions: 1.4
>Reporter: Noble Paul
>Assignee: Shalin Shekhar Mangar
>Priority: Minor
> Fix For: 1.4
>
> Attachments: 617.patch, solr-617.patch
>
>
> Lucene API provides means to configure deletion policy. Solr should be able 
> to expose it through configuration in solrconfig.xml. Moreover the new 
> replication (SOLR-561) strategy is going to rely on this .
> I propose the configuration go into the   section
> sample configuration
> {code:xml|title=solrconfig.xml}
> 
> 
> 
>
> true
>  
> 
>  
> 
> 
> 
>   
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.