[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Summary: Allow current single core deployments to be specified by solr.xml (was: Deprecate deployments w/o solr.xml) I think this description is more in line with what the proposal is - while deprecation may occur, its not the primary work to be done - this is an improvement and issue whether we decided to deprecate or not - we are also not deprecating "single core deployments" - we would be deprecating a lack of solr.xml. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1621: - Attachment: SOLR-1621.patch The necessary code changes. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: SOLR-1621.patch Looks like it has the same issue I ran into - The solrConfigFilename doesn't work right now (used by tests and web.xml override). What I did is add another load method that also takes the config filename (or not if its null). I don't like adding the extra methods for this, so I'm not sure this is the best solution, but its a solution to get started with. That will get the NoCacheHeaderTest to pass. I also dropped a solr.xml into example to get started there. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: SOLR-1621.patch This solves the closing core too many times issue you can have by just simply checking if a core is closed before closing it in shutdown. By the way, why not allow removing the DEFAULT_CORE? Shouldn't it be treated like any other core, other than the special property of getting a "" alias? > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: SOLR-1621.patch Whoops - wrong solr.xml example in wrong page - had core1 for the name. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: (was: SOLR-1621.patch) > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: SOLR-1621.patch Its up to trunk - looks like its an issue with $id - I'm so sick of running into that. Here is a patch with the $id created by the patch replaced with the actual $id string - that should make it apply. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1621: - Attachment: SOLR-1621.patch the index pages are fixed > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1621: - Attachment: SOLR-1621.patch it works now even after the alias command . I still think we should remove the 'alias' command. It is a fancy feature which adds too much of complexity into ref counting of cores > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1621: - Attachment: SOLR-1621.patch with ALIAS deprecated > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: SOLR-1621.patch You mark setSolrConfigFilename as deprecated, but it simply doesn't work anymore either - thats not really deprecation. I feel that deprecating solrconfig-filename should be its own issue so thats a more clear entry in CHANGES. And it should prob be deprecated rather than turned off out of the blue. I don't suppose its a big deal either way though. You have also changed CoreContainer#getCores - but that change is unrelated to this patch. I really feal an issue should just stick to the issue - it makes commits more clear. That change (which isn't back compat anyway), should be its own commit. This latest update removes a bunch of the unrelated changes. The patch is still unfinished though - you removed my fix to use the solrconfig override without replacing it with an alternative fix. As a result, some tests don't use the right config now, and in particular, NoCacheHeaderTest is back to failing. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-1621: -- Attachment: SOLR-1621.patch This patch reinstates a fix for the SolrDispatcher config name override so that all tests pass again. It also changes DEFAULT_CORE to use a final static constant rather than be repeated. Personally, I also almost think that removing the alias feature should be its own issue. > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
[ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1621: - Attachment: SOLR-1621.patch Throw a message saying 'ALIAS is removed' when ALIAS is invoked > Allow current single core deployments to be specified by solr.xml > - > > Key: SOLR-1621 > URL: https://issues.apache.org/jira/browse/SOLR-1621 > Project: Solr > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Noble Paul >Assignee: Noble Paul > Fix For: 1.5 > > Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, > SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch > > > supporting two different modes of deployments is turning out to be hard. This > leads to duplication of code. Moreover there is a lot of confusion on where > do we put common configuration. See the mail thread > http://markmail.org/message/3m3rqvp2ckausjnf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
