[jira] Updated: (SOLR-374) use IndexReader.reopen
[ https://issues.apache.org/jira/browse/SOLR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otis Gospodnetic updated SOLR-374: -- Fix Version/s: 1.4 use IndexReader.reopen -- Key: SOLR-374 URL: https://issues.apache.org/jira/browse/SOLR-374 Project: Solr Issue Type: Improvement Reporter: Yonik Seeley Fix For: 1.4 Attachments: SOLR-374.patch, SOLR-374.patch, SOLR-374.patch, SOLR-374.patch, SOLR-374.patch Take advantage of IndexReader.reopen(): LUCENE-743 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-374) use IndexReader.reopen
[ https://issues.apache.org/jira/browse/SOLR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-374: - Attachment: SOLR-374.patch Okay. Not sure how kosher taking ownership of the Reader form SolrIndexSearcher is, but it seems the thing to do then. use IndexReader.reopen -- Key: SOLR-374 URL: https://issues.apache.org/jira/browse/SOLR-374 Project: Solr Issue Type: Improvement Reporter: Yonik Seeley Attachments: SOLR-374.patch, SOLR-374.patch, SOLR-374.patch, SOLR-374.patch Take advantage of IndexReader.reopen(): LUCENE-743 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-374) use IndexReader.reopen
[ https://issues.apache.org/jira/browse/SOLR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-374: - Attachment: SOLR-374.patch I may be missing something but this one is pretty simple right? The biggest issue I see is that some tests rely on getting a new Reader reference whether its needed or not (the index hasn't changed) after a commit. So while I'd like to just return the searcher when the Reader hasnt changed, those tests would have to be changed. As is, a small change should actually be cheaper than no change I think. use IndexReader.reopen -- Key: SOLR-374 URL: https://issues.apache.org/jira/browse/SOLR-374 Project: Solr Issue Type: Improvement Reporter: Yonik Seeley Attachments: SOLR-374.patch Take advantage of IndexReader.reopen(): LUCENE-743 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-374) use IndexReader.reopen
[ https://issues.apache.org/jira/browse/SOLR-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-374: - Attachment: SOLR-374.patch Hmmm...looks like I was wrong about those tests failing just because of the same Reader - looked that way, and the expected fix worked, but doing things correctly as directed by yonik, now all the tests pass no problem. use IndexReader.reopen -- Key: SOLR-374 URL: https://issues.apache.org/jira/browse/SOLR-374 Project: Solr Issue Type: Improvement Reporter: Yonik Seeley Attachments: SOLR-374.patch, SOLR-374.patch Take advantage of IndexReader.reopen(): LUCENE-743 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
