[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch Added a SolrIndexSearcher.search() method that uses a command pattern. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (SOLR-502) Add search time out support
With the latest patch (Yonik's suggestion to have the flag in the response header) there is no change to the writers, so there is no compatibility issue. -Sean Noble Paul നോബിള് नोब्ळ् wrote: If the patch is going in immediately it may not be necessary. --Noble On Thu, Jun 5, 2008 at 8:37 PM, Sean Timm (JIRA) [EMAIL PROTECTED] wrote: [ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch This patch adds a conditional to ensure backwards compatibility within SOLR 1.3 nightly builds, per Noble Paul's suggestion. Is that necessary? Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch Changes the setting of the partialResults flag from the results to the responseHeader. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (SOLR-502) Add search time out support
If the patch is going in immediately it may not be necessary. --Noble On Thu, Jun 5, 2008 at 8:37 PM, Sean Timm (JIRA) [EMAIL PROTECTED] wrote: [ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch This patch adds a conditional to ensure backwards compatibility within SOLR 1.3 nightly builds, per Noble Paul's suggestion. Is that necessary? Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. -- --Noble Paul
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch This patch adds a conditional to ensure backwards compatibility within SOLR 1.3 nightly builds, per Noble Paul's suggestion. Is that necessary? Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch * Adds partialResults support to the binary response, which is used by distributed search. * Really removes the System.out.println() this time. * timeallowed param is now camelcase (timeAllowed). Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: SOLR-502.patch * Added Javadoc note that a timeallowed param =0 (or omitted) results in no timeout. * Fixed the CamelCase: timeallowed = timeAllowed * Removed the System.out.println(...) statements. bq. I see This should only be called using either filterList or filter, but not both., but I don't see a check for that. Should there be a test for the two vars? bq. This comment was copied from the existing getDocListC method (without the timeAllowed parameter). If there should be a sanity check there, it should probably be added as a separate JIRA issue. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502-solrj.patch, SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-502: --- Attachment: (was: SOLR-502-solrj.patch) Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Assignee: Otis Gospodnetic Priority: Minor Fix For: 1.3 Attachments: SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[
https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Otis Gospodnetic updated SOLR-502:
--
Fix Version/s: 1.3
Yes, I think we should get this in 1.3. I left the following comment in
SOLR-505, but since this issue includes the patch from SOLR-505, I will assume
the patch will be developed further as part of this issue and not SOLR-505.
I took a quick look at the patch and saw this:
{code}rsp.setAvoidHttpCaching(false);{code}
Am I the only one who has a harder time reading negative methods like this,
esp. when they take false?
Would it not be nicer to just have:
{code}rsp.setHttpCaching(true/false);{code}
or even
{code}rsp.httpCachingOn() + rsp.httpCachingOff(){code}
Similarly, instead of {code}isAvoidHttpCaching(){code} have
{code}isHttpCachingOn(){code}
I know this is just naming, but I think it helps with readability a bit.
I notice the unit test mods are not in the patch. Is there no need to test the
modified behaviour?
Add search time out support
---
Key: SOLR-502
URL: https://issues.apache.org/jira/browse/SOLR-502
Project: Solr
Issue Type: New Feature
Components: search
Reporter: Sean Timm
Priority: Minor
Fix For: 1.3
Attachments: SOLR-502-solrj.patch, solrTimeout.patch,
solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch
Uses LUCENE-997 to add time out support to Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: solrTimeout.patch Added the ability to allows timeouts to occur on one or more shards in a distributed search (SOLR-303) and still be merged. The resulting set is reported as a partial result and is not cachable in an HTTP cache. This fixes the last known issue. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: SOLR-502-solrj.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: solrTimeout.patch This patch includes Shalin's SolrJ patch and includes the SOLR-505 patch. HTTP cache headers are now suppressed on a timeout. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: SOLR-502-solrj.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-502: --- Attachment: SOLR-502-solrj.patch An updated patch which contains changes to SolrJ to support search timeouts. *Changes* * SolrQuery has two new methods - setTimeAllowed and getTimeAllowed to specify timeout in milliseconds * SolrDocumentList has isPartialResult and setPartialResult to signal that a timeout occured and the results returned are partial * XMLResponseParser#readDocuments handles the partialResults boolean attribute sent by the server * SolrQueryTest has a trivial test for adding/removing the timeAllowed parameter Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: SOLR-502-solrj.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-502: --- Attachment: SOLR-502-solrj.patch My previous patch wasn't generated correctly. This is a corrected patch. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: SOLR-502-solrj.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-502: --- Attachment: (was: SOLR-502-solrj.patch) Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: SOLR-502-solrj.patch, solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: solrTimeout.patch Better handling of timeout condition with other code paths such as sorting by a field. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: solrTimeout.patch, solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: solrTimeout.patch This patch adds a partialResults flag which is set to true in the event of a timeout. A partial set of results will be returned (including possibly no results). The flag is supported in the XML, JSON, Ruby, and Python response writers. A count of the number of timeouts is included in the statistics similar to the errors count. Caveats/ToDo: SolrJ is not aware of this setting, nor is distributed search (SOLR-303). Some execution paths may not recognize partial results (such as sorting by field) as I haven't tested those yet. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: solrTimeout.patch, solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-502) Add search time out support
[ https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Timm updated SOLR-502: --- Attachment: solrTimeout.patch This patch adds a timeallowed parameter which takes a time out value in milliseconds. On a timeout, an exception is thrown from the searcher which results in a 500 error page with the time out exception message. I'd like to add support to return partial results, but I haven't done that part yet. Add search time out support --- Key: SOLR-502 URL: https://issues.apache.org/jira/browse/SOLR-502 Project: Solr Issue Type: New Feature Components: search Reporter: Sean Timm Priority: Minor Attachments: solrTimeout.patch Uses LUCENE-997 to add time out support to Solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
