[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540.patch Attaching new patch which uses instanceof instead of comparing the classes directly and defers the generation of the list of fields to highlight on until they're requested. I left the assignment of fields the index reader knows about in the constructor because this shouldn't be too expensive. It could easily be moved into the getter as well though. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540.patch, SOLR-540.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540.patch Syncing patch with trunk. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540-highlight-all.patch Attaching patch which handles the case where a field is present in the index but not defined in the field by logging a warning instead of throwing a RuntimeException. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540-highlight-all.patch Syncing patch with trunk. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540-highlight-all.patch Attaching new patch which only highlights on stored text/string fields. Added test case to verify that. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540-highlight-all.patch Syncing patch with trunk. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch, SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540-highlight-all.patch The old patch didn't verify properly that only stored static fields are returned. The new patch fixes this. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch, > SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: SOLR-540-highlight-all.patch I've changed a couple of things and uploaded the new patch. * The stored fields are no longer determined in SolrHighlighter for every request, but in SolrIndexSearcher when creating a new object. The implementation now simply queries the schema for all field names the index reader knows about and checks for each whether it's stored. The collections of field names and stored field names are exposed through getters. SolrHighlighter simply matches against the items of the storedFieldNames collection. * Added generic support for wildcards; in addition to "*" things like "foo_*" also work now. Now for example the prototype of a dynamic field may be given as field name to highlight on and all instances of that prototype will be highlighted. * Added a unit test to verify that highlighting with wildcard fields works as expected. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: (was: solr-highlight-all.patch) > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: SOLR-540-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: (was: solr-highlight-all.patch) > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: solr-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: solr-highlight-all.patch New patch returning only the stored fields. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: solr-highlight-all.patch, solr-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-540) Add support for hl.fl=*
[ https://issues.apache.org/jira/browse/SOLR-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Kotthoff updated SOLR-540: --- Attachment: solr-highlight-all.patch Patch as described against svn revision 648118. > Add support for hl.fl=* > --- > > Key: SOLR-540 > URL: https://issues.apache.org/jira/browse/SOLR-540 > Project: Solr > Issue Type: New Feature > Components: highlighter >Affects Versions: 1.3 > Environment: Tomcat 5.5 >Reporter: Lars Kotthoff >Priority: Minor > Attachments: solr-highlight-all.patch > > > Adds support for the star value for the hl.fl parameter, i.e. highlighting > will be done on all fields (static and dynamic). Particularly useful in > conjunction with hl.requireFieldMatch=true, this way one can specify > "generic" highlighting parameters independent of the query/searched fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
