[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: solr-567.patch solr-567.patch Moved SimpleFacets.getFieldCacheCounts to SolrIndexSearcher to allow an alternate SolrCore to use a different implementation due to direct top level field cache access. > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr-567.patch, solr-567.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: solr-567.patch solr-567.patch Moved defining the solrcoreclass to config. SolrDispatchFilter and MultiCore construct SolrCore using reflection. > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr-567.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: (was: solr.567.5.17.2008.patch) > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr-567.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: (was: solr.567.5.11.2008.patch) > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr.567.5.17.2008.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: (was: solr.567.5.10.2008.patch) > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr.567.5.17.2008.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: solr.567.5.17.2008.patch solr.567.5.17.2008.patch In the interest of minimizing impact on the existing code base, the patch consists of a few things changed from private and the addition of classname attribute to coredescriptor and multicore dynamically loading the class. This allows alternate SolrCore implementations to be defined. > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr.567.5.17.2008.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: solr.567.5.11.2008.patch solr.567.5.11.2008.patch Needed to abstract SolrCore, old one became SolrCoreImpl. SolrConfig needs to be abstracted somehow. > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr.567.5.10.2008.patch, solr.567.5.11.2008.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-567) SolrCore Pluggable
[ https://issues.apache.org/jira/browse/SOLR-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rutherglen updated SOLR-567: -- Attachment: solr.567.5.10.2008.patch solr.567.5.10.2008.patch Here's a rough patch of the changes. SolrIndexSearcher becomes SolrIndexSearcherImpl. It looks like most of SolrCore can remain mostly the same and be inherited from. SolrIndexSearcher is an abstract class implementing methods the rest of the system uses. org.apache.solr.search.SolrIndexSearcher.initRegenerators should move and not static. The CacheRegenerator is a problem because it uses SolrCache which other Searcher implementations may not use and may implement a different cache system. Is UpdateHandler being deprecated? > SolrCore Pluggable > -- > > Key: SOLR-567 > URL: https://issues.apache.org/jira/browse/SOLR-567 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.3 >Reporter: Jason Rutherglen > Attachments: solr.567.5.10.2008.patch > > > SolrCore needs to be an abstract class with the existing functionality in a > subclass. SolrIndexSearcher the same. It seems that most of the Searcher > methods in SolrIndexSearcher are not used. The new abstract class need only > have the methods used by the other Solr classes. This will allow other > indexing and search implementations to reuse the other parts of Solr. Any > other classes that have functionality specific to the Solr implementation of > indexing and replication such as SolrConfig can be made abstract. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.