[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Yonik Seeley updated SOLR-59: - Attachment: SOLR-59-20061213.patch Ok, updated patch to - bump current & default version to 2.2 - bump version used in tests to 2.2 (added 2.0 to tests where necessary) - changed "name" of the normal doclist returned by the handlers to "response" - other little minor cleanups Bertrand, since you started this issue, I'll let you commit it if you feel comfortable with it :-) > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-20061103.patch, SOLR-59-20061106-newfiles.tar.gz, > SOLR-59-20061106.patch, SOLR-59-20061213.patch, > SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz updated SOLR-59: Attachment: SOLR-59-20061106-newfiles.tar.gz > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-20061103.patch, SOLR-59-20061106-newfiles.tar.gz, > SOLR-59-20061106.patch, SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz updated SOLR-59: Attachment: SOLR-59-20061106.patch Here's a new patch (the newfiles follow, also marked with 20061106). You're right that setting the headers like any other data object in the response makes things much simpler and consistent, at the expense of a change of output format, example for the XML: 0 0 10 0 . . . I have add the EchoParamsTest to check the XML output. > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-20061103.patch, SOLR-59-20061106-newfiles.tar.gz, > SOLR-59-20061106.patch, SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz updated SOLR-59: Attachment: SOLR-59-20061103.patch > ...I think it might make more sense to use the normal query parameter > mechanism to control this (requestHandler defaults in solrconfig). .. I agree, but I'm not sure how to access these values, are they provided somewhere in SolrCore, or how should I best get them? > ...Also, why the extra addInfo element in the responseHeader?.. Right, makes no sense. This modifed patch goes back to the previous format (still needs the additional files of attachment 3). 0 1 10 ... > ...should we make responseHeader consistent with the generic response format? I think so. I didn't want to change that as it changes the existing format, but it makes sense. > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-20061103.patch, SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz updated SOLR-59: Attachment: SOLR-59-new-files-20061102.tar.gz New files for SOLR-59-20061102.patch > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz updated SOLR-59: Attachment: SOLR-59-20061102.patch Here's a new patch (SOLR-59-20061102.patch and SOLR-59-new-files-20061102.tar.gz). I have added a SolrQueryResponseHeaders class to handle these (and any future) additional information fields in the response headers. The XML output format is a bit different, example for http://localhost:8983/solr/select/?stylesheet=&q=apache&version=2.1&start=0&rows=10&indent=on&multi=red&multi=blue 0 0 red blue 10 0 on apache 2.1 And the same info is available in a similar way in the JSON, Python and Ruby response writers. The explicitQueryParameters list is activated by the following (optional) parameter in solrconfig.xml, which defaults to false: Default parameters are not dumped for now, adding them should only require changing SolrQueryResponseHeaders.setStandardHeaders(). Also, DefaultSolrParams.getParameterNamesIterator() now returns all parameters thanks to the new IteratorChain utility class (is there a better way without copying collections? sounds fairly hairy for a simple thing). > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-59) Copy request parameters to Solr's response
[ http://issues.apache.org/jira/browse/SOLR-59?page=all ] Bertrand Delacretaz updated SOLR-59: Attachment: SOLR-59-20061024.patch > Copy request parameters to Solr's response > -- > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > > 0 > 1 > > > red > blue > > 10 > 0 > on > solr > > 2.1 > > > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
