[jira] Updated: (SOLR-874) Dismax parser exceptions on trailing OPERATOR
[
https://issues.apache.org/jira/browse/SOLR-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Darroch updated SOLR-874:
---
Attachment: SOLR-874-1.3.patch
Hi, I'm one of the httpd devs but I thought I'd throw in this patch for Solr
1.3 (I'll try to make one for trunk later) which handles a number of the issues
raised in this report for us.
First, and | are escaped, and the dismax logic is changed a little so that if
the various query-munging methods return a blank string, we fall back to using
the configured default query.
Next, consecutive + or - chars are flattened to a single char; this handles
cases where a user might accidentally type --foo when they just mean -foo.
Strings of mixed + and - chars are removed, since we have no way of knowing the
user's intent without something like +-foo or similar.
Together these two steps handle one of the reported cases where the query
starts with multiple + or - operators.
Any remaining + or - chars which trail the last term, or which have whitespace
on their right side, are removed. Our users found it puzzling in the extreme
that a search on questions 1 - 10 explicitly excluded results with 10 in
them, because - 10 is treated as -10. So we just remove any + or - operators
which aren't right up against the following term.
Finally, we escape AND, OR, and NOT when they appear outside of quotes, and
remove any trailing unmatched quote. This changes the previous behaviour which
removes all quotes if they aren't perfectly balanced; we felt this was more in
line with what users expect if they mistype and enter an extra quote char.
So far I haven't been able to generate any Lucene query parser exceptions with
this code, but it doesn't mean it's perfect, obviously -- there may still be
some way to slip an invalid Lucene query past it. But I'm cautiously
optimistic that it covers all or most of the issues raised so far in the thread.
Dismax parser exceptions on trailing OPERATOR
-
Key: SOLR-874
URL: https://issues.apache.org/jira/browse/SOLR-874
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.3
Reporter: Erik Hatcher
Fix For: 1.5
Attachments: SOLR-874-1.3.patch, SOLR-874.patch
Dismax is supposed to be immune to parse exceptions, but alas it's not:
http://localhost:8983/solr/select?defType=dismaxqf=nameq=ipod+AND
kaboom!
Caused by: org.apache.lucene.queryParser.ParseException: Cannot parse 'ipod
AND': Encountered EOF at line 1, column 8.
Was expecting one of:
NOT ...
+ ...
- ...
( ...
* ...
QUOTED ...
TERM ...
PREFIXTERM ...
WILDTERM ...
[ ...
{ ...
NUMBER ...
TERM ...
* ...
at org.apache.lucene.queryParser.QueryParser.parse(QueryParser.java:175)
at
org.apache.solr.search.DismaxQParser.parse(DisMaxQParserPlugin.java:138)
at org.apache.solr.search.QParser.getQuery(QParser.java:88)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-874) Dismax parser exceptions on trailing OPERATOR
[
https://issues.apache.org/jira/browse/SOLR-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-874:
---
Fix Version/s: 1.5
Dismax parser exceptions on trailing OPERATOR
-
Key: SOLR-874
URL: https://issues.apache.org/jira/browse/SOLR-874
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.3
Reporter: Erik Hatcher
Fix For: 1.5
Attachments: SOLR-874.patch
Dismax is supposed to be immune to parse exceptions, but alas it's not:
http://localhost:8983/solr/select?defType=dismaxqf=nameq=ipod+AND
kaboom!
Caused by: org.apache.lucene.queryParser.ParseException: Cannot parse 'ipod
AND': Encountered EOF at line 1, column 8.
Was expecting one of:
NOT ...
+ ...
- ...
( ...
* ...
QUOTED ...
TERM ...
PREFIXTERM ...
WILDTERM ...
[ ...
{ ...
NUMBER ...
TERM ...
* ...
at org.apache.lucene.queryParser.QueryParser.parse(QueryParser.java:175)
at
org.apache.solr.search.DismaxQParser.parse(DisMaxQParserPlugin.java:138)
at org.apache.solr.search.QParser.getQuery(QParser.java:88)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-874) Dismax parser exceptions on trailing OPERATOR
[
https://issues.apache.org/jira/browse/SOLR-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Wolanin updated SOLR-874:
---
Attachment: SOLR-874.patch
Here's a simple patch that escapes with a \. It prevents the exception,
however, this fails to match and/or/not (after removing those from the
stopwords file) so it's clearly not quite right.
Dismax parser exceptions on trailing OPERATOR
-
Key: SOLR-874
URL: https://issues.apache.org/jira/browse/SOLR-874
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.3
Reporter: Erik Hatcher
Attachments: SOLR-874.patch
Dismax is supposed to be immune to parse exceptions, but alas it's not:
http://localhost:8983/solr/select?defType=dismaxqf=nameq=ipod+AND
kaboom!
Caused by: org.apache.lucene.queryParser.ParseException: Cannot parse 'ipod
AND': Encountered EOF at line 1, column 8.
Was expecting one of:
NOT ...
+ ...
- ...
( ...
* ...
QUOTED ...
TERM ...
PREFIXTERM ...
WILDTERM ...
[ ...
{ ...
NUMBER ...
TERM ...
* ...
at org.apache.lucene.queryParser.QueryParser.parse(QueryParser.java:175)
at
org.apache.solr.search.DismaxQParser.parse(DisMaxQParserPlugin.java:138)
at org.apache.solr.search.QParser.getQuery(QParser.java:88)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
