Re: MultiCore and load()

2008-03-25 Thread Ryan McKinley 

If it makes something easier, I think that is fine.


Grant Ingersoll wrote:

More on multicore:

Would it also make sense for there to be a MultiCore(String dir, File 
config) constructor that just calls load()?


-Grant

Re: MultiCore and load()

2008-03-25 Thread Ryan McKinley 

check the latest patch...

Grant Ingersoll wrote:
It seems like the MultiCore instance could be put into the Servlet 
Context, then index.jsp would have access to it.



On Mar 25, 2008, at 9:32 AM, Ryan McKinley wrote:


Grant Ingersoll wrote:

More on multicore:
Would it also make sense for there to be a MultiCore(String dir, File 
config) constructor that just calls load()?


In what context are you calling new MultiCore() directly?  The 
getInstance() bit is there so that if someone else modifies the 
MultiCore settings *before* SolrDispatchFilter, those multicore 
settings would be used.


Looking at it fresh, this edge use case could use a custom 
SoleDispatchFilter subclass and return the MultiCore directly from:


 protected MultiCore initMultiCore(FilterConfig config) { }

I'll create a quick patch and see what you guys think.

ryan

Re: MultiCore and load()

2008-03-25 Thread Grant Ingersoll 
It seems like the MultiCore instance could be put into the Servlet  
Context, then index.jsp would have access to it.



On Mar 25, 2008, at 9:32 AM, Ryan McKinley wrote:


Grant Ingersoll wrote:

More on multicore:
Would it also make sense for there to be a MultiCore(String dir,  
File config) constructor that just calls load()?


In what context are you calling new MultiCore() directly?  The  
getInstance() bit is there so that if someone else modifies the  
MultiCore settings *before* SolrDispatchFilter, those multicore  
settings would be used.


Looking at it fresh, this edge use case could use a custom  
SoleDispatchFilter subclass and return the MultiCore directly from:


 protected MultiCore initMultiCore(FilterConfig config) { }

I'll create a quick patch and see what you guys think.

ryan

Re: MultiCore and load()

2008-03-25 Thread Ryan McKinley 

Grant Ingersoll wrote:

More on multicore:

Would it also make sense for there to be a MultiCore(String dir, File 
config) constructor that just calls load()?




In what context are you calling new MultiCore() directly?  The 
getInstance() bit is there so that if someone else modifies the 
MultiCore settings *before* SolrDispatchFilter, those multicore settings 
would be used.


Looking at it fresh, this edge use case could use a custom 
SoleDispatchFilter subclass and return the MultiCore directly from:


  protected MultiCore initMultiCore(FilterConfig config) { }

I'll create a quick patch and see what you guys think.

ryan