Re: XMLWriter
Created SOLR-1823. I attached a patch for this particular problem. Any other places we missed this? None, that I could spot, there are so many warnings about unchecked castings rsp. not using Generics. -- mit freundlichem Gruß, Frank Wesemann Fotofinder GmbH USt-IdNr. DE812854514 Software EntwicklungWeb: http://www.fotofinder.com/ Potsdamer Str. 96 Tel: +49 30 25 79 28 90 10785 BerlinFax: +49 30 25 79 28 999 Sitz: Berlin Amtsgericht Berlin Charlottenburg (HRB 73099) Geschäftsführer: Ali Paczensky
Re: XMLWriter
On Fri, Mar 12, 2010 at 3:37 PM, Frank Wesemann f.wesem...@fotofinder.net wrote: Hello, I don't want to roll up all the XMLWriter issues, but stumpled upon this: http://lucene.apache.org/solr/api/org/apache/solr/response/SolrQueryResponse.html#returnable_data says that a Map containing any of the items in this list may be contained in a SolrQueryResponse and will be handled by QueryResponseWriters. This is not true for (at least) Keys in Maps. XMLWriter tries to cast any key to a String. ( There is even a comment on this in the source !?). Is there a reason not to use String.valueOf( entry.getKey() ) or such? Yeah, seems like the right approach. Any other places we missed this? -Yonik http://www.lucidimagination.com
Re: XMLWriter
Yeah, seems like the right approach. Good, I feared I missed sth. obvious. :-) Any other places we missed this? I'll have a look at it. I'll also open an JIRA issue and add patches etc, if you don't mind. -- mit freundlichem Gruß, Frank Wesemann Fotofinder GmbH USt-IdNr. DE812854514 Software EntwicklungWeb: http://www.fotofinder.com/ Potsdamer Str. 96 Tel: +49 30 25 79 28 90 10785 BerlinFax: +49 30 25 79 28 999 Sitz: Berlin Amtsgericht Berlin Charlottenburg (HRB 73099) Geschäftsführer: Ali Paczensky
Re: XMLWriter escaping issue
On 4/21/06, Erik Hatcher [EMAIL PROTECTED] wrote: I've corrected this in my local copy with this patch adding the escaping to attribute names and the quot; to XML.chardata_escapes. The question is, is it appropriate to escape quotes everywhere, or should it just be done when writing attribute values? I'd prefer just escaping quotes in attribute values as it makes things like debugging output that contains query strings easier to read, and easier to paste back into the query box for debugging from someone elses output. The attribute values definitely need to be XML escaped though. -Yonik
