Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/HighlightParams.java src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apa
I'm getting compile errors on clean : [mkdir] Created dir:/solr-trunk/build/core [javac] Compiling 314 source files to ...solr-trunk/build/core [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:45: cannot find symbol [javac] symbol : class SpanScorer [javac] location: package org.apache.lucene.search.highlight [javac] import org.apache.lucene.search.highlight.SpanScorer; [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:144: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] private SpanScorer getSpanQueryScorer(Query query, String fieldName, CachingTokenFilter tokenStream, SolrQueryRequest request) throws IOException { [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:147: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, fieldName, tokenStream); [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:150: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, null, tokenStream); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 4 errors SVN Info: >svn info Path: . URL: https://svn.apache.org/repos/asf/lucene/solr/trunk Repository Root: https://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 659696 Node Kind: directory Schedule: normal Last Changed Author: otis Last Changed Rev: 659668 Last Changed Date: 2008-05-23 17:32:45 -0400 (Fri, 23 May 2008) Doesn't this require new Lucene jars? -Grant On May 23, 2008, at 5:23 PM, [EMAIL PROTECTED] wrote: Author: otis Date: Fri May 23 14:23:25 2008 New Revision: 659664 URL: http://svn.apache.org/viewvc?rev=659664&view=rev Log: SOLR-553 Use SpanScorer when highlighting phrase terms and hl.usePhraseHighlighter=true Modified: lucene/solr/trunk/CHANGES.txt lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java lucene/solr/trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java lucene/solr/trunk/src/test/org/apache/solr/highlight/ HighlighterTest.java Modified: lucene/solr/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=659664&r1=659663&r2=659664&view=diff = = = = = = = = == --- lucene/solr/trunk/CHANGES.txt (original) +++ lucene/solr/trunk/CHANGES.txt Fri May 23 14:23:25 2008 @@ -409,7 +409,14 @@ 31. SOLR-514: Added explicit media-type with UTF* charset to *.xsl files that don't already have one. (hossman) - + +32. SOLR-505: Give RequestHandlers the possiblity to suppress the generation +of HTTP caching headers. (Thomas Peuss via Otis Gospodnetic) + +33. SOLR-553: Handle highlighting of phrase terms better when +hl.usePhraseHighligher=true URL param is used. +(Bojan Smid via Otis Gospodnetic) + Other Changes 1. SOLR-135: Moved common classes to org.apache.solr.common and altered the build scripts to make two jars: apache-solr-1.3.jar and Modified: lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/common/params/HighlightParams.java?rev=659664&r1=659663&r2=659664&view=diff = = = = = = = = == --- lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java (original) +++ lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java Fri May 23 14:23:25 2008 @@ -33,6 +33,8 @@ public static final String FIELD_MATCH = HIGHLIGHT +".requireFieldMatch"; public static final String ALTERNATE_FIELD = HIGHLIGHT +".alternateField"; public static final String ALTERNATE_FIELD_LENGTH = HIGHLIGHT +".maxAlternateFieldLength"; + + public static final String USE_PHRASE_HIGHLIGHTER = HIGHLIGHT +".usePhraseHighlighter"; public static final String MERGE_CONTIGUOUS_FRAGMENTS = HIGHLIGHT + ".mergeContiguous"; // Formatter Modified: lucene/solr/trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/highl
Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/HighlightParams.java src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apa
Ah, sorry about that - I was looking at that issue trying to remember why I made a reference to Lucene. Now I remember. :) I assume nobody minds getting 2.4-dev in there, right? Shall I move all lib/lucene*jar to 2.4-dev or just the highlighter? Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch - Original Message > From: Grant Ingersoll <[EMAIL PROTECTED]> > To: solr-dev@lucene.apache.org > Sent: Friday, May 23, 2008 6:47:28 PM > Subject: Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt > src/java/org/apache/solr/common/params/HighlightParams.java > src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java > src/test/org/apache/solr/highlight/HighlighterTest.java > > I'm getting compile errors on clean : > [mkdir] Created dir:/solr-trunk/build/core > [javac] Compiling 314 source files to ...solr-trunk/build/core > [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ > DefaultSolrHighlighter.java:45: cannot find symbol > [javac] symbol : class SpanScorer > [javac] location: package org.apache.lucene.search.highlight > [javac] import org.apache.lucene.search.highlight.SpanScorer; > [javac] ^ > [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ > DefaultSolrHighlighter.java:144: cannot find symbol > [javac] symbol : class SpanScorer > [javac] location: class > org.apache.solr.highlight.DefaultSolrHighlighter > [javac] private SpanScorer getSpanQueryScorer(Query query, > String fieldName, CachingTokenFilter tokenStream, SolrQueryRequest > request) throws IOException { > [javac] ^ > [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ > DefaultSolrHighlighter.java:147: cannot find symbol > [javac] symbol : class SpanScorer > [javac] location: class > org.apache.solr.highlight.DefaultSolrHighlighter > [javac] return new SpanScorer(query, fieldName, tokenStream); > [javac] ^ > [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ > DefaultSolrHighlighter.java:150: cannot find symbol > [javac] symbol : class SpanScorer > [javac] location: class > org.apache.solr.highlight.DefaultSolrHighlighter > [javac] return new SpanScorer(query, null, tokenStream); > [javac] ^ > [javac] Note: Some input files use or override a deprecated API. > [javac] Note: Recompile with -Xlint:deprecation for details. > [javac] Note: Some input files use unchecked or unsafe operations. > [javac] Note: Recompile with -Xlint:unchecked for details. > [javac] 4 errors > > SVN Info: > > >svn info > Path: . > URL: https://svn.apache.org/repos/asf/lucene/solr/trunk > Repository Root: https://svn.apache.org/repos/asf > Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 > Revision: 659696 > Node Kind: directory > Schedule: normal > Last Changed Author: otis > Last Changed Rev: 659668 > Last Changed Date: 2008-05-23 17:32:45 -0400 (Fri, 23 May 2008) > > Doesn't this require new Lucene jars? > > -Grant > > > > On May 23, 2008, at 5:23 PM, [EMAIL PROTECTED] wrote: > > > Author: otis > > Date: Fri May 23 14:23:25 2008 > > New Revision: 659664 > > > > URL: http://svn.apache.org/viewvc?rev=659664&view=rev > > Log: > > SOLR-553 Use SpanScorer when highlighting phrase terms and > > hl.usePhraseHighlighter=true > > > > Modified: > >lucene/solr/trunk/CHANGES.txt > >lucene/solr/trunk/src/java/org/apache/solr/common/params/ > > HighlightParams.java > >lucene/solr/trunk/src/java/org/apache/solr/highlight/ > > DefaultSolrHighlighter.java > >lucene/solr/trunk/src/test/org/apache/solr/highlight/ > > HighlighterTest.java > > > > Modified: lucene/solr/trunk/CHANGES.txt > > URL: > http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=659664&r1=659663&r2=659664&view=diff > > = > > = > > = > > = > > = > > = > > = > > = > > == > > --- lucene/solr/trunk/CHANGES.txt (original) > > +++ lucene/solr/trunk/CHANGES.txt Fri May 23 14:23:25 2008 > > @@ -409,7 +409,14 @@ > > > > 31. SOLR-514: Added explicit media-type with UTF* charset to *.xsl > > files that > > don't already have one. (hossman) > > - > > + > > +32. SOLR-505: Give RequestHandlers the possiblity to suppress the > > generation > > +of HTTP caching headers. (Thomas Peuss via Otis Gospodnetic) > > + > > +33. SOLR-553: Handle highlighting of phrase terms better when > > +hl.usePhraseHighligher=true URL param is used. > > +(Bojan Smid via Otis Gospodnetic) > > + > > Other Changes > > 1. SOLR-135: Moved common classes to org.apache.solr.common and > > altered the > > build scripts to make two jars: apache-solr-1.3.jar and > > > > Modified: lucene/solr/trunk/src/java/org/apache/solr/common/params/ > > HighlightParams.java > > URL: > http://svn.apache.org/v
Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/HighlightParams.java src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apa
Well, if we're not sure on upgrading, we probably should roll this one back. I personally haven't tested 2.4-dev with Solr, but it probably is fine. I don't think copying just the highlighter is the right thing. -Grant On May 23, 2008, at 11:15 PM, Otis Gospodnetic wrote: Ah, sorry about that - I was looking at that issue trying to remember why I made a reference to Lucene. Now I remember. :) I assume nobody minds getting 2.4-dev in there, right? Shall I move all lib/lucene*jar to 2.4-dev or just the highlighter? Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch - Original Message From: Grant Ingersoll <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Friday, May 23, 2008 6:47:28 PM Subject: Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/ HighlightParams.java src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/ HighlighterTest.java I'm getting compile errors on clean : [mkdir] Created dir:/solr-trunk/build/core [javac] Compiling 314 source files to ...solr-trunk/build/core [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:45: cannot find symbol [javac] symbol : class SpanScorer [javac] location: package org.apache.lucene.search.highlight [javac] import org.apache.lucene.search.highlight.SpanScorer; [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:144: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] private SpanScorer getSpanQueryScorer(Query query, String fieldName, CachingTokenFilter tokenStream, SolrQueryRequest request) throws IOException { [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:147: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, fieldName, tokenStream); [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:150: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, null, tokenStream); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 4 errors SVN Info: svn info Path: . URL: https://svn.apache.org/repos/asf/lucene/solr/trunk Repository Root: https://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 659696 Node Kind: directory Schedule: normal Last Changed Author: otis Last Changed Rev: 659668 Last Changed Date: 2008-05-23 17:32:45 -0400 (Fri, 23 May 2008) Doesn't this require new Lucene jars? -Grant On May 23, 2008, at 5:23 PM, [EMAIL PROTECTED] wrote: Author: otis Date: Fri May 23 14:23:25 2008 New Revision: 659664 URL: http://svn.apache.org/viewvc?rev=659664&view=rev Log: SOLR-553 Use SpanScorer when highlighting phrase terms and hl.usePhraseHighlighter=true Modified: lucene/solr/trunk/CHANGES.txt lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java lucene/solr/trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java lucene/solr/trunk/src/test/org/apache/solr/highlight/ HighlighterTest.java Modified: lucene/solr/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=659664&r1=659663&r2=659664&view=diff = = = = = = = = = = --- lucene/solr/trunk/CHANGES.txt (original) +++ lucene/solr/trunk/CHANGES.txt Fri May 23 14:23:25 2008 @@ -409,7 +409,14 @@ 31. SOLR-514: Added explicit media-type with UTF* charset to *.xsl files that don't already have one. (hossman) - + +32. SOLR-505: Give RequestHandlers the possiblity to suppress the generation +of HTTP caching headers. (Thomas Peuss via Otis Gospodnetic) + +33. SOLR-553: Handle highlighting of phrase terms better when +hl.usePhraseHighligher=true URL param is used. +(Bojan Smid via Otis Gospodnetic) + Other Changes 1. SOLR-135: Moved common classes to org.apache.solr.common and altered the build scripts to make two jars: apache-solr-1.3.jar and Modified: lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/common/params/HighlightParams.java?rev=659664&r1=659663&r2=659
Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/HighlightParams.java src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apa
So, upgrading to Lucene trunk breaks the SpellCheckerRequestHandler: Running org.apache.solr.handler.SpellCheckerRequestHandlerTest [junit] [junit] 01responseHeader>10name="cat">1name="cat">1 [junit] [junit] ) [junit] Tests run: 5, Failures: 1, Errors: 0, Time elapsed: 3.037 sec [junit] Test org.apache.solr.handler.SpellCheckerRequestHandlerTest FAILED I only see a few changes in Lucene that were related to the Spell Checker: https://issues.apache.org/jira/browse/LUCENE-1046 https://issues.apache.org/jira/browse/LUCENE-852 https://issues.apache.org/jira/browse/LUCENE-1152 Frankly, the only one that seems like it would be the cause is 1046, which means the test is probably wrong. I'd suggest we rollback this change until proper testing has occurred. -Grant On May 24, 2008, at 7:02 AM, Grant Ingersoll wrote: Well, if we're not sure on upgrading, we probably should roll this one back. I personally haven't tested 2.4-dev with Solr, but it probably is fine. I don't think copying just the highlighter is the right thing. -Grant On May 23, 2008, at 11:15 PM, Otis Gospodnetic wrote: Ah, sorry about that - I was looking at that issue trying to remember why I made a reference to Lucene. Now I remember. :) I assume nobody minds getting 2.4-dev in there, right? Shall I move all lib/lucene*jar to 2.4-dev or just the highlighter? Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch - Original Message From: Grant Ingersoll <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Friday, May 23, 2008 6:47:28 PM Subject: Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/ HighlightParams.java src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/ HighlighterTest.java I'm getting compile errors on clean : [mkdir] Created dir:/solr-trunk/build/core [javac] Compiling 314 source files to ...solr-trunk/build/core [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:45: cannot find symbol [javac] symbol : class SpanScorer [javac] location: package org.apache.lucene.search.highlight [javac] import org.apache.lucene.search.highlight.SpanScorer; [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:144: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] private SpanScorer getSpanQueryScorer(Query query, String fieldName, CachingTokenFilter tokenStream, SolrQueryRequest request) throws IOException { [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:147: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, fieldName, tokenStream); [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:150: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, null, tokenStream); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 4 errors SVN Info: svn info Path: . URL: https://svn.apache.org/repos/asf/lucene/solr/trunk Repository Root: https://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 659696 Node Kind: directory Schedule: normal Last Changed Author: otis Last Changed Rev: 659668 Last Changed Date: 2008-05-23 17:32:45 -0400 (Fri, 23 May 2008) Doesn't this require new Lucene jars? -Grant On May 23, 2008, at 5:23 PM, [EMAIL PROTECTED] wrote: Author: otis Date: Fri May 23 14:23:25 2008 New Revision: 659664 URL: http://svn.apache.org/viewvc?rev=659664&view=rev Log: SOLR-553 Use SpanScorer when highlighting phrase terms and hl.usePhraseHighlighter=true Modified: lucene/solr/trunk/CHANGES.txt lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java lucene/solr/trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java lucene/solr/trunk/src/test/org/apache/solr/highlight/ HighlighterTest.java Modified: lucene/solr/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=659664&r1=659663&r2=659664&view=diff = = = = = = = = = = = === --- lucene/solr/trunk/CHANGES.txt (original) +++ lucene/solr/trunk/CHANGES.txt Fri May
Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/HighlightParams.java src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apa
Also https://issues.apache.org/jira/browse/LUCENE-1183 On May 24, 2008, at 8:06 AM, Grant Ingersoll wrote: So, upgrading to Lucene trunk breaks the SpellCheckerRequestHandler: Running org.apache.solr.handler.SpellCheckerRequestHandlerTest [junit] [junit] 01responseHeader>10name="cat">1name="cat">1 [junit] [junit] ) [junit] Tests run: 5, Failures: 1, Errors: 0, Time elapsed: 3.037 sec [junit] Test org.apache.solr.handler.SpellCheckerRequestHandlerTest FAILED I only see a few changes in Lucene that were related to the Spell Checker: https://issues.apache.org/jira/browse/LUCENE-1046 https://issues.apache.org/jira/browse/LUCENE-852 https://issues.apache.org/jira/browse/LUCENE-1152 Frankly, the only one that seems like it would be the cause is 1046, which means the test is probably wrong. I'd suggest we rollback this change until proper testing has occurred. -Grant On May 24, 2008, at 7:02 AM, Grant Ingersoll wrote: Well, if we're not sure on upgrading, we probably should roll this one back. I personally haven't tested 2.4-dev with Solr, but it probably is fine. I don't think copying just the highlighter is the right thing. -Grant On May 23, 2008, at 11:15 PM, Otis Gospodnetic wrote: Ah, sorry about that - I was looking at that issue trying to remember why I made a reference to Lucene. Now I remember. :) I assume nobody minds getting 2.4-dev in there, right? Shall I move all lib/lucene*jar to 2.4-dev or just the highlighter? Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch - Original Message From: Grant Ingersoll <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Friday, May 23, 2008 6:47:28 PM Subject: Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/ HighlightParams.java src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/ HighlighterTest.java I'm getting compile errors on clean : [mkdir] Created dir:/solr-trunk/build/core [javac] Compiling 314 source files to ...solr-trunk/build/core [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:45: cannot find symbol [javac] symbol : class SpanScorer [javac] location: package org.apache.lucene.search.highlight [javac] import org.apache.lucene.search.highlight.SpanScorer; [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:144: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] private SpanScorer getSpanQueryScorer(Query query, String fieldName, CachingTokenFilter tokenStream, SolrQueryRequest request) throws IOException { [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:147: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, fieldName, tokenStream); [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:150: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, null, tokenStream); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 4 errors SVN Info: svn info Path: . URL: https://svn.apache.org/repos/asf/lucene/solr/trunk Repository Root: https://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 659696 Node Kind: directory Schedule: normal Last Changed Author: otis Last Changed Rev: 659668 Last Changed Date: 2008-05-23 17:32:45 -0400 (Fri, 23 May 2008) Doesn't this require new Lucene jars? -Grant On May 23, 2008, at 5:23 PM, [EMAIL PROTECTED] wrote: Author: otis Date: Fri May 23 14:23:25 2008 New Revision: 659664 URL: http://svn.apache.org/viewvc?rev=659664&view=rev Log: SOLR-553 Use SpanScorer when highlighting phrase terms and hl.usePhraseHighlighter=true Modified: lucene/solr/trunk/CHANGES.txt lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java lucene/solr/trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java lucene/solr/trunk/src/test/org/apache/solr/highlight/ HighlighterTest.java Modified: lucene/solr/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=659664&r1=659663&r2=659664&view=diff = = = = = = = = = = = = == --- lucene/
Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/HighlightParams.java src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java src/test/org/apa
I think the issue is that the Spell Checker is now returning the original word as a suggestion even when the word is spelled correctly, whereas the test assumes there are no entries. -Grant On May 24, 2008, at 8:06 AM, Grant Ingersoll wrote: So, upgrading to Lucene trunk breaks the SpellCheckerRequestHandler: Running org.apache.solr.handler.SpellCheckerRequestHandlerTest [junit] [junit] 01responseHeader>10name="cat">1name="cat">1 [junit] [junit] ) [junit] Tests run: 5, Failures: 1, Errors: 0, Time elapsed: 3.037 sec [junit] Test org.apache.solr.handler.SpellCheckerRequestHandlerTest FAILED I only see a few changes in Lucene that were related to the Spell Checker: https://issues.apache.org/jira/browse/LUCENE-1046 https://issues.apache.org/jira/browse/LUCENE-852 https://issues.apache.org/jira/browse/LUCENE-1152 Frankly, the only one that seems like it would be the cause is 1046, which means the test is probably wrong. I'd suggest we rollback this change until proper testing has occurred. -Grant On May 24, 2008, at 7:02 AM, Grant Ingersoll wrote: Well, if we're not sure on upgrading, we probably should roll this one back. I personally haven't tested 2.4-dev with Solr, but it probably is fine. I don't think copying just the highlighter is the right thing. -Grant On May 23, 2008, at 11:15 PM, Otis Gospodnetic wrote: Ah, sorry about that - I was looking at that issue trying to remember why I made a reference to Lucene. Now I remember. :) I assume nobody minds getting 2.4-dev in there, right? Shall I move all lib/lucene*jar to 2.4-dev or just the highlighter? Otis -- Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch - Original Message From: Grant Ingersoll <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Friday, May 23, 2008 6:47:28 PM Subject: Re: svn commit: r659664 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/common/params/ HighlightParams.java src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java src/test/org/apache/solr/highlight/ HighlighterTest.java I'm getting compile errors on clean : [mkdir] Created dir:/solr-trunk/build/core [javac] Compiling 314 source files to ...solr-trunk/build/core [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:45: cannot find symbol [javac] symbol : class SpanScorer [javac] location: package org.apache.lucene.search.highlight [javac] import org.apache.lucene.search.highlight.SpanScorer; [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:144: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] private SpanScorer getSpanQueryScorer(Query query, String fieldName, CachingTokenFilter tokenStream, SolrQueryRequest request) throws IOException { [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:147: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, fieldName, tokenStream); [javac] ^ [javac] ...solr-trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java:150: cannot find symbol [javac] symbol : class SpanScorer [javac] location: class org.apache.solr.highlight.DefaultSolrHighlighter [javac] return new SpanScorer(query, null, tokenStream); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 4 errors SVN Info: svn info Path: . URL: https://svn.apache.org/repos/asf/lucene/solr/trunk Repository Root: https://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 659696 Node Kind: directory Schedule: normal Last Changed Author: otis Last Changed Rev: 659668 Last Changed Date: 2008-05-23 17:32:45 -0400 (Fri, 23 May 2008) Doesn't this require new Lucene jars? -Grant On May 23, 2008, at 5:23 PM, [EMAIL PROTECTED] wrote: Author: otis Date: Fri May 23 14:23:25 2008 New Revision: 659664 URL: http://svn.apache.org/viewvc?rev=659664&view=rev Log: SOLR-553 Use SpanScorer when highlighting phrase terms and hl.usePhraseHighlighter=true Modified: lucene/solr/trunk/CHANGES.txt lucene/solr/trunk/src/java/org/apache/solr/common/params/ HighlightParams.java lucene/solr/trunk/src/java/org/apache/solr/highlight/ DefaultSolrHighlighter.java lucene/solr/trunk/src/test/org/apache/solr/highlight/ HighlighterTest.java Modified: lucene/solr/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=659664