Re: The time that init.d script waits before shutdown should be configurable
Patch attached to https://issues.apache.org/jira/browse/SOLR-8065 The windows script is voodo for me :D, I haven’t the knowledge to port this to cmd script. —/Yago Riveiro On Mon, Nov 9, 2015 at 3:23 PM, Upayavira <u...@odoko.co.uk> wrote: > Yago, > I think a JIRA has been raised for this. I'd encourage you to hunt it > down and make a patch. > Upayavira > On Mon, Nov 9, 2015, at 03:09 PM, Yago Riveiro wrote: >> The time that init.d script waits before shutdown should be configurable >> >> The 5 seconds is not enough to all my shards notify the shutdown and the >> process ends with a kill command >> >> I think that in solr.in.sh should exists a entry to configure the time to >> wait before use a kill command >> >> >> >> - >> Best regards >> -- >> View this message in context: >> http://lucene.472066.n3.nabble.com/The-time-that-init-d-script-waits-before-shutdown-should-be-configurable-tp4239143.html >> Sent from the Solr - User mailing list archive at Nabble.com.
Re: The time that init.d script waits before shutdown should be configurable
If you're still going the shell script way, I'd suggest incorporating my changes (patch attached to the issue). It allows waiting for a longer time but only as long as necessary (like it already does during startup). --Ere 11.11.2015, 0.01, Upayavira kirjoitti: On Tue, Nov 10, 2015, at 04:22 PM, Yago Riveiro wrote: Patch attached to https://issues.apache.org/jira/browse/SOLR-8065 The windows script is voodo for me :D, I haven’t the knowledge to port this to cmd script. Great! I saw this! Two things - firstly, when making a patch, please try to avoid whitespace changes. The only changes that should show in the diff should be material changes. Secondly - I think there was a suggestion that this change could be ported *inside* the SolrCLI - i.e. into Java code. Do you reckon you could handle that change? Harder than just updating a shell script, I know, but could be very useful. Upayavira -- Ere Maijala Kansalliskirjasto / The National Library of Finland
Re: The time that init.d script waits before shutdown should be configurable
On Tue, Nov 10, 2015, at 04:22 PM, Yago Riveiro wrote: > Patch attached to https://issues.apache.org/jira/browse/SOLR-8065 > > > > > > The windows script is voodo for me :D, I haven’t the knowledge to port > this to cmd script. Great! I saw this! Two things - firstly, when making a patch, please try to avoid whitespace changes. The only changes that should show in the diff should be material changes. Secondly - I think there was a suggestion that this change could be ported *inside* the SolrCLI - i.e. into Java code. Do you reckon you could handle that change? Harder than just updating a shell script, I know, but could be very useful. Upayavira
The time that init.d script waits before shutdown should be configurable
The time that init.d script waits before shutdown should be configurable The 5 seconds is not enough to all my shards notify the shutdown and the process ends with a kill command I think that in solr.in.sh should exists a entry to configure the time to wait before use a kill command - Best regards -- View this message in context: http://lucene.472066.n3.nabble.com/The-time-that-init-d-script-waits-before-shutdown-should-be-configurable-tp4239143.html Sent from the Solr - User mailing list archive at Nabble.com.
Re: The time that init.d script waits before shutdown should be configurable
Yago, I think a JIRA has been raised for this. I'd encourage you to hunt it down and make a patch. Upayavira On Mon, Nov 9, 2015, at 03:09 PM, Yago Riveiro wrote: > The time that init.d script waits before shutdown should be configurable > > The 5 seconds is not enough to all my shards notify the shutdown and the > process ends with a kill command > > I think that in solr.in.sh should exists a entry to configure the time to > wait before use a kill command > > > > - > Best regards > -- > View this message in context: > http://lucene.472066.n3.nabble.com/The-time-that-init-d-script-waits-before-shutdown-should-be-configurable-tp4239143.html > Sent from the Solr - User mailing list archive at Nabble.com.
