CVS commit: src/sys/modules/compat_netbsd32
Module Name:src Committed By: pgoyette Date: Sat Mar 23 03:04:58 UTC 2019 Modified Files: src/sys/modules/compat_netbsd32: Makefile Log Message: The main compat_netbsd32 module doesn't contain any prior-version-compat code, so we don't need these CPP_FLAGS. The appropriate CPP_FLAGS are included in the Makefiles for the various compat_netbsd32_xx modules. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/modules/compat_netbsd32/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src Committed By: pgoyette Date: Sat Mar 23 03:04:58 UTC 2019 Modified Files: src/sys/modules/compat_netbsd32: Makefile Log Message: The main compat_netbsd32 module doesn't contain any prior-version-compat code, so we don't need these CPP_FLAGS. The appropriate CPP_FLAGS are included in the Makefiles for the various compat_netbsd32_xx modules. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/modules/compat_netbsd32/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/compat_netbsd32/Makefile diff -u src/sys/modules/compat_netbsd32/Makefile:1.23 src/sys/modules/compat_netbsd32/Makefile:1.24 --- src/sys/modules/compat_netbsd32/Makefile:1.23 Sun Feb 17 04:05:45 2019 +++ src/sys/modules/compat_netbsd32/Makefile Sat Mar 23 03:04:57 2019 @@ -1,23 +1,10 @@ -# $NetBSD: Makefile,v 1.23 2019/02/17 04:05:45 rin Exp $ +# $NetBSD: Makefile,v 1.24 2019/03/23 03:04:57 pgoyette Exp $ .include "../Makefile.inc" .include "../Makefile.assym" KMOD= compat_netbsd32 -CPPFLAGS+= -DCOMPAT_09 -CPPFLAGS+= -DCOMPAT_10 -CPPFLAGS+= -DCOMPAT_11 -CPPFLAGS+= -DCOMPAT_12 -CPPFLAGS+= -DCOMPAT_13 -CPPFLAGS+= -DCOMPAT_14 -CPPFLAGS+= -DCOMPAT_15 -CPPFLAGS+= -DCOMPAT_16 - -CPPFLAGS+= -DCOMPAT_20 -CPPFLAGS+= -DCOMPAT_30 -DCOMPAT_40 -DCOMPAT_50 -CPPFLAGS+= -DCOMPAT_60 -DCOMPAT_70 -DCOMPAT_80 -CPPFLAGS+= -DCOMPAT_43 CPPFLAGS+= -DCOMPAT_NETBSD32 CPPFLAGS+= -DEXEC_ELF32 -DEXEC_ELF64 CPPFLAGS+= -DCOREDUMP -DNTP -DVMSWAP
CVS commit: src/sys/dev/usb
Module Name:src Committed By: mrg Date: Sat Mar 23 02:19:31 UTC 2019 Modified Files: src/sys/dev/usb: uhid.c uhidev.h Log Message: use sc_lock not sc_access_lock to check UHIDEV_OPEN. fixes a soft hang when usbhidaction has a uhid open and bzflag tries to open it as well. XXX: pullup-7, pullup-8 (where i saw this originally.) To generate a diff of this commit: cvs rdiff -u -r1.106 -r1.107 src/sys/dev/usb/uhid.c cvs rdiff -u -r1.19 -r1.20 src/sys/dev/usb/uhidev.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/usb/uhid.c diff -u src/sys/dev/usb/uhid.c:1.106 src/sys/dev/usb/uhid.c:1.107 --- src/sys/dev/usb/uhid.c:1.106 Fri Mar 1 11:06:56 2019 +++ src/sys/dev/usb/uhid.c Sat Mar 23 02:19:31 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: uhid.c,v 1.106 2019/03/01 11:06:56 pgoyette Exp $ */ +/* $NetBSD: uhid.c,v 1.107 2019/03/23 02:19:31 mrg Exp $ */ /* * Copyright (c) 1998, 2004, 2008, 2012 The NetBSD Foundation, Inc. @@ -35,7 +35,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: uhid.c,v 1.106 2019/03/01 11:06:56 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: uhid.c,v 1.107 2019/03/23 02:19:31 mrg Exp $"); #ifdef _KERNEL_OPT #include "opt_compat_netbsd.h" @@ -317,21 +317,23 @@ uhidopen(dev_t dev, int flag, int mode, if (sc->sc_dying) return ENXIO; - mutex_enter(>sc_access_lock); + mutex_enter(>sc_lock); /* * uhid interrupts aren't enabled yet, so setup sc_q now, as * long as they're not already allocated. */ if (sc->sc_hdev.sc_state & UHIDEV_OPEN) { - mutex_exit(>sc_access_lock); + mutex_exit(>sc_lock); return EBUSY; } + mutex_exit(>sc_lock); + if (clalloc(>sc_q, UHID_BSIZE, 0) == -1) { - mutex_exit(>sc_access_lock); return ENOMEM; } + mutex_enter(>sc_access_lock); error = uhidev_open(>sc_hdev); if (error) { clfree(>sc_q); Index: src/sys/dev/usb/uhidev.h diff -u src/sys/dev/usb/uhidev.h:1.19 src/sys/dev/usb/uhidev.h:1.20 --- src/sys/dev/usb/uhidev.h:1.19 Sat Apr 23 10:15:32 2016 +++ src/sys/dev/usb/uhidev.h Sat Mar 23 02:19:31 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: uhidev.h,v 1.19 2016/04/23 10:15:32 skrll Exp $ */ +/* $NetBSD: uhidev.h,v 1.20 2019/03/23 02:19:31 mrg Exp $ */ /* * Copyright (c) 2001 The NetBSD Foundation, Inc. @@ -67,8 +67,8 @@ struct uhidev { struct uhidev_softc *sc_parent; uByte sc_report_id; uint8_t sc_state; - int sc_in_rep_size; #define UHIDEV_OPEN 0x01 /* device is open */ + int sc_in_rep_size; void (*sc_intr)(struct uhidev *, void *, u_int); krndsource_t rnd_source; };
CVS commit: src/sys/dev/usb
Module Name:src Committed By: mrg Date: Sat Mar 23 02:19:31 UTC 2019 Modified Files: src/sys/dev/usb: uhid.c uhidev.h Log Message: use sc_lock not sc_access_lock to check UHIDEV_OPEN. fixes a soft hang when usbhidaction has a uhid open and bzflag tries to open it as well. XXX: pullup-7, pullup-8 (where i saw this originally.) To generate a diff of this commit: cvs rdiff -u -r1.106 -r1.107 src/sys/dev/usb/uhid.c cvs rdiff -u -r1.19 -r1.20 src/sys/dev/usb/uhidev.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/crash
Module Name:src Committed By: mrg Date: Sat Mar 23 02:07:32 UTC 2019 Modified Files: src/usr.sbin/crash: crash.8 Log Message: add an example shell pipeline that will print *all* kernel stack traces. bump date. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/crash/crash.8 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/usr.sbin/crash/crash.8 diff -u src/usr.sbin/crash/crash.8:1.7 src/usr.sbin/crash/crash.8:1.8 --- src/usr.sbin/crash/crash.8:1.7 Mon Jul 3 21:35:30 2017 +++ src/usr.sbin/crash/crash.8 Sat Mar 23 02:07:32 2019 @@ -1,4 +1,4 @@ -.\" $NetBSD: crash.8,v 1.7 2017/07/03 21:35:30 wiz Exp $ +.\" $NetBSD: crash.8,v 1.8 2019/03/23 02:07:32 mrg Exp $ .\" .\" Copyright (c) 2009 The NetBSD Foundation, Inc. .\" All rights reserved. @@ -27,7 +27,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.Dd December 10, 2016 +.Dd March 22, 2019 .Dt CRASH 8 .Os .Sh NAME @@ -83,6 +83,13 @@ For example: crash> ps | more crash> ps | grep ioflush .Ed +.Sh EXAMPLES +You can obtain a full list of all kernel stack traces with a shell pipeline +like the following: +.Bd -literal -offset abcd +# echo ps | crash | grep '^[0-9]' | cut -c 30-46 | \\ + sed 's,^,bt/a ,' | crash +.Ed .Sh SEE ALSO .Xr ps 1 , .Xr vmstat 1 ,
CVS commit: src/usr.sbin/crash
Module Name:src Committed By: mrg Date: Sat Mar 23 02:07:32 UTC 2019 Modified Files: src/usr.sbin/crash: crash.8 Log Message: add an example shell pipeline that will print *all* kernel stack traces. bump date. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/crash/crash.8 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/dev/pci
Hello, On Fri, 22 Mar 2019 17:07:10 + m...@netbsd.org wrote: > On Fri, Mar 22, 2019 at 07:41:41AM +, Martin Husemann wrote: > > @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc > > pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, , > > >sc_biossz); > > > > + if (sc->sc_biossz == 0 || sc->sc_bios == NULL) > > + return; > > + > > foundit: > > if (sc->sc_biossz > 0) { > ^^^ Now the else branch isn't possible? ...and we also need to re-enable video DMA and output, so this is wrong, and I committed a fix earlier anyway. have fun Michael
Re: CVS commit: src/sys/dev/pci
On Fri, Mar 22, 2019 at 07:41:41AM +, Martin Husemann wrote: > @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc > pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, , > >sc_biossz); > > + if (sc->sc_biossz == 0 || sc->sc_bios == NULL) > + return; > + > foundit: > if (sc->sc_biossz > 0) { ^^^ Now the else branch isn't possible?
CVS commit: src/distrib/sets/lists/comp
Module Name:src Committed By: uki Date: Fri Mar 22 11:09:43 UTC 2019 Modified Files: src/distrib/sets/lists/comp: ad.aarch64 ad.arm ad.mips Log Message: give syspkg names to "-unknown-" files under comp category To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/distrib/sets/lists/comp/ad.aarch64 cvs rdiff -u -r1.96 -r1.97 src/distrib/sets/lists/comp/ad.arm cvs rdiff -u -r1.81 -r1.82 src/distrib/sets/lists/comp/ad.mips Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/comp/ad.aarch64 diff -u src/distrib/sets/lists/comp/ad.aarch64:1.31 src/distrib/sets/lists/comp/ad.aarch64:1.32 --- src/distrib/sets/lists/comp/ad.aarch64:1.31 Sat Feb 9 02:15:05 2019 +++ src/distrib/sets/lists/comp/ad.aarch64 Fri Mar 22 11:09:43 2019 @@ -1,4 +1,4 @@ -# $NetBSD: ad.aarch64,v 1.31 2019/02/09 02:15:05 mrg Exp $ +# $NetBSD: ad.aarch64,v 1.32 2019/03/22 11:09:43 uki Exp $ ./usr/include/aarch64comp-c-include ./usr/include/aarch64/ansi.h comp-c-include ./usr/include/aarch64/aout_machdep.h comp-c-include @@ -163,159 +163,159 @@ ./usr/lib/oabi/libc_vfp.so base-sys-shlib compat,pic,llvm ./usr/lib/oabi/libc_vfp_p.a comp-c-proflib compat,profile,llvm ./usr/lib/oabi/libc_vfp_pic.a comp-c-piclib compat,pic,picinstall,llvm -./usr/libdata/ldscripts/aarch64elf.x -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xbn -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xc -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xd -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xdc -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xdw -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xn -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xr -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xs -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xsc -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xsw -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xu -unknown- binutils -./usr/libdata/ldscripts/aarch64elf.xw -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.x -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xbn -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xc -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xd -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xdc -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xdw -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xn -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xr -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xs -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xsc -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xsw -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xu -unknown- binutils -./usr/libdata/ldscripts/aarch64elfb.xw -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.x -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xbn -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xc -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xd -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xdc -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xdw -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xn -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xr -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xs -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xsc -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xsw -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xu -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsd.xw -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.x -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xbn -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xc -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xd -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xdc -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xdw -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xn -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xr -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xs -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xsc -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xsw -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xu -unknown- binutils -./usr/libdata/ldscripts/aarch64nbsdb.xw -unknown- binutils -./usr/libdata/ldscripts/armelf.x -unknown- binutils -./usr/libdata/ldscripts/armelf.xbn -unknown- binutils -./usr/libdata/ldscripts/armelf.xc -unknown- binutils -./usr/libdata/ldscripts/armelf.xd -unknown- binutils=231 -./usr/libdata/ldscripts/armelf.xdc -unknown- binutils=231 -./usr/libdata/ldscripts/armelf.xdw -unknown- binutils=231 -./usr/libdata/ldscripts/armelf.xn -unknown- binutils
CVS commit: src/distrib/sets/lists/comp
Module Name:src Committed By: uki Date: Fri Mar 22 11:09:43 UTC 2019 Modified Files: src/distrib/sets/lists/comp: ad.aarch64 ad.arm ad.mips Log Message: give syspkg names to "-unknown-" files under comp category To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/distrib/sets/lists/comp/ad.aarch64 cvs rdiff -u -r1.96 -r1.97 src/distrib/sets/lists/comp/ad.arm cvs rdiff -u -r1.81 -r1.82 src/distrib/sets/lists/comp/ad.mips Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: martin Date: Fri Mar 22 07:41:41 UTC 2019 Modified Files: src/sys/dev/pci: radeonfb.c Log Message: Even if you try very hard, some cards just do not have a BIOS. To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103 src/sys/dev/pci/radeonfb.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/pci/radeonfb.c diff -u src/sys/dev/pci/radeonfb.c:1.102 src/sys/dev/pci/radeonfb.c:1.103 --- src/sys/dev/pci/radeonfb.c:1.102 Thu Mar 21 17:40:36 2019 +++ src/sys/dev/pci/radeonfb.c Fri Mar 22 07:41:41 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: radeonfb.c,v 1.102 2019/03/21 17:40:36 macallan Exp $ */ +/* $NetBSD: radeonfb.c,v 1.103 2019/03/22 07:41:41 martin Exp $ */ /*- * Copyright (c) 2006 Itronix Inc. @@ -70,7 +70,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: radeonfb.c,v 1.102 2019/03/21 17:40:36 macallan Exp $"); +__KERNEL_RCSID(0, "$NetBSD: radeonfb.c,v 1.103 2019/03/22 07:41:41 martin Exp $"); #include #include @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, , >sc_biossz); + if (sc->sc_biossz == 0 || sc->sc_bios == NULL) + return; + foundit: if (sc->sc_biossz > 0) { sc->sc_bios = malloc(sc->sc_biossz, M_DEVBUF, M_WAITOK);
CVS commit: src/sys/dev/pci
Module Name:src Committed By: martin Date: Fri Mar 22 07:41:41 UTC 2019 Modified Files: src/sys/dev/pci: radeonfb.c Log Message: Even if you try very hard, some cards just do not have a BIOS. To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103 src/sys/dev/pci/radeonfb.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: mrg Date: Fri Mar 22 07:25:15 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: adjust KASSERT() for sc_lock to handle polling case. should fix usb kdb in ddb. reported by martin. To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/sys/dev/usb/ohci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/usb/ohci.c diff -u src/sys/dev/usb/ohci.c:1.288 src/sys/dev/usb/ohci.c:1.289 --- src/sys/dev/usb/ohci.c:1.288 Sun Feb 17 04:17:52 2019 +++ src/sys/dev/usb/ohci.c Fri Mar 22 07:25:15 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: ohci.c,v 1.288 2019/02/17 04:17:52 rin Exp $ */ +/* $NetBSD: ohci.c,v 1.289 2019/03/22 07:25:15 mrg Exp $ */ /* * Copyright (c) 1998, 2004, 2005, 2012 The NetBSD Foundation, Inc. @@ -41,7 +41,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.288 2019/02/17 04:17:52 rin Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.289 2019/03/22 07:25:15 mrg Exp $"); #ifdef _KERNEL_OPT #include "opt_usb.h" @@ -585,7 +585,7 @@ ohci_reset_std_chain(ohci_softc_t *sc, s OHCIHIST_FUNC(); OHCIHIST_CALLED(); DPRINTF("start len=%jd", alen, 0, 0, 0); - KASSERT(mutex_owned(>sc_lock)); + KASSERT(sc->sc_bus.ub_usepolling || mutex_owned(>sc_lock)); DPRINTFN(8, "addr=%jd endpt=%jd len=%jd speed=%jd", xfer->ux_pipe->up_dev->ud_addr,
CVS commit: src/sys/dev/usb
Module Name:src Committed By: mrg Date: Fri Mar 22 07:25:15 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: adjust KASSERT() for sc_lock to handle polling case. should fix usb kdb in ddb. reported by martin. To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/sys/dev/usb/ohci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.