CVS commit: src/sys/arch/arm/arm
Module Name:src Committed By: skrll Date: Wed Feb 17 06:54:23 UTC 2021 Modified Files: src/sys/arch/arm/arm: idle_machdep.c Log Message: Trailing whitespace. *snigger* To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/arch/arm/arm/idle_machdep.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/x86/x86
Module Name:src Committed By: rillig Date: Wed Feb 17 06:33:48 UTC 2021 Modified Files: src/sys/arch/x86/x86: tsc.c Log Message: x86/tsc: fix double space in warning about TSC going backwards To generate a diff of this commit: cvs rdiff -u -r1.52 -r1.53 src/sys/arch/x86/x86/tsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: mlelstv Date: Wed Feb 17 06:30:57 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: Expose more descriptor items as device properties. To generate a diff of this commit: cvs rdiff -u -r1.248 -r1.249 src/sys/dev/usb/usb_subr.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: rillig Date: Wed Feb 17 06:25:11 UTC 2021 Modified Files: src/sys/kern: makesyscalls.sh systrace_args.c Log Message: makesyscalls.sh: fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.182 -r1.183 src/sys/kern/makesyscalls.sh cvs rdiff -u -r1.44 -r1.45 src/sys/kern/systrace_args.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/mit/xorg/bin/xterm
Module Name:src Committed By: mrg Date: Wed Feb 17 03:06:07 UTC 2021 Modified Files: src/external/mit/xorg/bin/xterm: Makefile Log Message: remove -DOPT_* from here (now in xtermcfg.h). restore comment lost in rev 1.18. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/external/mit/xorg/bin/xterm/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xterm/include
Module Name:xsrc Committed By: mrg Date: Wed Feb 17 03:03:28 UTC 2021 Modified Files: xsrc/external/mit/xterm/include: xtermcfg.h Log Message: define OPT_SIXEL_GRAPHICS here like everything else, rather than than Makefile. (OPT_GRAPHICS is already defined here.) To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 xsrc/external/mit/xterm/include/xtermcfg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/arm/pic
Module Name:src Committed By: jmcneill Date: Tue Feb 16 22:12:50 UTC 2021 Modified Files: src/sys/arch/arm/pic: pic.c pic_splfuncs.c Log Message: pic: avoid pic_do_pending_ints if pic_mark_pending_* has never been called To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65 src/sys/arch/arm/pic/pic.c cvs rdiff -u -r1.12 -r1.13 src/sys/arch/arm/pic/pic_splfuncs.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Tue Feb 16 19:46:15 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: clean up VarAdd, Var_Delete, Var_ReexportVars No functional change. To generate a diff of this commit: cvs rdiff -u -r1.830 -r1.831 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make/unit-tests
Module Name:src Committed By: rillig Date: Tue Feb 16 19:43:09 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varcmd.mk Log Message: make: document the bad state in which the test varcmd.mk is To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/usr.bin/make/unit-tests/varcmd.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make/unit-tests
Module Name:src
Committed By: rillig
Date: Tue Feb 16 19:01:18 UTC 2021
Modified Files:
src/usr.bin/make/unit-tests: directive-export.mk
Log Message:
make: test exporting a variable that itself depends on a subprocess
When the point that "isn't going to end well" is reached, the stacktrace
is quite long but still reasonable:
main
main_ReadFiles
ReadAllMakefiles
ReadMakefiledirective-export.mk
Parse_File
ParseLine # line 3 has: _!= :;:
ParseVarassign
Parse_DoVar
VarAssign_Eval
VarAssign_EvalShell # because of the '!='
Cmd_Exec:;:
Var_ReexportVars# before starting the subprocess
ExportVar EMPTY_SHELL
ExportVarEnv# was only marked for export
Var_Subst ${EMPTY_SHELL} # to get the value to export
VarSubstExpr${EMPTY_SHELL}
Var_Parse ${EMPTY_SHELL}
Var_Subst ${:sh} # since EMPTY_SHELL= ${:sh}
VarSubstExpr${:sh}
Var_Parse ${:sh}
ApplyModifiers
ApplySingleModifier :sh
ApplyModifier
ApplyModifier_SunShell :sh
Cmd_Exec"" # empty command
Var_ReexportVars
ExportVar EMPTY_SHELL
ExportVarEnv# skipping this edge case
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/usr.bin/make/unit-tests/directive-export.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/usr.bin/make/unit-tests
Module Name:src
Committed By: rillig
Date: Tue Feb 16 18:12:46 UTC 2021
Modified Files:
src/usr.bin/make/unit-tests: directive-export.mk
Log Message:
make: clarify what .export ${:U} means
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/usr.bin/make/unit-tests/directive-export.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/usr.bin/make/unit-tests
Module Name:src Committed By: rillig Date: Tue Feb 16 18:02:19 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: directive-undef.exp directive-undef.mk Log Message: make: demonstrate inconsistency in .undef of an exported variable To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/usr.bin/make/unit-tests/directive-undef.exp cvs rdiff -u -r1.9 -r1.10 src/usr.bin/make/unit-tests/directive-undef.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Tue Feb 16 17:41:23 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: clean up and update comments in var.c During the refactorings of the last months, several comments have become outdated, some are now redundant since the code is as clear as the comment, and some code benefits from a bit of explanation. To generate a diff of this commit: cvs rdiff -u -r1.829 -r1.830 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Tue Feb 16 16:33:40 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: use bit-shift expressions for VarFlags constants These are easier to read than hex constants. There was no need to skip bits 2 and 3 (there were no constants for 0x04 and 0x08). Close this gap, to avoid confusing future readers. Keep the relative order of the flags since that affects the debug output of -dv. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.828 -r1.829 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src Committed By: rillig Date: Tue Feb 16 16:28:41 UTC 2021 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: directive-export-impl.exp directive-export-impl.mk Log Message: make: rename constants for VarFlags The old prefix was "VAR_" and this prefix is used for several other constants as well, which made it ambiguous. To generate a diff of this commit: cvs rdiff -u -r1.827 -r1.828 src/usr.bin/make/var.c cvs rdiff -u -r1.3 -r1.4 \ src/usr.bin/make/unit-tests/directive-export-impl.exp cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/directive-export-impl.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/make
Module Name:src
Committed By: rillig
Date: Tue Feb 16 16:14:27 UTC 2021
Modified Files:
src/usr.bin/make: var.c
Log Message:
make: sync comment about duplicated code with reality
There are only very few places in var.c that contain really duplicate
code anymore.
There is still lots of _almost_ duplicate, for example the code for
parsing variable modifiers. It differs subtly in behavior:
* The modifiers ':M' and ':N' use '$$' to escape a '$' sign, while
almost all other modifiers use '\$' for this purpose.
* The modifiers ':M', ':N', ':S', ':@' and several others parse
balanced parentheses and braces, allowing '(' to '}' to match.
The modifiers ':D' and ':U' only treat the end character special but
not the other 3 of '(){}'.
* When parsing the modifier ':S' but not evaluating it, the code for
nested variable expressions is parsed differently from when it is in
evaluation mode (VARE_WANTRES). This applies to an outer ':S'
modifier and an inner ':D' or ':M' modifier.
Since these inconsistencies affect the behavior in edge cases and some
users of make might depend on it, they cannot be fixed by
behavior-preserving refactorings.
To generate a diff of this commit:
cvs rdiff -u -r1.826 -r1.827 src/usr.bin/make/var.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/bin/sh
Module Name:src Committed By: kre Date: Tue Feb 16 15:30:26 UTC 2021 Modified Files: src/bin/sh: input.c Log Message: PR bin/55979 Correctly handle (ie: ignore completely) \0 chars (nuls) in the shell command input stream (script, dot file, or stdin). Previously nul chars were ignored correctly in the line in which they occurred, but would cause trailing chars of that line to reappear as the start of the following line. If there was just one \0 skipped, this would generally result in an extra \n in the sh input, which in most cases has no effect. With multiple \0's in a single line, more of the end of that line was duplicated into the following one. This usually manifested as a weird "command not found" error. Note that any \0 chars in the sh input make the script non-conforming, so fixing this is not crucial (no \0's should really ever be seen) but it was an obvious bug in the code, which was attempting to ignore nul chars (as do many other shells), so let it be fixed. XXX pullup -9 To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72 src/bin/sh/input.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/bin/sh
Module Name:src Committed By: kre Date: Tue Feb 16 15:30:12 UTC 2021 Modified Files: src/bin/sh: exec.c Log Message: PR bin/55979 This fixes the MSAN detected reference to an unitialised variable (an unitialised field in a struct) which happens when a command is not found after a PATH search. Aside from skipping some known to be going to fail exec*() calls in some cases, the setting of the relevant field is irrelevant, so this problem makes no practical difference to the shell, or any shell script. XXX (maybe) pullup -9 To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55 src/bin/sh/exec.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/evbmips/mipssim
Module Name:src Committed By: simonb Date: Tue Feb 16 15:06:30 UTC 2021 Modified Files: src/sys/arch/evbmips/mipssim: mipssimreg.h Log Message: Whitespace nit. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/arch/evbmips/mipssim/mipssimreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/compat/netbsd32
Module Name:src Committed By: simonb Date: Tue Feb 16 14:47:20 UTC 2021 Modified Files: src/sys/compat/netbsd32: netbsd32_fs.c Log Message: In netbsd32___mount50() zero out the native fs_args union before use so we don't pass stack garbage to the lower layers in the MNT_GETARGS case. Fixes random errors like "Bad address" from "mount -vv" with nfs mounts. To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/sys/compat/netbsd32/netbsd32_fs.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libc
Module Name:src Committed By: riastradh Date: Tue Feb 16 14:44:26 UTC 2021 Modified Files: src/lib/libc/stdio: printf.3 wprintf.3 src/lib/libc/stdlib: rand48.3 Log Message: Correct floating-point terminology. Might want to harmonize the printf(3) and wprintf(3) descriptions of `%a'. To generate a diff of this commit: cvs rdiff -u -r1.68 -r1.69 src/lib/libc/stdio/printf.3 cvs rdiff -u -r1.8 -r1.9 src/lib/libc/stdio/wprintf.3 cvs rdiff -u -r1.13 -r1.14 src/lib/libc/stdlib/rand48.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/evbmips/conf
Module Name:src Committed By: reinoud Date: Tue Feb 16 10:58:33 UTC 2021 Modified Files: src/sys/arch/evbmips/conf: MIPSSIM files.mipssim Log Message: I forgot to add the needed conf files for the mipssim virtio addition To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/arch/evbmips/conf/MIPSSIM cvs rdiff -u -r1.1 -r1.2 src/sys/arch/evbmips/conf/files.mipssim Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet
Module Name:src Committed By: martin Date: Tue Feb 16 10:22:52 UTC 2021 Modified Files: src/sys/netinet: if_arp.c Log Message: One more time: backout arp header alignment, now that the alignment asserted has been aligned to reality. Also remove unused ARP_HDR_ALIGNED_P macro. Pointed out by roy. To generate a diff of this commit: cvs rdiff -u -r1.305 -r1.306 src/sys/netinet/if_arp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/net
Module Name:src Committed By: martin Date: Tue Feb 16 10:20:56 UTC 2021 Modified Files: src/sys/net: if_arp.h Log Message: ARP headers only need 2 byte alignment - pointed out by roy. To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41 src/sys/net/if_arp.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/etc/rc.d
Module Name:src Committed By: hannken Date: Tue Feb 16 10:02:42 UTC 2021 Modified Files: src/etc/rc.d: mountall mountd Log Message: Enable "/etc/zfs/exports" from "zfs share" in rc.d/mountd and rc.d/mountall. To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/etc/rc.d/mountall src/etc/rc.d/mountd Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/mountd
Module Name:src Committed By: wiz Date: Tue Feb 16 10:01:55 UTC 2021 Modified Files: src/usr.sbin/mountd: mountd.8 Log Message: Reword slightly. To generate a diff of this commit: cvs rdiff -u -r1.39 -r1.40 src/usr.sbin/mountd/mountd.8 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/mountd
Module Name:src Committed By: hannken Date: Tue Feb 16 10:00:27 UTC 2021 Modified Files: src/usr.sbin/mountd: mountd.8 mountd.c Log Message: Add support for multiple exports files. This will be useful for example for ZFS, where we have an automatically generated /etc/zfs/exports file, which should not be edited directly. To generate a diff of this commit: cvs rdiff -u -r1.38 -r1.39 src/usr.sbin/mountd/mountd.8 cvs rdiff -u -r1.133 -r1.134 src/usr.sbin/mountd/mountd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/mountd
Module Name:src Committed By: hannken Date: Tue Feb 16 09:58:35 UTC 2021 Modified Files: src/usr.sbin/mountd: mountd.c Log Message: Split get_exportlist() into get_exportlist() and get_exportlist_one() in preparation to support multiple input files. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.132 -r1.133 src/usr.sbin/mountd/mountd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: hannken Date: Tue Feb 16 09:56:32 UTC 2021 Modified Files: src/sys/kern: vfs_mount.c src/sys/uvm: uvm_swap.c Log Message: Reorganize uvm_swap_shutdown() a bit, make sure the vnode gets locked and referenced across the call to swap_off() and finally use it from vfs_unmountall1() to remove swap after unmounting the last file system. Adresses PR kern/54969 (Disk cache is no longer flushed on shutdown) To generate a diff of this commit: cvs rdiff -u -r1.85 -r1.86 src/sys/kern/vfs_mount.c cvs rdiff -u -r1.200 -r1.201 src/sys/uvm/uvm_swap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs/sys
Module Name:src Committed By: hannken Date: Tue Feb 16 09:54:17 UTC 2021 Modified Files: src/external/cddl/osnet/dist/uts/common/fs/zfs/sys: zfs_context.h Log Message: Use the right uid / gid for nobody:nobody like FreeBSD does. Prevents null pointer dereferences when ZFS replaces this illegal (according to IS_EPHEMERAL()) id with another illegal id in operation zfs_fuid_create_cred() and finally zfs_log_create() dereferences fuidp being NULL. Adresses PR misc/55042 (Panic when creating a directory on a NFS served ZFS) To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 \ src/external/cddl/osnet/dist/uts/common/fs/zfs/sys/zfs_context.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: kre Date: Tue Feb 16 09:46:24 UTC 2021 Modified Files: src/distrib/sets/lists/tests: mi src/tests/bin/sh: Makefile Added Files: src/tests/bin/sh: t_input.sh Log Message: PR bin/55979 Add a sh ATF test to demonstrate a bug in the way that \0 characters are dropped from scripts. This test will eventually be extended to test other potential sh script input related issues. When initially committed, this test should fail. It should succeed when the fix for the PR is committed (soon). Nb: this tests only the \0 related issues from the PR, the MSAN detected uninitialised variable (struct field) can only be detected by MSAN, as it has no visible impact on the operation of the shell when running on any real (or even emulated) hardware. (It will, however, also be fixed). To generate a diff of this commit: cvs rdiff -u -r1.1018 -r1.1019 src/distrib/sets/lists/tests/mi cvs rdiff -u -r1.14 -r1.15 src/tests/bin/sh/Makefile cvs rdiff -u -r0 -r1.1 src/tests/bin/sh/t_input.sh Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
