CVS commit: src/sys/dev/ata

2020-12-27 Thread Jared D. McNeill
Module Name:src
Committed By:   jmcneill
Date:   Sun Dec 27 15:15:45 UTC 2020

Modified Files:
src/sys/dev/ata: satareg.h

Log Message:
Add G3 and DevSleep definitions. This changes the mask used by
SControl_IPM_NONE from 0x3 to 0x7.


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ata/satareg.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-12-23 Thread Nick Hudson
Module Name:src
Committed By:   skrll
Date:   Wed Dec 23 08:17:01 UTC 2020

Modified Files:
src/sys/dev/ata: ata_subr.c

Log Message:
Add missing '\n' in debug


To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/ata/ata_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-12-19 Thread Jared D. McNeill
Module Name:src
Committed By:   jmcneill
Date:   Sat Dec 19 18:09:44 UTC 2020

Modified Files:
src/sys/dev/ata: ata_subr.c

Log Message:
ata_timeout: restore spl in ATACH_RECOVERING path


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/ata/ata_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-09-28 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Mon Sep 28 12:47:49 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
fix typo that prevented bytes/physsect reporting from working


To generate a diff of this commit:
cvs rdiff -u -r1.464 -r1.465 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-09-27 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Sep 27 16:58:11 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
de-quadruplicate, remove unused argument


To generate a diff of this commit:
cvs rdiff -u -r1.463 -r1.464 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-08-25 Thread Nick Hudson
Module Name:src
Committed By:   skrll
Date:   Tue Aug 25 13:42:09 UTC 2020

Modified Files:
src/sys/dev/ata: ata_raid.c

Log Message:
KNF


To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43 src/sys/dev/ata/ata_raid.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-25 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon May 25 19:05:30 UTC 2020

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
disable downgrade of ATA mode from DMA, as generally not relevant
any more - while it has been instrumental to inadvertedly discover
driver bugs in PIO mode under QEMU recently, generally the switch
more hurts than helps, so now only warn when DMA errors happen

code kept under ATA_DOWNGRADE_MODE ifdef, disabled by default


To generate a diff of this commit:
cvs rdiff -u -r1.158 -r1.159 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-25 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon May 25 18:29:25 UTC 2020

Modified Files:
src/sys/dev/ata: ata.c atavar.h

Log Message:
make ata_downgrade_mode() static, it's not used anywhere else


To generate a diff of this commit:
cvs rdiff -u -r1.157 -r1.158 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.107 -r1.108 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-24 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sun May 24 22:12:29 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
account for already transferred data (partially done I/O) when
retrying an xfer, to avoid reading/writing data from/to wrong offset,
and eventually beyond the end of data buffer

fixes data corruption under QEMU observed by Paul Ripke for emulated
IDE drives


To generate a diff of this commit:
cvs rdiff -u -r1.462 -r1.463 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-21 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Thu May 21 09:11:33 UTC 2020

Modified Files:
src/sys/dev/ata: ata_wdc.c

Log Message:
stop timeout handler while scheduling another part of partial I/O,
to avoid race between the timeout and I/O submission; the I/O
submission can sleep with xfer while waiting for the controller to
be ready once it gets to thread context, and timeout might cause
the xfer to be freed, leading to crashes due to use-after-free

this fixes another type of crashes with slow devices under QEMU reported
by Paul Ripke - thanks a lot with extensive debugging help


To generate a diff of this commit:
cvs rdiff -u -r1.117 -r1.118 src/sys/dev/ata/ata_wdc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-15 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Fri May 15 21:56:14 UTC 2020

Modified Files:
src/sys/dev/ata: atareg.h

Log Message:
remove unused atacmd_tostatq()


To generate a diff of this commit:
cvs rdiff -u -r1.44 -r1.45 src/sys/dev/ata/atareg.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-15 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Fri May 15 16:58:28 UTC 2020

Modified Files:
src/sys/dev/ata: ata_wdc.c

Log Message:
whitespace (bad indent)


To generate a diff of this commit:
cvs rdiff -u -r1.115 -r1.116 src/sys/dev/ata/ata_wdc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-05-02 Thread Jason R Thorpe
Module Name:src
Committed By:   thorpej
Date:   Sat May  2 19:09:56 UTC 2020

Modified Files:
src/sys/dev/ata: ata.c ata_subr.c atavar.h

Log Message:
Back out changes to use a threadpool for now; it's causing trouble
for some folks on Thinkpads.


To generate a diff of this commit:
cvs rdiff -u -r1.156 -r1.157 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/ata/ata_subr.c
cvs rdiff -u -r1.106 -r1.107 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-04-24 Thread Jason R Thorpe
Module Name:src
Committed By:   thorpej
Date:   Sat Apr 25 00:07:27 UTC 2020

Modified Files:
src/sys/dev/ata: ata.c ata_subr.c atavar.h

Log Message:
Rather than creating a kthread-per-channel, use a threadpool and a
threadpool-job-per-channel for the in-thread-context work that needs
to be done (which is rare).

On one of my test systems, this results in the total number of LWPs
after multi-user boot dropping from 116 to 78.


To generate a diff of this commit:
cvs rdiff -u -r1.155 -r1.156 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/ata_subr.c
cvs rdiff -u -r1.105 -r1.106 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-04-07 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Tue Apr  7 13:22:05 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
drop wd lock in wdstart1() before calling the ata_bio hook; when called
from ata thread context, that can still need to sleep for wdc attachments
in wdcwait()


To generate a diff of this commit:
cvs rdiff -u -r1.459 -r1.460 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-04-04 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sat Apr  4 22:30:03 UTC 2020

Modified Files:
src/sys/dev/ata: ata_recovery.c ata_subr.c

Log Message:
stop xfer timeouts during recovery, all xfers will be requeued anyway

this avoids race with the timeout routine when processing the xfers
for requeueing

should fix PR kern/54790 by Izumi Tsutsui


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ata/ata_recovery.c
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/ata/ata_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-01-18 Thread Simon Burge
Module Name:src
Committed By:   simonb
Date:   Sat Jan 18 11:24:40 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Tidy quirk table and remove outdated quick from the quirk format string.


To generate a diff of this commit:
cvs rdiff -u -r1.456 -r1.457 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-01-14 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Tue Jan 14 21:08:06 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
enable the BAD_NCQ quirk for all 860 EVO drives

XXX work-in-progress, it's not clear whether this is driver or controller
XXX problem


To generate a diff of this commit:
cvs rdiff -u -r1.454 -r1.455 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2020-01-13 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Jan 13 21:20:17 UTC 2020

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
disable NCQ by default for "Samsung SSD 860 EVO 1TB" and
"Samsung SSD 860 EVO 500GB" - these drives have known broken NCQ support
particularly when used with AMD SB710/750 chipsets, problem occur also
under Linux and Windows

https://eu.community.samsung.com/t5/Cameras-IT-Everything-Else/860-EVO-250GB-causing-freezes-on-AMD-system/td-p/575813
https://bugzilla.kernel.org/show_bug.cgi?id=201693

It seems there is no Samsung firmware update to fix this even.

Disable NCQ regardless of the controller, it's likely same problem
exists with other controllers too.

This should fix PR kern/54790 and PR kern/54855


To generate a diff of this commit:
cvs rdiff -u -r1.453 -r1.454 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-04-07 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Sun Apr  7 13:00:00 UTC 2019

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Really implement WDF_DIRTY. patch(1) did something silly here ...


To generate a diff of this commit:
cvs rdiff -u -r1.448 -r1.449 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-04-05 Thread Valeriy E. Ushakov
Module Name:src
Committed By:   uwe
Date:   Sat Apr  6 00:35:26 UTC 2019

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
Make sure the aprint_verbose chain is terminated with a newline.
Check sep instead of printed, b/c the latter is reset several times.


To generate a diff of this commit:
cvs rdiff -u -r1.147 -r1.148 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-04-05 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Fri Apr  5 21:31:44 UTC 2019

Modified Files:
src/sys/dev/ata: atavar.h wd.c

Log Message:
drop AT_RST_NOCMD, it's a cut'n'paste side effect


To generate a diff of this commit:
cvs rdiff -u -r1.102 -r1.103 src/sys/dev/ata/atavar.h
cvs rdiff -u -r1.447 -r1.448 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-04-05 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Fri Apr  5 20:44:09 UTC 2019

Modified Files:
src/sys/dev/ata: atavar.h

Log Message:
unbreak the build, someone forgot to commit more stuff :-)


To generate a diff of this commit:
cvs rdiff -u -r1.101 -r1.102 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-04-05 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Fri Apr  5 18:23:45 UTC 2019

Modified Files:
src/sys/dev/ata: wd.c wdvar.h

Log Message:
Implement a DIRTY flag (copied from sd(4)) so avoid flushing the cache if
there has been no write. This avoids a (long) timeout on the flush cache
command triggered by atactl sleep, when the device is open only by the atactl
command itself.
If a drive has no partition open and goes to sleep, the WDF_LOADED
flag is clear, and the next open will issue  wd_get_params() command.
But to wake up the drive a reset is required, and wd_get_params() doens't
issue a reset on timeout, so there's no way to wake up the disk.
Add a retry after reset to wd_get_params().

Tested by Hauke Fath; fixes PR kern/49457


To generate a diff of this commit:
cvs rdiff -u -r1.446 -r1.447 src/sys/dev/ata/wd.c
cvs rdiff -u -r1.48 -r1.49 src/sys/dev/ata/wdvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-03-19 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Tue Mar 19 16:56:29 UTC 2019

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
The NCQ support added a private request queue to the wd driver. This
makes the regular buffer queue ineffective, it also allowed to queue
an unlimited number of requests.

Fix this by limiting the number of requests queued to the driver to
the possible number of concurrent NCQ transactions.


To generate a diff of this commit:
cvs rdiff -u -r1.445 -r1.446 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-03-18 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Tue Mar 19 06:51:05 UTC 2019

Modified Files:
src/sys/dev/ata: wd.c wdvar.h

Log Message:
Set disk model name as disk type. The information can be queried through
drvctl(4).


To generate a diff of this commit:
cvs rdiff -u -r1.444 -r1.445 src/sys/dev/ata/wd.c
cvs rdiff -u -r1.47 -r1.48 src/sys/dev/ata/wdvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2019-03-18 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Tue Mar 19 06:47:12 UTC 2019

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Move standby on detach after wedges deletion in case wedges trigger
I/O on the parent disk. Add debug messages.


To generate a diff of this commit:
cvs rdiff -u -r1.443 -r1.444 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-12-11 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Tue Dec 11 23:06:30 UTC 2018

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
in atabus_detach(), shutdown the channel thread only after all the
children successfully detach; this is especially important for
atapibus, which needs the thread to execute commands

fixes hang on poweroff with root on ATAPI cd(4), reported by Christoph Badura


To generate a diff of this commit:
cvs rdiff -u -r1.146 -r1.147 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-11-07 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Nov  7 17:05:54 UTC 2018

Modified Files:
src/sys/dev/ata: ata_subr.c

Log Message:
don't touch the queue structure in ata_queue_active() if atabus is already
detached from the channel

fixes panic on null pointer derefence during shutdown reported privately
by Launey Thomas


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/ata/ata_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-24 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Oct 24 20:25:52 UTC 2018

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
ata_kill_active() needs to drop channel drop before calling kill_xfer() hook,
otherwise code tries to lock against itself when deactivating the xfer


To generate a diff of this commit:
cvs rdiff -u -r1.144 -r1.145 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-24 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Oct 24 20:03:07 UTC 2018

Removed Files:
src/sys/dev/ata: TODO.ncq

Log Message:
remove TODO.ncq; the FIS note was added to atastart(), and the note
about dump to unopened wd(4) device was attached to PR kern/16789, and
nothing else remains


To generate a diff of this commit:
cvs rdiff -u -r1.12 -r0 src/sys/dev/ata/TODO.ncq

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-24 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Oct 24 20:01:13 UTC 2018

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
add further note about FIS-based switching to atastart()


To generate a diff of this commit:
cvs rdiff -u -r1.143 -r1.144 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-24 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Oct 24 19:46:44 UTC 2018

Modified Files:
src/sys/dev/ata: TODO.ncq wd.c

Log Message:
move the comment (and expand) about NCQ TRIM to wd_trim()


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/ata/TODO.ncq
cvs rdiff -u -r1.442 -r1.443 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-23 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Oct 24 06:53:26 UTC 2018

Modified Files:
src/sys/dev/ata: files.ata

Log Message:
only include ata_recovery.c with atabus (same as ata.c which provides
ata_thread_run() used here)


To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sys/dev/ata/files.ata

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-23 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Tue Oct 23 22:05:01 UTC 2018

Modified Files:
src/sys/dev/ata: TODO.ncq ld_ataraid.c

Log Message:
add support for DIOCCACHESYNC (!), and DIOCGCACHE; code adapted from ccd(4)

tested with Intel ATA Raid


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/TODO.ncq
cvs rdiff -u -r1.47 -r1.48 src/sys/dev/ata/ld_ataraid.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-22 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Oct 22 21:25:23 UTC 2018

Modified Files:
src/sys/dev/ata: TODO.ncq

Log Message:
remove the note for dump, moral equivalent is done and biodone() most
certainly should not be done


To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/ata/TODO.ncq

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-22 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Oct 22 21:24:18 UTC 2018

Modified Files:
src/sys/dev/ata: TODO.ncq

Log Message:
remove the wd* at umass? entry (comment moved to umass_isdata.c and manpage)

remove MSI for ahcisata(4), siisata(4) - these were done


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/ata/TODO.ncq

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-22 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Oct 22 19:38:06 UTC 2018

Modified Files:
src/sys/dev/ata: ata_raid.c ata_raid_adaptec.c ata_raid_intel.c
ata_raid_jmicron.c ata_raid_nvidia.c ata_raid_promise.c
ata_raid_via.c

Log Message:
convert from malloc(9) to kmem(9)


To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sys/dev/ata/ata_raid.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/ata/ata_raid_adaptec.c
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/ata/ata_raid_intel.c \
src/sys/dev/ata/ata_raid_via.c
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/ata/ata_raid_jmicron.c
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/ata/ata_raid_nvidia.c
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/ata/ata_raid_promise.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-10-22 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Oct 22 19:36:28 UTC 2018

Modified Files:
src/sys/dev/ata: ld_ataraid.c

Log Message:
no need for  here


To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47 src/sys/dev/ata/ld_ataraid.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-08-31 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Fri Aug 31 18:44:04 UTC 2018

Modified Files:
src/sys/dev/ata: TODO.ncq

Log Message:
one less


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/ata/TODO.ncq

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-08-10 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Fri Aug 10 22:43:22 UTC 2018

Modified Files:
src/sys/dev/ata: ata_subr.c atavar.h wd.c

Log Message:
fix race in wd_lastclose() on systems with two ide disks on same
channel, which happened when one disk had pending I/O while the other
disk executed the final disk flush - need to restart bufq processing
once xfer is freed in this case

it could happen e.g. on boot when system executes fsck on different
partitions on the two drives in parallell and hence open and closes
the disk devices repeatedly

add KASSERT() for empty bufq on wd_lastclose(), and fix similar issue
also on suspend/standby path

this was introduced by the NCQ merge and not dksubr - before the merge
each drive had their own xfer, so they could not block each other

fixes PR kern/52783 by Onno van der Linden; many thanks for extensive
help with tracking this down


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ata/ata_subr.c
cvs rdiff -u -r1.98 -r1.99 src/sys/dev/ata/atavar.h
cvs rdiff -u -r1.440 -r1.441 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-08-06 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Aug  6 20:07:05 UTC 2018

Modified Files:
src/sys/dev/ata: ata_subr.c atavar.h wd.c

Log Message:
add wddebug() which dumps some status for attached disks; indended for
debugging of PR kern/52783


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/ata/ata_subr.c
cvs rdiff -u -r1.97 -r1.98 src/sys/dev/ata/atavar.h
cvs rdiff -u -r1.439 -r1.440 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-07-29 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sun Jul 29 14:11:30 UTC 2018

Modified Files:
src/sys/dev/ata: satapmp_subr.c satapmpvar.h

Log Message:
mark satapmp_rescan() static, it's not to be used outside satapmp_subr.c


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/ata/satapmp_subr.c
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/ata/satapmpvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-06-22 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Fri Jun 22 09:06:04 UTC 2018

Modified Files:
src/sys/dev/ata: ata_raid.c

Log Message:
Call config_cfattach_attach() regardless of whether the module is
being built as part of a kernel or as a external module.

Addresses kern/53389 - thanks for the report!

XXX pullup-8


To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 src/sys/dev/ata/ata_raid.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-06-21 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Thu Jun 21 21:52:15 UTC 2018

Modified Files:
src/sys/dev/ata: sata_subr.c satavar.h

Log Message:
split the port status reporting to new function sata_interpret_det()
so it can be called separately from sata_reset_interface()

do not treat PHY offline as an error, it's pretty normal when there
is no device actually connected

debugging aid for PR kern/52372


To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ata/sata_subr.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/satavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-06-03 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sun Jun  3 18:38:36 UTC 2018

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
take mutex around check for pending flush, as the code before dksubr
conversion had, to avoid possible race

on my system doesn't really change behaviour, besides the test runs
being slightly faster (3x parallell pkgsrc archive extraction, up
to 5% difference), thought that can just be noise

done as part of investigation for PR kern/53183 by Sevan Janiyan


To generate a diff of this commit:
cvs rdiff -u -r1.438 -r1.439 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-06-03 Thread Martin Husemann
Module Name:src
Committed By:   martin
Date:   Sun Jun  3 10:20:55 UTC 2018

Modified Files:
src/sys/dev/ata: ld_ataraid.c

Log Message:
Whitespace


To generate a diff of this commit:
cvs rdiff -u -r1.44 -r1.45 src/sys/dev/ata/ld_ataraid.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-06-01 Thread Michael Lorenz
Module Name:src
Committed By:   macallan
Date:   Fri Jun  1 18:13:30 UTC 2018

Modified Files:
src/sys/dev/ata: ata_wdc.c atavar.h

Log Message:
add a flag to start DMA before issuing commands - needed to work around a bug
in some SATA chips which get confused if the disk responds too fast
Mostly for K2 SATA / svwsata found in G5 Macs
adapted from OpenBSD


To generate a diff of this commit:
cvs rdiff -u -r1.109 -r1.110 src/sys/dev/ata/ata_wdc.c
cvs rdiff -u -r1.96 -r1.97 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-04-16 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Apr 16 22:33:28 UTC 2018

Modified Files:
src/sys/dev/ata: atavar.h

Log Message:
remove superfluous semicolon


To generate a diff of this commit:
cvs rdiff -u -r1.95 -r1.96 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2018-01-07 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jan  7 11:37:30 UTC 2018

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Fix block address calculation for bad sectors.


To generate a diff of this commit:
cvs rdiff -u -r1.437 -r1.438 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-12-13 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Wed Dec 13 10:24:31 UTC 2017

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Fix build for WD_SOFTBADSECT option.  PR kern/52814

XXX No clue if this option actually works.  This fix just makes it
XXX compile without error.


To generate a diff of this commit:
cvs rdiff -u -r1.436 -r1.437 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-11-06 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Tue Nov  7 04:09:08 UTC 2017

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Make wddone poll all drives of a channel again.


To generate a diff of this commit:
cvs rdiff -u -r1.435 -r1.436 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-11-03 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Fri Nov  3 13:01:26 UTC 2017

Modified Files:
src/sys/dev/ata: wd.c wdvar.h

Log Message:
Add WDF_OPEN flag to really disallow opening of a disk that has been 
invalidated.

Restore wdbiorestart function to actually retry the failed I/O request instead
of just restarting the queue.

Fix compilation without ATADEBUG.


To generate a diff of this commit:
cvs rdiff -u -r1.434 -r1.435 src/sys/dev/ata/wd.c
cvs rdiff -u -r1.45 -r1.46 src/sys/dev/ata/wdvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-11-01 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Nov  1 21:27:22 UTC 2017

Modified Files:
src/sys/dev/ata: TODO.ncq

Log Message:
one down - mlelstv converted wd(4) to dksubr


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ata/TODO.ncq

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-19 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Thu Oct 19 20:45:07 UTC 2017

Modified Files:
src/sys/dev/ata: ata.c ata_subr.c wd.c

Log Message:
more detailed debug info; also sync DEBUG_* values in wd.c with ata.c


To generate a diff of this commit:
cvs rdiff -u -r1.138 -r1.139 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ata/ata_subr.c
cvs rdiff -u -r1.432 -r1.433 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-18 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed Oct 18 08:38:35 UTC 2017

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
add newlines to the debug messages


To generate a diff of this commit:
cvs rdiff -u -r1.137 -r1.138 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-15 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sun Oct 15 14:41:07 UTC 2017

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
move the extra thaw for scheduled ata_reset_channel() to the function itself,
so it's done regardless if the actual reset is run from thread context
or e.g. call with AT_POLL; fixes a hang after xfer failure and dma downgrade

add some debugging printfs, so freeze/thaw issues are easier to track


To generate a diff of this commit:
cvs rdiff -u -r1.136 -r1.137 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-15 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sun Oct 15 11:27:14 UTC 2017

Modified Files:
src/sys/dev/ata: ata_wdc.c

Log Message:
revert the logic for wdc_wait_for_unbusy() in wdc_ata_bio_intr() to pre-NCQ,
wdcintr() and wdctimeout() need that; follows same change
in atapi_wdc.c rev. 1.128


To generate a diff of this commit:
cvs rdiff -u -r1.107 -r1.108 src/sys/dev/ata/ata_wdc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-14 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sat Oct 14 13:20:32 UTC 2017

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
do not use the NCQ priority by default; seems it negatively affects
performance at least with some drives, so this needs better understood first


To generate a diff of this commit:
cvs rdiff -u -r1.431 -r1.432 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-14 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sat Oct 14 13:15:14 UTC 2017

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
only call drive reset with AT_POLL when the command itself was
polled, so that the logic for AT_POLL matches how e.g. ata_dmaerr() is
called; this was the original intent of the change in 1.428.2.25,
to make the error handling safe wrt. polled xfers

this is stopgap fix for ATA channel wedge after DMA error, as reported
by Martin Husemann in PR kern/52606, and PR kern/52605

problem happened due to ata_reset_channel() being called once in ata_dmaerr()
with flags == 0, which freezed channel and set flag to reset via thread,
then ata_reset_channel() was called via wdc_drive_reset() with AT_POLL, which
just executed the reset and cleared the flag, without clearing the extra
freeze; that logic will be refactored in separate commit


To generate a diff of this commit:
cvs rdiff -u -r1.430 -r1.431 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-10 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Tue Oct 10 17:19:39 UTC 2017

Modified Files:
src/sys/dev/ata: ata.c ataconf.h atavar.h files.ata
Added Files:
src/sys/dev/ata: ata_subr.c

Log Message:
split off functions used by 'wd* at umass?' into separate file, unfortunately
the previous approach with NATABUS doesn't work for kernels which include
MODULAR, but not atabus - such as macppc and evbarm


To generate a diff of this commit:
cvs rdiff -u -r1.135 -r1.136 src/sys/dev/ata/ata.c
cvs rdiff -u -r0 -r1.1 src/sys/dev/ata/ata_subr.c
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/ata/ataconf.h
cvs rdiff -u -r1.93 -r1.94 src/sys/dev/ata/atavar.h
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/ata/files.ata

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-08 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Sun Oct  8 19:00:29 UTC 2017

Modified Files:
src/sys/dev/ata: ata.c ataconf.h files.ata

Log Message:
as a stopgap measure, include necessary parts of dev/ata/ata.c even
if no atabus is configured, so that kernels with just 'wd* at umass?'
and no atabus compile; fixes kernel builds for vax, pmax and evbmips
after NCQ branch merge

XXX wd* at umass? still actually untested after the merge, need to discuss
XXX what to do with it


To generate a diff of this commit:
cvs rdiff -u -r1.134 -r1.135 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/ata/ataconf.h
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/ata/files.ata

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-08 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Oct  8 13:35:04 UTC 2017

Modified Files:
src/sys/dev/ata: ata_wdc.c

Log Message:
Re-use the err label more so it is not unused for drivers that don't support
dma.


To generate a diff of this commit:
cvs rdiff -u -r1.106 -r1.107 src/sys/dev/ata/ata_wdc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-10-07 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Oct  8 04:52:33 UTC 2017

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
Don't assert channel lock in polled mode.

ahcisata (and maybe others) use ata_delay during initialization where
lock isn't taken.


To generate a diff of this commit:
cvs rdiff -u -r1.133 -r1.134 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-06-25 Thread Maxime Villard
Module Name:src
Committed By:   maxv
Date:   Sun Jun 25 12:29:32 UTC 2017

Modified Files:
src/sys/dev/ata: ata_raid_subr.c

Log Message:
dumb instruction


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ata/ata_raid_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-05-10 Thread SAITOH Masanobu
Module Name:src
Committed By:   msaitoh
Date:   Wed May 10 08:46:39 UTC 2017

Modified Files:
src/sys/dev/ata: sata_subr.c

Log Message:
 KNF. No functional change.


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/ata/sata_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2017-04-24 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Mon Apr 24 09:42:52 UTC 2017

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
remove the workaround for Seagate 'mod15write' bug, now driver only prints
error on boog; unfortunately the code actually doesn't work, and there is
little point trying to fix


To generate a diff of this commit:
cvs rdiff -u -r1.428 -r1.429 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2016-09-27 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Tue Sep 27 08:05:34 UTC 2016

Modified Files:
src/sys/dev/ata: ata_raid.c ld_ataraid.c

Log Message:
Remove some debug printf's that slipped through.  Thanks, wiz!


To generate a diff of this commit:
cvs rdiff -u -r1.38 -r1.39 src/sys/dev/ata/ata_raid.c
cvs rdiff -u -r1.43 -r1.44 src/sys/dev/ata/ld_ataraid.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2016-08-04 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Fri Aug  5 06:54:22 UTC 2016

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
CID 1364758:  Integer handling issues, avoid sign extension to 64 bits.


To generate a diff of this commit:
cvs rdiff -u -r1.425 -r1.426 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2016-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Fri Jul 22 12:55:34 UTC 2016

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Space before tab and trailing whitespace fixes.


To generate a diff of this commit:
cvs rdiff -u -r1.424 -r1.425 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2016-07-21 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Fri Jul 22 04:08:10 UTC 2016

Modified Files:
src/sys/dev/ata: wd.c wdvar.h

Log Message:
Add ATA8-ACS Long Logical Sector Feature Set support to wd(4).


To generate a diff of this commit:
cvs rdiff -u -r1.423 -r1.424 src/sys/dev/ata/wd.c
cvs rdiff -u -r1.42 -r1.43 src/sys/dev/ata/wdvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2016-07-21 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Thu Jul 21 19:05:03 UTC 2016

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Call wd_params_to_properties() after softc is sufficently
initialized.


To generate a diff of this commit:
cvs rdiff -u -r1.422 -r1.423 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2016-07-21 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Thu Jul 21 18:54:13 UTC 2016

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Remove unused 'params' argument of local function wd_params_to_properties()


To generate a diff of this commit:
cvs rdiff -u -r1.421 -r1.422 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2014-10-11 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sat Oct 11 14:05:12 UTC 2014

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
The partition size is always computed in native blocks. The code also assumes
that native blocks are always DEVB_SIZE (a few lines earlier) which makes
the current calculation a no-op.


To generate a diff of this commit:
cvs rdiff -u -r1.413 -r1.414 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2014-09-10 Thread Matt Thomas
Module Name:src
Committed By:   matt
Date:   Wed Sep 10 07:04:48 UTC 2014

Modified Files:
src/sys/dev/ata: ata.c ata_raidreg.h ata_wdc.c atavar.h wd.c wdvar.h

Log Message:
g/u_int[0-9]*_t/ s/u_int/uint/g


To generate a diff of this commit:
cvs rdiff -u -r1.131 -r1.132 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/ata/ata_raidreg.h
cvs rdiff -u -r1.103 -r1.104 src/sys/dev/ata/ata_wdc.c
cvs rdiff -u -r1.91 -r1.92 src/sys/dev/ata/atavar.h
cvs rdiff -u -r1.412 -r1.413 src/sys/dev/ata/wd.c
cvs rdiff -u -r1.40 -r1.41 src/sys/dev/ata/wdvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2014-07-25 Thread David A. Holland
Module Name:src
Committed By:   dholland
Date:   Fri Jul 25 08:34:27 UTC 2014

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Drop the old discard/trim ioctls from wd.c.


To generate a diff of this commit:
cvs rdiff -u -r1.410 -r1.411 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2014-07-25 Thread David A. Holland
Module Name:src
Committed By:   dholland
Date:   Fri Jul 25 08:22:08 UTC 2014

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Implement d_discard for wd.


To generate a diff of this commit:
cvs rdiff -u -r1.409 -r1.410 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-10-30 Thread Matthias Drochner
Module Name:src
Committed By:   drochner
Date:   Wed Oct 30 15:41:14 UTC 2013

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
play the addref/delref game on suspend, prevents crash if the disk/CF Card
is eg. in a PCMCIA adapter and not mounted


To generate a diff of this commit:
cvs rdiff -u -r1.405 -r1.406 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-08-19 Thread Nick Hudson
Module Name:src
Committed By:   skrll
Date:   Mon Aug 19 14:58:57 UTC 2013

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Don't return EPASSTHROUGH when succeeding in ODIOCGDINFO or ODIOCGDEFLABEL


To generate a diff of this commit:
cvs rdiff -u -r1.404 -r1.405 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-08-07 Thread Brett Lymn
Module Name:src
Committed By:   blymn
Date:   Wed Aug  7 12:50:17 UTC 2013

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
Make sure a channel has drives attached before resetting it otherwise
wdc_reset will panic the kernel due to a null derefrence of ch_drives.


To generate a diff of this commit:
cvs rdiff -u -r1.127 -r1.128 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-05-03 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Fri May  3 20:02:09 UTC 2013

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
Wait for DRDY after the PMP commands and don't wait before.
Should fix the worst part of PR kern/47793.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-04-17 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Wed Apr 17 12:22:44 UTC 2013

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
Also print port multiplier port number when register accesses fail.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-01-09 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Wed Jan  9 22:03:49 UTC 2013

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Initialize b_resid before biodone in wdioctlstrategy error branch.

Otherwise we may panic when physio's biodone callback kasserts
something about b_resid, since nothing will have initialized it.


To generate a diff of this commit:
cvs rdiff -u -r1.401 -r1.402 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2013-01-09 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Wed Jan  9 17:55:04 UTC 2013

Modified Files:
src/sys/dev/ata: atareg.h

Log Message:
Name the ATA SECURITY commands.


To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42 src/sys/dev/ata/atareg.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-11-01 Thread David Brownlee
Module Name:src
Committed By:   abs
Date:   Thu Nov  1 13:46:52 UTC 2012

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
Allow setting ATADEBUG_MASK to default value of atadebug_mask


To generate a diff of this commit:
cvs rdiff -u -r1.125 -r1.126 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-08-04 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Sat Aug  4 21:21:10 UTC 2012

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
If ch_ndrives is > 0, then ch_drive is not supposed to be NULL.


To generate a diff of this commit:
cvs rdiff -u -r1.124 -r1.125 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-08-01 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Wed Aug  1 09:38:55 UTC 2012

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
Make this compile again after DRIVET rename


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-08-01 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Wed Aug  1 09:02:04 UTC 2012

Added Files:
src/sys/dev/ata: satapmp_subr.c satapmpvar.h

Log Message:
Apply back changes that were reverted on Jul 24 and Jul 26 (general ata/wdc
cleanup and SATA PMP support), now that I'm back to fix the fallouts.


To generate a diff of this commit:
cvs rdiff -u -r0 -r1.9 src/sys/dev/ata/satapmp_subr.c
cvs rdiff -u -r0 -r1.3 src/sys/dev/ata/satapmpvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-29 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 29 21:10:50 UTC 2012

Modified Files:
src/sys/dev/ata: ata.c atavar.h

Log Message:
Remove ata_channel->ata_drives, it's redundant with the pointer in
ata_drive_datas.  Originally part of a commit by bouyer@.


To generate a diff of this commit:
cvs rdiff -u -r1.122 -r1.123 src/sys/dev/ata/ata.c
cvs rdiff -u -r1.88 -r1.89 src/sys/dev/ata/atavar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 19:07:34 UTC 2012

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
It turns out my previous commit here was off by one.


To generate a diff of this commit:
cvs rdiff -u -r1.119 -r1.120 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 18:42:11 UTC 2012

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
FLUSH CACHE EXT is a 48-bit command, issue as such.  Both FLUSH CACHE commands
will return the LBA of first failure in the return task file, specifiy that we
want it read, even if we don't look at the value.


To generate a diff of this commit:
cvs rdiff -u -r1.396 -r1.397 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 18:37:31 UTC 2012

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
ATA-6 and ACS-2 drafts both say the flush cache commands may take longer than
30 seconds to complete.  For now assume 5 minutes will always be enough.


To generate a diff of this commit:
cvs rdiff -u -r1.395 -r1.396 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 18:21:17 UTC 2012

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
Port multiplier registers are 64-bits wide (although the ones we need only
implement 32-bits).  Implement the access routines using 64-bit values and add
32-bit wrappers thereto.


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 18:17:30 UTC 2012

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
The vendor and product IDs are 16-bit, print out as such.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 18:12:01 UTC 2012

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
Correctly issue port multiplier register access commands as LBA48 now that the
FIS code doesn't get in the way of doing that.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 18:03:34 UTC 2012

Modified Files:
src/sys/dev/ata: satapmp_subr.c

Log Message:
KASSERT if we attempt to access an invalid port.
Also, small whitespace change for internal consistency.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ata/satapmp_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-22 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 22 17:57:58 UTC 2012

Modified Files:
src/sys/dev/ata: satafis_subr.c

Log Message:
SATA uses the head portion of the device register in the command protocol for
port multiplier register access.  Thus, in the LBA48 case, pass the complete
r(hd|dh)_dh byte back and forth to the upper layers.  (This is irrelevant in
the LBA28/CHS code path for what should be obvious reasons.)


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/ata/satafis_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-07-15 Thread Jonathan A. Kollasch
Module Name:src
Committed By:   jakllsch
Date:   Sun Jul 15 15:49:46 UTC 2012

Modified Files:
src/sys/dev/ata: ata.c

Log Message:
Stopgap crash prevention when atadebug_mask includes DEBUG_PROBE bit.


To generate a diff of this commit:
cvs rdiff -u -r1.118 -r1.119 src/sys/dev/ata/ata.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-06-26 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Tue Jun 26 09:49:25 UTC 2012

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
In some case, when an error is reported by the disk, the ahci controller
still reports a number of bytes transfered equal to bcount.
This then triggers a KASSERT in physio_biodone:
if (done == todo)
KASSERT(bp->b_error == 0);
Detect this case in wd(4) (so that the workaround works for other controllers
too if they have the same issue, or if the issue is with the drive)
and claim we didn't read/write anything.


To generate a diff of this commit:
cvs rdiff -u -r1.392 -r1.393 src/sys/dev/ata/wd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/ata

2012-05-15 Thread Manuel Bouyer
Module Name:src
Committed By:   bouyer
Date:   Tue May 15 19:01:10 UTC 2012

Modified Files:
src/sys/dev/ata: sata_subr.c

Log Message:
If the PHY reports link up but no communication, wait 5 more
seconds for communications to be established. This seems to be needed for
some configurations.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/ata/sata_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



  1   2   >