CVS commit: src/sys/dev/iscsi

2015-09-19 Thread David A. Holland
Module Name:src
Committed By:   dholland
Date:   Sat Sep 19 18:32:42 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
Use value *before* freeing it. Found by brainy, reported by maxv.


To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-12-23 Thread Kengo NAKAHARA
Module Name:src
Committed By:   knakahara
Date:   Thu Dec 24 03:41:04 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
fix amd64/conf/ALL build failure


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-05-29 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun May 29 13:51:16 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_rcv.c iscsi_send.c iscsi_text.c iscsi_utils.c

Log Message:
Several improvements to the ISCSI driver.

- Enable debug messages but set log level to be quiet. Provide a
  system (hw.iscsi.debug) to set the log level at run time.
- Replace old tsleep/wakeup synchronization with mutexes and condvars.
- Defer actions from callouts (basically timeouts) to the cleanup thread.
- Protect lists and unique ids with mutexes. protect connection usecount
  by using atomic operations.
- Assert kernel lock when calling into scsipi and network code.
- Use this to make send/receive/cleanup threads MPSAFE.

- Fix handling of out-of-CCB/out-of-PDU conditions against the scsipi layer.
- Bump number of PDUs to 128 to avoid virtually all out-of-PDU conditions

- Make use of softc structure for attach/detach operations.
- Track open file handles to prevent detach when busy.

- Move some global variables to make them static.

- Fix 'Overlapping Commands Attempted' error by marking commands as
  simply ordered (ATTR_SIMPLE) like FreeBSD.


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/iscsi/iscsi_text.c
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-05-31 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun  1 04:07:03 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
close session when last connection is removed.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-05-31 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun  1 04:19:08 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_send.c iscsi_utils.c

Log Message:
factor out sernum handling.
make incrementing sernum atomic.
declare variables for atomic operations as volatile.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.16 -r1.17 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-05-31 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun  1 05:13:07 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_rcv.c
iscsi_send.c iscsi_utils.c

Log Message:
refactor callouts
remove timed out ccbs and connections from cleanup queue when stopping timeout.


To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-05-31 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun  1 05:31:59 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
don't sleep in run_xfer path.


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-02 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Fri Jun  3 06:53:40 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
fix debug message


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-02 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Fri Jun  3 06:55:16 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
use sernum handling function


To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 04:36:05 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_main.c iscsi_rcv.c iscsi_send.c iscsi_utils.c

Log Message:
More debugging output, changed debug levels for some.


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.20 -r1.21 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 04:48:18 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_utils.c

Log Message:
When stopping a callout, wait until the cleanup thread has processed them.


To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 04:50:23 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Whitespace


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 04:51:57 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
ignore invalid ITT


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 04:53:23 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Tear down sysctls only after detaching children. This lets you enable
debugging while detaching hangs.


To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:07:23 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_rcv.c

Log Message:
Fix serial number check and account for commands in flight to avoid
unnecessary recovery actions.


To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:11:57 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
Handle ExpCmdSN and MaxCmdSN updates as specified. Don't compare
serial numbers as integers.


To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:18:59 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c iscsi_utils.c

Log Message:
Fix locking for pdu flags here, in particular PDUF_INQUEUE.


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:25:59 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
Make PDU init routines record serial number in CCB too.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:29:01 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Keep 1 CCB free for private use. This avoids frequent recovery in scsipi when
resources appear to be exhausted.


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:31:43 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c iscsi_send.c

Log Message:
No need to acquire KERNEL_LOCK when entering network code.
Also use the socket callbacks.


To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:36:57 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_send.c iscsi_utils.c

Log Message:
Replace the simple tag counter with the command tag coming down from scsipi.
Also set attributes according to tag types.


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:40:29 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c iscsi_send.c

Log Message:
Whitespace, braces.


To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 05:41:53 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_utils.c

Log Message:
ensure that timeout counter is cleared when ccb is (re-)used.


To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-04 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 06:19:59 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
Add missing mutex_exit().


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 08:30:13 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
appease compiler


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 09:03:10 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_utils.c

Log Message:
initialize before check.


To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 09:09:57 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
Need session mutex to read serial number.


To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 09:12:49 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
wrong assertion.


To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 09:21:14 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_utils.c

Log Message:
acquire session lock when changing throttling queue


To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 11:01:39 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
more debug output


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 13:45:56 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
More debug output. Dump pending CCBs when cleaning up.


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 13:54:28 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_send.c iscsi_utils.c

Log Message:
Handle freeing of PDU when referencing CCB is freed.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 14:00:13 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
Don't resume throttled CCBs when connection is terminating, except for
those being actively waited for. Stop unthrottling when reaching MaxCmdSN
again.


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  5 15:04:31 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
use correct comparison of serial numbers


To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-14 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun 15 03:41:00 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_pdu.h

Log Message:
Fix field name in response pdu.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_pdu.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-14 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun 15 03:51:55 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_utils.c

Log Message:
drop unused debug helper routine


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-14 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun 15 04:30:30 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi.h iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_rcv.c iscsi_send.c iscsi_utils.c

Log Message:
Remove throttling code, instead signal scsipi layer to reduce the openings
and retry the command. Start with a small openings number and let scsipi
request to grow it up to the current send window.

Adjust ccb and pdu counts to avoid ressource shortages. These are still
very ad-hoc numbers, but seem to be sufficient for a Gigabit link.

Use separate condvar for PDU pool and add counter to help debugging.

Revert setting PDU disposition to UNUSED before freeing. free_pdu
uses this as a flag to detect already returned PDUs.

Add reference counter for open commands to defer unmapping a session
that would lead to crashes in scsipi.

Move session cleanup to cleanup thread.

Use get_sernum to retrieve current serial number where possible and
make it check for immediate commands itself.

Adjust debug output.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi.h
cvs rdiff -u -r1.20 -r1.21 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_rcv.c src/sys/dev/iscsi/iscsi_utils.c
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.30 -r1.31 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-06-14 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Wed Jun 15 04:33:52 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
Work around an issue with MSG_WAITALL that would block for too long by
replacing it with a receive loop.


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2011-10-23 Thread Alistair G. Crooks
Module Name:src
Committed By:   agc
Date:   Sun Oct 23 21:15:02 UTC 2011

Added Files:
src/sys/dev/iscsi: Makefile base64.c base64.h files.iscsi iscsi.h
iscsi_globals.h iscsi_ioctl.c iscsi_ioctl.h iscsi_main.c
iscsi_pdu.h iscsi_perf.h iscsi_profile.c iscsi_profile.h
iscsi_rcv.c iscsi_send.c iscsi_test.c iscsi_test.h
iscsi_testlocal.h iscsi_text.c iscsi_utils.c

Log Message:
Start to move the in-kernel iSCSI initiator, kindly contributed to the
NetBSD Foundation by Wasabi Systems, from

othersrc/external/bsd/iscsi/sys/dev/iscsi

to

src/sys/dev/iscsi


To generate a diff of this commit:
cvs rdiff -u -r0 -r1.1 src/sys/dev/iscsi/Makefile src/sys/dev/iscsi/base64.c \
src/sys/dev/iscsi/base64.h src/sys/dev/iscsi/files.iscsi \
src/sys/dev/iscsi/iscsi.h src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c src/sys/dev/iscsi/iscsi_ioctl.h \
src/sys/dev/iscsi/iscsi_main.c src/sys/dev/iscsi/iscsi_pdu.h \
src/sys/dev/iscsi/iscsi_perf.h src/sys/dev/iscsi/iscsi_profile.c \
src/sys/dev/iscsi/iscsi_profile.h src/sys/dev/iscsi/iscsi_rcv.c \
src/sys/dev/iscsi/iscsi_send.c src/sys/dev/iscsi/iscsi_test.c \
src/sys/dev/iscsi/iscsi_test.h src/sys/dev/iscsi/iscsi_testlocal.h \
src/sys/dev/iscsi/iscsi_text.c src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2011-10-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Oct 29 16:04:39 UTC 2011

Modified Files:
src/sys/dev/iscsi: iscsi.h iscsi_ioctl.h

Log Message:
make all bitfields unsigned int


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/iscsi.h \
src/sys/dev/iscsi/iscsi_ioctl.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2011-11-08 Thread Jeff Rizzo
Module Name:src
Committed By:   riz
Date:   Wed Nov  9 00:51:01 UTC 2011

Modified Files:
src/sys/dev/iscsi: files.iscsi

Log Message:
Don't add iscsi_utils.c without 'iscsi' condition.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/files.iscsi

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-05-27 Thread Jeff Rizzo
Module Name:src
Committed By:   riz
Date:   Mon May 28 03:43:18 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Don't allow iscsi to autounload.  The default unload timeout is short,
and too much state is lost.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-05-27 Thread Jeff Rizzo
Module Name:src
Committed By:   riz
Date:   Mon May 28 04:18:12 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Expose some of the module framework when _MODULE is not defined, so
iscsi becomes a "built in" module in that case.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-06-02 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sat Jun  2 16:52:11 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_main.c

Log Message:
avoid namespace pollution when debugging
don't panic when printing data for a dead (NULL) connection


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-06-05 Thread Michael L. Hitch
Module Name:src
Committed By:   mhitch
Date:   Tue Jun  5 16:36:07 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c iscsi_send.c

Log Message:
Fix system freeze when trying to write to a raw iSCSI device with MAXPHYS
bytes.  Newfs does large writes when initializing the filesystem.
First, don't copy the head of a TAILQ to make a copy - the first entry will
still point back to the original head.  This caused the ccb list to link to
itself, resulting in a continous loop processing the same ccb and blocked
interrupts.  Use TAILQ_CONCAT() to copy the list.
Next, the ccb disposition was not set in the ccb when the ccb was throttled,
losing the CCBDISP_SCSIPI, so when a throttled ccb was resent, it failed to
call scscipi_done(), and left that I/O hanging.
I am now able to newfs an iSCSI device, was well as issued large writes
using dd.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/iscsi_rcv.c \
src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-06-08 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sat Jun  9 06:19:58 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_send.c iscsi_text.c iscsi_utils.c

Log Message:
Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_text.c
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_ioctl.c \
src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-06-19 Thread Martin Husemann
Module Name:src
Committed By:   martin
Date:   Tue Jun 19 14:19:46 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-06-24 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun 24 17:01:35 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c iscsi_rcv.c iscsi_send.c iscsi_text.c
iscsi_utils.c

Log Message:
Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_rcv.c \
src/sys/dev/iscsi/iscsi_utils.c
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/iscsi/iscsi_send.c \
src/sys/dev/iscsi/iscsi_text.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-06-25 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Mon Jun 25 20:34:26 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_utils.c

Log Message:
Make digests work also on big endian machines.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-08-12 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Aug 12 13:26:18 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_send.c iscsi_text.c

Log Message:
Don't use common variables, also prefix global variables to avoid
namespace pollution.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/iscsi/iscsi_main.c \
src/sys/dev/iscsi/iscsi_send.c src/sys/dev/iscsi/iscsi_text.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-09-08 Thread Michael L. Hitch
Module Name:src
Committed By:   mhitch
Date:   Sun Sep  9 06:06:30 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
Remove an erroneous change that crept in.  It was part of an earlier,
incorrect fix I had done for writing > 64K bytes.  It was still in the
set of changes mlelstv had committed.  I noticed it at the time, but did
not think it was problematic - until now.  This fixes the ccb corruption
I was seeing and fixes PR kern/46896.


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2012-12-29 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sat Dec 29 11:05:30 UTC 2012

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_rcv.c iscsi_send.c iscsi_test.c iscsi_utils.c

Log Message:
- defer session cleanup to not force detachments
- use more and explicit locking
- improve connection recovery
- use larger timeouts
- handle ccb buffer underflow correctly
- simplify throttling code

Sessions can now temporarily exist without a valid
connection, you also need to update iscsid(8).


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_test.c
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2013-04-04 Thread David Laight
Module Name:src
Committed By:   dsl
Date:   Thu Apr  4 22:17:13 UTC 2013

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.h

Log Message:
Explicitly #include  so that the build of usr/bin/kdump
doesn't rely on the order it happens to use for the headers.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/iscsi_ioctl.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2014-09-05 Thread Matt Thomas
Module Name:src
Committed By:   matt
Date:   Fri Sep  5 09:27:34 UTC 2014

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c iscsi_send.c

Log Message:
Try not to use f_data, use f_{vnode,socket,pipe,mqueue,kqueue,ksem} to get
a correctly typed pointer.


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2014-09-24 Thread Thor Lancelot Simon
Module Name:src
Committed By:   tls
Date:   Thu Sep 25 00:30:45 UTC 2014

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
The "throttling" code in the in-kernel iSCSI initiator is very questionable;
it sleeps on a ccb that appears highly unlikely to wake up, since it seems
to be waiting to _submit_ that very ccb!  This is doubtless why someone tried
to disable it in the default case via several #defines.

Unfortunately one of those #defines is later tested backwards.  Fix that.
The in-kernel initiator now seems to survive a system build without hanging.


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2014-11-24 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Mon Nov 24 21:49:17 UTC 2014

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
iscsi_attrs is not used when iscsi(4) is compiled into the kernel.


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-02-21 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Sat Feb 21 12:32:23 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Simplify.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-02-21 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Sat Feb 21 17:14:37 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Revert and add comment that this dance is for the sake of builtin module
registration.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-04-12 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Sun Apr 12 14:48:32 UTC 2015

Modified Files:
src/sys/dev/iscsi: files.iscsi

Log Message:
ISCSI_DEBUG needs a value, so make it a param.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/iscsi/files.iscsi

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-05-03 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Sun May  3 15:07:12 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
Make sure callout is halted, not just stopped, before freeing memory.


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-05-15 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Fri May 15 16:24:30 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_rcv.c iscsi_send.c iscsi_utils.c

Log Message:
Remove conditionals for NetBSD before 4.0.


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-05-15 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Fri May 15 16:25:50 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_text.c

Log Message:
Drop conditional support for writing large numbers as hex.


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/iscsi/iscsi_text.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-05-15 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Fri May 15 18:28:36 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Don't pre-compute string sizes in a relatively cold function.


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-05-30 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Sat May 30 18:09:31 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_rcv.c
iscsi_send.c

Log Message:
Inline SET_CCB_TIMEOUT and SET_CONN_TIMEOUT


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/iscsi/iscsi_globals.h \
src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2015-05-30 Thread Joerg Sonnenberger
Module Name:src
Committed By:   joerg
Date:   Sat May 30 18:12:09 UTC 2015

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_utils.c

Log Message:
Save space by making ack flag booleans.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-06-24 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sat Jun 24 11:31:26 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
Fix session cleanup.


To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-12-02 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Dec  3 07:23:12 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
add debug messages


To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-12-02 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Dec  3 07:23:45 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
use same lock for ref/deref.


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-12-02 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Dec  3 07:24:47 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
unreference session only for responses to SCSI commands.


To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-12-03 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Dec  3 19:07:10 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_main.c
iscsi_pdu.h iscsi_rcv.c iscsi_send.c iscsi_text.c iscsi_utils.c

Log Message:
- add a prefix to struct members (but not the ioctl ones because they affect
  the API)
- use consistent variable names.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.27 -r1.28 src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_pdu.h
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/iscsi/iscsi_rcv.c \
src/sys/dev/iscsi/iscsi_utils.c
cvs rdiff -u -r1.35 -r1.36 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.10 -r1.11 src/sys/dev/iscsi/iscsi_text.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-12-05 Thread Ryota Ozaki
Module Name:src
Committed By:   ozaki-r
Date:   Wed Dec  6 04:29:58 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
Fix typo


To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2018-03-03 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Mar  4 07:37:43 UTC 2018

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
Add sanity check.


To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2018-03-03 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Mar  4 07:39:45 UTC 2018

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
Return temporary errors when the session is trying to recover the last
connection. The scsipi layer will retry.


To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.37 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2021-03-07 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Mar  7 12:30:03 UTC 2021

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Stop advertising more openings after limit is reached.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2021-06-06 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  6 10:39:10 UTC 2021

Modified Files:
src/sys/dev/iscsi: iscsi_send.c

Log Message:
Schedule command timeout without connection lock being held to prevent
a deadlock.


To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2021-06-06 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jun  6 10:40:14 UTC 2021

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
Provide missing file ops. Before a simple read() would panic the kernel.
No longer fail close().


To generate a diff of this commit:
cvs rdiff -u -r1.35 -r1.36 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2013-10-20 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Oct 20 21:11:15 UTC 2013

Modified Files:
src/sys/dev/iscsi: iscsi_rcv.c

Log Message:
2 splbios in a row does not make sense. make the second one splx.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/iscsi/iscsi_rcv.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2014-03-27 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Fri Mar 28 02:15:56 UTC 2014

Modified Files:
src/sys/dev/iscsi: iscsi_text.c

Log Message:
avoid buffer overflow


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/iscsi/iscsi_text.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2014-06-20 Thread David A. Holland
Module Name:src
Committed By:   dholland
Date:   Sat Jun 21 03:42:52 UTC 2014

Modified Files:
src/sys/dev/iscsi: iscsi_pdu.h

Log Message:
__attribute__ ((__packed__)) -> __packed


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/iscsi_pdu.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2020-05-13 Thread Jaromir Dolecek
Module Name:src
Committed By:   jdolecek
Date:   Wed May 13 21:59:45 UTC 2020

Modified Files:
src/sys/dev/iscsi: iscsi_main.c

Log Message:
make the iscsi attached message aprint_verbose(), no need to show normally


To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/dev/iscsi/iscsi_main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2020-06-21 Thread Chuck Silvers
Module Name:src
Committed By:   chs
Date:   Sun Jun 21 23:08:16 UTC 2020

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c

Log Message:
avoid the use of UVM internals in the iscsi ioctl code.
copyin/out are fine in this context.


To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.31 -r1.32 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2016-12-24 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Dec 25 06:55:28 UTC 2016

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c iscsi_main.c iscsi_rcv.c iscsi_send.c
iscsi_utils.c

Log Message:
Lock correctly around CV calls.
Fix handling of session termination.
Enable MPSAFE processing for scsipi.


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/iscsi/iscsi_ioctl.c \
src/sys/dev/iscsi/iscsi_rcv.c
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.31 -r1.32 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-02-05 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Feb  5 12:05:46 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_ioctl.c iscsi_send.c
iscsi_utils.c

Log Message:
Destroy callouts when cleaning up.


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.32 -r1.33 src/sys/dev/iscsi/iscsi_send.c
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-02-25 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sat Feb 25 12:03:57 UTC 2017

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c iscsi_send.c

Log Message:
Use correct lock for session wakeup.


To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/iscsi/iscsi_ioctl.c
cvs rdiff -u -r1.33 -r1.34 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2017-04-18 Thread Maya Rashish
Module Name:src
Committed By:   maya
Date:   Tue Apr 18 17:28:18 UTC 2017

Modified Files:
src/sys/dev/iscsi: base64.c

Log Message:
Remove redundant duplicate assignment.

from clang static analyzer


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/dev/iscsi/base64.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2018-12-07 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Fri Dec  7 14:59:19 UTC 2018

Modified Files:
src/sys/dev/iscsi: iscsi_ioctl.c

Log Message:
interlock isn't taken when cleaning up.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/dev/iscsi/iscsi_ioctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2019-02-01 Thread matthew green
Module Name:src
Committed By:   mrg
Date:   Fri Feb  1 08:33:29 UTC 2019

Modified Files:
src/sys/dev/iscsi: iscsi_utils.c

Log Message:
fix FALLTRHOUGH spell-o.


To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/iscsi/iscsi_utils.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/iscsi

2019-04-21 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Apr 21 11:26:46 UTC 2019

Modified Files:
src/sys/dev/iscsi: iscsi_globals.h iscsi_main.c iscsi_text.c

Log Message:
Replace build option to enable hex encoded bignum parameters with a sysctl.


To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/iscsi/iscsi_globals.h
cvs rdiff -u -r1.28 -r1.29 src/sys/dev/iscsi/iscsi_main.c
cvs rdiff -u -r1.11 -r1.12 src/sys/dev/iscsi/iscsi_text.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.