CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 18:44:53 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): Explain what's wrong with using device pointers like this.

...and why the kernel lock is not enough.


To generate a diff of this commit:
cvs rdiff -u -r1.74 -r1.75 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 18:44:45 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
pad(4): Omit unused sc_blksize.


To generate a diff of this commit:
cvs rdiff -u -r1.73 -r1.74 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 18:44:37 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): Refactor for clarity, and fix locking bugs.

- Don't touch sc_buflen outside sc_intr_lock.

- Omit needless broadcast in pad_halt_output -- nothing wakes on the
  new condition (sc_buflen == 0), so this can't make a difference
  except possibly in buggy code.

- Sprinkle KASSERTs.


To generate a diff of this commit:
cvs rdiff -u -r1.72 -r1.73 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 10:21:21 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): Destroy the callout when done.

Should not be possible for it to be pending or firing at this point,
because we have detached the audio(4) child and so it should have
halted output.


To generate a diff of this commit:
cvs rdiff -u -r1.71 -r1.72 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 10:14:58 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): Make this exclusively a cloning device.

padN numbering never corresponded with audioM numbering except by
accident, so the non-cloning device never worked reliably for
scripting.  This simplifies the logic substantially.

While here, fix drvctl detach race.


To generate a diff of this commit:
cvs rdiff -u -r1.70 -r1.71 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 10:14:46 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
pad(4): Sort includes.  Add missing includes to padvar.h.


To generate a diff of this commit:
cvs rdiff -u -r1.69 -r1.70 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-14 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 10:14:01 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
pad(4): Fix some locking.

- No need for sc_cond_lock.
- Issue cv_broadcast under the correct lock.
- Use callout_halt, not haphazard callout_stop.
- IPL_SOFTCLOCK for a mutex taken from a callout.


To generate a diff of this commit:
cvs rdiff -u -r1.68 -r1.69 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-13 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Mon Jun 14 00:21:09 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): Some incomplete tidying.

- Put pseudo-device softc setup/teardown back in pad_attach/detach,
  not in the cdev/fops operations which are about file descriptors.
- Remove unnecessary sc_dying flag.
- Omit needless config_deactivate(sc->sc_audiodev); the only effect
  of this is already done by config_detach anyway, which is done in
  the same context.
- Issue config_detach_children and free softc stuff in the right
  order.
- Omit needless `if (sc == NULL) return ENXIO'.

Survives eight parallel t_mixerctl tests many times over on an
8-thread/4-core machine.

XXX TODO:
- Remove padconfig; it is not appropriate to hold a mutex over
  sleeping allocation or autoconf config_attach operations.  This
  should be done another way.
- Fix agreement of sc_condvar with locks: is it sc_cond_lock or
  sc_intr_lock?  Can't be both; unclear why both exist.
- Determine whether both cdev and fops are really needed -- it is
  confusing to have two types of paths into all this logic, and it
  seems to me only one of them should be necessary.


To generate a diff of this commit:
cvs rdiff -u -r1.67 -r1.68 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-13 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Sun Jun 13 23:09:23 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): Take kernel lock around autoconf stuff.

This is not really enough -- the padconfig locking logic violates
rules about sleeping while holding locks, might be deadlocky, and may
also be racy.  But, it'll serve to make progress.


To generate a diff of this commit:
cvs rdiff -u -r1.66 -r1.67 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2021-06-08 Thread Nia Alarie
Module Name:src
Committed By:   nia
Date:   Tue Jun  8 09:09:29 UTC 2021

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4): run the callout if the buffer is saturated instead of returning

reverts to the same behavior as in -8 and -9. prevents immediate failures
and device timeouts if there's a slight delay in the buffer being
consumed.

this is reproducible with the example in the man page that uses
ffmpeg to record the output of audioplay:

$ ffmpeg -f s16le -ar 44100 -ac 2 -i /dev/pad0 output.wav
$ audioplay -d /dev/audio1 input.wav

if output.wav already exists, ffmpeg will prompt for confirmation
to overwrite as soon as audioplay starts, causing a noticable delay,
followed by a write failure that causes audioplay to immediately
exit.


To generate a diff of this commit:
cvs rdiff -u -r1.65 -r1.66 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-09-24 Thread Takeshi Nakayama
Module Name:src
Committed By:   nakayama
Date:   Tue Sep 25 06:55:23 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4) mixer has only 1 channel, so return EINVAL in the case other than 1.

This fixes the following strange output of mixerctl(1):

outputs.master=255,0
inputs.dac=255,0


To generate a diff of this commit:
cvs rdiff -u -r1.57 -r1.58 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-09-24 Thread Takeshi Nakayama
Module Name:src
Committed By:   nakayama
Date:   Tue Sep 25 06:53:49 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Revert to rev.1.53.
I accidentally committed the netbsd-8 branch file in rev.1.54.


To generate a diff of this commit:
cvs rdiff -u -r1.56 -r1.57 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-09-23 Thread Robert Elz
Module Name:src
Committed By:   kre
Date:   Sun Sep 23 23:34:45 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Since we need an int paramater, and uio_resid is size_t cast it to int
to avoid warnings from the ever friendly compiler... (check that size if
in range was already made).


To generate a diff of this commit:
cvs rdiff -u -r1.55 -r1.56 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-09-23 Thread Robert Elz
Module Name:src
Committed By:   kre
Date:   Sun Sep 23 23:30:51 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Open code min() so we don't need to find its prototype ...


To generate a diff of this commit:
cvs rdiff -u -r1.54 -r1.55 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-09-23 Thread Takeshi Nakayama
Module Name:src
Committed By:   nakayama
Date:   Sun Sep 23 21:18:30 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
pad(4) mixer has only 1 channel, so return EINVAL in the case other than 1.

This fixes the following strange output of mixerctl(1):

outputs.master=255,0
inputs.dac=255,0


To generate a diff of this commit:
cvs rdiff -u -r1.53 -r1.54 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-01-26 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Fri Jan 26 23:36:01 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Fix typo in previous.  mea culpa, mea culpa, mea maxima culpa


To generate a diff of this commit:
cvs rdiff -u -r1.51 -r1.52 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-01-26 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Fri Jan 26 22:48:22 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Unitialized variable - CID/1428657


To generate a diff of this commit:
cvs rdiff -u -r1.50 -r1.51 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2018-01-08 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Tue Jan  9 04:23:59 UTC 2018

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Fix pad on systems with many cores/cpus:

* Introduce a lock to serialize attach/detach of pad devices.
* Forcefully detach children of pad on close.
* Be more carefull in pad_open with regards to config_detach only
  if new instances of the pad device are created and fail to open.

Addresses PR kern/52889.

These changes were developed with and tested by pgoyette@.


To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-12-17 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Sun Dec 17 21:57:11 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
If config_fini_component() fails (due to device driver busy), don't
discard its error value when re-attaching the devsw.  If the devsw
is successfully re-attached and we return success, the module will
get detached anyway.  And, since the device is actually busy, we'll
eventually panic.

Thanks to nat@ for providing the reproduction instructions.

XXX A driver-busy condition will currently still trigger the error
XXX message from config_fini_component()
XXX configure: attachment `pad' of `pad' driver fini failed: 16
XXX This will be addresses separately by having pad maintain its own
XXX ref-count and not relying on config_fini_component() to detect
XXX the busy state.


To generate a diff of this commit:
cvs rdiff -u -r1.48 -r1.49 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-12-15 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Sat Dec 16 02:45:14 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Remove the correct extra #endif

:)


To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-12-15 Thread matthew green
Module Name:src
Committed By:   mrg
Date:   Sat Dec 16 02:13:13 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
remove extra #endif left in previous commit.


To generate a diff of this commit:
cvs rdiff -u -r1.45 -r1.46 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-12-15 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Fri Dec 15 23:57:42 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Replace manipulation of individual config structures with calls to
config_{init,fini}_component()


To generate a diff of this commit:
cvs rdiff -u -r1.44 -r1.45 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-12-15 Thread Paul Goyette
Module Name:src
Committed By:   pgoyette
Date:   Fri Dec 15 11:49:32 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Rework so that module infrastructure is provided even when the module
is built-in to the kernel.

XXX pullup-8?


To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-07-29 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Sun Jul 30 00:50:52 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
The pad module will now compile with WARNS=5.


To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-07-02 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Sun Jul  2 13:32:51 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
If a particular pad device is opened, ie pad1 then configure and use pad1
if it is not already configured.

This improves scriptability as you will know the particular pad(4) device
you have opened.

pad(4) devices still have a cloning interface if pad device (minor
number 254) is opened it will attach the next free device.  This action
can be repeated.

XXX update MAKEDEV scripts to make /dev/pad the cloning device.

Ok christos@.


To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-07-01 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Sun Jul  2 05:59:27 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Return early from read if kpause is interrupted by a signal.


To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-30 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Sat Jul  1 05:50:10 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
sc_audiodev should be defined as a device_t as this is what audio_attach_mi
returns.


To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.9 -r1.10 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-19 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Mon Jun 19 23:54:00 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Use defines to specify pad audio format.  NFCI.

Ok christos@.


To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.37 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-06 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Tue Jun  6 07:32:41 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Style change.


To generate a diff of this commit:
cvs rdiff -u -r1.35 -r1.36 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-06 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Tue Jun  6 07:31:41 UTC 2017

Modified Files:
src/sys/dev/pad: padvar.h

Log Message:
pad blocksize 1024 -> 8192.  Helps when sleeping in rate limiter.


To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-06 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Tue Jun  6 07:29:35 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Simplification of rate limiter.  It now works uni/multiprocessor.


To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-06 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Tue Jun  6 07:27:15 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
sc_bytes_count needs to be set in pad_audio_open not pad_open.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-06-06 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Tue Jun  6 07:18:38 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Express BYTESTOSLEEP as an 64 bit integer.
Use BYTESTOSLEEP in expresson of BYTES_PER_SEC.


To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-05-27 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Sat May 27 10:43:30 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Add missing sc_bytes_count.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-05-27 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Sat May 27 10:02:26 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
Rework of previous.
Math for BYTESTOSLEEP and TIMENEXTREAD is now correct.


To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-02-23 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Thu Feb 23 23:13:27 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
Update pad due to changes in audio.  sc_bytes_count and BYTESTOSLEEP are
no longer required.


To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.6 -r1.7 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2017-01-25 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Thu Jan 26 04:10:27 UTC 2017

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Don't hold the thread_lock between successive calls to sc_intr as it
breaks mixing.

This will help passing the atf test.  Changes to audio.c to ensue this
will be in a followup commit.


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2016-02-26 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Fri Feb 26 13:17:04 UTC 2016

Modified Files:
src/sys/dev/pad: pad.c padvar.h

Log Message:
Allow reads from pad(4) less or greater than PAD_BLKSIZE.

Ensure that audio data is ready before reading.
Addresses PR 39204.

OK jmcneil@.


To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/sys/dev/pad/pad.c
cvs rdiff -u -r1.5 -r1.6 src/sys/dev/pad/padvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2015-07-10 Thread Nathanial Sloss
Module Name:src
Committed By:   nat
Date:   Fri Jul 10 21:58:56 UTC 2015

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Wrap up calls to sc_intr in kpreempt[en/dis]able.

This commit was approved by christos@


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2013-11-01 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Nov  2 00:37:12 UTC 2013

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
sprinke __diagused


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2011-11-23 Thread Alistair G. Crooks
Module Name:src
Committed By:   agc
Date:   Thu Nov 24 01:54:08 UTC 2011

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
get rid of a variable which is no longer used after the demise of splaudio


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2011-11-23 Thread Jared D. McNeill
Module Name:src
Committed By:   jmcneill
Date:   Thu Nov 24 01:11:05 UTC 2011

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
splaudio is no more


To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2011-02-28 Thread Jeff Rizzo
Module Name:src
Committed By:   riz
Date:   Mon Feb 28 16:56:39 UTC 2011

Modified Files:
src/sys/dev/pad: padvol.c

Log Message:
Use le16enc()/be16enc() to encode LE/BE values back into the audio stream.
This fixes the tests/dev/audio test on my macppc box.

While I'm here, use le16dec()/be16dec() directly instead of rewriting them.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/dev/pad/padvol.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2010-09-03 Thread Jared D. McNeill
Module Name:src
Committed By:   jmcneill
Date:   Fri Sep  3 19:19:49 UTC 2010

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
- return EIO if audio data is received and /dev/pad isn't open
- give a better description for AUDIO_GETDEV


To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2010-06-28 Thread Antti Kantee
Module Name:src
Committed By:   pooka
Date:   Mon Jun 28 17:45:08 UTC 2010

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Don't print spammy message if read is interrupted (ctrl-c)
while waiting for data.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2010-05-01 Thread Antti Kantee
Module Name:src
Committed By:   pooka
Date:   Sat May  1 23:40:22 UTC 2010

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
fix field initializers


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/pad

2010-04-09 Thread Adam Hoka
Module Name:src
Committed By:   ahoka
Date:   Fri Apr  9 13:39:17 UTC 2010

Modified Files:
src/sys/dev/pad: pad.c

Log Message:
Add support to be built as a kernel module.


To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/sys/dev/pad/pad.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.