CVS commit: src/tests/lib/libcurses/tests

2024-06-05 Thread Valery Ushakov
Module Name:src
Committed By:   uwe
Date:   Wed Jun  5 16:09:59 UTC 2024

Modified Files:
src/tests/lib/libcurses/tests: curs_set

Log Message:
adjust initial cursor state to reflect reality

Missed in PR bin/58090
Fixes PR lib/58313


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/curs_set

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/curs_set
diff -u src/tests/lib/libcurses/tests/curs_set:1.1 src/tests/lib/libcurses/tests/curs_set:1.2
--- src/tests/lib/libcurses/tests/curs_set:1.1	Sun Apr 10 09:55:10 2011
+++ src/tests/lib/libcurses/tests/curs_set	Wed Jun  5 16:09:59 2024
@@ -1,5 +1,5 @@
 include start
-call 2 curs_set 0
+call 1 curs_set 0
 compare curs_set1.chk
 call 0 curs_set 1
 compare curs_set2.chk



CVS commit: src/tests/lib/libcurses/tests

2024-06-05 Thread Valery Ushakov
Module Name:src
Committed By:   uwe
Date:   Wed Jun  5 16:09:59 UTC 2024

Modified Files:
src/tests/lib/libcurses/tests: curs_set

Log Message:
adjust initial cursor state to reflect reality

Missed in PR bin/58090
Fixes PR lib/58313


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/curs_set

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-06-15 Thread Brett Lymn
Module Name:src
Committed By:   blymn
Date:   Tue Jun 15 22:21:09 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: slk

Log Message:
Restore the slk_wset test after fixing a but in libcurses.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/tests/slk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/slk
diff -u src/tests/lib/libcurses/tests/slk:1.2 src/tests/lib/libcurses/tests/slk:1.3
--- src/tests/lib/libcurses/tests/slk:1.2	Sun Jun  6 04:57:58 2021
+++ src/tests/lib/libcurses/tests/slk	Tue Jun 15 22:21:09 2021
@@ -56,6 +56,6 @@ compare slk6.chk
 # test slk_wset
 # returning ERR now - blymn 20210606
 # [buggy??] 'b' should be printed as (wcswidth(wstr) == 6) <= 8 
-#wchar WSTR [0x3401, "a", 0x3401, "b"]
-#call OK slk_wset 3 $WSTR 1
-#call OK slk_refresh
+wchar WSTR [0x3401, "a", 0x3401, "b"]
+call OK slk_wset 3 $WSTR 1
+call OK slk_refresh



CVS commit: src/tests/lib/libcurses/tests

2021-06-15 Thread Brett Lymn
Module Name:src
Committed By:   blymn
Date:   Tue Jun 15 22:21:09 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: slk

Log Message:
Restore the slk_wset test after fixing a but in libcurses.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/tests/slk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-06-05 Thread Brett Lymn
Module Name:src
Committed By:   blymn
Date:   Sat Jun  5 06:13:37 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: clear

Log Message:
Decouple the clear test from the addstr test, they should not be linked
together because they are not really related.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/clear

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/clear
diff -u src/tests/lib/libcurses/tests/clear:1.1 src/tests/lib/libcurses/tests/clear:1.2
--- src/tests/lib/libcurses/tests/clear:1.1	Sun Apr 10 09:55:10 2011
+++ src/tests/lib/libcurses/tests/clear	Sat Jun  5 06:13:36 2021
@@ -1,4 +1,10 @@
-include addstr
+include start
+call OK addstr "abcde\n"
+call OK addstr "\n"
+call OK addstr "\t8\n"
+call OK addstr "0123456\t8\n"
+call OK refresh
+compare clear0.chk
 call OK clear
 call OK refresh
 compare clear1.chk



CVS commit: src/tests/lib/libcurses/tests

2021-06-05 Thread Brett Lymn
Module Name:src
Committed By:   blymn
Date:   Sat Jun  5 06:13:37 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: clear

Log Message:
Decouple the clear test from the addstr test, they should not be linked
together because they are not really related.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/clear

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-24 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Thu Feb 25 01:07:43 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addbytes addch

Log Message:
tests/libcurses: add test for '\b' in addch

Just to ensure that addch and addstr behave the same, after the recent
fix for handling '\t'.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libcurses/tests/addbytes
cvs rdiff -u -r1.7 -r1.8 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addbytes
diff -u src/tests/lib/libcurses/tests/addbytes:1.3 src/tests/lib/libcurses/tests/addbytes:1.4
--- src/tests/lib/libcurses/tests/addbytes:1.3	Thu Feb 25 00:26:57 2021
+++ src/tests/lib/libcurses/tests/addbytes	Thu Feb 25 01:07:43 2021
@@ -1,4 +1,4 @@
-# $NetBSD: addbytes,v 1.3 2021/02/25 00:26:57 rillig Exp $
+# $NetBSD: addbytes,v 1.4 2021/02/25 01:07:43 rillig Exp $
 #
 # Tests adding bytes to stdscr.
 #
@@ -19,13 +19,15 @@ call2 0 16 getyx STDSCR
 call OK addbytes "\n" 1
 call2 1 0 getyx STDSCR
 
+# Ensure that backspace works as intended.
+# See tests/addch.
 call OK addbytes "12345\010" 6
 call2 1 4 getyx STDSCR
 
 call OK addbytes "\010\010\010\010" 4
 call2 1 0 getyx STDSCR
 
-# When curx is already 0, backspace is a no-op.
+# If curx is already 0, backspace is a no-op.
 call OK addbytes "\010" 1
 call2 1 0 getyx STDSCR
 

Index: src/tests/lib/libcurses/tests/addch
diff -u src/tests/lib/libcurses/tests/addch:1.7 src/tests/lib/libcurses/tests/addch:1.8
--- src/tests/lib/libcurses/tests/addch:1.7	Sun Feb 14 11:21:37 2021
+++ src/tests/lib/libcurses/tests/addch	Thu Feb 25 01:07:43 2021
@@ -1,4 +1,4 @@
-# $NetBSD: addch,v 1.7 2021/02/14 11:21:37 rillig Exp $
+# $NetBSD: addch,v 1.8 2021/02/25 01:07:43 rillig Exp $
 #
 # Between at least 2012 and 2016, addstr did not advance win->curx for a '\t',
 # but addch did.  This was inconsistent.
@@ -33,3 +33,29 @@ call OK addch `\000\n`
 
 call OK refresh
 compare addch.chk
+
+# Ensure that backspace works as intended.
+# See tests/addbytes.
+call OK move 1 0
+call OK addstr "12345"
+call OK addch `\000\010`
+call2 1 4 getyx STDSCR
+
+call OK addch `\000\010`
+call OK addch `\000\010`
+call OK addch `\000\010`
+call OK addch `\000\010`
+call2 1 0 getyx STDSCR
+
+# If curx is already 0, backspace is a no-op.
+call OK addch `\000\010`
+call2 1 0 getyx STDSCR
+
+call OK addstr "123"
+call OK addch `\000\t`
+call2 1 8 getyx STDSCR
+
+# Backspace affects the cursor position, no matter whether the previously
+# output char was a tab or a space.
+call OK addch `\000\010`
+call2 1 7 getyx STDSCR



CVS commit: src/tests/lib/libcurses/tests

2021-02-24 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Thu Feb 25 01:07:43 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addbytes addch

Log Message:
tests/libcurses: add test for '\b' in addch

Just to ensure that addch and addstr behave the same, after the recent
fix for handling '\t'.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libcurses/tests/addbytes
cvs rdiff -u -r1.7 -r1.8 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-24 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Thu Feb 25 00:26:57 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addbytes

Log Message:
libcurses: ensure that '\b' in handled correctly in addstr

Just to ensure that the recent fix for '\t' handling in addstr/addch
didn't introduce another bug.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/tests/addbytes

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addbytes
diff -u src/tests/lib/libcurses/tests/addbytes:1.2 src/tests/lib/libcurses/tests/addbytes:1.3
--- src/tests/lib/libcurses/tests/addbytes:1.2	Sat Feb 13 22:19:47 2021
+++ src/tests/lib/libcurses/tests/addbytes	Thu Feb 25 00:26:57 2021
@@ -1,4 +1,4 @@
-# $NetBSD: addbytes,v 1.2 2021/02/13 22:19:47 rillig Exp $
+# $NetBSD: addbytes,v 1.3 2021/02/25 00:26:57 rillig Exp $
 #
 # Tests adding bytes to stdscr.
 #
@@ -18,3 +18,21 @@ call2 0 16 getyx STDSCR
 
 call OK addbytes "\n" 1
 call2 1 0 getyx STDSCR
+
+call OK addbytes "12345\010" 6
+call2 1 4 getyx STDSCR
+
+call OK addbytes "\010\010\010\010" 4
+call2 1 0 getyx STDSCR
+
+# When curx is already 0, backspace is a no-op.
+call OK addbytes "\010" 1
+call2 1 0 getyx STDSCR
+
+call OK addbytes "123\t" 4
+call2 1 8 getyx STDSCR
+
+# Backspace affects the cursor position, no matter whether the previously
+# output char was a tab or a space.
+call OK addbytes "\010" 1
+call2 1 7 getyx STDSCR



CVS commit: src/tests/lib/libcurses/tests

2021-02-24 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Thu Feb 25 00:26:57 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addbytes

Log Message:
libcurses: ensure that '\b' in handled correctly in addstr

Just to ensure that the recent fix for '\t' handling in addstr/addch
didn't introduce another bug.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/tests/addbytes

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-14 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sun Feb 14 11:21:37 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addch

Log Message:
tests/libcurses: document the history about tab bugs in addch/addstr

Verified by installing all versions of libcurses from 2012 to 2021 and
running a simple test program on them:

#include 
#include 

int
main(int argc, char **argv)
{
int xstr, ystr, xch, ych;

initscr();

addstr("\t");
xstr = getcurx(stdscr);
addstr("\n");
ystr = getcury(stdscr);

addch('\t');
xch = getcurx(stdscr);
addch('\n');
ych = getcury(stdscr);

endwin();

fprintf(stderr, "%s\t%d,%d\t%d,%d\n",
argv[1], ystr, xstr, ych, xch);
}

Some selected outputs:

...
2016.11.24.14.49.08 1,0 2,8
2016.11.28.18.25.26 1,8 2,8
...
2019.05.12.02.29.00 1,8 2,8
2019.05.20.22.17.41 1,8 2,16
...
2021.02.13.10.37.00 1,8 2,16
2021.02.13.14.30.37 1,8 2,8


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-14 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sun Feb 14 11:21:37 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addch

Log Message:
tests/libcurses: document the history about tab bugs in addch/addstr

Verified by installing all versions of libcurses from 2012 to 2021 and
running a simple test program on them:

#include 
#include 

int
main(int argc, char **argv)
{
int xstr, ystr, xch, ych;

initscr();

addstr("\t");
xstr = getcurx(stdscr);
addstr("\n");
ystr = getcury(stdscr);

addch('\t');
xch = getcurx(stdscr);
addch('\n');
ych = getcury(stdscr);

endwin();

fprintf(stderr, "%s\t%d,%d\t%d,%d\n",
argv[1], ystr, xstr, ych, xch);
}

Some selected outputs:

...
2016.11.24.14.49.08 1,0 2,8
2016.11.28.18.25.26 1,8 2,8
...
2019.05.12.02.29.00 1,8 2,8
2019.05.20.22.17.41 1,8 2,16
...
2021.02.13.10.37.00 1,8 2,16
2021.02.13.14.30.37 1,8 2,8


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addch
diff -u src/tests/lib/libcurses/tests/addch:1.6 src/tests/lib/libcurses/tests/addch:1.7
--- src/tests/lib/libcurses/tests/addch:1.6	Sat Feb 13 14:30:37 2021
+++ src/tests/lib/libcurses/tests/addch	Sun Feb 14 11:21:37 2021
@@ -1,3 +1,18 @@
+# $NetBSD: addch,v 1.7 2021/02/14 11:21:37 rillig Exp $
+#
+# Between at least 2012 and 2016, addstr did not advance win->curx for a '\t',
+# but addch did.  This was inconsistent.
+#
+# On 2016.11.28.18.25.26 on NetBSD 7.99.43, this inconsistency was fixed.
+# Now both functions advanced win->curx.
+#
+# On 2019.05.20.22.17.41 on NetBSD 8.99.41, the fix was modified, which
+# introduced another inconsistency.  Since then, addstr advanced win->curx as
+# expected, but addch advanced it by twice the amount.
+#
+# On 2021.02.13.14.30.37 on NetBSD 9.99.80, this inconsistency was fixed.
+# Now both functions advanced win->curx again.
+
 include start
 call OK addch `\001t`
 call OK refresh
@@ -5,17 +20,11 @@ call OK mvaddch 5 3 `\003e`
 call OK refresh
 call OK addch `\000\n`
 
-# Somewhere between NetBSD 8.0 and 9.0, a bug was added to addch that
-# doubled the spaces for a tab.  Instead of 8 spaces, there were 16.
-# Fixed in NetBSD 9.99.80.
 call OK addch `\000\t`
 call2 6 8 getyx STDSCR
 call OK addch `\0008`
 call OK addch `\000\n`
 
-# Somewhere between NetBSD 8.0 and 9.0, a bug was added to addch that
-# doubled the spaces for a tab.  Instead of 1 space, there were 2.
-# Fixed in NetBSD 9.99.80.
 call OK addstr "0123456"
 call OK addch `\000\t`
 call2 7 8 getyx STDSCR



CVS commit: src/tests/lib/libcurses/tests

2021-02-13 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sat Feb 13 22:19:47 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addbytes

Log Message:
tests/libcurses: note that addbytes is not part of the API

https://mail-index.netbsd.org/source-changes-d/2021/02/13/msg013199.html


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/addbytes

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-13 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sat Feb 13 22:19:47 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addbytes

Log Message:
tests/libcurses: note that addbytes is not part of the API

https://mail-index.netbsd.org/source-changes-d/2021/02/13/msg013199.html


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/addbytes

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addbytes
diff -u src/tests/lib/libcurses/tests/addbytes:1.1 src/tests/lib/libcurses/tests/addbytes:1.2
--- src/tests/lib/libcurses/tests/addbytes:1.1	Sat Feb 13 06:29:45 2021
+++ src/tests/lib/libcurses/tests/addbytes	Sat Feb 13 22:19:47 2021
@@ -1,6 +1,9 @@
-# $NetBSD: addbytes,v 1.1 2021/02/13 06:29:45 rillig Exp $
+# $NetBSD: addbytes,v 1.2 2021/02/13 22:19:47 rillig Exp $
 #
 # Tests adding bytes to stdscr.
+#
+# Note that addbytes is not part of the official curses API, it is merely
+# an internal helper function.
 
 include start
 



CVS commit: src/tests/lib/libcurses/tests

2021-02-13 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sat Feb 13 08:37:21 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: mvwin

Log Message:
tests/libcurses: "fix" test mvwin

The test mvwin previously expected an endless stream of bytes, by
comparing the actual output with /dev/zero.  This didn't make sense as
the curses output does not contain '\0' in any of the test cases.

Compare with /dev/null instead.  This is as wrong as before, but the
curses test framework currently ignores this situation, as for many
other test cases.  See the numerous "Excess" messages in atf-run.log.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/mvwin

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-13 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sat Feb 13 08:37:21 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: mvwin

Log Message:
tests/libcurses: "fix" test mvwin

The test mvwin previously expected an endless stream of bytes, by
comparing the actual output with /dev/zero.  This didn't make sense as
the curses output does not contain '\0' in any of the test cases.

Compare with /dev/null instead.  This is as wrong as before, but the
curses test framework currently ignores this situation, as for many
other test cases.  See the numerous "Excess" messages in atf-run.log.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/mvwin

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/mvwin
diff -u src/tests/lib/libcurses/tests/mvwin:1.1 src/tests/lib/libcurses/tests/mvwin:1.2
--- src/tests/lib/libcurses/tests/mvwin:1.1	Sun Apr 10 09:55:10 2011
+++ src/tests/lib/libcurses/tests/mvwin	Sat Feb 13 08:37:21 2021
@@ -2,11 +2,11 @@ include window
 call OK wmove $win1 1 1
 call OK wprintw $win1 "%s" ""
 call OK wrefresh $win1
-compare /dev/zero
+compare /dev/null
 call OK refresh
-compare /dev/zero
+compare /dev/null
 call OK mvwin $win1 4 7
 call OK wrefresh $win1
-compare /dev/zero
+compare /dev/null
 call OK refresh
-compare /dev/zero
+compare /dev/null



CVS commit: src/tests/lib/libcurses/tests

2021-02-07 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sun Feb  7 23:30:33 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addch

Log Message:
tests/libcurses: fix undefined behavior in test addch

The libcurses framework is not strictly typed and thus provides plenty
of ways to shoot yourself in the foot.  It's a waste of time debugging
things that a proper programming language can easily prevent.

The function addch expects an argument of type 'chtype'.  Passing a
"double-quoted" string does not match this, as 'chtype' is completely
different from a plain 'char'.  Instead, functions taking a 'chtype'
must be passed a `backtick-quoted` string.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addch
diff -u src/tests/lib/libcurses/tests/addch:1.4 src/tests/lib/libcurses/tests/addch:1.5
--- src/tests/lib/libcurses/tests/addch:1.4	Sun Feb  7 13:06:02 2021
+++ src/tests/lib/libcurses/tests/addch	Sun Feb  7 23:30:33 2021
@@ -3,23 +3,22 @@ call OK addch `\001t`
 call OK refresh
 call OK mvaddch 5 3 `\003e`
 call OK refresh
-call OK addch "\n"
+call OK addch `\000\n`
 
 # Somewhere between NetBSD 8.0 and 9.0, a bug was added to addch that
 # doubled the spaces for a tab.  Instead of 8 spaces, there are now 16.
-call OK addch "\t"
+call OK addch `\000\t`
 call2 6 16 getyx STDSCR		# FIXME: must be 8, not 16
-call OK addch "8"
-call OK addch "\n"
+call OK addch `\0008`
+call OK addch `\000\n`
 
 # Somewhere between NetBSD 8.0 and 9.0, a bug was added to addch that
 # doubled the spaces for a tab.  Instead of 1 space, there are now 2.
 call OK addstr "0123456"
-call OK addch "\t"
-call2 7 9 getyx STDSCR		# FIXME: with probability around 50%, the
-# 7 comes out as a 6.
-call OK addch "8"
-call OK addch "\n"
+call OK addch `\000\t`
+call2 7 9 getyx STDSCR
+call OK addch `\0008`
+call OK addch `\000\n`
 
 call OK refresh
 compare addch.chk



CVS commit: src/tests/lib/libcurses/tests

2021-02-07 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sun Feb  7 23:30:33 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addch

Log Message:
tests/libcurses: fix undefined behavior in test addch

The libcurses framework is not strictly typed and thus provides plenty
of ways to shoot yourself in the foot.  It's a waste of time debugging
things that a proper programming language can easily prevent.

The function addch expects an argument of type 'chtype'.  Passing a
"double-quoted" string does not match this, as 'chtype' is completely
different from a plain 'char'.  Instead, functions taking a 'chtype'
must be passed a `backtick-quoted` string.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2021-02-07 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sun Feb  7 13:06:02 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addch

Log Message:
tests/libcurses: demonstrate more bugs in addch


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addch
diff -u src/tests/lib/libcurses/tests/addch:1.3 src/tests/lib/libcurses/tests/addch:1.4
--- src/tests/lib/libcurses/tests/addch:1.3	Sun Feb  7 01:53:54 2021
+++ src/tests/lib/libcurses/tests/addch	Sun Feb  7 13:06:02 2021
@@ -8,6 +8,7 @@ call OK addch "\n"
 # Somewhere between NetBSD 8.0 and 9.0, a bug was added to addch that
 # doubled the spaces for a tab.  Instead of 8 spaces, there are now 16.
 call OK addch "\t"
+call2 6 16 getyx STDSCR		# FIXME: must be 8, not 16
 call OK addch "8"
 call OK addch "\n"
 
@@ -15,6 +16,8 @@ call OK addch "\n"
 # doubled the spaces for a tab.  Instead of 1 space, there are now 2.
 call OK addstr "0123456"
 call OK addch "\t"
+call2 7 9 getyx STDSCR		# FIXME: with probability around 50%, the
+# 7 comes out as a 6.
 call OK addch "8"
 call OK addch "\n"
 



CVS commit: src/tests/lib/libcurses/tests

2021-02-07 Thread Roland Illig
Module Name:src
Committed By:   rillig
Date:   Sun Feb  7 13:06:02 UTC 2021

Modified Files:
src/tests/lib/libcurses/tests: addch

Log Message:
tests/libcurses: demonstrate more bugs in addch


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libcurses/tests/addch

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2020-02-07 Thread Valeriy E. Ushakov
Module Name:src
Committed By:   uwe
Date:   Fri Feb  7 19:56:51 UTC 2020

Modified Files:
src/tests/lib/libcurses/tests: mvscanw

Log Message:
Fix typo in a comment.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/tests/mvscanw

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/mvscanw
diff -u src/tests/lib/libcurses/tests/mvscanw:1.2 src/tests/lib/libcurses/tests/mvscanw:1.3
--- src/tests/lib/libcurses/tests/mvscanw:1.2	Tue Jun 25 22:19:29 2019
+++ src/tests/lib/libcurses/tests/mvscanw	Fri Feb  7 19:56:51 2020
@@ -7,5 +7,5 @@ call2 OK "test" mvscanw 3 5 "%4s"
 input "50 12\n"
 call2 OK "2" mvscanw 3 5 "%d"
 input "aa bb 50 12\n"
-# expect ERR becauss input has alpha and scanw wants integer
+# expect ERR because input has alpha and scanw wants integer
 call2 ERR "2" mvscanw 3 5 "%d"



CVS commit: src/tests/lib/libcurses/tests

2020-02-07 Thread Valeriy E. Ushakov
Module Name:src
Committed By:   uwe
Date:   Fri Feb  7 19:56:51 UTC 2020

Modified Files:
src/tests/lib/libcurses/tests: mvscanw

Log Message:
Fix typo in a comment.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/tests/mvscanw

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2011-08-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Mon Aug 29 12:42:58 UTC 2011

Modified Files:
src/tests/lib/libcurses/tests: addnstr

Log Message:
This could have never worked before since the syntax was wrong. Unfortunately
since I added the error checking, I was blamed for it failing. Go figure.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/addnstr

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/addnstr
diff -u src/tests/lib/libcurses/tests/addnstr:1.1 src/tests/lib/libcurses/tests/addnstr:1.2
--- src/tests/lib/libcurses/tests/addnstr:1.1	Sun Apr 10 05:55:10 2011
+++ src/tests/lib/libcurses/tests/addnstr	Mon Aug 29 08:42:57 2011
@@ -1,5 +1,5 @@
 include start
-call OK addnstr abdcefg 5
-refresh
+call OK addnstr abcdefg 5
+call OK refresh
 # should be the same as addstr
-compare addstr
+compare addstr.chk



CVS commit: src/tests/lib/libcurses/tests

2011-08-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Mon Aug 29 12:43:52 UTC 2011

Modified Files:
src/tests/lib/libcurses/tests: assume_default_colors

Log Message:
change comparend to compare so that this passes now.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/assume_default_colors

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/tests/lib/libcurses/tests/assume_default_colors
diff -u src/tests/lib/libcurses/tests/assume_default_colors:1.1 src/tests/lib/libcurses/tests/assume_default_colors:1.2
--- src/tests/lib/libcurses/tests/assume_default_colors:1.1	Sun Apr 10 05:55:10 2011
+++ src/tests/lib/libcurses/tests/assume_default_colors	Mon Aug 29 08:43:51 2011
@@ -2,7 +2,7 @@
 call OK start_color
 call OK assume_default_colors -1 -1
 call OK refresh
-comparend color_start.chk
+compare color_start.chk
 # This should be the same as the default
 compare color_default.chk
 # default foreground, blue background



CVS commit: src/tests/lib/libcurses/tests

2011-08-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Mon Aug 29 12:42:58 UTC 2011

Modified Files:
src/tests/lib/libcurses/tests: addnstr

Log Message:
This could have never worked before since the syntax was wrong. Unfortunately
since I added the error checking, I was blamed for it failing. Go figure.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/addnstr

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2011-08-29 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Mon Aug 29 12:43:52 UTC 2011

Modified Files:
src/tests/lib/libcurses/tests: assume_default_colors

Log Message:
change comparend to compare so that this passes now.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/assume_default_colors

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/tests/lib/libcurses/tests

2011-04-20 Thread Brett Lymn
Module Name:src
Committed By:   blymn
Date:   Wed Apr 20 10:40:14 UTC 2011

Modified Files:
src/tests/lib/libcurses/tests: std_defines

Log Message:
Add boolean values to the standard definitions.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/std_defines

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.