Re: CVS: cvs.openbsd.org: src

2018-06-20 Thread Kevin Lo
On Wed, Jun 20, 2018 at 11:41:54PM -0600, Kevin Lo wrote:
> 
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   ke...@cvs.openbsd.org   2018/06/20 23:41:54
> 
> Modified files:
>   sys/arch/amd64/amd64: vmm.c 
> 
> Log message:
> Add missing comma.  This fixes compilation if we enable VMM_DEBUG macro.
> 
> ok deraadt@

And ok mlarkin@



CVS: cvs.openbsd.org: src

2018-06-20 Thread Kevin Lo
CVSROOT:/cvs
Module name:src
Changes by: ke...@cvs.openbsd.org   2018/06/20 23:41:54

Modified files:
sys/arch/amd64/amd64: vmm.c 

Log message:
Add missing comma.  This fixes compilation if we enable VMM_DEBUG macro.

ok deraadt@



CVS: cvs.openbsd.org: src

2018-06-20 Thread Stuart Henderson
CVSROOT:/cvs
Module name:src
Changes by: st...@cvs.openbsd.org   2018/06/20 13:30:34

Modified files:
sys/arch/amd64/amd64: identcpu.c 

Log message:
On newer AMD parts, use CoreId (EBX) and NodeId (ECX) from cpuid 0x801e
to detect smt cores. As there's no "smt id" on these like there is on Intel
parts, check against other already-id'd cpus to detect which are additional
smt threads on a core.

jmatthew noticed some unusual (non-contiguous) numbering on an single
socket EPYC 7551p but there's no indication that the actual ID numbers
need to be sequential.

"As long as we treat ci_core_id as just a number, that shouldn't be an
issue" and OK kettenis@

ref: 54945 rev 1.14 - PPR for AMD Family 17h Models 00h-0Fh



CVS: cvs.openbsd.org: src

2018-06-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2018/06/20 12:13:33

Modified files:
distrib/sets/lists/base: mi 

Log message:
sync



CVS: cvs.openbsd.org: src

2018-06-20 Thread Reyk Floeter
CVSROOT:/cvs
Module name:src
Changes by: r...@cvs.openbsd.org2018/06/20 10:43:05

Modified files:
usr.sbin/httpd : config.c httpd.conf.5 httpd.h parse.y 
 server_http.c 

Log message:
Add support for simple one-off internal rewrites.

For example:

location match "/page/(%d+)/.*" {
request rewrite "/static/index.php?id=%1&$QUERY_STRING"
}

Requested by many.

Ok benno@



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 08:56:55

Modified files:
usr.sbin/pkg_add/OpenBSD: Dependencies.pm 

Log message:
make it possible to do @tag sthg in the same package that does
@define-tag sthg



Re: CVS: cvs.openbsd.org: src

2018-06-20 Thread Florian Obser
On Wed, Jun 20, 2018 at 08:55:29AM -0600, Florian Obser wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   flor...@cvs.openbsd.org 2018/06/20 08:55:29
> 
> Modified files:
>   sbin/slaacd: engine.c 
> 
> Log message:
> This might have been a good idea 20 years ago but in this day and age
> the compiler is probably better at unrolling loops.
> style nit fcambus
> OK phessler
> 

and OK kn

-- 
I'm not entirely sure you are real.



CVS: cvs.openbsd.org: src

2018-06-20 Thread Florian Obser
CVSROOT:/cvs
Module name:src
Changes by: flor...@cvs.openbsd.org 2018/06/20 08:55:29

Modified files:
sbin/slaacd: engine.c 

Log message:
This might have been a good idea 20 years ago but in this day and age
the compiler is probably better at unrolling loops.
style nit fcambus
OK phessler



Re: CVS: cvs.openbsd.org: src

2018-06-20 Thread Theo de Raadt
Jasper Lievisse Adriaanse  wrote:

> Thanks to Ben Gras of VUSec for sharing an early version the research paper
> with us. More details will be made public soon as 'tlbleed'.

Thanks for saying that Jasper.  And thanks to Ben for getting the
paper to us.

As demonstrated in the commit message, we hesitate to pass on more
information.  That remains Ben's thunder in Vegas.

However we wanted to get a usable mitigation for the problem into
public.  Maybe Intel has solutions with less overhead.  But Intel
excluded us from conversation so we don't know what those solutions
might be.  So we follow a pattern of immediately releasing a rough
solution, which we can retract if a cheaper solution becomes published.



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 08:34:49

Modified files:
usr.sbin/pkg_add/OpenBSD: Dependencies.pm 

Log message:
so tags will need to match OLD tag definitions as well as new ones.
we can probably get away without doing it if no tags exist (to do later)



Re: CVS: cvs.openbsd.org: src

2018-06-20 Thread Jasper Lievisse Adriaanse
On Tue, Jun 19, 2018 at 01:29:52PM -0600, Mark Kettenis wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   kette...@cvs.openbsd.org2018/06/19 13:29:52
> 
> Modified files:
>   sys/arch/amd64/amd64: cpu.c 
>   sys/arch/amd64/include: cpu.h 
>   sys/kern   : kern_sched.c kern_sysctl.c 
>   sys/sys: sched.h sysctl.h 
> 
> Log message:
> SMT (Simultanious Multi Threading) implementations typically share
> TLBs and L1 caches between threads.  This can make cache timing
> attacks a lot easier and we strongly suspect that this will make
> several spectre-class bugs exploitable.  Especially on Intel's SMT
> implementation which is better known as Hypter-threading.  We really
> should not run different security domains on different processor
> threads of the same core.  Unfortunately changing our scheduler to
> take this into account is far from trivial.  Since many modern
> machines no longer provide the ability to disable Hyper-threading in
> the BIOS setup, provide a way to disable the use of additional
> processor threads in our scheduler.  And since we suspect there are
> serious risks, we disable them by default.  This can be controlled
> through a new hw.smt sysctl.  For now this only works on Intel CPUs
> when running OpenBSD/amd64.  But we're planning to extend this feature
> to CPUs from other vendors and other hardware architectures.
> 
> Note that SMT doesn't necessarily have a posive effect on performance;
> it highly depends on the workload.  In all likelyhood it will actually
> slow down most workloads if you have a CPU with more than two cores.
> 
> ok deraadt@

Thanks to Ben Gras of VUSec for sharing an early version the research paper
with us. More details will be made public soon as 'tlbleed'.

Cheers,
-- 
jasper



CVS: cvs.openbsd.org: src

2018-06-20 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2018/06/20 07:09:08

Modified files:
usr.bin/systat : pool.c 

Log message:
Remove unused variable. Make clang happier.



CVS: cvs.openbsd.org: src

2018-06-20 Thread Stuart Henderson
CVSROOT:/cvs
Module name:src
Changes by: st...@cvs.openbsd.org   2018/06/20 06:10:46

Modified files:
sbin/dhclient  : dhclient.c 

Log message:
dhclient.c r1.569 started writing some files before calling daemon(),
which involved doing a write_option_db() call at a different point in
bind_lease().

However one of the parameters was in a variable that was also used for
iterating a TAILQ so this did not have the intended contents (it was
always NULL at the end of TAILQ_FOREACH*, resulting in a null deref
when dhclient -L is used).

Fix by using a new temporary variable.  ok krw@



CVS: cvs.openbsd.org: src

2018-06-20 Thread Helg Bredow
CVSROOT:/cvs
Module name:src
Changes by: h...@cvs.openbsd.org2018/06/20 04:57:39

Modified files:
sys/miscfs/fuse: fuse_vnops.c 

Log message:
Fix formatting.



CVS: cvs.openbsd.org: src

2018-06-20 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2018/06/20 04:53:30

Modified files:
sys/kern   : init_sysent.c syscalls.c 
sys/sys: syscall.h syscallargs.h 

Log message:
regen



CVS: cvs.openbsd.org: src

2018-06-20 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2018/06/20 04:52:49

Modified files:
sys/kern   : kern_descrip.c kern_sysctl.c syscalls.master 
 uipc_syscalls.c uipc_usrreq.c 
sys/sys: file.h 

Log message:
Unlock sendmsg(2) and sendto(2).

These syscalls can now be executed w/o the KERNEL_LOCK() depending on
the kind of socket.

The current solution uses a single global mutex to serialize access to,
and reference count, 'struct file'.

ok visa@, kettenis@



CVS: cvs.openbsd.org: src

2018-06-20 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2018/06/20 04:48:55

Modified files:
sys/kern   : kern_ktrace.c kern_pledge.c 

Log message:
Grab and/or assert for the KERNEL_LOCK() in in ktrace & pledge.

This is required to run network syscall mostly without the KERNEL_LOCK().

ok visa@, kettenis@ as part of a larger diff.



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 04:23:18

Modified files:
usr.sbin/pkg_add/OpenBSD: UpdateSet.pm 

Log message:
tags from changed_handles will be relevant, from nowhere else...



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 04:21:40

Modified files:
usr.sbin/pkg_add/OpenBSD: PkgAdd.pm 

Log message:
use delete_handle here as well



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 04:15:42

Modified files:
usr.sbin/pkg_add/OpenBSD: Delete.pm PkgDelete.pm 

Log message:
modernize pkg_delete code, we have DeleteSets, which means handle
so let the handle do the heavy lifting of plist loading all the
time (this is also what tag solver will need)



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 04:13:31

Modified files:
usr.sbin/pkg_add/OpenBSD: PkgAdd.pm UpdateSet.pm 

Log message:
move the solver autoloader into UpdateSet so that pkg_delete will be
able to use it.



CVS: cvs.openbsd.org: src

2018-06-20 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2018/06/20 03:44:51

Modified files:
sys/net: pfkeyv2.c 

Log message:
Use the socket lock rather than the KERNEL_LOCK() in pfkey_sendup().

inputs & ok visa@



CVS: cvs.openbsd.org: src

2018-06-20 Thread Reyk Floeter
CVSROOT:/cvs
Module name:src
Changes by: r...@cvs.openbsd.org2018/06/20 03:20:51

Modified files:
usr.sbin/snmpd : mib.h 

Log message:
Add bsws and arcaTrust PENs



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 02:53:14

src/usr.sbin/pkg_add/OpenBSD/Dependencies

Update of /cvs/src/usr.sbin/pkg_add/OpenBSD/Dependencies
In directory cvs.openbsd.org:/tmp/cvs-serv9577/Dependencies

Log Message:
Directory /cvs/src/usr.sbin/pkg_add/OpenBSD/Dependencies added to the repository



CVS: cvs.openbsd.org: src

2018-06-20 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2018/06/20 02:53:49

Modified files:
usr.sbin/pkg_add: Makefile 
Added files:
usr.sbin/pkg_add/OpenBSD/Dependencies: SolverBase.pm 

Log message:
prepare to split half of the dependencies code into a manageable subclass