CVS: cvs.openbsd.org: src

2019-07-04 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2019/07/04 23:30:50

Modified files:
distrib/sets/lists/man: mi 

Log message:
sync



CVS: cvs.openbsd.org: src

2019-07-04 Thread Jason McIntyre
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2019/07/04 23:22:57

Modified files:
share/man/man4 : aggr.4 

Log message:
tweak previous; ok dlg



CVS: cvs.openbsd.org: src

2019-07-04 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2019/07/04 23:04:26

Modified files:
lib/libc/stdlib: realpath.c 

Log message:
The last consumer of pre-posix realpath behaviour has stopped
requiring it (sftp-server).
Remove the /exists/ behaviour from here.  The /nonexistant
behaviour remains in the kernel and needs to be shot next.
There may be ports fallout, but we doubt it.
ok beck djm



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 23:00:40

Modified files:
sys/net: if_aggr.c 

Log message:
fix the $OpenBSD$ tag



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 23:00:07

Modified files:
sys/net: if_aggr.c 

Log message:
initialise sc_lacp_timeout to AGGR_LACP_TIMEOUT_SLOW, not 0;

it's the same, but there was a misleading comment on the same line
which this cleans up too.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 22:59:00

Modified files:
sys/net: if_aggr.c 

Log message:
iterate over distributing ports when populating the tx map, not all ports

this probably explains why ive seen a box decide not to use a
distributing port, even though the state machine and all the lacp
state flags say it's fine. it may also explain why jmatthew@ has
seen a port still transmitting after it's been removed from an
aggr(4).



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 22:56:16

Modified files:
sys/net: if_aggr.c 

Log message:
init the log of tx times to somewhere in the past when adding a port.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Damien Miller
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 22:55:41

Modified files:
usr.bin/ssh: sftp-server.c ssh-keygen.c 
usr.bin/ssh/sftp-server: Makefile 
usr.bin/ssh/ssh-keygen: Makefile 
usr.bin/ssh/sshd: Makefile 
Added files:
usr.bin/ssh: sftp-realpath.c 

Log message:
add a local implementation of BSD realpath() for sftp-server use
ahead of OpenBSD's realpath changing to match POSIX;

ok deraadt@ (thanks for snaps testing)



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 22:46:26

Modified files:
share/man/man9 : SMR_PTR_GET.9 

Log message:
make the pointer value argument name "v" instead of "value"

this makes a sentence read better when there's no syntax hilighting
in effect.

while here, say the write-write memory barrier is implemented with
membar_producer so it's easier to go read about what that provides.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 22:41:23

Modified files:
share/man/man9 : smr_call.9 SMR_LIST_INIT.9 SMR_PTR_GET.9 

Log message:
Xr between all the different smr pages.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Darren Tucker
CVSROOT:/cvs
Module name:src
Changes by: dtuc...@cvs.openbsd.org 2019/07/04 22:19:39

Modified files:
regress/usr.bin/ssh: Makefile 

Log message:
Add (recently added) rsa_oldfmt to CLEANFILES.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Darren Tucker
CVSROOT:/cvs
Module name:src
Changes by: dtuc...@cvs.openbsd.org 2019/07/04 22:12:46

Modified files:
regress/usr.bin/ssh: conch-ciphers.sh test-exec.sh 

Log message:
Adapt the PuTTY/Conch tests to new key names.

A recent regress change (2a9b3a2ce411d16cda9c79ab713c55f65b0ec257 in
portable) broke the PuTTY and Twisted Conch interop tests, because the
key they want to use is now called ssh-rsa rather than rsa.  Adapt the
tests to the new file names.  bz#3020, patch from cjwatson at debian.org.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Darren Tucker
CVSROOT:/cvs
Module name:src
Changes by: dtuc...@cvs.openbsd.org 2019/07/04 22:03:13

Modified files:
regress/usr.bin/ssh: multiplex.sh 

Log message:
Add a sleep to allow forwards to come up.

Currently when the multiplex client requests a forward it returns
once the request has been sent but not necessarily when the forward
is up.  This causes intermittent text failures due to this race,
so add some sleeps to mitigate this until we can fix it properly.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 21:34:53

Modified files:
sys/net: if_aggr.c 

Log message:
move a declaration before a statement.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 20:36:31

Modified files:
sys/net: if_aggr.c 

Log message:
report a port as active to userland if it is muxed



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 20:27:48

Modified files:
sys/net: if_aggr.c 

Log message:
tweak mtu handling and propagate mtu setting to trunkports

make setting a trunkports mtu to its current mtu a nop. set a
trunkports mtu to the aggr mtu when the port is getting added. set
the mtu on all trunkports when the aggr mtu is set so things look
consistent. restore a trunkports mtu when it is removed from an
aggr.

this is mostly cosmetic since the mtu on trunkports isn't really
used anywhere.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:41:14

Modified files:
share/man/man4 : Makefile 

Log message:
+aggr.4



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:39:55

Added files:
share/man/man4 : aggr.4 

Log message:
make a start at a manpage for aggr(4)



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:37:53

Modified files:
sys/conf   : GENERIC 

Log message:
add aggr, but leave it commented out for now.

it needs to be a bit more robust before making it more available to try.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:37:13

Modified files:
sys/conf   : files 

Log message:
wire up aggr



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:35:58

Added files:
sys/net: if_aggr.c 

Log message:
add aggr(4), a dedicated driver that implements 802.1AX link aggregation

802.1AX (formerly known as 802.3ad) describes the Link Aggregation
Control Protocol (LACP) and how to use it in a bunch of different
state machines to control when to bundle interfaces into an
aggregation.

technically the trunk(4) driver already implements support for
802.1AX, but it had a couple of problems i struggled to deal with
as part of that driver. firstly, i couldnt easily make the output
path in trunk mpsafe without getting bogged down, and the state
machine handling had a few hard to diagnose edge cases that i couldnt
figure out.

the new driver has an mpsafe output path, and implements ifq bypass
like vlan(4) does. this means output with aggr(4) is up to twice
as fast as trunk(4). the implementation of the state machines as
per the standard means the driver behaves more correctly in edge
cases like when a physical link looks like it is up, but is logically
unidirectional.

the code has been good enough for me to use in production, but it
does need more work. that can happen in tree now instead of carrying
a large diff around.

some testing by ccardenas@, hrvoje popovski, and jmatthew@
ok deraadt@ ccardenas@ jmatthew@



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:24:56

Modified files:
sys/net: if_trunk.c 

Log message:
record when trunk takes over an interface by setting ac_trunkport

this will be used to prevent trunk and the upcoming aggr driver
from taking ownership of an Ethernet interface at the same time.



CVS: cvs.openbsd.org: src

2019-07-04 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2019/07/04 19:23:22

Modified files:
sys/netinet: if_ether.h 

Log message:
add ac_trunkport to arpcom so trunks can coordinate owning an interface

Ethernet interfaces can be used by trunk(4), and i'm about to commit
a new aggr(4) driver which should not be able to use an interface
while trunk owns it and visa versa.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Ted Unangst
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2019/07/04 13:04:17

Modified files:
usr.bin/doas   : doas.1 

Log message:
note that authentication is required, unless otherwise configured.
ok sthen



CVS: cvs.openbsd.org: src

2019-07-04 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2019/07/04 12:09:17

Modified files:
sys/dev: softraid.c softraid_crypto.c softraidvar.h 

Log message:
Fix a free size panic when detaching a crypto softraid on i386.
Store the size of struct sr_workunit depending on the softraid type
in struct sr_discipline.
testing and OK jan@



CVS: cvs.openbsd.org: src

2019-07-04 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2019/07/04 11:42:17

Modified files:
sys/kern   : uipc_socket.c 
share/man/man9 : sosplice.9 

Log message:
Remove a useless kernel lock from the TCP socket splicing path.
When send buffer space in the drain socket becomes available, a
task is added to move data, and also the userland was informed.
The latter is not usefull as this would mix a kernel and user stream.
So programs do not wait for this event.  Avoid calling sowakeup()
from sowwakeup(), this also reduces grabing the kernel lock.  Instead
inform the userland about the write event when the splicing is
dissolved in sounsplice().
OK claudio@



CVS: cvs.openbsd.org: src

2019-07-04 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2019/07/04 10:20:10

Modified files:
usr.bin/ssh: sshpty.c 

Log message:
fatal() if getgrnam() cannot find "tty"



CVS: cvs.openbsd.org: src

2019-07-04 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2019/07/04 10:16:51

Modified files:
usr.bin/ssh: sshpty.c 

Log message:
stat() returns precisely -1 to indicate error



CVS: cvs.openbsd.org: src

2019-07-04 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2019/07/04 09:25:17

Modified files:
usr.sbin/pkg_add: pkg_info.1 pkg_add.1 

Log message:
PKG_TMPDIR now defaults to /tmp instead of /var/tmp



CVS: cvs.openbsd.org: src

2019-07-04 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2019/07/04 09:08:27

Modified files:
usr.sbin/pkg_add/OpenBSD: Paths.pm 

Log message:
get vartmp to point to /tmp



CVS: cvs.openbsd.org: src

2019-07-04 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2019/07/04 08:53:27

Modified files:
usr.sbin/pkg_add/OpenBSD: PackageLocation.pm 

Log message:
unhardcode  error message, suggested by otto@



CVS: cvs.openbsd.org: src

2019-07-04 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2019/07/04 08:50:01

Modified files:
usr.sbin/pkg_add/OpenBSD: Temp.pm 

Log message:
unbreak, mkdtemp returns a scalar
found out the hard way by otto@



CVS: cvs.openbsd.org: src

2019-07-04 Thread Inoguchi Kinichiro
CVSROOT:/cvs
Module name:src
Changes by: inogu...@cvs.openbsd.org2019/07/04 07:55:20

Modified files:
usr.bin/openssl: openssl.1 

Log message:
Fix manual openssl(1) crl

- Add undocumented options -crlnumber, -hash_old, -nameopt and -verify

ok jmc@



CVS: cvs.openbsd.org: src

2019-07-04 Thread Inoguchi Kinichiro
CVSROOT:/cvs
Module name:src
Changes by: inogu...@cvs.openbsd.org2019/07/04 07:00:42

Modified files:
usr.bin/openssl: openssl.1 

Log message:
Fix manual openssl(1) ca

- Add undocumented options -crlsec and -sigopt
- Sync argument name between usage and options description

ok jmc@



CVS: cvs.openbsd.org: src

2019-07-04 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2019/07/04 04:20:59

Modified files:
regress/usr.sbin/bgpd/unittests: rde_community_test.c 

Log message:
Add a dummy attr_writebuf() so that this code links again.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2019/07/04 03:48:24

Modified files:
regress/usr.sbin/pkg_add: Makefile 

Log message:
add a beautify test... which obviously found bugs, ahah



CVS: cvs.openbsd.org: src

2019-07-04 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2019/07/04 03:47:09

Modified files:
usr.sbin/pkg_add/OpenBSD: UpdateSet.pm 

Log message:
gc old code (unused since it couldn't work without a state)
hack "print" to do the right thing because it wouldn't.
this will probably need some cleanse at some point, like doing smart_join
in a smarter way.



CVS: cvs.openbsd.org: src

2019-07-04 Thread Jonathan Matthew
CVSROOT:/cvs
Module name:src
Changes by: jmatt...@cvs.openbsd.org2019/07/04 00:31:03

Modified files:
sys/dev/pci: if_ixl.c 

Log message:
when the mac address changes, update the mac/vlan filters accordingly.

ok dlg@