CVS: cvs.openbsd.org: src

2019-07-22 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2019/07/23 00:26:44

Modified files:
usr.sbin/bgpd  : bgpd.c bgpd.h kroute.c parse.y rde.c 

Log message:
Clean up RIB related kroute code. Introduce a way to flush a FIB table
from the RDE. Make sure that all nexthops don't get removed in the FIB
when a FIB table is removed. This should only happen for the main FIB.
Remove F_RIB_HASNOFIB which is just confusing since there is already
F_RIB_NOFIB and F_RIB_NOFIBSYNC.
OK benno@



CVS: cvs.openbsd.org: src

2019-07-22 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2019/07/22 18:31:31

Modified files:
usr.sbin/switchd: switchd.c 

Log message:
delete a stray blank from the usage() message; reported by Jesper Wallin



CVS: cvs.openbsd.org: src

2019-07-22 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2019/07/22 17:01:48

Modified files:
usr.sbin/smtpd : to.c 

Log message:
Use mnemonic IPPORT_HILASTAUTO

More readable, no binary change.

OK kmos



CVS: cvs.openbsd.org: src

2019-07-22 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2019/07/22 11:20:06

Modified files:
sbin/dhclient  : clparse.c dhcpd.h parse.c 

Log message:
Cleanup/simplify parse_number():

1) Restructure to explicitly set a long long result and take the
desired low/high constraints for strtonum().

2) No need to use a temporary variable when setting long long
(a.k.a. time_t) fields.

3) Fewer magic numbers when processing integer valued option
data. Less memcpy()'ing where a cast or two is sufficient to make
integer assignment work.

No intentional functional change.



CVS: cvs.openbsd.org: src

2019-07-22 Thread Anton Lindqvist
CVSROOT:/cvs
Module name:src
Changes by: an...@cvs.openbsd.org   2019/07/22 10:43:10

Modified files:
sys/kern   : vfs_syscalls.c 

Log message:
Correct minor style nit in sys_getdents() for consistency, missing parens around
return expression.



CVS: cvs.openbsd.org: src

2019-07-22 Thread Anton Lindqvist
CVSROOT:/cvs
Module name:src
Changes by: an...@cvs.openbsd.org   2019/07/22 10:39:29

Modified files:
sys/kern   : vfs_syscalls.c 

Log message:
Grab the vnode lock earlier in sys_getdents() since it could end up
sleeping, allowing the file offset to change. This is part of the
ongoing effort to protect the file offset using the vnode lock.

ok mpi@ visa@



CVS: cvs.openbsd.org: src

2019-07-22 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2019/07/22 09:59:49

Modified files:
sbin/dhclient  : clparse.c 

Log message:
Eliminate pointless "... else {}" branch to improve readability.



CVS: cvs.openbsd.org: src

2019-07-22 Thread Robert Nagy
CVSROOT:/cvs
Module name:src
Changes by: rob...@cvs.openbsd.org  2019/07/22 09:34:07

Modified files:
lib/libc/sys   : getsockopt.2 
sys/sys: socket.h 
sys/kern   : uipc_socket.c 

Log message:
implement SO_DOMAIN and SO_PROTOCOL so that the domain and the protocol
can also be retrieved with getsockopt(3)
it looks like these will also be in the next issue of posix:
http://austingroupbugs.net/view.php?id=840#c2263

ok claudio@, sthen@



CVS: cvs.openbsd.org: src

2019-07-22 Thread joshua stein
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2019/07/22 08:37:06

Modified files:
sys/dev/acpi   : dwiic_acpi.c 
sys/dev/i2c: i2cvar.h ihidev.c ihidev.h 

Log message:
Even when polling is requested, install ihidev's interrupt handler

If an interrupt is received, turn off polling and rely on
interrupts.  This may happen after S3 resume.

Also properly shut down polling during suspend and start it up again
on resume only after dwiic is back in action.



CVS: cvs.openbsd.org: src

2019-07-22 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2019/07/22 06:39:02

Modified files:
usr.bin/vi/common: recover.c 

Log message:
In secure mode (-S), skip sending mail when executing the :pre[serve]
command or when dying from SIGTERM.  This way, creating the recovery
file works again without re-adding "proc exec" to the pledge(2).
As reported by Jesper Wallin , this got
broken by common/main.c rev. 1.29 (Nov 19, 2015).
The general direction of the fix was suggested by brynet@.
OK brynet@ and no opposition when shown on tech@



CVS: cvs.openbsd.org: src

2019-07-22 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2019/07/22 05:51:30

Modified files:
sys/arch/armv7/stand/efiboot: conf.c exec.c 

Log message:
Disable caches and MMU before jumping to the kernel entry point.  Needed
because UEFI on 32-bit ARM is supposed to leave them enabled and U-boot
was changed (starting with release 2019.04) to follow the spec here.  However
the OpenBSD/armv7 kernel expects to be booted with caches and MMU turned off.

Note that there are still issues on boards that enable the non-architected
L2 cache.  UEFI demands that such caches are not turned on, but U-Boot
does turn them on and this makes our kernel fail to boot.

With help from jsg@

ok jsg@



CVS: cvs.openbsd.org: src

2019-07-22 Thread Ricardo Mestre
CVSROOT:/cvs
Module name:src
Changes by: mes...@cvs.openbsd.org  2019/07/22 03:19:52

Modified files:
usr.sbin/switchd: switchd.c 

Log message:
switchd(8)'s main proc needs to open the following paths, and which can be
unveiled:

/ -> read, it will open config files from anywhere in the system
/dev -> read/write, in order to open /dev/tap* and /dev/switch*

hint and OK akoshibe@



CVS: cvs.openbsd.org: src

2019-07-22 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2019/07/22 02:06:52

Modified files:
usr.sbin/apmd  : apmd.c 

Log message:
Zap useless globals

Initialize stack variables directly instead of using global state in
between.

OK tedu deraadt



CVS: cvs.openbsd.org: src

2019-07-22 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2019/07/22 01:34:16

Modified files:
usr.sbin/bgpd  : rde_decide.c 

Log message:
No need to check first if something is not NULL to assign NULL to it.
Just do it all the time.



CVS: cvs.openbsd.org: src

2019-07-22 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2019/07/22 01:32:16

Modified files:
usr.sbin/bgpd  : rde.h 

Log message:
GC three prototypes whose function have gone long ago.



CVS: cvs.openbsd.org: src

2019-07-22 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2019/07/22 00:59:41

Modified files:
usr.sbin/pkg_add/OpenBSD: Error.pm PackageRepository.pm Temp.pm 

Log message:
separate the atend behavior, because dpb wants a pure signal intercept
but not an END code.

This fixes the stupid bug I had. Was looking in the wrong location,
not surprisingly