CVS: cvs.openbsd.org: src

2023-12-23 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/12/23 23:35:05

Modified files:
usr.sbin/dev_mkdb: dev_mkdb.c 

Log message:
Rewrite dev_mkdb with FTS

This adds support for the devices in nested directories.

Pointers, review, and OK by semarie@



CVS: cvs.openbsd.org: src

2023-12-23 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/12/23 16:03:00

Modified files:
usr.bin/ftp: main.c 

Log message:
Relax -C pledge to unbreak shelling out in interactive mode

r1.69 introduced -C in 2008 "to continue multiple transfers";
'ftp -C ftp://ftp.eu.openbsd.org/' lands in "ftp> " and turns "mget"
into "reget" by default.

r1.139 -C/resume without "proc exec" thusly was too strict.
Instead, now after recent cleanups/tweaks, prevent execution with -o.

OK millert



CVS: cvs.openbsd.org: src

2023-12-23 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/12/23 15:40:42

Modified files:
sys/dev/fdt: rkdrm.c 

Log message:
Remove unused variables.



CVS: cvs.openbsd.org: src

2023-12-23 Thread Andrew Fresh
CVSROOT:/cvs
Module name:src
Changes by: afre...@cvs.openbsd.org 2023/12/23 14:03:01

Modified files:
distrib/sets/lists/base: mi 
distrib/sets/lists/man: mi 

Log message:
Sync for perl 5.36.3



CVS: cvs.openbsd.org: src

2023-12-23 Thread Andrew Fresh
CVSROOT:/cvs
Module name:src
Changes by: afre...@cvs.openbsd.org 2023/12/23 14:02:21

Modified files:
gnu/usr.bin/perl: INSTALL MANIFEST META.json META.yml 
  Makefile.SH Makefile.bsd-wrapper1 README.haiku 
  README.macosx README.os2 README.vms 
  patchlevel.h 
gnu/usr.bin/perl/Cross: config.sh-arm-linux 
config.sh-arm-linux-n770 
gnu/usr.bin/perl/Porting: config.sh config_H epigraphs.pod 
  make-rmg-checklist 
  perldelta_template.pod 
  release_schedule.pod todo.pod 
gnu/usr.bin/perl/dist/Module-CoreList: Changes 
gnu/usr.bin/perl/dist/Module-CoreList/lib/Module: CoreList.pm 
gnu/usr.bin/perl/dist/Module-CoreList/lib/Module/CoreList: 
   Utils.pm 
gnu/usr.bin/perl/hints: catamount.sh 
gnu/usr.bin/perl/lib/B: Op_private.pm 
gnu/usr.bin/perl/plan9: config_sh.sample 
gnu/usr.bin/perl/pod: perl.pod perldelta.pod perlhist.pod 
gnu/usr.bin/perl/t/win32: system.t 
gnu/usr.bin/perl/vms: descrip_mms.template 
gnu/usr.bin/perl/win32: GNUmakefile Makefile pod.mak win32.c 
Added files:
gnu/usr.bin/perl/pod: perl5342delta.pod perl5343delta.pod 
  perl5361delta.pod perl5362delta.pod 

Log message:
Update to perl 5.36.3

No changes to perl, as those were already committed for the earlier errata.
This just brings documentation and such in line with upstream.

ok bluhm@



CVS: cvs.openbsd.org: src

2023-12-23 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/12/23 11:28:38

Modified files:
sys/arch/arm64/dev: apldart.c 

Log message:
Add support for "locked" DARTs.  These have the page table registers
locked down and we need to retain the existing mappings.

ok patrick@



Re: CVS: cvs.openbsd.org: src

2023-12-23 Thread Todd C . Miller
On Sat, 23 Dec 2023 09:05:54 +0100, Anton Lindqvist wrote:

> On Fri, Dec 22, 2023 at 10:12:13AM -0700, Todd C. Miller wrote:
> > CVSROOT:/cvs
> > Module name:src
> > Changes by: mill...@cvs.openbsd.org 2023/12/22 10:12:13
> > 
> > Modified files:
> > regress/usr.bin/xargs: xargs-L.sh 
> > usr.bin/xargs  : xargs.c 
> > 
> > Log message:
> > xargs: fix parsing of empty fields when "xargs -0" is used.
> > Previously, these fields would be skipped.  From Hiltjo Posthuma.
>
> This broke the common `find -print0 | xargs -0` idiom:
>
> $ mkdir -p /tmp/a
> $ find /tmp/a -print0 | xargs -0r rm -r
> rm: : No such file or directory

Thanks, this should be fixed now.

 - todd



CVS: cvs.openbsd.org: src

2023-12-23 Thread Todd C . Miller
CVSROOT:/cvs
Module name:src
Changes by: mill...@cvs.openbsd.org 2023/12/23 08:58:58

Modified files:
usr.bin/xargs  : xargs.c 

Log message:
Suppress a spurious empty arg at EOF w/ "find -0" caused by the last commit.



Re: CVS: cvs.openbsd.org: src

2023-12-23 Thread Vitaliy Makkoveev
> On 23 Dec 2023, at 13:15, Alexander Bluhm  wrote:
> 
> On Fri, Dec 22, 2023 at 04:01:50PM -0700, Vitaliy Makkoveev wrote:
>> CVSROOT: /cvs
>> Module name: src
>> Changes by:  m...@cvs.openbsd.org2023/12/22 16:01:50
>> 
>> Modified files:
>>  sys/net: if.c if_aggr.c if_bpe.c if_etherip.c if_gif.c
>>   if_gre.c if_mpe.c if_mpip.c if_mpw.c if_pflow.c
>>   if_pfsync.c if_pppx.c if_sec.c if_tpmr.c
>>   if_trunk.c if_tun.c if_var.h if_veb.c if_vlan.c
>>   if_vxlan.c if_wg.c
>>  sys/netinet: ip_carp.c
>> 
>> Log message:
>> Always allocate per-CPU statistics counters for network interface
>> descriptor.
> 
> It looks like this breaks interface attach.
> It should be backed out.
> 

Thanks for backout and sorry for delay.



CVS: cvs.openbsd.org: src

2023-12-23 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/12/23 07:18:27

Modified files:
sys/dev/pci/drm: drm_linux.c 
sys/dev/pci/drm/include/drm: drm_file.h 
sys/dev/pci/drm/include/linux: backlight.h device.h io.h 
   ioport.h jiffies.h kernel.h pci.h 

Log message:
Provide more complete implementations of some of the Linux compat
interfaces that are needed for the upcoming apple kms driver.

ok jsg@



CVS: cvs.openbsd.org: src

2023-12-23 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/12/23 06:44:57

Modified files:
sys/dev/pci/drm/include/linux: types.h 

Log message:
Change the type of dma_addr_t to uint64_t.  It is a 64-bit type on most
Linux architectures (including the most popular 32-bit ones) and a new
driver I'm working on tries to print a dma_addr_t variable using %llx.

ok jsg@



Re: CVS: cvs.openbsd.org: src

2023-12-23 Thread Alexander Bluhm
On Fri, Dec 22, 2023 at 04:01:50PM -0700, Vitaliy Makkoveev wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   m...@cvs.openbsd.org2023/12/22 16:01:50
>
> Modified files:
>   sys/net: if.c if_aggr.c if_bpe.c if_etherip.c if_gif.c
>if_gre.c if_mpe.c if_mpip.c if_mpw.c if_pflow.c
>if_pfsync.c if_pppx.c if_sec.c if_tpmr.c
>if_trunk.c if_tun.c if_var.h if_veb.c if_vlan.c
>if_vxlan.c if_wg.c
>   sys/netinet: ip_carp.c
>
> Log message:
> Always allocate per-CPU statistics counters for network interface
> descriptor.

It looks like this breaks interface attach.
It should be backed out.

bluhm

pci4 at ppb3 bus 4
em0 at pci4 dev 0 function 0 "Intel 82571EB" rev 0x06: apic 8 int 17uvm_fault(0
x824bf360, 0x8, 0, 1) -> e
kernel: page fault trap, code=0
Stopped at  pool_get+0x6e:  movq0x8(%rax),%r11
TIDPIDUID PRFLAGS PFLAGS  CPU  COMMAND
* 0  0  0 0x1  0x2000K swapper
pool_get(825aac78,1,a619daefe381a0c,8017a048,d,8017a7e8
) at pool_get+0x6e
counters_alloc(c,c,a1f03e534e639ae1,8017a048,8017a048,8
017a7e8) at counters_alloc+0x3f
if_attach_common(8017a048,8017a048,ce773033c5bc7a4c,801
7a048,8017a048,e) at if_attach_common+0xa7
if_attach(8017a048,8017a048,8017a000,e,81618525
,8295be70) at if_attach+0x15
em_setup_interface(8017a000,8017a000,8017a578,8
017a000,8017a548,0) at em_setup_interface+0x1c8
em_attach(80177900,8017a000,8295bfa8,80177900,b
d8850f5395a4cef,80177900) at em_attach+0x410
config_attach(80177900,8245e5a8,8295bfa8,81b39c
50,e47e39a69ab854bf,8004) at config_attach+0x1e2
pci_probe_device(80177900,8004,0,0,e374438be72c4e6d,0) at pci_probe
_device+0x4c4
pci_enumerate_bus(80177900,0,0,80177900,f5afadb07e1609f4,80
179000) at pci_enumerate_bus+0x183
config_attach(80179000,8245d9d8,8295c1d0,82037f
00,e47e39a699089b75,8295c348) at config_attach+0x1e2
ppbattach(80177700,80179000,8295c348,80177700,f
7ff70c80a4ae9eb,80177700) at ppbattach+0x74e
config_attach(80177700,8245e2d0,8295c348,81b39c
50,e47e39a69ab854bf,80020800) at config_attach+0x1e2
pci_probe_device(80177700,80020800,0,0,e374438be72c4e6d,0) at pci_probe
_device+0x4c4
pci_enumerate_bus(80177700,0,0,80177700,f5afadb07e1609f4,80
178800) at pci_enumerate_bus+0x183
end trace frame: 0x8295c550, count: 0

> We have the mess in network interface statistics. Only pseudo drivers
> do per-CPU counters allocation, all other network devices use the old
> `if_data'. The network stack partially uses per-CPU counters and
> partially use `if_data', but the protection is inconsistent: some times
> counters accessed with exclusive netlock, some times with shared
> netlock, some times with kernel lock, but without netlock, some times
> with another locks.
>
> To make network interfaces statistics more consistent, always allocate
> per-CPU counters at interface attachment time and use it instead of
> `if_data'. At this step only move counters allocation to the if_attach()
> internals. The `if_data' removal will be performed with the following
> diffs to make review and tests easier.
>
> ok bluhm



CVS: cvs.openbsd.org: src

2023-12-23 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/12/23 06:05:06

Modified files:
lib/libcrypto/evp: evp_enc.c 

Log message:
Use more consistent order for Init/Update/Final

Consistently implement the _ex() version after the non-extended versions,
First Cipher Init/Update/Final, then Encrypt, then Decrypt. This only
switches the order of CipherFinal{,_ex} and move the DecryptInit* down,
so they are no longer somewhere in the middle of the Encrypt* functions.



CVS: cvs.openbsd.org: src

2023-12-23 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2023/12/23 03:52:55

Modified files:
sys/net: if.c if_aggr.c if_bpe.c if_etherip.c if_gif.c 
 if_gre.c if_mpe.c if_mpip.c if_mpw.c if_pflow.c 
 if_pfsync.c if_pppx.c if_sec.c if_tpmr.c 
 if_trunk.c if_tun.c if_var.h if_veb.c if_vlan.c 
 if_vxlan.c if_wg.c 
sys/netinet: ip_carp.c 

Log message:
Backout always allocate per-CPU statistics counters for network
interface descriptor.  It panics during attach of em(4) device at
boot.



CVS: cvs.openbsd.org: src

2023-12-23 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/12/23 03:29:05

Modified files:
usr.sbin/smtpd : smtp_session.c 

Log message:
remove trailing whitespaces



Re: CVS: cvs.openbsd.org: src

2023-12-23 Thread Anton Lindqvist
On Fri, Dec 22, 2023 at 10:12:13AM -0700, Todd C. Miller wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   mill...@cvs.openbsd.org 2023/12/22 10:12:13
> 
> Modified files:
>   regress/usr.bin/xargs: xargs-L.sh 
>   usr.bin/xargs  : xargs.c 
> 
> Log message:
> xargs: fix parsing of empty fields when "xargs -0" is used.
> Previously, these fields would be skipped.  From Hiltjo Posthuma.

This broke the common `find -print0 | xargs -0` idiom:

$ mkdir -p /tmp/a
$ find /tmp/a -print0 | xargs -0r rm -r
rm: : No such file or directory